---------- Forwarded message ---------- From: Holden Karau <[EMAIL PROTECTED]> Date: Oct 30, 2006 12:49 PM Subject: Re: [PATCH] wireless-2.6 zd1211rw check against regulatory domain rather than hardcoded value of 11 To: [EMAIL PROTECTED] Cc: Daniel Drake <[EMAIL PROTECTED]>, zd1211-devs@lists.sourceforge.net, [EMAIL PROTECTED], netdev <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org, [EMAIL PROTECTED], Johannes Berg <[EMAIL PROTECTED]>
Hi Ulrich, I'm fairly certain the patch is safe, even for non-US regulatory domains. Looking at the zd1211rw code the highest channel in the geo object would appear to be set in zd_geo_init as determined by zd_channel_range which just does a simple look up in channel_ranges[], so if this code behaves correctly [and there is no indication it does not], then setting the upper channel to be that in the geo object would appear to be safe for any of the supported regulatory domains. Cheers, Holden :-) On 10/30/06, Johannes Berg <[EMAIL PROTECTED]> wrote: > > > I'm not so sure about this. This patching might be US-specific and we > > cannot simply apply the setting for top channel of another domain > > instead of channel 11. One option would be to set the value only under > > the US regulatory domain. > > ?? > What the patch does is replace the top channel which is hardcoded to 11 > by the top channel given by the current regulatory domain. How can that > be wrong? Except that you may want to init the regulatory domain from > the EEPROM but I'm not sure how the ieee80211 code works wrt. that. > > johannes > -- Cell: 613-276-1645 -- Cell: 613-276-1645 ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Zd1211-devs mailing list - http://zd1211.ath.cx/ Unsubscribe: https://lists.sourceforge.net/lists/listinfo/zd1211-devs