On Sat, 4 Nov 2006, Uli Kunitz wrote:

>>> Guennadi, you are probably right. The reason is that the gcc is aligning
>>> embedded structures always to a word boundary on ARM. I didn't know about 
>>> that
>>> and didn't care for while removing the packed attributes.
>
> I have written a patch which should solve the problem.

NAK. This is not enough. Uli, I am afraid, at the moment I don't have much 
time to test further test versions of this "packed" patch, this is also 
the reason why testing of this one has taken me so long (sorry anyway). 
Please, just revert that your patch COMPLETELY. I understand it is good to 
avoid superfluous packed attributes, but it is not that critical, I 
think. We may look at it some time in the future, if you like, but, I 
think, ATM our best bet would be to just revert it.

For the future, or if anybody else can and wish to test it on ARM, only 
"pure software" structures can be safely made "unpacked", i.e. only those, 
describing internal classes. Of course, it may happen that an object gets 
transferred to the hardware, but only as a transfer / storage medium, and 
it will be afterwards read out by a system with THE SAME default packing 
rules. But it is always just safer to take care about packing in the 
software explicitely, instead of relying on default platform-specific gcc 
rules, as long as an object has to go on the wire.

Please restore your git tree to the working state.

Thanks
Guennadi
---------------------------------
Guennadi Liakhovetski, Ph.D.
DSA Daten- und Systemtechnik GmbH
Pascalstr. 28
D-52076 Aachen
Germany

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Zd1211-devs mailing list - http://zd1211.ath.cx/
Unsubscribe: https://lists.sourceforge.net/lists/listinfo/zd1211-devs

Reply via email to