Nice! I've merged it.
On Sat, Dec 14, 2013 at 11:36 PM, Trevor Bernard <trevor.bern...@gmail.com> wrote: > Good ol' pedantry. > > I'll take a stab at submitting a pull request. > > -Trev > > On Fri, Dec 13, 2013 at 3:14 PM, Pieter Hintjens <p...@imatix.com> wrote: >> I'll pedantically ask that we record problems rather than features. >> >> Problem: SUB accepts multiple connects to same PUB endpoint and result >> is nonsensical >> Solution: SUB socket should not allow multiple connects to same PUB endpoint. >> >> An issue will just rot, so you may want to find a way to send a patch >> to fix this problem. >> >> >> On Thu, Dec 12, 2013 at 8:09 PM, Trevor Bernard >> <trevor.bern...@gmail.com> wrote: >>> Should I submit an issue for this feature? I would find it extremely useful. >>> >>> -Trev >>> >>> On Wed, Oct 16, 2013 at 11:39 AM, Pieter Hintjens <p...@imatix.com> wrote: >>>> Having said that, it is undocumented behavior, and there is no valid >>>> use for this in pub-sub (nor in dealer-router, nor in req-rep) and we >>>> might want to change the behavior. We do know what endpoints are >>>> already used, and could reject duplicate connects to the same >>>> endpoint. >>>> >>>> On Wed, Oct 16, 2013 at 4:26 PM, Pieter Hintjens <p...@imatix.com> wrote: >>>>> Yes, this is expected behavior. Each connect is independent. In >>>>> pub-sub this produces nonsense results but in other patterns it can be >>>>> used to do things like prioritize one node over others (e.g. a PULL >>>>> that connects twice to a PUSH). >>>>> >>>>> On Wed, Oct 16, 2013 at 4:17 PM, Trevor Bernard >>>>> <trevor.bern...@gmail.com> wrote: >>>>>> I have a PUB/SUB topology and I accidently called connect twice to the >>>>>> same PUB endpoint and received duplicate messages. This holds true for >>>>>> N connects as well. Is this the correct behaviour? >>>>>> >>>>>> Simple test that recreates it: >>>>>> >>>>>> >>>>>> https://github.com/trevorbernard/double-trouble/blob/master/src/double_trouble/core.clj >>>>>> >>>>>> -Trev >>>>>> _______________________________________________ >>>>>> zeromq-dev mailing list >>>>>> zeromq-dev@lists.zeromq.org >>>>>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >>>>> >>>>> >>>>> >>>>> -- >>>>> - >>>>> Pieter Hintjens >>>>> CEO of iMatix.com >>>>> Founder of ZeroMQ community >>>>> blog: http://hintjens.com >>>> >>>> >>>> >>>> -- >>>> - >>>> Pieter Hintjens >>>> CEO of iMatix.com >>>> Founder of ZeroMQ community >>>> blog: http://hintjens.com >>>> _______________________________________________ >>>> zeromq-dev mailing list >>>> zeromq-dev@lists.zeromq.org >>>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >>> _______________________________________________ >>> zeromq-dev mailing list >>> zeromq-dev@lists.zeromq.org >>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >> _______________________________________________ >> zeromq-dev mailing list >> zeromq-dev@lists.zeromq.org >> http://lists.zeromq.org/mailman/listinfo/zeromq-dev > _______________________________________________ > zeromq-dev mailing list > zeromq-dev@lists.zeromq.org > http://lists.zeromq.org/mailman/listinfo/zeromq-dev _______________________________________________ zeromq-dev mailing list zeromq-dev@lists.zeromq.org http://lists.zeromq.org/mailman/listinfo/zeromq-dev
