On Wed, Oct 17, 2012 at 5:29 AM, Arne Jansen <sensi...@gmx.net> wrote:
> We have finished a beta version of the feature. A webrev for it > can be found here: > > http://cr.illumos.org/~webrev/sensille/fits-send/ > > It adds a command 'zfs fits-send'. The resulting streams can > currently only be received on btrfs, but more receivers will > follow. > It would be great if anyone interested could give it some testing > and/or review. If there are no objections, I'll send a formal > webrev soon. I haven't looked at the FITS-specific code yet but have some high-level comments: I'm not sure that we should add another subcommand for this, vs. a new flag to zfs send. The final review should include the code to receive this stream with a new command in /usr/bin. Please don't bother changing libzfs (and proliferating the copypasta there) -- do it like lzc_send(). Likewise, zfs_ioc_fits_send should use the new-style API. See the comment at the beginning of zfs_ioctl.c. I'm not a fan of the name "FITS" but I suppose somebody else already named the format. If we are going to follow someone else's format though, it at least needs to be well-documented. Where can we find the documentation? FYI, #1 google hit for "FITS": http://en.wikipedia.org/wiki/FITS #3 hit: http://code.google.com/p/fits/ Both have to do with file formats. The entire first page of google results for "FITS format" and "FITS file format" are related to these two formats. "FITS btrfs" didn't return anything specific to the file format, either. --matt
_______________________________________________ zfs-discuss mailing list zfs-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/zfs-discuss
