Henry Robinson updated ZOOKEEPER-631:

    Attachment: ZOOKEEPER-631.patch

Attached patch addresses the following:

1. Formatting redone to be (nearly) consistent
2. Comments added to every function
3. zookeeper.c reorganised logically
4. Py_None now reference counted correctly (see ZOOKEEPER-742)
5. Memory allocations now checked, and general error handling greatly improved. 
6. A variety of small bugs and typos fixed

The result is hopefully a much more stable zkpython. This patch will look like 
a rewrite - there are lots of changes. Apologies to the reviewer in advance! 

(I am happy for this patch to be used by the ASF, but the button is not 
available to be checked). 

> zkpython's C code could do with a style clean-up
> ------------------------------------------------
>                 Key: ZOOKEEPER-631
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-631
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bindings
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>            Priority: Minor
>         Attachments: ZOOKEEPER-631.patch
> Inconsistent formatting / use of parenthesis / some error checking - all need 
> fixing. 
> Also, the documentation in the header file could do with a reformat. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to