[ https://issues.apache.org/jira/browse/ZOOKEEPER-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-631: ----------------------------------- Status: Resolved (was: Patch Available) Hadoop Flags: [Reviewed] Resolution: Fixed Committed to 3.3 branch and trunk. Thanks Henry! I verified by inspecting the code changes, running the unit tests, but I also used the zk-smoketest/zk-latencies http://github.com/phunt/zk-smoketest to verify the changed code. One suggestion - next time create multiple JIRAs with individual patches rather than one big patch. Would make it much easier to review (say reformatting only, docs, acl/memory fixes. something like that.) > zkpython's C code could do with a style clean-up > ------------------------------------------------ > > Key: ZOOKEEPER-631 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-631 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bindings > Reporter: Henry Robinson > Assignee: Henry Robinson > Priority: Minor > Fix For: 3.3.1, 3.4.0 > > Attachments: ZOOKEEPER-631.patch > > > Inconsistent formatting / use of parenthesis / some error checking - all need > fixing. > Also, the documentation in the header file could do with a reformat. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.