[
https://issues.apache.org/jira/browse/ZOOKEEPER-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858375#action_12858375
]
Hadoop QA commented on ZOOKEEPER-631:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442027/ZOOKEEPER-631.patch
against trunk revision 934312.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/57/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/57/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/57/console
This message is automatically generated.
> zkpython's C code could do with a style clean-up
> ------------------------------------------------
>
> Key: ZOOKEEPER-631
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-631
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bindings
> Reporter: Henry Robinson
> Assignee: Henry Robinson
> Priority: Minor
> Attachments: ZOOKEEPER-631.patch
>
>
> Inconsistent formatting / use of parenthesis / some error checking - all need
> fixing.
> Also, the documentation in the header file could do with a reformat.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
