On Feb 24, 2009, at 11:12 AM, Tres Seaver wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Jim Fulton wrote: >> On Feb 24, 2009, at 9:26 AM, Tres Seaver wrote: >> ... >>>> As for TestRequest, I could update the setup.py of various packages >>>> that >>>> currently depend on zope.publisher just for TestRequest. I would >>>> make >>>> zope.publisher a test-only requirement. >>> Frankly, any code using a testing stub which is that heavyweight >>> needs >>> to be refactored. >> >> >> There's nothing all that heavyweight about TestRequest. > > - - It derives from BrowserRequest, which means carrying along a *lot* > of extra implementation baggage. Tests which use this class, rather > than stubbing out a dummy request which provides only the API > required > by the application-under-test, will tend to grow unexpected / > undesirable tentacles to the request implementation. > > - - Using TestRequest involves pulling in all of zope.publisher, a > *big* > dependency; Shane wants to reduce such dependencies.
OK, I don't agree that zope.publisher is a big dependency, especially for code that is meant to run in the context of it. Any view (or resource) code, which is the only code who's tests would need zope.publisher, will be used in together with zope.publisher in practice. Jim -- Jim Fulton Zope Corporation _______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )