Hello again,

On 07/07/2009 Andreas Jung wrote:
> As Tres already pointed out: the *relevant* scripts are registered using
> entry points afaik and will use the right Python interpreter.
> 
> Wrong references to old Python versions in
> 
> src/AccessControl/securitySuite/regressionSecurity.py
> src/Products/ZCTextIndex/tests/mhindex.py
> 
> should be fixed but this only a cosmetic issue here.

and as I can see in svn, you already fixed both of them. thanks for
that.

but what about all the scripts that still have python2.4 hardcoded as
interpreter? if zope2.12 doesn't support python2.4, these should be
fixed as well in my eyes.

here's a list of scripts that use hardcoded python2.4 interpreter:

src/Zope2/utilities/check_catalog.py
src/Zope2/utilities/compilezpy.py
src/Zope2/utilities/copyzopeskel.py
src/Zope2/utilities/decompilezpy.py
src/Zope2/utilities/load_site.py
src/Zope2/utilities/mkzeoinstance.py
src/Zope2/utilities/mkzopeinstance.py
src/Zope2/utilities/requestprofiler.py
src/Zope2/utilities/zpasswd.py

and one test has a python2.4 requirement in documentation:

src/ZPublisher/tests/generate_conflicts.py

see the attached patch to fix these remaining ones.

greetings,
 jonas
diff -rNu Zope2.12.old/src/ZPublisher/tests/generate_conflicts.py Zope2.12/src/ZPublisher/tests/generate_conflicts.py
--- Zope2.12.old/src/ZPublisher/tests/generate_conflicts.py	2009-07-10 16:24:51.000000000 +0200
+++ Zope2.12/src/ZPublisher/tests/generate_conflicts.py	2009-07-10 16:25:06.000000000 +0200
@@ -1,10 +1,10 @@
 ## This script requires:
-## - python2.4
+## - python >= 2.4
 ## - Zope 3's zope.testbrowser package:
 ##   http://www.zope.org/Members/benji_york/ZopeTestbrowser-0.9.0.tgz
 ##
 ## The just run:
-## $python2.4 generate_conflicts.py
+## $python generate_conflicts.py
 import base64
 import string
 import threading
diff -rNu Zope2.12.old/src/Zope2/utilities/check_catalog.py Zope2.12/src/Zope2/utilities/check_catalog.py
--- Zope2.12.old/src/Zope2/utilities/check_catalog.py	2009-07-10 16:24:50.000000000 +0200
+++ Zope2.12/src/Zope2/utilities/check_catalog.py	2009-07-10 16:25:22.000000000 +0200
@@ -1,4 +1,3 @@
-#!/usr/bin/env python2.4
 ##############################################################################
 #
 # Copyright (c) 2002 Zope Corporation and Contributors. All Rights Reserved.
diff -rNu Zope2.12.old/src/Zope2/utilities/compilezpy.py Zope2.12/src/Zope2/utilities/compilezpy.py
--- Zope2.12.old/src/Zope2/utilities/compilezpy.py	2009-07-10 16:24:50.000000000 +0200
+++ Zope2.12/src/Zope2/utilities/compilezpy.py	2009-07-10 16:25:39.000000000 +0200
@@ -1,5 +1,3 @@
-#!/usr/bin/env python2.4
-
 ##############################################################################
 #
 # Copyright (c) 2002 Zope Corporation and Contributors. All Rights Reserved.
diff -rNu Zope2.12.old/src/Zope2/utilities/copyzopeskel.py Zope2.12/src/Zope2/utilities/copyzopeskel.py
--- Zope2.12.old/src/Zope2/utilities/copyzopeskel.py	2009-07-10 16:24:50.000000000 +0200
+++ Zope2.12/src/Zope2/utilities/copyzopeskel.py	2009-07-10 16:25:44.000000000 +0200
@@ -1,5 +1,3 @@
-#!/usr/bin/env python2.4
-
 ##############################################################################
 #
 # Copyright (c) 2002 Zope Corporation and Contributors. All Rights Reserved.
diff -rNu Zope2.12.old/src/Zope2/utilities/decompilezpy.py Zope2.12/src/Zope2/utilities/decompilezpy.py
--- Zope2.12.old/src/Zope2/utilities/decompilezpy.py	2009-07-10 16:24:50.000000000 +0200
+++ Zope2.12/src/Zope2/utilities/decompilezpy.py	2009-07-10 16:26:00.000000000 +0200
@@ -1,5 +1,3 @@
-#!/usr/bin/env python2.4
-
 ##############################################################################
 #
 # Copyright (c) 2002 Zope Corporation and Contributors. All Rights Reserved.
diff -rNu Zope2.12.old/src/Zope2/utilities/load_site.py Zope2.12/src/Zope2/utilities/load_site.py
--- Zope2.12.old/src/Zope2/utilities/load_site.py	2009-07-10 16:24:50.000000000 +0200
+++ Zope2.12/src/Zope2/utilities/load_site.py	2009-07-10 16:26:05.000000000 +0200
@@ -1,5 +1,3 @@
-#!/usr/bin/env python2.4
-
 ##############################################################################
 #
 # Copyright (c) 2002 Zope Corporation and Contributors. All Rights Reserved.
diff -rNu Zope2.12.old/src/Zope2/utilities/mkzeoinstance.py Zope2.12/src/Zope2/utilities/mkzeoinstance.py
--- Zope2.12.old/src/Zope2/utilities/mkzeoinstance.py	2009-07-10 16:24:50.000000000 +0200
+++ Zope2.12/src/Zope2/utilities/mkzeoinstance.py	2009-07-10 16:26:11.000000000 +0200
@@ -1,5 +1,3 @@
-#!/usr/bin/env python2.4
-
 ##############################################################################
 #
 # Copyright (c) 2002 Zope Corporation and Contributors. All Rights Reserved.
diff -rNu Zope2.12.old/src/Zope2/utilities/mkzopeinstance.py Zope2.12/src/Zope2/utilities/mkzopeinstance.py
--- Zope2.12.old/src/Zope2/utilities/mkzopeinstance.py	2009-07-10 16:24:50.000000000 +0200
+++ Zope2.12/src/Zope2/utilities/mkzopeinstance.py	2009-07-10 16:26:15.000000000 +0200
@@ -1,5 +1,3 @@
-#!/usr/bin/env python2.4
-
 ##############################################################################
 #
 # Copyright (c) 2002 Zope Corporation and Contributors. All Rights Reserved.
diff -rNu Zope2.12.old/src/Zope2/utilities/requestprofiler.py Zope2.12/src/Zope2/utilities/requestprofiler.py
--- Zope2.12.old/src/Zope2/utilities/requestprofiler.py	2009-07-10 16:24:50.000000000 +0200
+++ Zope2.12/src/Zope2/utilities/requestprofiler.py	2009-07-10 16:26:21.000000000 +0200
@@ -1,4 +1,3 @@
-#!/usr/bin/env python2.4
 ##############################################################################
 #
 # Copyright (c) 2002 Zope Corporation and Contributors. All Rights Reserved.
diff -rNu Zope2.12.old/src/Zope2/utilities/zpasswd.py Zope2.12/src/Zope2/utilities/zpasswd.py
--- Zope2.12.old/src/Zope2/utilities/zpasswd.py	2009-07-10 16:24:50.000000000 +0200
+++ Zope2.12/src/Zope2/utilities/zpasswd.py	2009-07-10 16:26:25.000000000 +0200
@@ -1,5 +1,3 @@
-#!/usr/bin/env python2.4
-
 ##############################################################################
 #
 # Copyright (c) 2001,2002 Zope Corporation and Contributors.
_______________________________________________
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )

Reply via email to