Review: Needs Fixing

You didn't actually create singleton zorba::Items for the JSON object key 
strings. Using C++ #defines isn't the same. This code will still create a 
separate zorba::Item for the string "name" for every single entry in every 
archive passed to a:entries().


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1188033/+merge/176523
Your team Zorba Coders is subscribed to branch lp:zorba/archive-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to