Review: Approve

Global Items code looks good now!

As a general rule, don't put actual function definitions into header files. 
Certain small methods (accessors, usually) can be inline for efficiency, but 
anything more significant can cause code bloat and other problems. I moved the 
ArchiveModule() constructor definition into archive_module.cpp. With that done, 
everything looks fine.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1188033/+merge/176523
Your team Zorba Coders is subscribed to branch lp:zorba/archive-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to