Maurizio,
I think we're all in agreement at this point. Could you put together a
patch?
-J
Maurizio Martignano wrote:
Don
In Aolserver source code
95% of more of the times sockets are declared as SOCKET; the other times as
int.
This is an inconsistency and is a fact.
If you wanted to develop only for Unix why did you use SOCKET in some
occasions and int in some others?
The source code is inconsistent and it just happens to work on Unix because
there SOCKET and int have the same size. And this is also a fact.
But I believe we should stop here, I admit all the faults you want, but
please let's use SOCKET everywhere....
Cheers,
Maurizio
-----Original Message-----
From: AOLserver Discussion [mailto:AOLSERVER@LISTSERV.AOL.COM] On Behalf Of
Don Baccus
Sent: 04 August 2011 19:25
To: AOLSERVER@LISTSERV.AOL.COM
Subject: Re: [AOLSERVER] Aolserver Progress - Some few examples....
On Aug 4, 2011, at 9:55 AM, Maurizio Martignano wrote:
All of this depends on the week type system of C, were types with
different names, supposed to be used for different needs are
considered equivalent is their size is the same. If we had used Ada
none of this would have had
happened: types with different names are different no matter what
their size is.
If we were using Ada a file descriptor in Unix would still be described as
an integer.
I'm not saying that the Unix code you've uncovered is portable between Unix
and Windows.
I'm just pointing out that pipes are defined as an array of two integers in
Unix, so that the code isn't "wrong" for Unix, as you originally claimed.
I did so hoping it would increase your understanding, i.e. your claim that
it appears to be a bug even in Unix is incorrect.
If you want to make progress here, just accept that the code is perfectly
good Unix code and then figure out how to make the code work for both Unix
and Windows, instead of trying to argue incorrectly that the code's not
correct for Unix. It's not portable, but it's correct for Unix.
Thank you.
Anyhow in the base code 95% of the times or even more sockets are
declared as SOCKET sockets.
Here and there they are declared as int. This is an inconsistency and
it should be removed.
I do beg the community to do this little change because it is in the
benefit and interest of everybody.
I'm sure that the community will accept a patch that declares the pipe in a
way that makes both Unix and Windows happy if you'll provide one.
Meanwhile, quit complaining because I pointed out that, in Unix, int
pipefd[2] is the correct declaration for a pipe.
----
Don Baccus
http://donb.photo.net
http://birdnotes.net
http://openacs.org
--
AOLserver - http://www.aolserver.com/
To Remove yourself from this list, simply send an email to
<lists...@listserv.aol.com> with the body of "SIGNOFF AOLSERVER" in the
email message. You can leave the Subject: field of your email blank.
--
AOLserver - http://www.aolserver.com/
To Remove yourself from this list, simply send an email
to<lists...@listserv.aol.com> with the
body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject:
field of your email blank.
--
AOLserver - http://www.aolserver.com/
To Remove yourself from this list, simply send an email to
<lists...@listserv.aol.com> with the
body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject:
field of your email blank.
