On Wed, Oct 28, 2009 at 1:37 PM, Evan Martin <e...@chromium.org> wrote:
>
> On Wed, Oct 28, 2009 at 1:23 PM, Albert J. Wong (王重傑)
> <ajw...@chromium.org> wrote:
> > I actually got some weird warnings on the make build a while back when I
> > specified the same file in two sources entries...something about circular
> > dependencies and make ignore one. But don't remember the exact scenario.
> > I betcha it isn't a problem in chrome cause it'd only trigger a bug if
> the
> > file was compiled with different flags that modified behavior. Since our
> > defines and compiler options are so stable (especially within one
> target),
> > building once probably doesn't break stuff...
>
> Currently, as far as I know, no files in Chrome require this "compile
> twice" behavior.
> I am skeptical of the utility of gyp features that are unused by
> Chrome. But this may be the magic bullet to make -fPIC on 64-bit
> work.
>
> I think I still see situations where the generated strings aren't
> properly rebuilt in the make build. You have to run it twice. At
> this point, given the number of people hammering on it, I suspect the
> gyp rules are wrong and that the make build parallelizes too
> aggressively, but that is likely just wishful thinking and there's a
> subtle bug in there. :(
> That means for the build bots to switch, they need to always run make
> twice to be sure everything was built.
>
> (PS: currently every time you run make it rebuilds some NACL stuff
> too. I am so tired of NACL busting my build that I just turned it off
> locally.)
>
That was a regression that I think I fixed.
Antoine
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
