Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: tools: Make system and REST API rebase
......................................................................
Patch Set 2: (7 inline comments)
No real in depth review, but some smaller remarks. The bigger one is splitting
into 3 separate commits that only do 1 thing.
....................................................
Commit Message
Line 12: - Remove some references to RHEV in manpage
Maybe you should split these into separate commits.
....................................................
File Makefile
Line 18: NAME = engine-iso-uploader
Why the tab char? You're not aligning anything else.
Line 52: $(SRPM): tarball $(SPEC_FILE_IN)
Trailing whitespace
Line 67: rpmbuild --define="_topdir $(RPMBUILD)" --rebuild $<
Trailing whitespace
....................................................
File packaging/spec/iso-uploader.spec.in
Line 20: ISO Uploader tool for oVirt Engine
Trailing whitespace
Line 33: %files
Trailing whitespace
....................................................
File src/engine-iso-uploader.py
Line 389: logging.debug("Found a DC named(%s)" % dcName)
You can use:
logging.debug("Found a DC named(%s)", dcName)
--
To view, visit http://gerrit.ovirt.org/2674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63579697dff18a8e9adc52207906c0144fb89722
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
