Ofer Schreiber has posted comments on this change.
Change subject: tools: Make system and REST API rebase
......................................................................
Patch Set 3: (4 inline comments)
comments inline.
....................................................
File Makefile
Line 24: SPEC_FILE=iso-uploader.spec
rpmlint doesn't like the name.
spec file name should be ovirt-iso-uploader.spec
Line 62: rpmbuild -bs --define="_topdir $(SRCRPMBUILD)"
--define="_sourcedir ." $(SPEC_FILE)
sourcedir should be RPMTOP/SOURCES, not .
Line 64: rm -rf $(SRCRPMBUILD) $(SPEC_FILE) $(TARBALL)
There's no need to create both {SRCRPMBUILD} and {RPMBUILD}
just create rpmtop/{RPMS,SRPMS,SOURCES,BUILD...} and don't delete it
Line 71: rm -rf $(RPMBUILD)
there's no need to do the 'mv' and 'rm -rf'
just keep the directory as it is.
--
To view, visit http://gerrit.ovirt.org/2674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63579697dff18a8e9adc52207906c0144fb89722
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
