Ofer Schreiber has posted comments on this change.
Change subject: tools: Make system and REST API rebase
......................................................................
Patch Set 2: (4 inline comments)
Great patch, some inline comments.
....................................................
File packaging/spec/iso-uploader.spec.in
Line 2: %global __os_install_post %(echo '%{__os_install_post}' | sed -e
's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g')
why do you need this?
Line 27: rm -rf %{buildroot}/*
no need to execute rm -rf
Line 31: %{__rm} -rf %{buildroot}
%clean is not needed.
Line 37: %doc %{_mandir}/man8/engine-iso-uploader.8.gz
what about add %doc AUTHORS and %doc LICENSE?
--
To view, visit http://gerrit.ovirt.org/2674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63579697dff18a8e9adc52207906c0144fb89722
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
