Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: tools: Make system and REST API rebase
......................................................................
Patch Set 2: (7 inline comments)
I generally agree with your comments, but replies inline. Also added some more
since you're not going to split the commit.
....................................................
Commit Message
Line 12: - Remove some references to RHEV in manpage
Personally I think you should start following best practices as soon as you
can, but not going to make a problem out of it.
....................................................
File Makefile
Line 41: done; \
I don't know how compatible with find you want to be, but with GNU find you can
use:
find . -iname '*.pyc' -or -iname '*.pyc' -delete
Line 81: chmod 755
$(PREFIX)/usr/share/ovirt-engine/iso-uploader/engine-iso-uploader.py
Using install:
install -m 0755 ./src/engine-iso-uploader.py
$(PREFIX)/usr/share/ovirt-engine/iso-uploader/engine-iso-uploader.py
You could use install -D to instead of the mkdir -p in create_dirs
Line 85: chmod 600 $(PREFIX)/etc/ovirt-engine/isouploader.conf
install -m 0600 ./src/isouploader.conf
$(PREFIX)/etc/ovirt-engine/isouploader.conf
....................................................
File src/engine-iso-uploader.py
Line 347: # The API has not been intialized yet.
you're missing the first i in initialized
Line 370: logging.error(_("Unable to connect to REST API.
Message: %s" % e))
You're translating including the message. Maybe use _("Message: %s") % e?
Line 389: logging.debug("Found a DC named(%s)" % dcName)
Done
--
To view, visit http://gerrit.ovirt.org/2674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63579697dff18a8e9adc52207906c0144fb89722
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
