On Sun, Nov 18, 2012 at 04:28:00AM +0000, Robin H. Johnson wrote: > On Sat, Nov 17, 2012 at 11:06:38PM -0500, Richard Yao wrote: > > On 11/17/2012 10:39 PM, Greg KH wrote: > > > Anyway, I now see a _very_ dangerous commit in the "Copyright" branch > > > that better not get merged into the tree, as it's wrong, and illegal > > > under all countries that follow the "normal" body of Copyright Law. It > > > should be removed right now before someone gets into trouble, not the > > > least of which would be the orginization that the copyright is now being > > > attributed to. > > > > > > Come on people, this is basic copyright law, it's not something > > > radically new. It's something that _all_ software developers should > > > know, either from school, or any company they have ever worked at. > > > > > > Please fix this now. > > klondike discussed the copyright branch changes with robbat2 before they > > started and there was no problem at the time. We have retained all > > copyright notices and looking at the branch, I find nothing objectionable. > To note here, since I was CC'd directly: > I said changed files should get the modified notice, as Gentoo should have > copyright on the changes that are explicitly new by Gentoo. I didn't say to > add > it to every file in the repo (but I will admit that I didn't tell him not to > either). > > I'll state it clearly what should be the case: > - the s/systemd/eudev/ line, and insertion of "From prior code in systemd and > pre-systemd udev" being added now is fine. > - WHEN substantial changes are made to an existing file, the copyright > attribution should be amended to include the Gentoo Foundation. The > attribution should NOT be changed before this. Better text given the > existing > wording would be: > Portions Copyright 2012 Gentoo Foundation. > > - Files that have no copyright notice should NOT be touched until such time as > a major addition is added to them. > > http://dpaste.com/832634/ is what I approved with klondike (his 2nd paste to > me > in the discussion).
That makes sense, but is not what ended up in that commit. The commit needs to be removed. Also, how can any new work be assigned to the Gentoo Foundation? Is there an explicit copyright assignment happening somewhere that I am not aware of? thanks, greg k-h
