Just small, very small comments. To avoid being accused of bikeshedding, I'm totally fine if you don't apply any of them. It's entirely up to you. :)
https://bugs.gentoo.org/show_bug.cgi?id=480826 : > if use directfb ; then > # since DirectFB can link against SDL and trigger a > # dependency loop, only link against DirectFB if it > # isn't broken #61592 > echo 'int main(){}' > directfb-test.c > $(tc-getCC) directfb-test.c -ldirectfb 2>/dev/null \ > && directfbconf="--enable-video-directfb" \ > || ewarn "Disabling DirectFB since libdirectfb.so is > broken" > fi Suggestion: print what to do in the ewarn (or just reference the bug number in he ewarn so the user doesn't have to read the ebuild). > # --disable-threads broken If there is some reference why/how it is broken, it'd be great to reference it there (to avoid kind of cargo cult programming "it's here because it always was here, and it is probably still broken but nobody remembers how"). https://bugs.gentoo.org/show_bug.cgi?id=481796 : > RDEPEND=${DEPEND} > > S=${WORKDIR}/SDL2_mixer-${PV} Why no quotes? ("") https://bugs.gentoo.org/show_bug.cgi?id=481794 : > S=${WORKDIR}/${MY_P} Why no quotes? ("") > src_configure() { > econf \ > --disable-gui \ > $(use_enable static-libs static) > } Would it make sense to add USE flag to --enable-gui? https://bugs.gentoo.org/show_bug.cgi?id=481788 : > S=${WORKDIR}/SDL2_ttf-${PV} I suggest quotes (""). > src_install() { > emake DESTDIR="${D}" install || die > dodoc {CHANGES,README}.txt > use static-libs || prune_libtool_files --all > } In EAPI-5 die after emake is not needed. Again, these things are _tiny_ details, and it's entirely up to you what to do with it. I hope it'll be at least somewhat useful. And of course everything else looks good. :) Thank you for working on sdl2 bumps! Paweł
signature.asc
Description: OpenPGP digital signature
