On Sep 9, 2018, at 12:32 PM, Ulrich Mueller <u...@gentoo.org> wrote:
>>>>>> On Sun, 09 Sep 2018, Andrew Savchenko wrote:
>
>> What I'm trying to do is to allow maintainers to keep -Werror if
>> they really want to do this, understand what they are doing and
>> have enough manpower to support this.
>
> Bug 665464 has just proven that this doesn't work. That bug would not
> have happened if the policy had been followed. Also its fix (removal of
> an unused variable) should have been applied only upstream. I don't see
> a good reason for adding downstream patches that will make no difference
> for the resulting binary. At least not when the upstream package is
> maintained, and the issue will likely go away with one of the next
> releases.
>
>> As can be seen from aforementioned bugs right now developer and
>> upstream support this to their best and yet QA team tries to
>> enforce -Werror drop using the brute force and ignoring active best
>> effort support. This should not happen.
>
> See flameeyes's old blog post for the rationale why the current policy
> is in place:
> https://flameeyes.blog/2009/02/25/future-proof-your-code-dont-use-werror/
For every pointless check that fails -Werror, there is likely one that actually
does matter. An unused variable could go either way if upstream intended to use
that variable, but used another one by mistake (it happens).
Allowing users to opt into -Werror behavior on specific packages whose
maintainers have a good reason to do it and are keeping up with things would be
alright.
>
> Ulrich
>
