Hi Jacopo, On 2018-04-16 01:16:35 +0200, Niklas Söderlund wrote:
[snip] > > > + > > > + /* Set frequency range if we have it */ > > > + if (priv->info->csi0clkfreqrange) > > > + rcar_csi2_write(priv, CSI0CLKFCPR_REG, > > > + CSI0CLKFREQRANGE(priv->info->csi0clkfreqrange)); > > > + > > > + rcar_csi2_write(priv, PHYCNT_REG, phycnt); > > > + rcar_csi2_write(priv, LINKCNT_REG, LINKCNT_MONITOR_EN | > > > + LINKCNT_REG_MONI_PACT_EN | LINKCNT_ICLK_NONSTOP); > > > + rcar_csi2_write(priv, PHYCNT_REG, phycnt | PHYCNT_SHUTDOWNZ); > > > + rcar_csi2_write(priv, PHYCNT_REG, phycnt | PHYCNT_SHUTDOWNZ | > > > + PHYCNT_RSTZ); > > > > Nit: from tables 25.[17-20] it seems to me you do not have to re-issue > > PHYCNT_SHUTDOWNZ when writing PHYCNT_RSTZ to PHYCNT_REG. > > You are correct, I miss read '.... Here, the ENABLE_0 to ENABLE_3 and > ENABLECLK values set above should be retained' as all previous PHYCNT > bits should be retained not just the ones explicitly listed. I will give > this a test and if it still works I will remove it for the next version. This change breaks capture and LP-11 is never detected. So I will continue to retain the PHYCNT_SHUTDOWNZ here. -- Regards, Niklas Söderlund
