Al Hopper writes: > Please don't ask an unpaid, volunteer, OpenSolaris developer to make > changes that are simply stylistic or (personal) preference based.
That doesn't seem at all right to me. Are you saying that style (and thus readability) no longer matters in a code review? > If its important to you personally - then please feel perfectly free > to checkout the relevant files and make the changes yourself. ... and that seems quite wrong. It's not at all the reviewer's responsibility to implement the required changes. That responsibility rests with the project team. If we set the requirement that high, no sane person would ever volunteer to review anything. Note that the reviewers are volunteers. They're not being paid by Sun to do this. They get no brownie points for it. They're doing it as a favor for the project team. > PS: If its good enough to integrate its *good* *enough* to integrate. > We simply can't build GOLD-PLATED software using unpaid OpenSolaris > volunteers. So, how much lower should the bar be set? The project team chose to go into ON rather than some other more suitable consolidation such as SFW. ON's bar is intentionally set very high -- these are the crown jewels we're talking about here. I doubt you're going to get much agreement that the bar on entry to ON should be lowered to allow just "any" open source code. I think it's Roland's cross to bear that he chose ON and is sticking with it. -- James Carlson, Solaris Networking <[EMAIL PROTECTED]> Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 _______________________________________________ opensolaris-code mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
