Michael: Thanks for giving this a good hard look.
Good catch on the fast tempo bug. I understand this one. I relied on
TempoMapper, which never inserts the default tempo. I am compiling a fix
for that now.
Tempo ramping is another issue. I don't know how to make a MIDI file
represent ramping.
I can't reproduce the volume 0 bug. I have no problem, and the volume IPB
is happily showing me 100.
I can reproduce the last note being cut off. It hasn't actually
disappeared, it just has an immediate noteoff. I suspect the problem may
be on the input end, because when I play the same file in aplaymidi, it
plays the last note as long as it should. But it resembles something I
fixed. I will trace the final noteoff's time when I insert it, which
should tell me for sure which side the problem is on.
Also while fixing the fast tempo, I discovered that we're leaking memory
by "new"ing MappedEvents in mappers, but the new object isn't used or
deleted, just a copy of it is inserted into an array. I'll patch that
next.
I didn't do anything with the input end except add a call to
clearMidiComposition. But I did find some non-trivial bugs in importing:
* It sometimes crashes if it exports MIDI, than imports. There are
specific circumstances that always do that, but I haven't tried to
isolate a minimal example. Not new, my old copy does this too. That's
what I hoped to fix by calling "clearMidiComposition" but it didn't help.
* It kinda understands program changes, but thinks there can be no more
than one per channel. I'm exercising that harder, but it's always had a
problem there.
* It leaves program change controllers in Segments. This seems wrong.
I'm not sure I'm up to debugging the import end. It was a pretty big
effort doing the export end, and right now I'd like to stabilize what I've
done before it drifts any further away from the trunk.
Tom Breton (Tehom)
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
