On Tuesday, February 07, 2012, Tom Breton (Tehom) wrote: > Good catch on the fast tempo bug. I understand this one. I relied on > TempoMapper, which never inserts the default tempo. I am compiling a fix > for that now.
OK. > Tempo ramping is another issue. I don't know how to make a MIDI file > represent ramping. Neither does anybody else. I was kind of hoping your approach to all of this might address that problem. If I understand it right, I'm expecting your code will wind up writing out, for example, longer and longer notes for a given duration while the tempo is ramping down. There will be no MIDI tempo changes during that period of time, but I'm thinking the raw note data ought to compensate. Maybe. That's what I was hoping anyway. > I can't reproduce the volume 0 bug. I have no problem, and the volume IPB > is happily showing me 100. With the original version of the file (still found in your branch) or the new one or both? Very interesting. I should probably go back to the original file and take a harder look at everything. > I can reproduce the last note being cut off. It hasn't actually > disappeared, it just has an immediate noteoff. I suspect the problem may > be on the input end, because when I play the same file in aplaymidi, it > plays the last note as long as it should. But it resembles something I > fixed. I will trace the final noteoff's time when I insert it, which > should tell me for sure which side the problem is on. OK. > Also while fixing the fast tempo, I discovered that we're leaking memory > by "new"ing MappedEvents in mappers, but the new object isn't used or > deleted, just a copy of it is inserted into an array. I'll patch that > next. Good catch! > I didn't do anything with the input end except add a call to > clearMidiComposition. But I did find some non-trivial bugs in importing: One thing at a time, right? Those problems are all ancient, and we can ignore them for at least one more iteration, surely. > I'm not sure I'm up to debugging the import end. It was a pretty big > effort doing the export end, and right now I'd like to stabilize what I've > done before it drifts any further away from the trunk. Fine by me. Maybe we can come back to the import side on the next pass. In the near term, I'm thinking I'd like to get your stuff stabilized and merged, and start thinking about maybe releasing toward the first of April or so. Nice work on all of this. For a first run of something this audacious, it worked impressively well. -- D. Michael McIntyre ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
