On 03/26/2013 04:29 PM, Tom Breton (Tehom) wrote: > OK, I coded it up. Since 13.04 release is in progress, I'll put it on a > new branch, say notation-move-vertically.
Fine. > * I said that if no segment contains the playback, "use the nearest", but > now that looks to be a significant change for little apparent benefit. > (Whereas the "contains" logic just re-uses existing code) I will still > code that if people really want focus to go to the nearest segment, but > if it's not important to anybody I won't. That's the part I was expecting to have to look at and see what I thought of it. Sometimes the nearest might be a long, long way from where you started, and it might be confusing, and it might seem natural. I'd have to see it to make up my mind. If you don't code it, I won't evaluate it. > edited (visually highest). I would really like feedback on how people > think it should go. Me, I don't pay that much attention to selected > track, so I'd just as soon always use the first track, but it's about 6 > lines of code so it's easy to change. I'll play with and evaluate that, and let you know what I think. I'm sure it's possible to come up with a set of rules that seem to flow well, but I don't have any solid concept in my head what I think the rules ought to be. I'm going to have to play with it and see how it feels. > * Bonus: slotMoveEventsUpStaff/slotMoveEventsDownStaff are less > error-prone. No more squashing notes together in the wrong segment! > This just fell out. They use getStaffBelow/getStaffAbove too, so for > them I just passed the time the selection starts instead of playback > pointer. So now they find a reasonable target segment if available. > (They probably still kaboom if you move upwards from the top staff etc) That has been buggy as hell since 10.02. Maybe you fixed some old bugs as a bonus side effect of this little project. I'll investigate that too. -- D. Michael McIntyre ------------------------------------------------------------------------------ Own the Future-Intel® Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
