On Saturday 14 November 2015 13:49:15 Chris Cannam wrote: > > On Fri, Nov 13, 2015, at 08:37 PM, David Faure wrote: > > All done (for Qt4 at least) [...] > > Worked nicely here. I might rely on this as a reference for CMake in the > future -- it's especially informative because I knew what the old > Makefile did so I can compare them.
Yep - and I tried to document the CMake buildsystem as much as possible. > About the tests, I'd have thought that since running them is (always > supposed to be) fast, but building them is slower, it ought to make > sense to run them every time they're built. Right now they are fast, but over time they will grow, and you guys will get really annoyed at being slowed down in the edit-compile-run cycle by 1 minute of unit tests running. In my experience (with Qt itself, kdelibs, KF5, and customer projects) I have rarely seen tests running automatically during the build. I think this would push people to disable the tests altogether, compared to the usual middle ground which is, building them as part of the rest, but running them explicitly. If I end up actually calling `lilypond` from the test, it won't be fast ;) > When I said RG used to have a few tests, it wasn't actually the three in > the test dir that I was thinking of Ah. Well, I was glad that these still exist and actually pass after I ported them to QTestLib :) It's a start. > -- there was another handful of > tests lost in history somewhere that completely stopped working. > Probably a decade ago. I can't remember what they tested or what > happened to them, though I assume they exist in an old revision somehow. OK. I don't feel like digging that up, because I would be unable to port them to any API changes that happened in the rosegarden classes since then. But feel free :-) -- David Faure, [email protected], http://www.davidfaure.fr Working on KDE Frameworks 5 ------------------------------------------------------------------------------ _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
