[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977556#comment-15977556
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user PascalSchumacher commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/261#discussion_r112563123
  
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -457,6 +457,44 @@ public static String getAbbreviatedName(final String 
className, final int len) {
 }
 
 /**
+ * Gets a combination of {@link #getAllSuperclasses}(Class)} and
+ * {@link #getAllInterfaces}(Class)}, one from superclasses, one
+ * from interfaces, and so on in a breadth first way.
+ *
+ * @param cls  the class to look up, may be {@code null}
+ * @return the {@code List} of superclasses in order going up from 
this one
--- End diff --

This should also mention Interfaces.

Can you add a since tag to this method?

Thanks!


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977282#comment-15977282
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user yasserzamani commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
> Sorry for the delay, other open source projects and vacations interfered.

You're welcome, I understand and as an open source fun contributor, I'm 
patient enough :)

> I'm not sure if the priority parameter is necessary?

No, is not. I just thought I should make it more general with more options 
to prevent future needs for other user's PRs. Now, with thanks to your 
recommendations I remove it :)


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977277#comment-15977277
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/261
  

[![Coverage 
Status](https://coveralls.io/builds/11170248/badge)](https://coveralls.io/builds/11170248)

Coverage increased (+0.07%) to 94.675% when pulling 
**90e252f571377cac39f5e2a3fc73749f589c24de on yasserzamani:LANG-1317** into 
**4a300fee2ef1c03902d0fb25ceb02aa01d0fab46 on apache:master**.



> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976758#comment-15976758
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
@yasserzamani Sorry for the delay, other open source projects and vacations 
interfered.

I'm not sure if the priority parameter of `getAllSuperclassesAndInterfaces` 
is necessary? Are you aware of any use-cases where it is necessary? Maybe we 
should keep things simple and remove it?

Otherwise the pull request is fine. :=) :+1: 


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952636#comment-15952636
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
Concerning the coverage: I think it's because the coverage differs between 
java versions. The build used to determine coverage depends on the order in 
which the travis builds finish.


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946564#comment-15946564
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user yasserzamani commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
Thank you @Abrasha ,

I signed up with [coveralls.io](http://coveralls.io) and see that all of 
this PR's changes are covered with unit tests: 
[MethodUtils](https://coveralls.io/jobs/24310263/source_files/797094203#L845) , 
[ClassUtils](https://coveralls.io/jobs/24310263/source_files/797094115#L477).

Also these files show enhancement in coverage at [COVERAGE 
CHANGED](https://coveralls.io/jobs/24310263) :thinking: 


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946537#comment-15946537
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/261
  

[![Coverage 
Status](https://coveralls.io/builds/10822401/badge)](https://coveralls.io/builds/10822401)

Coverage decreased (-0.03%) to 94.577% when pulling 
**b79fe6f9e350edb3086c44220968ae3dfcc0d2cb on yasserzamani:LANG-1317** into 
**4a300fee2ef1c03902d0fb25ceb02aa01d0fab46 on apache:master**.



> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945339#comment-15945339
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user Abrasha commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
@yasserzamani I thinks because you added more conditional branches in the 
latest commit and that is why less LOC are covered 


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944956#comment-15944956
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user yasserzamani commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
@PascalSchumacher , I made it better  thanks a lot!

Please feel free to make any recommendation if you think I can make it 
better.

> Coverage decreased (-0.03%) to 94.571%

 Do you know why?  


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944952#comment-15944952
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/261
  

[![Coverage 
Status](https://coveralls.io/builds/10806431/badge)](https://coveralls.io/builds/10806431)

Coverage decreased (-0.03%) to 94.571% when pulling 
**7390433b9dc9f53d2cf472421fe63d8240756492 on yasserzamani:LANG-1317** into 
**4a300fee2ef1c03902d0fb25ceb02aa01d0fab46 on apache:master**.



> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943790#comment-15943790
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user yasserzamani commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
 I am working on a new commit. thanks!


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943681#comment-15943681
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
Well we have to keep `getMethodsWithAnnotation(cls, annotationCls)` for 
compatibility reasons.  In my opinion it is not problem if is equal to 
`getMethodsWithAnnotation(cls, annotationCls, false, false)`. It can be 
refactored to call `getMethodsWithAnnotation(cls, annotationCls, false, false)` 
and then it is just some sugar for the most? common use case.


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942595#comment-15942595
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user yasserzamani commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
Another bad thing is that `getMethodsWithAnnotation(cls, annotationCls, 
false, false)` will be a duplicate for `getMethodsWithAnnotation(cls, 
annotationCls)`.

Another solution is to keep my current changes not modified but add 
following javadoc:

```
 *
 * To lookup annotations on the given class level only choose {@code 
get*()} methods
 * and to lookup in the entire inheritance hierarchy of the given class and 
ignore 
 * accessibility, choose {@code find*()} methods
 *
 * @since 2.5
 */
public class MethodUtils {
```


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942402#comment-15942402
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
You are right. The method signature I suggested omits the important super 
part. I agree it should be something like `getMethodsWithAnnotation(Class cls, 
annotationCls, boolean searchSupers, boolean ignoreAccess)`. (I'm not a fan of 
boolean parameters (especially multiple ones), so if somebody has an idea for a 
good method name, that is welcome.)


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942390#comment-15942390
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user yasserzamani commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
@PascalSchumacher , thank you! I was overloaded by another job and forgot 
that I also can use method overloads. Yes, strongly I agree. Just I have some 
doubts about name `ignoreAccessiblitiy` because the new method is not only 
about accessibility, but also about traverse super classes and implemented 
interface and super interfaces while the annotation maybe is not present on the 
given class but is present on lower layers. Maybe we should also add another 
param named `searchSupers` for example.


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942375#comment-15942375
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
Thanks for the pull request!

It is really unfortunate  that the existing method 
`getMethodsWithAnnotation` is not called `getAccessibleMethodsWithAnnotation` : 
(, because then the new method could be called `getMethodsWithAnnotation`.

I would not have been able to tell the difference between 
`getMethodsWithAnnotation` and `findMethodsWithAnnotation` without reading the 
javadoc.

I believe we need a more intention revealing method name or maybe  we 
should just add an overload of `getMethodsWithAnnotation` e.g. 
`getMethodsWithAnnotation(Class cls, annotationCls, boolean 
ignoreAccessiblitiy)`.

What do you think?




> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942195#comment-15942195
 ] 

ASF GitHub Bot commented on LANG-1317:
--

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/261
  

[![Coverage 
Status](https://coveralls.io/builds/10775689/badge)](https://coveralls.io/builds/10775689)

Coverage decreased (-0.002%) to 94.603% when pulling 
**e49a3a2099759f5fee2423aff2b9fa762881c36b on yasserzamani:LANG-1317** into 
**4a300fee2ef1c03902d0fb25ceb02aa01d0fab46 on apache:master**.



> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941979#comment-15941979
 ] 

ASF GitHub Bot commented on LANG-1317:
--

GitHub user yasserzamani opened a pull request:

https://github.com/apache/commons-lang/pull/261

LANG-1317: Add findAnnotation and findMethodsWithAnnotation

In order to fix [WW-4744](https://issues.apache.org/jira/browse/WW-4744) ,

findAnnotation will be an extension for Method.getAnnotation that also 
searches interfaces and super classes.

findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
that also supports non public methods, super class and interface methods.

NOTES:
To keep changes simple, currently no cache provided. Let's do that when 
needed  

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yasserzamani/commons-lang LANG-1317

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #261


commit 74241a7cd79f2dda723f07948c7925f9b6511989
Author: Yasser Zamani 
Date:   2017-03-25T21:19:46Z

LANG-1317: Add findAnnotation and findMethodsWithAnnotation to MethodUtils




> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Yasser Zamani
>  Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)