Re: New Theorems Module

[Pavel Sanda]

On Mon, Jun 19, 2023 at 04:51:01PM +0300, Udicoudco wrote:
> This is not really urgent so it could wait for the next release. In the 
> meantime
> I will upload the new modules to LyX wiki.

Ok, thanks much for the executive summary, I'm dropping this from my 2.4 
TODO list...

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Udicoudco]

On Fri, Jun 16, 2023 at 6:17 PM Pavel Sanda  wrote:
>
> On Thu, Jul 14, 2022 at 07:20:13AM +0300, Udicoudco wrote:
> > I wrote a module that provides essentially the same layouts as the "
> > Theorems (Numbered by Type within Sections)" module, but with a new
>
> Dear Udi,
>
> I got somewhat lost in the long and detailed thread. Would you mind to 
> summarize
> the current status (current patch, missing things, unfixed bugs, objections 
> from
> others on so on).
>
Sorry for the delayed response. I've noticed that users (sometimes even me)
are getting confused with the current situation of the theorems
modules, especially
with regards to the `Requires` and `Excludes` attributes, and I don't
want to accentuate
the confusion with more modules.

For example see this thread
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg219221.html
theoretically the situation with `Requires` and `Excludes` graphs
could be messy, practically
it only happens with the theorems modules, without a real
justification for the mess, while
all other modules seem to be fine.

I think it would be better to organize the existing  modules before
adding a new one.
I'll open a ticket where I'll explain the current situation, add some
suggestions and ask for
some advice.

>I think this is the last moment to consider this stuff into 2.4...

This is not really urgent so it could wait for the next release. In the meantime
I will upload the new modules to LyX wiki.

As for the minor bugs I described in
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg218016.html
the fix for them could potentially modify the output (at least the one
related to named theorems and the one
about theorems-proof-std.inc), so I'm not sure what the policy is here
(maybe a file format change is required?).

Best,
Udi

> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Pavel Sanda]

On Thu, Jul 14, 2022 at 07:20:13AM +0300, Udicoudco wrote:
> I wrote a module that provides essentially the same layouts as the "
> Theorems (Numbered by Type within Sections)" module, but with a new

Dear Udi,

I got somewhat lost in the long and detailed thread. Would you mind to summarize
the current status (current patch, missing things, unfixed bugs, objections from
others on so on).

I think this is the last moment to consider this stuff into 2.4...

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Richard Kimberly Heck]

On 12/31/22 08:26, Udicoudco wrote:



On Sat, Dec 31, 2022 at 12:49 PM Udicoudco  wrote:



On Sat, Dec 31, 2022 at 10:33 AM Thibaut Cuvelier
 wrote:

On Sat, 31 Dec 2022 at 03:36, Scott Kostyshak
 wrote:

On Sat, Dec 31, 2022 at 02:00:34AM +0100, Thibaut Cuvelier
wrote:
> I've pushed your patch online: 42c2a25fb8. I had to
rebase it manually, I
> hope I didn't make too many mistakes. I'm also attaching
the patch to this
> email so that you can check it more easily if you want.
>
> (If someone can add Udi to the blanket permissions, here
is the link on the
> mailing list:
https://marc.info/?l=lyx-devel=165779733507955=2
)
>
> Thibaut Cuvelier

Some ctests are failing on current master. I'm not sure if
it's because
of your recent commit or not.

But, for example, if I open up lib/doc/Additional.lyx, I
get a message
about a module that is not found: theorems-ams-extended

Also some tex2lyx tests are failing. Can you check those
as well?


Given the failures, I'm reverting the commit, especially as
Udi is working on a new version. For the missing modules, I
suppose that Udi should restore the corresponding .module
files, even if they just include something else, or could we
do something about it in lyx2lyx? (I.e. does this change
warrant a format update?)
-- 


I will restore the missing modules, so we don't need to do
anything about lyx2lyx.


If i ill change the non-AMS modules to not use amsthm, and will add to 
their name `-plain`
prefix, would it be possible to make lyx2lyx update files using e.g. 
theorems.module to use

theorems-ams.module?


Yes, that's easy. I can do that part, if need be.

Let's not commit anything about this until I get beta 2 built.

Riki

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[José Matos]

On Sat, 2022-12-31 at 12:33 -0500, Scott Kostyshak wrote:
> Thanks for the quick response and checking it, Udi!
> 
> @Thibaut thanks for reverting in the meantime.
> 
> Scott

+1

BWT I wish you all a Good Year of 2023...
with lots of LyX's releases. :-D

Best regards,
-- 
José Abílio
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Scott Kostyshak]

On Sat, Dec 31, 2022 at 10:28:19AM +0200, Udicoudco wrote:
> On Sat, Dec 31, 2022 at 4:36 AM Scott Kostyshak  wrote:
> 
> > On Sat, Dec 31, 2022 at 02:00:34AM +0100, Thibaut Cuvelier wrote:
> > > I've pushed your patch online: 42c2a25fb8. I had to rebase it manually, I
> > > hope I didn't make too many mistakes. I'm also attaching the patch to
> > this
> > > email so that you can check it more easily if you want.
> > >
> > > (If someone can add Udi to the blanket permissions, here is the link on
> > the
> > > mailing list: https://marc.info/?l=lyx-devel=165779733507955=2)
> > >
> > > Thibaut Cuvelier
> >
> > Some ctests are failing on current master. I'm not sure if it's because
> > of your recent commit or not.
> >
> > But, for example, if I open up lib/doc/Additional.lyx, I get a message
> > about a module that is not found: theorems-ams-extended
> >
> > Also some tex2lyx tests are failing. Can you check those as well?
> >
> > Scott
> >
> >
> Hi Scott,
> 
> It is the fault of my patch, I will send a new one.

Thanks for the quick response and checking it, Udi!

@Thibaut thanks for reverting in the meantime.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Udicoudco]

On Sat, Dec 31, 2022 at 12:49 PM Udicoudco  wrote:

>
>
> On Sat, Dec 31, 2022 at 10:33 AM Thibaut Cuvelier 
> wrote:
>
>> On Sat, 31 Dec 2022 at 03:36, Scott Kostyshak  wrote:
>>
>>> On Sat, Dec 31, 2022 at 02:00:34AM +0100, Thibaut Cuvelier wrote:
>>> > I've pushed your patch online: 42c2a25fb8. I had to rebase it
>>> manually, I
>>> > hope I didn't make too many mistakes. I'm also attaching the patch to
>>> this
>>> > email so that you can check it more easily if you want.
>>> >
>>> > (If someone can add Udi to the blanket permissions, here is the link
>>> on the
>>> > mailing list: https://marc.info/?l=lyx-devel=165779733507955=2)
>>> >
>>> > Thibaut Cuvelier
>>>
>>> Some ctests are failing on current master. I'm not sure if it's because
>>> of your recent commit or not.
>>>
>>> But, for example, if I open up lib/doc/Additional.lyx, I get a message
>>> about a module that is not found: theorems-ams-extended
>>>
>>> Also some tex2lyx tests are failing. Can you check those as well?
>>>
>>
>> Given the failures, I'm reverting the commit, especially as Udi is
>> working on a new version. For the missing modules, I suppose that Udi
>> should restore the corresponding .module files, even if they just include
>> something else, or could we do something about it in lyx2lyx? (I.e. does
>> this change warrant a format update?)
>> --
>>
> I will restore the missing modules, so we don't need to do anything about
> lyx2lyx.
>

If i ill change the non-AMS modules to not use amsthm, and will add to
their name `-plain`
prefix, would it be possible to make lyx2lyx update files using e.g.
theorems.module to use
theorems-ams.module?

If so, I could add the changes to the non-AMS modules to the patch, but I
don't know anything about lyx2lyx.


>
>> lyx-devel mailing list
>> lyx-devel@lists.lyx.org
>> http://lists.lyx.org/mailman/listinfo/lyx-devel
>>
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Udicoudco]

On Sat, Dec 31, 2022 at 10:35 AM Thibaut Cuvelier 
wrote:

>
>
> How many such options would you add? Isn't it possible to implement the
> new options using arguments? Otherwise, I don't think it's too much of a
> problem to have many entries in the Modules menu, because it was
> restructured with 2.4. But having too many variants of Theorems might be a
> problem for beginners (I already had troubles with the AMS and non-AMS,
> extended or not, numbered by such and such, for the record).
>

I think that some of the confusion comes from the fact that the options for
the AMS and non-AMS are not symmetrical, and the fact that
currently the non-AMS actually use amsthm (this is the part I tried to fix
in the patch but it did not work, but it shouldn't be hard to fix).

If we would consider adding all the options to all three theorem backends
(LaTeX kernel, amsthm, and thmtools), there would
be 36 theorem modules (not including the starred theorems and named
theorems), as there will be 3 options for backends,
3 options for the parent counter (none, chapter, section), two options to
number-by type (yes/no), and two options for extended (yes, no).

Maybe it would be more user friendly to add a Theorems dialog to
Document->Settings? I think it was like that in old LyX versions.
The dialog could have a check box to indicate if the user wants to use
theorems or not.
If yes there would be a drop-down menu for each category to choose the type
of theorems
you want to use.

It will also help with the confusion that sometimes occurs with the fact
that some theorem modules
require other theorem modules to be loaded first.

I don't know how to implement that so it is just a proposal.
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Udicoudco]

On Sat, Dec 31, 2022 at 10:33 AM Thibaut Cuvelier 
wrote:

> On Sat, 31 Dec 2022 at 03:36, Scott Kostyshak  wrote:
>
>> On Sat, Dec 31, 2022 at 02:00:34AM +0100, Thibaut Cuvelier wrote:
>> > I've pushed your patch online: 42c2a25fb8. I had to rebase it manually,
>> I
>> > hope I didn't make too many mistakes. I'm also attaching the patch to
>> this
>> > email so that you can check it more easily if you want.
>> >
>> > (If someone can add Udi to the blanket permissions, here is the link on
>> the
>> > mailing list: https://marc.info/?l=lyx-devel=165779733507955=2)
>> >
>> > Thibaut Cuvelier
>>
>> Some ctests are failing on current master. I'm not sure if it's because
>> of your recent commit or not.
>>
>> But, for example, if I open up lib/doc/Additional.lyx, I get a message
>> about a module that is not found: theorems-ams-extended
>>
>> Also some tex2lyx tests are failing. Can you check those as well?
>>
>
> Given the failures, I'm reverting the commit, especially as Udi is working
> on a new version. For the missing modules, I suppose that Udi should
> restore the corresponding .module files, even if they just include
> something else, or could we do something about it in lyx2lyx? (I.e. does
> this change warrant a format update?)
> --
>
I will restore the missing modules, so we don't need to do anything about
lyx2lyx.


> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Thibaut Cuvelier]

On Sat, 31 Dec 2022 at 09:35, Udicoudco  wrote:

>
>
> In the last patch i sent only one module that support List of Theorems.
> In that module the theorems are numbered by type and within sections,
> Should I add new ones to support different numbering format?
> I don't want to ֲclog the modules menu too much.
>

How many such options would you add? Isn't it possible to implement the new
options using arguments? Otherwise, I don't think it's too much of a
problem to have many entries in the Modules menu, because it was
restructured with 2.4. But having too many variants of Theorems might be a
problem for beginners (I already had troubles with the AMS and non-AMS,
extended or not, numbered by such and such, for the record).
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Thibaut Cuvelier]

On Sat, 31 Dec 2022 at 03:36, Scott Kostyshak  wrote:

> On Sat, Dec 31, 2022 at 02:00:34AM +0100, Thibaut Cuvelier wrote:
> > I've pushed your patch online: 42c2a25fb8. I had to rebase it manually, I
> > hope I didn't make too many mistakes. I'm also attaching the patch to
> this
> > email so that you can check it more easily if you want.
> >
> > (If someone can add Udi to the blanket permissions, here is the link on
> the
> > mailing list: https://marc.info/?l=lyx-devel=165779733507955=2)
> >
> > Thibaut Cuvelier
>
> Some ctests are failing on current master. I'm not sure if it's because
> of your recent commit or not.
>
> But, for example, if I open up lib/doc/Additional.lyx, I get a message
> about a module that is not found: theorems-ams-extended
>
> Also some tex2lyx tests are failing. Can you check those as well?
>

Given the failures, I'm reverting the commit, especially as Udi is working
on a new version. For the missing modules, I suppose that Udi should
restore the corresponding .module files, even if they just include
something else, or could we do something about it in lyx2lyx? (I.e. does
this change warrant a format update?)
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Udicoudco]

In the last patch i sent only one module that support List of Theorems.
In that module the theorems are numbered by type and within sections,
Should I add new ones to support different numbering format?
I don't want to ֲclog the modules menu too much.
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Udicoudco]

On Sat, Dec 31, 2022 at 4:36 AM Scott Kostyshak  wrote:

> On Sat, Dec 31, 2022 at 02:00:34AM +0100, Thibaut Cuvelier wrote:
> > I've pushed your patch online: 42c2a25fb8. I had to rebase it manually, I
> > hope I didn't make too many mistakes. I'm also attaching the patch to
> this
> > email so that you can check it more easily if you want.
> >
> > (If someone can add Udi to the blanket permissions, here is the link on
> the
> > mailing list: https://marc.info/?l=lyx-devel=165779733507955=2)
> >
> > Thibaut Cuvelier
>
> Some ctests are failing on current master. I'm not sure if it's because
> of your recent commit or not.
>
> But, for example, if I open up lib/doc/Additional.lyx, I get a message
> about a module that is not found: theorems-ams-extended
>
> Also some tex2lyx tests are failing. Can you check those as well?
>
> Scott
>
>
Hi Scott,

It is the fault of my patch, I will send a new one.

Regards,
Udi

> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Udicoudco]

On Sat, Dec 31, 2022 at 3:00 AM Thibaut Cuvelier 
wrote:

> I've pushed your patch online: 42c2a25fb8. I had to rebase it manually, I
> hope I didn't make too many mistakes. I'm also attaching the patch to this
> email so that you can check it more easily if you want.
>
>
Hi Thibaut Cuvelier, thank you for the patch. After browsing LyX's bug
tracker in the past few weeks, i now realize that some of the changes i've
made on the subject discussed in this thread
  will
break backward compatibility and and will produce undesirable export to TeX
code (one that works, for example, the syntax won't be supported by IDEs).

 I will send today a patch regarding only the new module so it will be
easier to test it.


> (If someone can add Udi to the blanket permissions, here is the link on
> the mailing list: https://marc.info/?l=lyx-devel=165779733507955=2)
>
> Thibaut Cuvelier
>
>
> On Sat, 31 Dec 2022 at 01:00, Thibaut Cuvelier 
> wrote:
>
>> Hi,
>>
>> I'm jumping back in this discussion. There have been recent changes in
>> the DocBook implementation of theorems. Instead of setting DocBookTag and
>> DocBookAttr like this:
>>
>> DocBookTagpara
>> DocBookAttr   role='theorem'
>>
>> we now use a wrapper to delimit theorems:
>>
>> DocBookWrapperTag figure
>> DocBookWrapperAttrrole='theorem'
>> DocBookTagpara
>> DocBookGenerateTitle  true
>>
>> For your other theorems, just update the line role= with the right kind
>> of element (just like on master). I can take care of this step when merging
>> your patch, as there seems to be some consensus around it.
>>
>> I noticed you asked whether anything was required for lists of theorems
>> and the list: no, the DocBook processor is supposed to take care of that.
>>
>> As you gave permission to use your patch under the GPL in an earlier
>> message (why isn't it listed on https://www.lyx.org/BlanketPermission?),
>> I'm proceeding with integrating your patch :).
>>
>> All the best,
>> Thibaut Cuvelier
>>
>>
I will add these changes to the new patch.

Best Regards,
Udi
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Scott Kostyshak]

On Sat, Dec 31, 2022 at 02:00:34AM +0100, Thibaut Cuvelier wrote:
> I've pushed your patch online: 42c2a25fb8. I had to rebase it manually, I
> hope I didn't make too many mistakes. I'm also attaching the patch to this
> email so that you can check it more easily if you want.
> 
> (If someone can add Udi to the blanket permissions, here is the link on the
> mailing list: https://marc.info/?l=lyx-devel=165779733507955=2)
> 
> Thibaut Cuvelier

Some ctests are failing on current master. I'm not sure if it's because
of your recent commit or not.

But, for example, if I open up lib/doc/Additional.lyx, I get a message
about a module that is not found: theorems-ams-extended

Also some tex2lyx tests are failing. Can you check those as well?

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Thibaut Cuvelier]

Hi,

I'm jumping back in this discussion. There have been recent changes in the
DocBook implementation of theorems. Instead of setting DocBookTag and
DocBookAttr like this:

DocBookTagpara
DocBookAttr   role='theorem'

we now use a wrapper to delimit theorems:

DocBookWrapperTag figure
DocBookWrapperAttrrole='theorem'
DocBookTagpara
DocBookGenerateTitle  true

For your other theorems, just update the line role= with the right kind of
element (just like on master). I can take care of this step when merging
your patch, as there seems to be some consensus around it.

I noticed you asked whether anything was required for lists of theorems and
the list: no, the DocBook processor is supposed to take care of that.

As you gave permission to use your patch under the GPL in an earlier
message (why isn't it listed on https://www.lyx.org/BlanketPermission?),
I'm proceeding with integrating your patch :).

All the best,
Thibaut Cuvelier


On Mon, 7 Nov 2022 at 23:29, Paul A. Rubin  wrote:

> On 10/13/22 02:45, Udicoudco wrote:
>
>
>
> On Fri, Sep 23, 2022 at 12:25 AM Paul A. Rubin 
> wrote:
>
>> On 9/19/22 22:26, Udicoudco wrote:
>>
>> I've noticed that the definition environment is not numbered in the
>> output files. After checking the module again, I hope there are no
>> issues any more. The fixed module is attached.
>>
>> Regards,
>> Udi
>>
>>
>> I noticed a new pathology with this version. Steps to reproduce are as
>> follows:
>>
>>1. Compile the test_thmtools_module.lyx document (which works fine).
>>2. Delete the entire contents of section 2, other than the section
>>heading, and recompile. I've attached the PDF I get. Note the garbled
>>contents where the theorem lists go.
>>3. Make any minor edit to the document (to force a fresh compile) and
>>recompile. The output is as expected.
>>
>> HTH,
>>
>> Paul
>> --
>>
>
> Hi Paul,
>
> Sorry for the late reply, it is the holiday season in my country.
>
> I've managed to solve this issue with a simple trick. The updated module
> can be found in here .
> If you will try it again, I would be glad to hear from you.
>
> Best Regards,
> Udi
>
>> lyx-devel mailing list
>> lyx-devel@lists.lyx.org
>> http://lists.lyx.org/mailman/listinfo/lyx-devel
>>
>
> Udi,
>
> Speaking of late replies, it's my turn to apologize. You posted this just
> as I was heading out to a conference. Since getting back, I've been
> (slowly) catching up on accumulated work.
>
> I just tested the updated module, and can confirm that the problem I
> noticed is gone. Good job!
>
> Paul
>
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Paul A. Rubin]

On 10/13/22 02:45, Udicoudco wrote:



On Fri, Sep 23, 2022 at 12:25 AM Paul A. Rubin  
wrote:


On 9/19/22 22:26, Udicoudco wrote:

I've noticed that the definition environment is not numbered in the
output files. After checking the module again, I hope there are no
issues any more. The fixed module is attached.

Regards,
Udi


I noticed a new pathology with this version. Steps to reproduce
are as follows:

 1. Compile the test_thmtools_module.lyx document (which works fine).
 2. Delete the entire contents of section 2, other than the
section heading, and recompile. I've attached the PDF I get.
Note the garbled contents where the theorem lists go.
 3. Make any minor edit to the document (to force a fresh compile)
and recompile. The output is as expected.

HTH,

Paul

--


Hi Paul,

Sorry for the late reply, it is the holiday season in my country.

I've managed to solve this issue with a simple trick. The updated 
module can be found in here .

If you will try it again, I would be glad to hear from you.

Best Regards,
Udi

lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel



Udi,

Speaking of late replies, it's my turn to apologize. You posted this 
just as I was heading out to a conference. Since getting back, I've been 
(slowly) catching up on accumulated work.


I just tested the updated module, and can confirm that the problem I 
noticed is gone. Good job!


Paul
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Udicoudco]

On Fri, Sep 23, 2022 at 12:25 AM Paul A. Rubin  wrote:

> On 9/19/22 22:26, Udicoudco wrote:
>
> I've noticed that the definition environment is not numbered in the
> output files. After checking the module again, I hope there are no
> issues any more. The fixed module is attached.
>
> Regards,
> Udi
>
>
> I noticed a new pathology with this version. Steps to reproduce are as
> follows:
>
>1. Compile the test_thmtools_module.lyx document (which works fine).
>2. Delete the entire contents of section 2, other than the section
>heading, and recompile. I've attached the PDF I get. Note the garbled
>contents where the theorem lists go.
>3. Make any minor edit to the document (to force a fresh compile) and
>recompile. The output is as expected.
>
> HTH,
>
> Paul
> --
>

Hi Paul,

Sorry for the late reply, it is the holiday season in my country.

I've managed to solve this issue with a simple trick. The updated module
can be found in here .
If you will try it again, I would be glad to hear from you.

Best Regards,
Udi

> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Paul A. Rubin]

On 9/19/22 22:26, Udicoudco wrote:

I've noticed that the definition environment is not numbered in the
output files. After checking the module again, I hope there are no
issues any more. The fixed module is attached.

Regards,
Udi

I noticed a new pathology with this version. Steps to reproduce are as 
follows:


1. Compile the test_thmtools_module.lyx document (which works fine).
2. Delete the entire contents of section 2, other than the section
   heading, and recompile. I've attached the PDF I get. Note the
   garbled contents where the theorem lists go.
3. Make any minor edit to the document (to force a fresh compile) and
   recompile. The output is as expected.

HTH,

Paul


test_thmtools_module.pdf
Description: Adobe PDF document
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Udicoudco]

> I'm jumping in the conversation as my ears were buzzing :).

Hello Thibaut ,

>
>
> @Udi: as long as your new theorems are roughly similar to the previous ones 
> (without more nesting, for instance), you should be able to use exactly the 
> same configuration. I haven't been focusing on having the smallest 
> configuration that works yet. If you need help or want to delegate the 
> DocBook export, no problem, just let me know :). I think that we can proceed 
> with merging your patch without any DocBook-related changes first (unless 
> your module makes the DocBook export crash, I believe that's not likely t 
> all), then I can have a look later on. But everything DocBook requires LyX 
> 2.4, that might make it harder for you to test.

I've decided to try and build the master, as I wanted to fix some
modules as discussed here. I've followed the instructions on the LyX
"How To Use Git" page and I believe everything went fine (as this is
my first time, i'm not sure).
I've added the docbook tags to my module (But i did not know what
should be in the List of Theorems, if any), tested DocBook export, and
it seems to work.

>
> Nevertheless, it would be best to have an example document with all your new 
> constructs to be used in the test suite (a file like 
> autotests/export/docbook/theorems-thmtools.lyx), even if you don't touch the 
> DocBook part: it would be very useful in the longer term to ensure that 
> nothing breaks regarding the DocBook export of your new constructs, and also 
> simply to write the required configuration. You would be the best person to 
> build this document, as you know how everything is supposed to be used, I 
> would have to figure it out almost from scratch.
> I have noticed your included test_thmtools_module.lyx, but I don't know how 
> complete it is :).

I've added a file, with a name you suggested, containing all the
layouts defined in the module, and It's exported to DocBook.

Best regards,
Udi

On Tue, Sep 20, 2022 at 11:31 PM Thibaut Cuvelier  wrote:
>
> On Tue, 20 Sept 2022 at 16:54, Kornel Benko  wrote:
>>
>> Am Tue, 20 Sep 2022 16:57:02 +0300
>> schrieb Udicoudco :
>>
>> > On Tue, Sep 20, 2022 at 4:36 PM Kornel Benko  wrote:
>> > >
>> > > Am Tue, 20 Sep 2022 05:26:49 +0300
>> > > schrieb Udicoudco :
>> >
>> > > You may want to add the module to the list of math-modules.
>> > > Add
>> > > #\DeclareCategory{Maths}
>> > > as the second line (before the #DescriptionBegin)
>> >
>> > Hi Kornel,
>> >
>> > Thank you for the suggestion, I'm guessing this is related to the
>> > redesigned module selection dialog in LyX 2.4?
>>
>> Yes, that is the case.
>>
>> > Also, could you care to explain what is the purpose of the new tags i
>> > saw in the master (DocBookWrapperTag, DocBookTag, DocBookAttr)?
>>
>> They are important for export to docbook (in contrast to exporting to pdf 
>> via some latex
>> engine)
>> But the better reference person (than me) is Thibaut Cuvelier 
>> (tcuvel...@lyx.org).
>>
>> > It
>> > might be a good idea to add those too, but i did not want to add these
>> > without knowing their functionality (I've noticed that all theorem
>> > layouts has "DocBookTag   para" wouldn't it be copied with the
>> > CopyStyle tag?)
>>
>> You should test docbook export before this can go to trunk IMO. But Thibaut 
>> can help you
>> more.
>
>
> I'm jumping in the conversation as my ears were buzzing :).
>
> @Udi: as long as your new theorems are roughly similar to the previous ones 
> (without more nesting, for instance), you should be able to use exactly the 
> same configuration. I haven't been focusing on having the smallest 
> configuration that works yet. If you need help or want to delegate the 
> DocBook export, no problem, just let me know :). I think that we can proceed 
> with merging your patch without any DocBook-related changes first (unless 
> your module makes the DocBook export crash, I believe that's not likely t 
> all), then I can have a look later on. But everything DocBook requires LyX 
> 2.4, that might make it harder for you to test.
>
> Nevertheless, it would be best to have an example document with all your new 
> constructs to be used in the test suite (a file like 
> autotests/export/docbook/theorems-thmtools.lyx), even if you don't touch the 
> DocBook part: it would be very useful in the longer term to ensure that 
> nothing breaks regarding the DocBook export of your new constructs, and also 
> simply to write the required configuration. You would be the best person to 
> build this document, as you know how everything is supposed to be used, I 
> would have to figure it out almost from scratch.
> I have noticed your included test_thmtools_module.lyx, but I don't know how 
> complete it is :).
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
<>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Thibaut Cuvelier]

On Tue, 20 Sept 2022 at 16:54, Kornel Benko  wrote:

> Am Tue, 20 Sep 2022 16:57:02 +0300
> schrieb Udicoudco :
>
> > On Tue, Sep 20, 2022 at 4:36 PM Kornel Benko  wrote:
> > >
> > > Am Tue, 20 Sep 2022 05:26:49 +0300
> > > schrieb Udicoudco :
> >
> > > You may want to add the module to the list of math-modules.
> > > Add
> > > #\DeclareCategory{Maths}
> > > as the second line (before the #DescriptionBegin)
> >
> > Hi Kornel,
> >
> > Thank you for the suggestion, I'm guessing this is related to the
> > redesigned module selection dialog in LyX 2.4?
>
> Yes, that is the case.
>
> > Also, could you care to explain what is the purpose of the new tags i
> > saw in the master (DocBookWrapperTag, DocBookTag, DocBookAttr)?
>
> They are important for export to docbook (in contrast to exporting to pdf
> via some latex
> engine)
> But the better reference person (than me) is Thibaut Cuvelier (
> tcuvel...@lyx.org).
>
> > It
> > might be a good idea to add those too, but i did not want to add these
> > without knowing their functionality (I've noticed that all theorem
> > layouts has "DocBookTag   para" wouldn't it be copied with the
> > CopyStyle tag?)
>
> You should test docbook export before this can go to trunk IMO. But
> Thibaut can help you
> more.
>

I'm jumping in the conversation as my ears were buzzing :).

@Udi: as long as your new theorems are roughly similar to the previous ones
(without more nesting, for instance), you should be able to use exactly the
same configuration. I haven't been focusing on having the smallest
configuration that works yet. If you need help or want to delegate the
DocBook export, no problem, just let me know :). I think that we can
proceed with merging your patch without any DocBook-related changes first
(unless your module makes the DocBook export crash, I believe that's not
likely t all), then I can have a look later on. But everything DocBook
requires LyX 2.4, that might make it harder for you to test.

Nevertheless, it would be best to have an example document with all your
new constructs to be used in the test suite (a file like
autotests/export/docbook/theorems-thmtools.lyx), even if you don't touch
the DocBook part: it would be very useful in the longer term to ensure that
nothing breaks regarding the DocBook export of your new constructs, and
also simply to write the required configuration. You would be the best
person to build this document, as you know how everything is supposed to be
used, I would have to figure it out almost from scratch.
I have noticed your included test_thmtools_module.lyx, but I don't know how
complete it is :).
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Kornel Benko]

Am Tue, 20 Sep 2022 16:57:02 +0300
schrieb Udicoudco :

> On Tue, Sep 20, 2022 at 4:36 PM Kornel Benko  wrote:
> >
> > Am Tue, 20 Sep 2022 05:26:49 +0300
> > schrieb Udicoudco :  
> 
> > You may want to add the module to the list of math-modules.
> > Add
> > #\DeclareCategory{Maths}
> > as the second line (before the #DescriptionBegin)  
> 
> Hi Kornel,
> 
> Thank you for the suggestion, I'm guessing this is related to the
> redesigned module selection dialog in LyX 2.4?

Yes, that is the case.

> Also, could you care to explain what is the purpose of the new tags i
> saw in the master (DocBookWrapperTag, DocBookTag, DocBookAttr)?

They are important for export to docbook (in contrast to exporting to pdf via 
some latex
engine)
But the better reference person (than me) is Thibaut Cuvelier 
(tcuvel...@lyx.org).

> It
> might be a good idea to add those too, but i did not want to add these
> without knowing their functionality (I've noticed that all theorem
> layouts has "DocBookTag   para" wouldn't it be copied with the
> CopyStyle tag?)

You should test docbook export before this can go to trunk IMO. But Thibaut can 
help you
more.

> Regrads,
> Udi

Kornel



pgpe_N4CRzqVx.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Udicoudco]

On Tue, Sep 20, 2022 at 4:36 PM Kornel Benko  wrote:
>
> Am Tue, 20 Sep 2022 05:26:49 +0300
> schrieb Udicoudco :

> You may want to add the module to the list of math-modules.
> Add
> #\DeclareCategory{Maths}
> as the second line (before the #DescriptionBegin)

Hi Kornel,

Thank you for the suggestion, I'm guessing this is related to the
redesigned module selection dialog in LyX 2.4?
Also, could you care to explain what is the purpose of the new tags i
saw in the master (DocBookWrapperTag, DocBookTag, DocBookAttr)? It
might be a good idea to add those too, but i did not want to add these
without knowing their functionality (I've noticed that all theorem
layouts has "DocBookTag   para" wouldn't it be copied with the
CopyStyle tag?)

Regrads,
Udi
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Kornel Benko]

Am Tue, 20 Sep 2022 05:26:49 +0300
schrieb Udicoudco :

> I've noticed that the definition environment is not numbered in the
> output files. After checking the module again, I hope there are no
> issues any more. The fixed module is attached.
> 
> Regards,
> Udi

You may want to add the module to the list of math-modules.
Add
#\DeclareCategory{Maths}
as the second line (before the #DescriptionBegin)

Kornel


pgpTeyGF3QkyA.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Udicoudco]

I've noticed that the definition environment is not numbered in the
output files. After checking the module again, I hope there are no
issues any more. The fixed module is attached.

Regards,
Udi


theorems-thmtools.module
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Udicoudco]

On Fri, Sep 16, 2022 at 9:30 PM Paul A. Rubin  wrote:
>
> On 9/15/22 20:24, Udicoudco wrote:
> > While trying to solve this issue, I also realised that if a user would
> > use a bilingual document, with theorems used in two languages, he will
> > only see the labels (in the list of theorems) of the language at which
> > the list of theorems will be written.
> >
> > I believe I was able to solve both bugs, the new module file is attached.
> >
> > Regards,
> > Udi
> >
> Udi,
>
> Thanks for the detailed explanation. I tested the new module file, and
> it seems to fix the issue of what happens if you delete all instances of
> one species of environment and then recompile. While testing the other
> issue (list of theorems when there are none), I encountered a new pathology.
>
> Start with an empty document, add your module, insert a list of theorems
> (and nothing else) and compile. An error occurs. The same error happens
> if I start with one or more theorem type environments present, compile
> (which works), then delete them and recompile (which bombs).

Hi Paul,

I fixed this bug in the attached module file.

> I was also wondering whether the menu item to insert a list of theorems
> could be added to the Insert > List / TOC menu via a tweak to the layout
> file. I suspect this is possible, but one of the developers more
> familiar with layouts than I am might have to weigh in with the details.
> It's the first place I would look when trying to insert a list of theorems.

To my knowledge, Modules can only add layouts to specific menus,
depending on the   layout type. I think that to add the list of
theorems to the List / ToC menu, we have to change a file in the ui
folder, called stdmenus.inc. If you recall any module file that add an
inset into the List / ToC menu, I could read it's file and maybe infer
how to do that.



> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel


theorems-thmtools.module
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Paul A. Rubin]

On 9/15/22 20:24, Udicoudco wrote:

While trying to solve this issue, I also realised that if a user would
use a bilingual document, with theorems used in two languages, he will
only see the labels (in the list of theorems) of the language at which
the list of theorems will be written.

I believe I was able to solve both bugs, the new module file is attached.

Regards,
Udi


Udi,

Thanks for the detailed explanation. I tested the new module file, and 
it seems to fix the issue of what happens if you delete all instances of 
one species of environment and then recompile. While testing the other 
issue (list of theorems when there are none), I encountered a new pathology.


Start with an empty document, add your module, insert a list of theorems 
(and nothing else) and compile. An error occurs. The same error happens 
if I start with one or more theorem type environments present, compile 
(which works), then delete them and recompile (which bombs).


I was also wondering whether the menu item to insert a list of theorems 
could be added to the Insert > List / TOC menu via a tweak to the layout 
file. I suspect this is possible, but one of the developers more 
familiar with layouts than I am might have to weigh in with the details. 
It's the first place I would look when trying to insert a list of theorems.


Cheers,
Paul

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Udicoudco]

On Thu, Sep 15, 2022 at 9:54 PM Paul A. Rubin  wrote:
>
> On 9/13/22 18:48, Udicoudco wrote:
>
> On Tue, Aug 30, 2022 at 10:27 AM Jürgen Spitzmüller  wrote:
>
> Am Donnerstag, dem 14.07.2022 um 14:17 +0300 schrieb Udicoudco:
>
> Hello again,
>
> Hi,
>
> Hi Jürgen,
> Thank you for the reply.
>
> Thanks for this and sorry for the late reply. Most people are busy with
> their real lifes.
>
> No apologies needed, thank  you all for developing great software.
>
> I had some mistakes in the .inc file and the .lyx file. The updated
> files are attached.
>
> As I do not use theorems myself, I cannot comment on the usage and
> usefulness of thmtools and the need for a module. So you probably have
> to be even more patient until the math users are back.
>
> Well, the matter is not urgent, and I have patience :).
>
> One remark on the layout:
>
> AddToPreamble
>  \usepackage{amsthm}
>  \usepackage{thmtools}
> EndPreamble
>
> At least for amsthm, this should rather be
>
> Require amsthm
>
> I've fixed this issue (see the attached file). I'v also used the
> DependsOn key so that the module will call thmtools only once.
>
> I think also thmtools should be added to the packages LyX knows and
> loaded that way.
>
> I don't know how to do that.
>
> Regards,
> Udi
>
>
> Hi Udi,
>
> I've been playing a bit with your module, and I've encountered a couple of 
> non-fatal issues. The first may sound a bit silly. If you have a list of 
> theorems but do not have any theorem-like environments (either because you 
> put in the list of theorems code first or because you deleted all the things 
> that would have been listed and have not yet added new ones), the document 
> will not compile because the thm-tools package has not been loaded. Either 
> requiring thm-tools in the list of theorems environment or making it depend 
> on theorems (the way claim, lemma etc. do) should cure that.
>

Hi paul,

Thank you for trying out the module. I actually made the List of
Theorems layout dependent on the Theorem layout, but it seems that LyX
does not support the key DependsOn with flex insets, so in the new
module file the List of Theorems layout loads thmtools.

> The second one is perhaps a bug in the thm-tools package itself. To reproduce 
> it, you can follow these steps.

Actually, it is not a bug in thmtools, it is just how latex works (see
the explanation below) with aux files, toc files, etc., but I did not
think of a situation such as you described when I wrote the module.

To write all the information needed to be in aux files and such, LaTeX
checks at the end of the compilation (for example, in thmtools it is
done with \AtEndDocument) if the aux file exists, if not it will
create one and write the information in it, if yes, it will update
what it needs to update. It does that at the end of the document so
there won't be a need to open the file and close it several times,
which might prolong compilation time.

When you call a macro such as \tableofcontents, or \listoftheorems in
our case, it will try to read the toc, or loe file, and get the
contents of the list from there, and since this file has not been
written yet (as it will be created at the end)  the Table of Contents
or List of Theorems will be empty after the first compilation of a tex
file.

In LyX we don't experiencing it, since it will compile a number of
times, until the toc or lot will be with the right contents (which
usually takes two compilations), all the references  will have the
correct numbering and pages (which might take more than two
compilations) and there are more stuff that requires multiple
compilations.

> Open your test_thmtools_module.lyx file and compile it (which works, of 
> course).
> Delete the claims in section 2 (so that section 2 begins with Conjecture 2.1) 
> and recompile. When I do this, I get four undefined control sequence errors, 
> at least three of which contain the macro \claimname. If I select "view 
> output anyway", the document seems to display correctly.

Each layout in the module defines a macro that holds the label of the
theorem (for example, for the Claim layouts it was \claimname). Since
we can't know in which language the user will use, we must make the
label protected, so it would not expand early, and we can change it
according to the language. A side effect of that, is the fact that
this macro was written to the loe file, without being expanded, and
thus remain as \claimname. After you erased the Claim layouts,
\claimname was was never defined, and the loe file will update at the
end of the compilation, after \listoftheorems already read the loe
file, and did not know what is \claimname.

> Now it gets goofier. If I make some trivial text edit (just to force a 
> recompilation), say adding a character to the section heading, and recompile, 
> the document compiles correctly without the error messages.

At the second compilation, the loe file has already been updated, and
\claimname was erased from there, 

Re: New Theorems Module

[Paul A. Rubin]

On 9/13/22 18:48, Udicoudco wrote:

On Tue, Aug 30, 2022 at 10:27 AM Jürgen Spitzmüller  wrote:

Am Donnerstag, dem 14.07.2022 um 14:17 +0300 schrieb Udicoudco:

Hello again,

Hi,

Hi Jürgen,
Thank you for the reply.


Thanks for this and sorry for the late reply. Most people are busy with
their real lifes.

No apologies needed, thank  you all for developing great software.


I had some mistakes in the .inc file and the .lyx file. The updated
files are attached.

As I do not use theorems myself, I cannot comment on the usage and
usefulness of thmtools and the need for a module. So you probably have
to be even more patient until the math users are back.

Well, the matter is not urgent, and I have patience :).


One remark on the layout:

AddToPreamble
  \usepackage{amsthm}
  \usepackage{thmtools}
EndPreamble

At least for amsthm, this should rather be

Require amsthm

I've fixed this issue (see the attached file). I'v also used the
DependsOn key so that the module will call thmtools only once.


I think also thmtools should be added to the packages LyX knows and
loaded that way.

I don't know how to do that.

Regards,
Udi


Hi Udi,

I've been playing a bit with your module, and I've encountered a couple 
of non-fatal issues. The first may sound a bit silly. If you have a list 
of theorems but do not have any theorem-like environments (either 
because you put in the list of theorems code first or because you 
deleted all the things that would have been listed and have not yet 
added new ones), the document will not compile because the thm-tools 
package has not been loaded. Either requiring thm-tools in the list of 
theorems environment or making it depend on theorems (the way claim, 
lemma etc. do) should cure that.


The second one is perhaps a bug in the thm-tools package itself. To 
reproduce it, you can follow these steps.


1. Open your test_thmtools_module.lyx file and compile it (which works,
   of course).
2. Delete the claims in section 2 (so that section 2 begins with
   Conjecture 2.1) and recompile. When I do this, I get four undefined
   control sequence errors, at least three of which contain the macro
   \claimname. If I select "view output anyway", the document seems to
   display correctly.
3. Now it gets goofier. If I make some trivial text edit (just to force
   a recompilation), say adding a character to the section heading, and
   recompile, the document compiles correctly without the error messages.

Something similar happens if, in step 2, I delete all the definitions 
rather than all the claims, except that the errors now refer to 
\definitionname. It's important to note that this only happens if I 
compile the original document first. If I open the document, delete 
claims or definitions, and then compile for the first time, there is no 
error. So something is carrying over (in the buffer directory) from the 
initial compilation that maybe ought not carry over. Also, it only seems 
to happen when I delete all of one type of environment (all claims, all 
definitions, ...). As long as I leave one claim or one definition 
intact, the error does not occur.


I did a little digging. It turns out that compilation creates both a 
.aux file and a .loe file in the buffer directory. After compiling the 
full document, both contain instances of \claimname. After deleting all 
claims and recompiling (producing the error messages), both are rebuilt 
with no references to \claimname. If, however, I delete either one after 
compiling the full document and before compiling the edited version, the 
edited version generates no error messages. So I suspect there is some 
sort of timing issue here, in which the first compilation of the edited 
document inherits some undefined instances of \claimname (missing from 
both .aux and .loe after they were rebuilt) whereas a recompilation does 
not inherit \claimname. Deleting either the .aux or .loe file may force 
them to rebuilt before \claimname leaks into the main document. I hope 
that makes sense. (If it does, please explain to me what I just wrote. :-))


Cheers,

Paul
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Udicoudco]

On Tue, Aug 30, 2022 at 10:27 AM Jürgen Spitzmüller  wrote:
>
> Am Donnerstag, dem 14.07.2022 um 14:17 +0300 schrieb Udicoudco:
> > Hello again,
>
> Hi,

Hi Jürgen,
Thank you for the reply.

> Thanks for this and sorry for the late reply. Most people are busy with
> their real lifes.

No apologies needed, thank  you all for developing great software.

> > I had some mistakes in the .inc file and the .lyx file. The updated
> > files are attached.
>
> As I do not use theorems myself, I cannot comment on the usage and
> usefulness of thmtools and the need for a module. So you probably have
> to be even more patient until the math users are back.

Well, the matter is not urgent, and I have patience :).

> One remark on the layout:
>
> AddToPreamble
>  \usepackage{amsthm}
>  \usepackage{thmtools}
> EndPreamble
>
> At least for amsthm, this should rather be
>
> Require amsthm

I've fixed this issue (see the attached file). I'v also used the
DependsOn key so that the module will call thmtools only once.

> I think also thmtools should be added to the packages LyX knows and
> loaded that way.

I don't know how to do that.

Regards,
Udi


theorems-thmtools.module
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: New Theorems Module

[Jürgen Spitzmüller]

Am Donnerstag, dem 14.07.2022 um 14:17 +0300 schrieb Udicoudco:
> Hello again,

Hi,

Thanks for this and sorry for the late reply. Most people are busy with
their real lifes.

> 
> I had some mistakes in the .inc file and the .lyx file. The updated
> files are attached. 

As I do not use theorems myself, I cannot comment on the usage and
usefulness of thmtools and the need for a module. So you probably have
to be even more patient until the math users are back.

One remark on the layout:

AddToPreamble
 \usepackage{amsthm}
 \usepackage{thmtools}
EndPreamble

At least for amsthm, this should rather be

Require amsthm

I think also thmtools should be added to the packages LyX knows and
loaded that way.

> I also grant permission to licence this  module under the Gnu General
> Public Licence. I don't know if this was the intention by "giving
> permission". 

Yes, this should be sufficient.

Best,
Jürgen


> 
> ‫בתאריך יום ה׳, 14 ביולי 2022 ב-7:20 מאת ‪Udicoudco‬‏
> <‪udifog...@gmail.com‬‏>:‬
> > 
> > Hello, 
> > 
> > I wrote a module that provides essentially the same layouts as the
> > " Theorems (Numbered by Type within Sections)" module, but with a
> > new feature, a list of theorems. I don't know if this is the right
> > place to send it to, but in the attached files there are the module
> > files, a lyx file with a description of the module and the pdf
> > output of the lyx file. I tried to write it as close as possible to
> > generic theorems module already implemented in lyx. 
> > 
> > Best Regards,
> > Udi Fogiel

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel