/tech/tc/httpredirects/
Thanks,
Dawit Alemayehu
wonder what Mozilla/Chromium
send when the windowing system is something other than X11. Probably the same
thing.
- Dawit Alemayehu
On Feb. 13, 2014, 1:03 p.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail
1351119
kio/kio/accessmanager.cpp 7a806e8
kio/kio/job.cpp 13107c2
kioslave/http/http.cpp b13eed1
Diff: https://git.reviewboard.kde.org/r/115689/diff/
Testing
---
Tested HEAD redirection with http://greenbytes.de/tech/tc/httpredirects/
Thanks,
Dawit Alemayehu
/http.cpp b13eed1
Diff: https://git.reviewboard.kde.org/r/115651/diff/
Testing
---
Run tests at
http://greenbytes.de/tech/tc/httpredirects/t301methods.html
http://greenbytes.de/tech/tc/httpredirects/t302methods.html
http://greenbytes.de/tech/tc/httpredirects/t303methods.html
Thanks,
Dawit
is not returned when
doing a stat operation like HEAD.
Diffs
-
Diff: https://git.reviewboard.kde.org/r/115689/diff/
Testing
---
Tested HEAD redirection with http://greenbytes.de/tech/tc/httpredirects/
Thanks,
Dawit Alemayehu
the following:
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko)
Chrome/32.0.1700.107 Safari/537.36
So removing the platform name from the user-agent string might have
consequences on sites that rely on it.
- Dawit Alemayehu
On Feb. 10, 2014, 9:15 a.m., Martin Gräßlin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115250/#review49496
---
Ship it!
Ship It!
- Dawit Alemayehu
On Jan. 23, 2014, 11
is much simpler. See
https://git.reviewboard.kde.org/r/114926/
- Dawit Alemayehu
On Jan. 9, 2014, 12:09 p.m., Jonathan Marten wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114924
. This results the
View-View Mode items not being updated correctly when the mode is changed
through Dolphin's view mode toolbar.
Diffs
-
konqueror/src/konqmainwindow.cpp 8a21c1b
Diff: https://git.reviewboard.kde.org/r/114926/diff/
Testing
---
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/114926/diff/
Testing
---
Thanks,
Dawit Alemayehu
Window.
6. In the new Konqueror window that is opened with the site or directory you
last visited, repeat step #5.
Step #6 should result in a crash.
Thanks,
Dawit Alemayehu
a site or browse a directory.
4. Close it.
5. Launch it again and click on Edit-Undo: Closed Window.
6. In the new Konqueror window that is opened with the site or directory you
last visited, repeat step #5.
Step #6 should result in a crash.
Thanks,
Dawit Alemayehu
-43cf-b3fa-18cc0a44b212__before.png
Add new folder w/ patch
https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/353b3c50-ccc8-4390-9d76-a9f85a703987__after.png
Thanks,
Dawit Alemayehu
-b3fa-18cc0a44b212__before.png
Add new folder w/ patch
https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/353b3c50-ccc8-4390-9d76-a9f85a703987__after.png
Thanks,
Dawit Alemayehu
-b3fa-18cc0a44b212__before.png
Add new folder w/ patch
https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/353b3c50-ccc8-4390-9d76-a9f85a703987__after.png
Thanks,
Dawit Alemayehu
. This prevents a message box in one window from blocking
all other windows.
Diffs
-
kio/kio/jobuidelegate.cpp 8534863
Diff: https://git.reviewboard.kde.org/r/114436/diff/
Testing
---
Thanks,
Dawit Alemayehu
state :-/
[1] http://en.munknex.net/2012/06/new-kde-copy-dialog-first-preview.html
Dawit Alemayehu wrote:
1. Why should these dialogs be modal at all? Everything that KIO does
is asynchronous, so it could very well be that the window isn't even
showing the directory (where
/uploaded/files/2013/12/15/1be1b4c9-eddd-43cf-b3fa-18cc0a44b212__before.png
Add new folder w/ patch
https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/353b3c50-ccc8-4390-9d76-a9f85a703987__after.png
Thanks,
Dawit Alemayehu
-18cc0a44b212__before.png
Add new folder w/ patch
https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/353b3c50-ccc8-4390-9d76-a9f85a703987__after.png
Thanks,
Dawit Alemayehu
clicks on OpenWith in the context
menu or unknown file in the Dolphin part.
Diffs
-
kio/kio/krun.cpp ad5656e
Diff: https://git.reviewboard.kde.org/r/114473/diff/
Testing
---
Thanks,
Dawit Alemayehu
https://bugs.kde.org/show_bug.cgi?id=302342
Dawit Alemayehu ada...@kde.org changed:
What|Removed |Added
Component|file|kdewebkit
Platform
state :-/
[1] http://en.munknex.net/2012/06/new-kde-copy-dialog-first-preview.html
Dawit Alemayehu wrote:
1. Why should these dialogs be modal at all? Everything that KIO does
is asynchronous, so it could very well be that the window isn't even
showing the directory (where
/kio/krun.cpp ad5656e
Diff: http://git.reviewboard.kde.org/r/114473/diff/
Testing
---
Thanks,
Dawit Alemayehu
/
Testing
---
Thanks,
Dawit Alemayehu
/uploaded/files/2013/12/15/353b3c50-ccc8-4390-9d76-a9f85a703987__after.png
Thanks,
Dawit Alemayehu
---
On Dec. 13, 2013, 1:53 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114436
/kio/jobuidelegate.cpp 8534863
Diff: http://git.reviewboard.kde.org/r/114436/diff/
Testing
---
Thanks,
Dawit Alemayehu
On Nov. 28, 2013, 5:17 a.m., Dawit Alemayehu wrote:
konqueror/settings/kio/kproxydlg.cpp, line 295
http://git.reviewboard.kde.org/r/114105/diff/1/?file=219633#file219633line295
nitpick: no need for KSaveIOConfig here.
Andrea Iacovitti wrote:
?. Not sure what do you mean
On Nov. 28, 2013, 5:17 a.m., Dawit Alemayehu wrote:
konqueror/settings/kio/kproxydlg.cpp, line 444
http://git.reviewboard.kde.org/r/114105/diff/1/?file=219633#file219633line444
This does not make sense. I explicitly check show me the value and you
uncheck it as a result of me
-setChecked(false);
- Dawit Alemayehu
On Nov. 27, 2013, 9:22 p.m., Andrea Iacovitti wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114105
On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote:
It's been stalled for almost three months now, any chance to see progress
or should it be discarded?
Mark Gaiser wrote:
No, it should most certainly not be disgarded. It was even working when i
posted this post up for review.
://git.reviewboard.kde.org/r/114105/#comment31874
This does not make sense. I explicitly check show me the value and you
uncheck it as a result of me clicking on the Auto Detect button? No.
- Dawit Alemayehu
On Nov. 27, 2013, 9:22 p.m., Andrea Iacovitti wrote
On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote:
It's been stalled for almost three months now, any chance to see progress
or should it be discarded?
Mark Gaiser wrote:
No, it should most certainly not be disgarded. It was even working when i
posted this post up for review.
/kio_smb_internal.cpp 3c35583
kioslave/smb/smb.protocol 654bcfb
Diff: http://git.reviewboard.kde.org/r/112982/diff/
Testing
---
- Copied files to and from smb share.
- Resumed interrupted file copy to and from smb share.
Thanks,
Dawit Alemayehu
files to and from smb share.
- Resumed interrupted file copy to and from smb share.
Thanks,
Dawit Alemayehu
to such a large
value. See
http://blogs.msdn.com/b/openspecification/archive/2009/04/10/smb-maximum-transmit-buffer-size-and-performance-tuning.aspx
- Dawit Alemayehu
On Nov. 17, 2013, 8:33 p.m., Federico Cuello wrote
.
Thanks,
Dawit Alemayehu
3c35583
kioslave/smb/smb.protocol 654bcfb
Diff: http://git.reviewboard.kde.org/r/112982/diff/
Testing
---
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/113785/#review43352
---
On Nov. 10, 2013, 2:51 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
/113785/diff/
Testing
---
Thanks,
Dawit Alemayehu
(org.kde.KPAC.ProxyScout));
if (proxyScout.isValid()) {
Q_FOREACH(const KUrl url, badProxyUrls) {
(void)proxyScout.asyncCall(QLatin1String(blackListProxy), url.url());
}
}
- Dawit Alemayehu
On Oct. 28, 2013, 9:52 p.m., Andrea Iacovitti wrote
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113492/#review42672
---
Ship it!
Ship It!
- Dawit Alemayehu
On Oct. 29, 2013, 5:40
support for the other
half, the copyFromFile optimization.
Diffs
-
kioslave/smb/kio_smb.h 55efb44
kioslave/smb/kio_smb_dir.cpp 5573266
kioslave/smb/smb.protocol 654bcfb
Diff: http://git.reviewboard.kde.org/r/112982/diff/
Testing
---
Thanks,
Dawit Alemayehu
sure you have tested
the other modes before I give it a thumbs up. Did you try the manual proxy
setup with your patch? Also adding some exceptions to make sure it honors those
as well? If not can you please do that I do not have the bandwidth to test that
at the moment.
- Dawit Alemayehu
On Oct
/diff/
Testing
---
Thanks,
Dawit Alemayehu
---
On Oct. 5, 2013, 3:07 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112982/
---
(Updated Oct. 5
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113366/#review42146
---
Ship it!
Ship It!
- Dawit Alemayehu
On Oct. 21, 2013, 3:23
::connect: (sender name: 'Bookmarks')
Diffs
-
plasma/generic/runners/bookmarks/browsers/kdebrowser.h 3302e41
plasma/generic/runners/bookmarks/bookmarksrunner.cpp b36ad7f
Diff: http://git.reviewboard.kde.org/r/113131/diff/
Testing
---
Thanks,
Dawit Alemayehu
/dolphinpart.cpp 6609735
dolphin/src/dolphinpart_ext.h 423e79e
dolphin/src/dolphinpart_ext.cpp e98c064
Diff: http://git.reviewboard.kde.org/r/113132/diff/
Testing
---
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113129/#review41298
---
Ship it!
Thanks for the fix.
- Dawit Alemayehu
On Oct. 6
/kdebrowser.h 3302e41
plasma/generic/runners/bookmarks/bookmarksrunner.cpp b36ad7f
Diff: http://git.reviewboard.kde.org/r/113131/diff/
Testing
---
Thanks,
Dawit Alemayehu
Diff: http://git.reviewboard.kde.org/r/113132/diff/
Testing
---
Thanks,
Dawit Alemayehu
/r/112982/#review41273
---
On Sept. 29, 2013, 4:10 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r
---
Thanks,
Dawit Alemayehu
---
On Oct. 5, 2013, 3:07 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112982
, mounting the same share through CIFS
(mount.cifs) gives mu much greater speed with ~86MB/s. Is there anything
you can do to make this about equal in speed compared to cifs?
Dawit Alemayehu wrote:
Can you provide the mount options you used? We use libsmbclient for so
there should
, mounting the same share through CIFS
(mount.cifs) gives mu much greater speed with ~86MB/s. Is there anything
you can do to make this about equal in speed compared to cifs?
Dawit Alemayehu wrote:
Can you provide the mount options you used? We use libsmbclient for so
there should
.
http://bugs.kde.org/show_bug.cgi?id=291835
Diffs (updated)
-
kioslave/smb/kio_smb.h 55efb44
kioslave/smb/kio_smb_dir.cpp 5573266
kioslave/smb/smb.protocol 654bcfb
Diff: http://git.reviewboard.kde.org/r/112982/diff/
Testing
---
Thanks,
Dawit Alemayehu
/kio_smb.h 55efb44
kioslave/smb/kio_smb_dir.cpp 5573266
kioslave/smb/smb.protocol 654bcfb
Diff: http://git.reviewboard.kde.org/r/112982/diff/
Testing
---
Thanks,
Dawit Alemayehu
On Sept. 6, 2013, 1:10 p.m., Dawit Alemayehu wrote:
I have several changes coming to this ioslave. Mainly I am going to
implement the copyFrom and copyTo optimizations like I did for the sftp
ioslave and add support for upload/download resumptions. The changes are
going to come
On Sept. 6, 2013, 1:10 p.m., Dawit Alemayehu wrote:
I have several changes coming to this ioslave. Mainly I am going to
implement the copyFrom and copyTo optimizations like I did for the sftp
ioslave and add support for upload/download resumptions. The changes are
going to come
changes after your port,
then feel free to ship this, otherwise would it be possible for you to hold off
on this port? For the record I am not the maintainer of this code base. I am
just trying to improve as many of these ioslaves as I can when I get the chance.
- Dawit Alemayehu
On Sept. 2
.
http://bugs.kde.org/show_bug.cgi?id=197903
Diffs (updated)
-
kioslave/smb/kio_smb_browse.cpp fec6449
Diff: http://git.reviewboard.kde.org/r/112529/diff/
Testing (updated)
---
Tested against shares from a Windows 7 machine.
Thanks,
Dawit Alemayehu
above.
On Sept. 6, 2013, 11:04 a.m., Dawit Alemayehu wrote:
I don't know much in the samba department, but just happened to touch the
exact same code a few days ago when porting it to Qt5/KF5 - which is still
waiting for someone to review it btw ;)
I saw that. I was going to comment
://bugs.kde.org/show_bug.cgi?id=197903
Diffs (updated)
-
kioslave/smb/kio_smb_browse.cpp fec6449
Diff: http://git.reviewboard.kde.org/r/112529/diff/
Testing
---
Tested against shares from a Windows 7 machine.
Thanks,
Dawit Alemayehu
changes after your port,
then feel free to ship this, otherwise would it be possible for you to hold off
on this port? For the record I am not the maintainer of this code base. I am
just trying to improve as many of these ioslaves as I can when I get the chance.
- Dawit Alemayehu
On Sept. 2
://bugs.kde.org/show_bug.cgi?id=197903
Diffs (updated)
-
kioslave/smb/kio_smb_browse.cpp fec6449
Diff: http://git.reviewboard.kde.org/r/112529/diff/
Testing
---
Thanks,
Dawit Alemayehu
for it and it is inconsistent with what kio_file does for local file
copy operations.
This addresses bug 55804.
http://bugs.kde.org/show_bug.cgi?id=55804
Diffs
-
kio/kio/job.cpp 8ff088c
Diff: http://git.reviewboard.kde.org/r/112528/diff/
Testing
---
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/112529/diff/
Testing
---
Thanks,
Dawit Alemayehu
---
Thanks,
Dawit Alemayehu
/show_bug.cgi?id=314571
Diffs
-
kioslave/smb/kio_smb_auth.cpp 4d236b4
Diff: http://git.reviewboard.kde.org/r/112467/diff/
Testing
---
Thanks,
Dawit Alemayehu
://bugs.kde.org/show_bug.cgi?id=314571
Diffs
-
kioslave/smb/kio_smb_auth.cpp 4d236b4
Diff: http://git.reviewboard.kde.org/r/112467/diff/
Testing
---
Thanks,
Dawit Alemayehu
8e76ece
Diff: http://git.reviewboard.kde.org/r/112173/diff/
Testing
---
Thanks,
Dawit Alemayehu
. To reply, visit:
http://git.reviewboard.kde.org/r/112173/#review38210
---
On Aug. 20, 2013, 1:22 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit
e3d32bd
kio/kio/copyjob.cpp fbe3cc7
kio/kio/deletejob.cpp a822373
kio/kio/fileundomanager.cpp f0f4168
kio/kio/job.cpp c7c354f
kio/kio/paste.cpp 62490bb
Diff: http://git.reviewboard.kde.org/r/111883/diff/
Testing
---
Thanks,
Dawit Alemayehu
/111883/diff/
Testing
---
Thanks,
Dawit Alemayehu
/111883/diff/
Testing
---
Thanks,
Dawit Alemayehu
---
On Aug. 2, 2013, 12:37 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111776
---
On Aug. 2, 2013, 12:37 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111776
://git.reviewboard.kde.org/r/111776/diff/
Testing
---
Unite tests.
Thanks,
Dawit Alemayehu
system.
- check if there is a flood of stat calls on both the file being copied and its
destination directory.
Thanks,
Dawit Alemayehu
/fileundomanagertest.cpp 7c1352c
Diff: http://git.reviewboard.kde.org/r/111585/diff/
Testing
---
Unit and manual tests.
Thanks,
Dawit Alemayehu
kio/tests/fileundomanagertest.cpp 7c1352c
Diff: http://git.reviewboard.kde.org/r/111585/diff/
Testing
---
Unit and manual tests.
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111585/#review36226
---
On July 20, 2013, 2:06 p.m., Dawit Alemayehu wrote
kio/kio/fileundomanager.cpp 9f76fef
kio/kio/paste.cpp ca451fb
kio/kio/updateclipboard.cpp PRE-CREATION
kio/kio/updateclipboard_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/111585/diff/
Testing
---
Unit and manual tests.
Thanks,
Dawit Alemayehu
/fileundomanagertest.cpp 7c1352c
Diff: http://git.reviewboard.kde.org/r/111585/diff/
Testing
---
Unit and manual tests.
Thanks,
Dawit Alemayehu
url?
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111585/#review36168
---
On July 19, 2013, 1:17 p.m., Dawit Alemayehu
thinking of the use case of downloading one very big file; copying
tons of small files is a different issue)
Dawit Alemayehu wrote:
To me the number stats, which btw are 4 and not 2 because of the
additional destination directory stat, simply seem to be an overkill. If you
copy just 4
and its
destination directory.
Thanks,
Dawit Alemayehu
---
On July 13, 2013, 1:30 a.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335
/111335/diff/
Testing
---
Visit a site that throws up SSL warnings and causes KIO to show more than one
error dialog.
Thanks,
Dawit Alemayehu
Diff: http://git.reviewboard.kde.org/r/111335/diff/
Testing
---
Visit a site that throws up SSL warnings and causes KIO to show more than one
error dialog.
Thanks,
Dawit Alemayehu
kio/kio/usernotificationhandler_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/111335/diff/
Testing
---
Visit a site that throws up SSL warnings and causes KIO to show more than one
error dialog.
Thanks,
Dawit Alemayehu
in frameworks,
and scheduler is definitely core, while kmessagebox is definitely not.
Please find a way to separate the two.
Dawit Alemayehu wrote:
So how were you planning to separate the core and gui aspects in
frameworks? Without this patch KIO::Scheduler will still be linking
copied and its
destination directory.
Thanks,
Dawit Alemayehu
in frameworks,
and scheduler is definitely core, while kmessagebox is definitely not.
Please find a way to separate the two.
Dawit Alemayehu wrote:
So how were you planning to separate the core and gui aspects in
frameworks? Without this patch KIO::Scheduler will still be linking
://git.reviewboard.kde.org/r/111419/diff/
Testing
---
kioclient exec FILE:///
Thanks,
Dawit Alemayehu
/tests/kurltest.cpp 71770ee
Diff: http://git.reviewboard.kde.org/r/111419/diff/
Testing
---
kioclient exec FILE:///
Thanks,
Dawit Alemayehu
in frameworks,
and scheduler is definitely core, while kmessagebox is definitely not.
Please find a way to separate the two.
Dawit Alemayehu wrote:
So how were you planning to separate the core and gui aspects in
frameworks? Without this patch KIO::Scheduler will still be linking
in frameworks,
and scheduler is definitely core, while kmessagebox is definitely not.
Please find a way to separate the two.
Dawit Alemayehu wrote:
So how were you planning to separate the core and gui aspects in
frameworks? Without this patch KIO::Scheduler will still be linking
101 - 200 of 638 matches
Mail list logo
