D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25520 To: crossi, #plasma, ervin, bport, mart, davidedmundson Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25149: Add a new template for KCMs

ervin added inline comments. INLINE COMMENTS > kcm.cpp:37 > +KAboutData* about = new KAboutData( > +QStringLiteral("kcm_%{APPNAMELC}"), i18n("%{APPNAME} Configuration > Module"), > +QStringLiteral("0.1"), QString(), KAboutLicense::GPL, Nitpick: indentation looks broken here, I

D24224: Start of the accessibility KCM

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. A few changes still needed. Also, in all the QML code we need to handle immutability of the settings (unfortunately that part can't be easily made magic like for the widgets).

D25321: Remove dead code

ervin created this revision. ervin added reviewers: Plasma, davidedmundson, crossi, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D25321

D25322: Have the wallpaper combo managed by KConfigDialogManager

ervin created this revision. ervin added reviewers: Plasma, davidedmundson, crossi, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY We use an intermediate property which maps to an index since it's

D25290: KCM launchfeedback : port to KConfig XT

ervin added inline comments. INLINE COMMENTS > crossi wrote in main.qml:33 > I agree it's a bit tricky, we have a kind of enum choice written as a binary > representation in the config file. > > Will try to work it with a QML enum to make it less confusing. Or... but that's more work and I'd

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

ervin accepted this revision. ervin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > crossi wrote in kcmstyle.cpp:245 > m_effectsDirty is checked line 291, to trigger or not a refresh of all > applications. > > This check before save is now useless,

D25149: Add a new template for KCMs

ervin added inline comments. INLINE COMMENTS > tcanabrava wrote in kcm.cpp:43 > What's the correct form then? No need to connect the settings *at all*? No need indeed... it's *magic*! ;-) > tcanabrava wrote in main.qml:39 > The default fake setting will not be immutable, or you mean that you

D25149: Add a new template for KCMs

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > %{APPNAMELC}settings.kcfgc:5 > +DefaultValueGetters=true > +GenerateProperties=true You also want "ParentInConstructor=true" in here. > kcm.cpp:32 > +:

D25287: Integrate the lnf and wallpaper settings with the KCM logic

ervin created this revision. ervin added reviewers: Plasma, mart, davidedmundson, bport, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY This was currently very much disconnected and broken in quite a few

D25286: Allow to disable autosave behavior in ConfigPropertyMap

This revision was automatically updated to reflect the committed changes. Closed by commit R296:40b94af6f0f4: Allow to disable autosave behavior in ConfigPropertyMap (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25286?vs=69676=69677

D25286: Allow to disable autosave behavior in ConfigPropertyMap

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart, davidedmundson, bport. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This is especially important when ConfigPropertyMap

D25212: Move the shortcut management in the settings object

This revision was automatically updated to reflect the committed changes. Closed by commit R133:68bdeb8cd7d9: Move the shortcut management in the settings object (authored by ervin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25212?vs=69435=69675

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

This revision was automatically updated to reflect the committed changes. Closed by commit R237:44cfa0631d25: Prepare KConfigSkeletonItem to allow inheriting its private class (authored by ervin). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D25211: Add KPropertySkeletonItem

This revision was automatically updated to reflect the committed changes. Closed by commit R237:d63955cfe547: Add KPropertySkeletonItem (authored by ervin). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25211?vs=69628=69674 REVISION DETAIL

[frameworks-kconfigwidgets] [Bug 413980] "Defaults" button should restore system wide defaults

https://bugs.kde.org/show_bug.cgi?id=413980 --- Comment #4 from Kevin Ottens --- Currently 100% done (with all patches merged): desktoptheme and ksplash. There are more which are basically done but in various stages of review, and even more in the works. -- You are receiving this mail because

D25274: KCM LookAndFeel : port to KConfig XT

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Just a recurring typo, otherwise LGTM INLINE COMMENTS > kcm.cpp:220 > + > +//Model has been cleared so pretend the selected look and fell changed > to force view update > +

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

ervin added inline comments. INLINE COMMENTS > crossi wrote in kcmstyle.cpp:248 > m_model->selectedStyle() is bound to m_settings->widgetStyle() and vice > versa, so I need to save previous state to allow a rollback. > I should have used m_settings->widgetStyle() here and after for consistency.

D25212: Move the shortcut management in the settings object

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:198 > This part appears to have gone? Yes, it was never triggered. It turns out KKeySequenceWidget does that already as soon as you pick a new shortcut, so it could never end up conflicting here since said conflict

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

ervin added inline comments. INLINE COMMENTS > kcmstyle.cpp:98 > > -connect(m_model, ::selectedStyleChanged, this, [this] { > -m_selectedStyleDirty = true; > -setNeedsSave(true); > +connect(m_model, ::selectedStyleChanged, this, [this](const > QString& style) { > +

D25211: Add KPropertySkeletonItem

ervin updated this revision to Diff 69628. ervin added a comment. Avoid potential ownership problem on the propertyName REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25211?vs=69442=69628 REVISION DETAIL https://phabricator.kde.org/D25211 AFFECTED

D25249: KDirModel: port to qCDebug, with its own category

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25249 To: dfaure, mlaurent, sandsmark, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25211: Add KPropertySkeletonItem

ervin updated this revision to Diff 69442. ervin added a comment. Fix member variable naming convention REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25211?vs=69432=69442 REVISION DETAIL https://phabricator.kde.org/D25211 AFFECTED FILES

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

ervin added a comment. In D25210#559977 , @vkrause wrote: > Ok as such, but I think KConfigSkeletonItemPrivate would need a virtual dtor for this to actually work safely when used by a sub-class? You mean like not leaking memory? woops.

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

ervin updated this revision to Diff 69440. ervin added a comment. Add missing virtual dtor REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25210?vs=69431=69440 REVISION DETAIL https://phabricator.kde.org/D25210 AFFECTED FILES

D25209: Register KKeySequenceWidget to KConfigDialogManager

This revision was automatically updated to reflect the committed changes. Closed by commit R265:c0a8cd4a2a95: Register KKeySequenceWidget to KConfigDialogManager (authored by ervin). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25209?vs=69430=69439

D25208: Add missing property to KKeySequenceWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R263:fab6d95a9fad: Add missing property to KKeySequenceWidget (authored by ervin). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25208?vs=69429=69436 REVISION DETAIL

D25212: Move the shortcut management in the settings object

ervin updated this revision to Diff 69435. ervin added a comment. Remove stale updateState() function REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25212?vs=69433=69435 REVISION DETAIL https://phabricator.kde.org/D25212 AFFECTED FILES

D25212: Move the shortcut management in the settings object

ervin created this revision. ervin added reviewers: Plasma, davidedmundson, bport, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY This uses the new KPropertySkeletonItem facility to allow proper

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

ervin created this revision. ervin added reviewers: Frameworks, dfaure, davidedmundson, bport, crossi. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REPOSITORY R237 KConfig REVISION DETAIL

D25211: Add KPropertySkeletonItem

ervin created this revision. ervin added reviewers: Frameworks, dfaure, davidedmundson, bport, crossi. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This new item allows to use a QObject property as

D25209: Register KKeySequenceWidget to KConfigDialogManager

ervin created this revision. ervin added reviewers: Frameworks, dfaure, davidedmundson, bport. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This makes it usable in a KConfigXT context. Depends

D25208: Add missing property to KKeySequenceWidget

ervin created this revision. ervin added reviewers: Frameworks, dfaure, davidedmundson, bport. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY Oddly enough we had all the necessary to manage

D25198: KCM Colors : port color scheme state management to KConfigXT

ervin added a comment. In D25198#559853 , @broulik wrote: > Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them

D25147: Remove gtkrc-2.0 legacy settings

ervin added a comment. FWIW, LGTM as well, agree with Nate that it likely requires some more extensive testing though. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH remove-legacy-gtkrc-settings (branched from master) REVISION DETAIL https://phabricator.kde.org/D25147 To: gikari,

D25149: Add a new Template for KCM's.

ervin added a comment. What about having the template use kcfg and ManagedConfigModule as well? It'd give better behaving modules by default and is a better practice than starting without them. I'd rather have people make the conscious decision to remove them because it turns out it's a KCM

[zanshin] [Bug 413813] Hide completed tasks

https://bugs.kde.org/show_bug.cgi?id=413813 Kevin Ottens changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0

D25074: Disable the restore defaults button if the KCModule says so

This revision was automatically updated to reflect the committed changes. Closed by commit R124:fe180972acbb: Disable the restore defaults button if the KCModule says so (authored by ervin). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D25074: Disable the restore defaults button if the KCModule says so

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in ModuleView.cpp:427 > Not saying this is wrong, but can you explain this change? > > In https://phabricator.kde.org/D25072 > > we do setEnabled((buttons & Default) && !defaulted) rather than changing > visibility,

D25074: Disable the restore defaults button if the KCModule says so

ervin updated this revision to Diff 69275. ervin added a comment. Deal with David's comment and realign ModuleView with KCMultiDialog regarding button state management. REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25074?vs=69044=69275 REVISION

D25072: Disable the restore defaults button if the KCModule says so

This revision was automatically updated to reflect the committed changes. Closed by commit R295:f2f04d67e221: Disable the restore defaults button if the KCModule says so (authored by ervin). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25072?vs=69042=69274

D25070: Make KCModuleQml conform to the defaulted() signal

This revision was automatically updated to reflect the committed changes. Closed by commit R295:4dc999b9eba1: Make KCModuleQml conform to the defaulted() signal (authored by ervin). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25070?vs=69040=69272

D25071: Have KCModuleProxy take care of the defaulted state

This revision was automatically updated to reflect the committed changes. Closed by commit R295:dc836403bb5d: Have KCModuleProxy take care of the defaulted state (authored by ervin). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25071?vs=69270=69273

D25069: Adjust KCModule to also channel information about defaults

This revision was automatically updated to reflect the committed changes. Closed by commit R265:0762203eb9df: Adjust KCModule to also channel information about defaults (authored by ervin). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D25071: Have KCModuleProxy take care of the defaulted state

ervin updated this revision to Diff 69270. ervin added a comment. Add missing @since markers REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25071?vs=69041=69270 REVISION DETAIL https://phabricator.kde.org/D25071 AFFECTED FILES src/kcmoduleproxy.cpp

D25069: Adjust KCModule to also channel information about defaults

ervin updated this revision to Diff 69269. ervin added a comment. Add missing @since markers REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25069?vs=69039=69269 REVISION DETAIL https://phabricator.kde.org/D25069 AFFECTED FILES src/kcmodule.cpp

D24743: Update GTK settings according to Plasma settings

ervin added a comment. Just a minor thing, otherwise LGTM, I'll let Kai give the last stamp of approval. INLINE COMMENTS > gtkconfig.cpp:113 > +setFont(); > +setFont(); > +setIconTheme(KIconLoader::Group::Desktop); Are you sure you want to call setFont() twice here? That looks

D25094: Fix reset to defaults in the fonts KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7b0149c79ea4: Fix reset to defaults in the fonts KCM (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25094?vs=69118=69119 REVISION

D25094: Fix reset to defaults in the fonts KCM

ervin created this revision. ervin added reviewers: Plasma, bport, davidedmundson, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY Turns out one of the properties was utterly broken emitting the wrong

D24848: fix kcm fonts "typo" on connect

This revision was automatically updated to reflect the committed changes. Closed by commit R119:08a8914d7169: fix kcm fonts typo on connect (authored by bport, committed by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24848?vs=68500=69094

D24743: Update GTK settings according to Plasma settings

ervin added inline comments. INLINE COMMENTS > configeditor.cpp:49 > +QString > configLocation(QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation)); > +QString gtk3ConfigPath(configLocation + "/gtk-3.0/settings.ini"); > + Better wrap the const char* in a

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Looks good to me. Please just wait a bit before pushing to give David a chance to object to my comments. ;-) REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in kpropertywriter_p.h:26 > Throwing out another option > > class KPropertyWriter : public QObject, public QQmlPropertyValueSource > { > Q_INVOKABLE bool writeProperty(QVariant value); > } > >

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin added a comment. In D25000#556761 , @davidedmundson wrote: > There's a Plasma rule that if we're working round a Qt bug, there should be a Qt bug created and linked before accepting a workaround. > > From the sounds of it we want a

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. Once we got D25000 completed, please remember to abandon that one. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24916 To: crossi, #plasma, ervin, mart, bport Cc: broulik, plasma-devel, LeGast00n,

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Almost there! Glad we're getting near a proper fix. Can you confirm this works with *and* without D24916 applied? Can you also confirm this

D25070: Make KCModuleQml conform to the defaulted() signal

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmoduleqml.cpp:80-82 > needsSave emits the current state and then connects for changes > representsDefaults only connects for changes > > I would expect them to match as they're doing equivalent things. > > It looks to me

D25071: Have KCModuleProxy take care of the defaulted state

ervin added a comment. In D25071#556681 , @davidedmundson wrote: > Edit: ah, I see why. > > KCMMultiDialog and system settings re-evaluate the buttons on receipt of the changed signal > Still seems maybe a bit odd, but it makes sense in

D25077: Use compile time checked connect

This revision was automatically updated to reflect the committed changes. Closed by commit R296:92f6e85438f8: Use compile time checked connect (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25077?vs=69051=69052 REVISION DETAIL

D25077: Use compile time checked connect

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY Benjamin made me realized we went through introspection

D25071: Have KCModuleProxy take care of the defaulted state

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmoduleproxy.cpp:196-197 > Why emit changed? > > Given KCModuleProxy mirrors KCModule API I would have expected a defaulted > signal to match? Because all the consumers I found surprisingly don't care about the

D25069: Adjust KCModule to also channel information about defaults

ervin marked an inline comment as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25069 To: ervin, #frameworks, #plasma, mart, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25068: Adjust QtQuickSettings KCM to use KConfigXT in full

This revision was automatically updated to reflect the committed changes. Closed by commit R119:61cd3d4b19a9: Adjust QtQuickSettings KCM to use KConfigXT in full (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25068?vs=69038=69049

D25076: Force reevaluating state on pending deletion changes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:35c84cb5f9d2: Force reevaluating state on pending deletion changes (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25076?vs=69046=69050

D24847: KCM Icons fix theme selected when we hit delete theme

ervin added a comment. nitpick, but otherwise LGTM, giving time to others (in particular Nate) to chip in. INLINE COMMENTS > iconsmodel.cpp:87 > } > - > emit pendingDeletionsChanged(); I'd say keep the empty line please. REPOSITORY R119 Plasma Desktop REVISION

D24846: Port kcm icons to kconfigxt

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.cpp:101 > > -connect(m_model, ::selectedThemeChanged, this, [this] { > -m_selectedThemeDirty = true; > -setNeedsSave(true); > -

D25073: Get KQuickAddons::ConfigModule to expose if we're in the defaults state

This revision was automatically updated to reflect the committed changes. Closed by commit R296:b2788c1a0894: Get KQuickAddons::ConfigModule to expose if were in the defaults state (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D25075: Make the settingChanged() slot protected.

This revision was automatically updated to reflect the committed changes. Closed by commit R296:372dbb493df6: Make the settingChanged() slot protected. (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25075?vs=69045=69048 REVISION

D25068: Adjust QtQuickSettings KCM to use KConfigXT in full

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in renderer.kcfg:10 > Will this mean we write "automaticloop" to the config file? > > If so, we'll need to change the KQuickAddons::QtQuickSettings::init > As it passes the variables in the config directly to Qt envs, which

D25076: Force reevaluating state on pending deletion changes

ervin created this revision. ervin added reviewers: Plasma, bport, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY This was missing and thus the apply button wouldn't get enabled in case

D25075: Make the settingChanged() slot protected.

ervin created this revision. ervin added reviewers: Plasma, Frameworks, bport, mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This might be necessary for some subclasses which

D25074: Disable the restore defaults button if the KCModule says so

ervin created this revision. ervin added reviewers: Plasma, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D25074 AFFECTED

D25073: Get KQuickAddons::ConfigModule to expose if we're in the defaults state

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY ManagedConfigModule is adjusted as well to manage that new

D25070: Make KCModuleQml conform to the defaulted() signal

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart, davidedmundson, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This new signal got introduced in KCModule, so we

D25072: Disable the restore defaults button if the KCModule says so

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart, davidedmundson, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REPOSITORY R295 KCMUtils REVISION DETAIL

D25071: Have KCModuleProxy take care of the defaulted state

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart, davidedmundson, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY Now that KCModule exposes a defaulted() signal,

D25069: Adjust KCModule to also channel information about defaults

ervin created this revision. ervin added reviewers: Frameworks, Plasma, mart, davidedmundson, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY We'd probably do things differently nowadays

D25068: Adjust QtQuickSettings KCM to use KConfigXT in full

ervin created this revision. ervin added reviewers: Plasma, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY This removes quite a lot of uneeded code and fixes the automatic default

D25061: kconfig_compiler: Move the KSharedConfig::Ptr when using them

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. LGTM, maybe give some times to others to chip in. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D25061 To: aacid, ervin Cc: kde-frameworks-devel,

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin added a comment. Good start, there's one case still missing... which looks hard to reach, I wonder how to get there. INLINE COMMENTS > ComboBox.qml:92 > if (indexUnderMouse > -1) { > controlRoot.currentIndex = indexUnderMouse; >

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. Style wise, functions come before children objects. Other than that looks good to me. Through Kai comments, the question also becomes, wouldn't it be better to fix the root cause? It's likely we'll encounter that ComboBox breakage at other places. REPOSITORY

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. In D24916#553958 , @broulik wrote: > > Ah somehow I thought we had a third more "clever" case of currentIndex moving. > > Heh, yea, there's also some more elaborate "change index while moving the mouse" going on :(

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. In D24916#553919 , @broulik wrote: > > AFAICT it won't be pretty though. :-) > > I think it's pretty straightforward > 1.) the delegate must not explicitly set a `currentIndex` because Qt does it for us, see D18299

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. In D24916#553886 , @broulik wrote: > Hm I think qqc2-desktop-style breaks the binding on `currentIndex`, otherwise this would not be neccessary... Good point... What about fixing that? AFAICT it won't be pretty

D24917: KCM Style port to KConfigXT

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmstyle.cpp:317 > + > +m_model->setSelectedStyle(m_settings->widgetStyle()); > That line and the metaenum wrangling could likely be factored out somehow

D24916: KCM style : fix combobox that weren't updated after user made change

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > EffectSettingsPopup.qml:72 > +onMainToolBarStyleChanged: { > +mainToolBarStyleCombo.currentIndex = >

D24846: Port kcm icons to kconfigxt

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > broulik wrote in main.cpp:141 > Does this `KIconTheme` instance need caching? I recall creating those parses > a tonne of files and directories and is quite

D24847: KCM Icons fix theme selected when we hit delete theme

ervin added a comment. In D24847#552665 , @bport wrote: > I will update this patch to allow to delete current selected theme but remove bug > So if we have A B C, A selected > > 1. we delete B : B pending deletion A still selected > 2.

Re: D24847: KCM Icons fix theme selected when we hit delete theme

Hello, On Tuesday, 22 October 2019 20:17:15 CEST Nathaniel Graham wrote: > Does this patch have unmarked dependencies? It doesn't apply for me: I'd expect it also needs D24845 and D24846. They got all submitted together. Regards. -- Kevin Ottens, http://ervin.ipsquad.net enioka Ha

D24847: KCM Icons fix theme selected when we hit delete theme

ervin added a subscriber: bport. ervin added a comment. Hello, - F7654931: signature.asc REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24847 To: bport, mart, ervin, #plasma, crossi Cc: bport, ngraham, broulik,

D24822: Port the desktoptheme kcm to ManagedConfigModule

This revision was automatically updated to reflect the committed changes. Closed by commit R119:331c25893d06: Port the desktoptheme kcm to ManagedConfigModule (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24822?vs=68409=68547

D24821: Add ManagedConfigModule

This revision was automatically updated to reflect the committed changes. Closed by commit R296:c8b95b07c53b: Add ManagedConfigModule (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24821?vs=68530=68545 REVISION DETAIL

D24821: Add ManagedConfigModule

ervin updated this revision to Diff 68530. ervin added a comment. Address David's comments REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24821?vs=68411=68530 REVISION DETAIL https://phabricator.kde.org/D24821 AFFECTED FILES

D24821: Add ManagedConfigModule

ervin marked an inline comment as done. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24821 To: ervin, #plasma, #frameworks, mart, bport, davidedmundson Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24821: Add ManagedConfigModule

ervin marked 4 inline comments as done. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24821 To: ervin, #plasma, #frameworks, mart, bport, davidedmundson Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24848: fix kcm fonts "typo" on connect

ervin accepted this revision. ervin added a comment. In D24848#551863 , @broulik wrote: > Interesting, I thought Qt would/could static_assert that Well, it turns out the signatures were compatible in fact (getters connected to a function

D24821: Add ManagedConfigModule

ervin added a comment. In D24821#551179 , @davidedmundson wrote: > Nice! > > I'm not super sold on magically doing findChildren to get the config skeletons over an explicit > registerSettings(KCoreConfigSkeleton*). > > I'm not

D24821: Add ManagedConfigModule

ervin updated this revision to Diff 68411. ervin added a comment. Addresses bport's comment REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24821?vs=68408=68411 REVISION DETAIL https://phabricator.kde.org/D24821 AFFECTED FILES

D24821: Add ManagedConfigModule

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This is a new type of ConfigModule which will manage the state of

D24822: Port the desktoptheme kcm to ManagedConfigModule

ervin created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY This depends on https://phabricator.kde.org/D24821 REPOSITORY R119 Plasma Desktop REVISION DETAIL

<    1   2   3   4   5   6   7   8   9   10   >