Is there a place that actually describes when it's appropriate to use which
string type, and how to know if we should be fixing code we run across?
Is everything just supposed to be string16?
-Albert
On Fri, May 1, 2009 at 11:59 AM, Evan Martin e...@chromium.org wrote:
We have a bunch of
On Fri, May 1, 2009 at 1:31 PM, Jeremy Orlow jor...@chromium.org wrote:
On Fri, May 1, 2009 at 1:27 PM, Adam Langley a...@chromium.org wrote:
On Fri, May 1, 2009 at 12:53 PM, Jeremy Orlow jor...@google.com wrote:
I'm still kind of new here, so forgive me if this is a silly question,
but
If there was a nice way to get a PlatformCanvas out of a
PlatformGraphicsContext when PLATFORM(CG), that'd be awesome.
Brett, I'm not quite sure how you mean to do that. Do you mean that in the
glue code, we should instantiate a byte buffer that we ask the rendered to
fill in, then use webkit's
, Albert J. Wong (王重傑)
ajw...@chromium.org wrote:
If there was a nice way to get a PlatformCanvas out of a
PlatformGraphicsContext when PLATFORM(CG), that'd be awesome.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View
On Fri, May 15, 2009 at 9:48 AM, Albert J. Wong (王重傑)
ajw...@chromium.org wrote:
On Fri, May 15, 2009 at 9:14 AM, Steven Knight s...@google.com wrote:
Guys, it would be a major win to get gmock landed. I'd like to keep
trying here, even if not trivially small.
Re: boost size. If necessary
, Albert J. Wong (王重傑)
ajw...@chromium.org wrote:
One other idea to explore...what about reimplementing tr1::tuple using
base::Tuple? It'd be a pretty naughty hack (adding something to the
tr1::
namespace), but for the limited use-case of gmock, it could be good
enough?
-Albert
On Fri, May
As of r16639, the linux build now requires ALSA to build.
src/build/install-build-deps.sh has been updated with the dependency.
Please run that if the compiler starts complaining that alsa/asound.h
cannot be found.
-Albert
--~--~-~--~~~---~--~~
Chromium
Do we have any unittest support for python in the chromium code base? I did
a find ./ -name '*test*.py' and didn't find much.
I'm writing a tool to auto-gen some stub code, and didn't see a clear test
framework to hook into.
-Albert
--~--~-~--~~~---~--~~
Chromium
As of r17066, GoogleMock (also known as gmock) is available for use in unit
tests! Yaay!
*What is it?*
Gmock it is a is a C++ mock-object framework, similar to EasyMock for
java, built on top of Google Test for use in C++. There's lots of
documentation on the Google Mock project
...fixing...the subject. It's now available. Small difference in
semantics. :-/
On Thu, May 28, 2009 at 11:16 AM, Albert J. Wong (王重傑)
ajw...@chromium.orgwrote:
As of r17066, GoogleMock (also known as gmock) is available for use in unit
tests! Yaay!
*What is it?*
Gmock it is a is a C
Found this yesterday.
If any of the hex digits in the msvs_guid (specified in the .gyp files) for
your target are lowercase, IncrediBuild's BuildConsole will silently ignore
building said target.
The target will build fine under Visual Studio, using either normal build,
or IncrediBuild.
I will be checking in a /D change to essential.vsprops that requires a
clobber build.
The change is to enable TR1 for VS2008 SP1 so that gmock can compile on that
platform.
I'm running through the clobber builds locally right now, and will probalby
submit the change tomorrow morning. Will send
This has been submitted as r17430.
On Mon, Jun 1, 2009 at 2:13 PM, Albert Wong (王重傑) ajw...@chromium.orgwrote:
I will be checking in a /D change to essential.vsprops that requires a
clobber build.
The change is to enable TR1 for VS2008 SP1 so that gmock can compile on
that platform.
I'm
sorry for the bustage. I had assumed the make file was still a toy with
only 2-3 people using it (not many linux chrome folks where I am).
Thanks for rolling it back Adam. I'll probably just submit the generated
files as tony suggested.
-Albert
On Thu, Jun 11, 2009 at 9:51 AM, Thomas Van
This isn't an issue that I've heard of yet...
Can you post a few more details such as which file (or files) is failing the
compile?
-Albert
On Sun, Jun 14, 2009 at 4:01 PM, nakro yoav.zilberb...@gmail.com wrote:
C:\Program Files\Microsoft Visual Studio 9.0\VC\include\tuple(498) :
error
On Mon, Jun 15, 2009 at 9:03 AM, nakro yoav.zilberb...@gmail.com wrote:
Hi albret,
projects that fail :
gmockj
gmockmain
here is an example out from gmockmain
C:\Program Files\Microsoft Visual Studio 9.0\VC\include\tuple(498) :
error C2065: '_Is_swap_move' : undeclared identifier
1
I'll be upgrading googletest to r267 and googlemock to r173 in order to
break our tr1 dependency on windows, and one rtti dependency in linux/mac.
When I land the patch to set _HAS_TR1=0 on windows, it will necessitate a
full clober to fix the precompiled headers.
Over the last couple of weeks,
2009/6/18 Evan Martin e...@chromium.org
On Thu, Jun 18, 2009 at 3:51 PM, Albert J. Wong
(王重傑)ajw...@chromium.org wrote:
This upgrade should fix the compatibility issues MSVS 2008 users hav been
having due to bad tr1 interactions with various bits of code. It also
moves
us closer
If you didn't see my other mail to chromium-dev, I'll be trying to whack the
tr1 dependency next week. That should hopefully fix the issue you were
having. Will update this thread again when the patch is committed.
-Albert
On Mon, Jun 15, 2009 at 9:11 AM, Albert J. Wong (王重傑)
ajw
at 4:03 PM, Albert J. Wong (王重傑)
ajw...@chromium.orgwrote:
2009/6/18 Evan Martin e...@chromium.org
On Thu, Jun 18, 2009 at 3:51 PM, Albert J. Wong
(王重傑)ajw...@chromium.org wrote:
This upgrade should fix the compatibility issues MSVS 2008 users hav
been
having due to bad tr1 interactions
I just submitted the change to remove _HAS_TR1 in vs2008.
http://src.chromium.org/viewvc/chrome?view=revrevision=19049
This should fix the vs2008 issues with gmock. Let me know if you continue
to see problems.
-Albert
On Fri, Jun 19, 2009 at 5:23 PM, Albert J. Wong (王重傑)
ajw
with that if necessary.
On Mon, Jun 15, 2009 at 12:11 PM, Albert J. Wong(王重傑)
ajw...@chromium.org wrote:
On Mon, Jun 15, 2009 at 9:03 AM, nakro yoav.zilberb...@gmail.com
wrote:
Hi albret,
projects that fail :
gmockj
gmockmain
here is an example out from gmockmain
C
:49 PM, Albert J. Wong (王重傑)
ajw...@chromium.orgwrote:
Hi Thiago,
Did you sync pas revision 19049? And did you do a clean build?
Thanks,
Albert
On Tue, Jun 23, 2009 at 9:37 AM, Thiago Farina thiago.far...@gmail.comwrote:
I have the same problem with tuple.
On Jun 15, 1:24 pm, Marc
Doesn't gclient runhooks --force setup the scons build on linux? Or did the
make build become default at some point?
On Thu, Jun 25, 2009 at 5:57 PM, Dan Kegel daniel.r.ke...@gmail.com wrote:
I did
rm Makefile
gclient runhooks --force
and it didn't regenerate Makefile.
tools/gyp/gyp -f
If it's assumed ASCII, would it be sensible to assert it in the gyp parser?
On Sat, Jun 27, 2009 at 1:17 PM, Daniel Cowx daniel.c...@gmail.com wrote:
No use case. I was just creating a new GYP file and wanted to know
what encoding to save the file as...that's all :-)
On Jun 26, 10:52 pm,
TBR = To be reviewed (means the checkin was done w/o a review and needs to
be looked at by someone)
CL = Change list. Usually referring to some rietveld change number.
On Sun, Jul 5, 2009 at 12:54 PM, Thiago Farina thiago.far...@gmail.comwrote:
In some reviews and patch I saw this
On Tue, Jul 14, 2009 at 2:35 PM, Nicolas Sylvain nsylv...@chromium.orgwrote:
On Tue, Jul 14, 2009 at 2:25 PM, Evan Martin e...@chromium.org wrote:
On Tue, Jul 14, 2009 at 2:18 PM, Nicolas Sylvainnsylv...@chromium.org
wrote:
The underlying problem with buildbot is the database format,
On Wed, Jul 15, 2009 at 1:45 PM, Adam Barth aba...@chromium.org wrote:
On Wed, Jul 15, 2009 at 1:40 PM, Peter Kastingpkast...@chromium.org
wrote:
On Wed, Jul 15, 2009 at 1:34 PM, Adam Barth aba...@chromium.org wrote:
On Wed, Jul 15, 2009 at 12:57 PM, Peter Kastingpkast...@chromium.org
Since you built it, you should be able to fire it up in a debugger and see
where it's dying. That's what I'd try first.
-A
On Wed, Jul 15, 2009 at 3:47 PM, n179911 n179...@gmail.com wrote:
Hi,
I download the source of chromium and build successfully on MacOSX.
When I start the
(Oh and for the folks that added in boost, I'll be adding in an
MSVS_VERSION variable you'll be able to use at gyp time so you can have
different behaviors).
Good to know. BTW, boost got removed about 3 weeks ago after zhanyong broke
the dependency from gmock to boost and tr1 (yay!). So no
I need to find a way to know when a context menu is closed, either via a
menu item selection, or via hitting escape, opening a new menu, unfocusing
the window, etc.
Ideally, there'd be some sort of menu closed function or event that is
called when the menu stops being displayed. On the gtk port,
. The description of that is:
The *WM_UNINITMENUPOPUP* message is sent when a drop-down menu or submenu
has been destroyed.
Is that less appropriate to use that WM_EXITMENULOOP?
Thanks,
Albert
On Wed, Jul 22, 2009 at 2:13 PM, Albert J. Wong (王重傑)
ajw...@chromium.org
wrote:
I need
On Wed, Jul 22, 2009 at 1:26 PM, Albert J. Wong (王重傑)
ajw...@chromium.orgwrote:
On Wed, Jul 22, 2009 at 1:19 PM, Nico Weber tha...@chromium.org wrote:
On mac, you can probably set the NSMenu's delegate to an object of
your choice and have it implement menuDidClose: if you want to
implement
On Wed, Jul 22, 2009 at 6:11 PM, Peter Kasting pkast...@google.com wrote:
On Wed, Jul 22, 2009 at 6:05 PM, Albert J. Wong (王重傑) ajw...@chromium.org
wrote:
The problem currently is that, for certain context menu items on a HTML5
media element, I need to keep a reference inside the renderer
It seems like there's some bad interaction between gclient and gyp's make
build generator that got uncovered when the gyp DEPS were rolled to r555.
The effect is the top-level make file ends up having src/ prepended to
the paths for all the sub-makefiles. A simple work around is to run gyp by
This has come up a bunch, so I think it warrants a post.
If you're playing with the HTML5 video tag in a chromium build (ie. Daily
builds, or your own builds from source), the only video codec enabled is
Ogg/Vorbis. Thus, http://www.youtube.com/html5 isn't going to work. Please
try a ogg/vorbis
), and bloating the build (like M-A
said)
Of these three choices, I'm tempted to go with the shim approach, with the
mock being passed during construction.
-Albert
On Mon, Aug 3, 2009 at 8:23 PM, Albert J. Wong (王重傑)
ajw...@chromium.org
wrote:
I've noticed that most public functions
On Thu, Aug 6, 2009 at 10:36 AM, Evan Martin e...@chromium.org wrote:
On Thu, Aug 6, 2009 at 10:15 AM, Ojan Vafaio...@chromium.org wrote:
After following the instructions in that document trunk/src is git and
everything else (pulled in via DEPS, including webkit and also ICU,
skia, etc.)
FYI, the code in debug_util.h will generate a stack trace, but symbol
resolution doesn't work on mac. Last I messed with it (~4 months ago), mac
didn't work because most of the symbols are private. Mark Mentovai
suggested trying to reimplement dladdr, but I could never get it working.
Here's the
On the bright side, now you only download the binaries that make sense for
your platform. :)
-Albert
On Mon, Aug 10, 2009 at 5:18 PM, Andrew Scherkus scher...@chromium.orgwrote:
We shuffled these around on Friday such that these binaries now live in
/deps/third_party/ffmpeg and are pulling in
oh man...been wanting this for ages. Thanks!
On Fri, Aug 14, 2009 at 2:06 PM, Eric Seidel esei...@chromium.org wrote:
That is really slick. gyp-authors++
-eric
On Fri, Aug 14, 2009 at 2:02 PM, Darin Fisher da...@chromium.org wrote:
If you are like me and accustomed to hacking
On Sun, Aug 16, 2009 at 7:37 AM, Mark Mentovai m...@chromium.org wrote:
n179...@gmail.com wrote:
Does Chromium use boost library? In the source tree, i see there is a
'boost' directory under 'third-party'.
It appears to be an incomplete version of boost 1.36. I said
incomplete since a
Awesome! :)
FYI, video will not work out of the box since the ffmpeg binaries we have
are 32-bit. We need a bit of work to shift them over. If you see bugs
there, it's expected.
-Albert
On Thu, Aug 20, 2009 at 10:18 AM, Michael Moss mm...@chromium.org wrote:
Awesome! I'll work on the
I started a page to collect the common terms/lingo that gets used in
chromium development. It's pretty anemic right now, but if a term keeps
needing to get reexplained to people, please add it to the page. Also, if
anyone has a better idea for formatting, please feel free to change it. I
tried
Nope. Feel free to move it, or I'll do it tomorrow.
-A
On Thu, Aug 20, 2009 at 7:41 PM, Evan Stade est...@chromium.org wrote:
is there a reason this isn't on the wiki?
-- Evan Stade
On Thu, Aug 20, 2009 at 11:31 AM, Albert J. Wong
(王重傑)ajw...@chromium.org wrote:
I started a page
awesome. thanks!
2009/8/20 Evan Stade est...@chromium.org
ported:
http://code.google.com/p/chromium/wiki/Glossary?ts=1250828818updated=Glossary
-- Evan Stade
On Thu, Aug 20, 2009 at 8:57 PM, Albert J. Wong
(王重傑)ajw...@chromium.org wrote:
Nope. Feel free to move it, or I'll do
We're moving the location of the ffmpeg binaries -- hopefully for the last
time -- to allow for different variants for each platform. The specific
first use case is x64 linux, and debug builds of ffmpeg for mac and linux.
We don't do debug builds for windows because the gcc-built ffmpeg cannot
I've started a little wiki to record useful git recipes that people use for
developing chromium.
http://code.google.com/p/chromium/wiki/GitCookbook
Currently, it just has an entry for how to exclude files from a git-cl
upload, while preserving them in another branch. If you have a useful
We just noticed that the Chromium Helper.app cannot locate the ffmpeg
binaries (libav*.dylib) in Mac Chromium. This leads to the video feature
being disabled. :(
Where should the ffmpeg binaries go? Should they be put alongside the
binary in the Chromium Helper.app/Contents/MacOS? If we do
On Wed, Oct 7, 2009 at 11:36 AM, Andrew Scherkus scher...@chromium.orgwrote:
On Wed, Oct 7, 2009 at 11:34 AM, Albert J. Wong (王重傑) ajw...@chromium.org
wrote:
We just noticed that the Chromium Helper.app cannot locate the ffmpeg
binaries (libav*.dylib) in Mac Chromium. This leads
What is @loader_path relative off of?
On Wed, Oct 7, 2009 at 12:35 PM, Mark Mentovai m...@chromium.org wrote:
My preference would be to place them inside Chromium
Framework.framework, then. If you need to, you can put them inside
Chromium Helper.app/Contents/MacOS instead, but I'm trying
What do people think about creating a bot for isolating flakey tests from
each major category of tests?
The idea would be to try and move the flaky tests onto one bot so that the
signal-to-noise ratio on the other bots gets better. Also, with layout
tests that might flake via timeouts, you can
Would a hack like running nm --defined-only on each generated object, and
then checking for dups work? You'd have to ignore weak symbols, and
probably some others, but sounds doable.
-Albert
On Tue, Oct 27, 2009 at 6:48 PM, Peter Kasting pkast...@google.com wrote:
On Tue, Oct 27, 2009 at
If I'm not mistaken, I think like most everyone running on linux is using
the make build nowadays, and the make build seems to work well enough for
most people. The only time I hear someone mention the scons build, it's in
reference to you broke the scons build, or so you developed on make. Did
:28 PM, Albert J. Wong (王重傑)
ajw...@chromium.org wrote:
If I'm not mistaken, I think like most everyone running on linux is
using
the make build nowadays, and the make build seems to work well enough
for
most people. The only time I hear someone mention the scons build, it's
in
reference
2009/10/28 Lei Zhang thes...@chromium.org
mmoss has been working on the make gyp generator, maybe he has a
better feel for what's keeping us from switching.
On Wed, Oct 28, 2009 at 12:35 PM, Albert J. Wong (王重傑)
ajw...@chromium.org wrote:
On Wed, Oct 28, 2009 at 12:34 PM, Marc-Antoine Ruel
of it).
-BradN
On Wed, Oct 28, 2009 at 1:13 PM, Albert J. Wong (王重傑) ajw...@chromium.org
wrote:
I ran into that yesterday as well trying to make a make generator fix. I
think I'll hang on until mmoss gets back since I heard he's in the middle of
trying to fix that. But assuming the unittest can
As of r30640, on Linux and FreeBSD, we are now building the FFmpeg binaries
as part of the normal Chromium build process. This means we now have a
dependency on libbz2. :)
Make sure to install the libbz2-dev package. I've updated the
src/build/install-build-deps.sh script to reflect the new
Sounds really powerful...but this scares methough that could just be my
generalized fear of inheritance. However, if we start putting inheritance
into the system, I worry about the level of complexity the gyp specification
language will pick up and the possible breakages of information hiding
On Sun, Nov 1, 2009 at 3:26 PM, Bradley Nelson bradnel...@google.comwrote:
1) Do you support multiple inheritance? I notice the inherit_from is
specified as an array. That's scaryish.
Multiple inheritance is supported, not sure it's wise to use, but well gyp
has lots of features like
On Mon, Nov 2, 2009 at 3:37 PM, Bradley Nelson bradnel...@google.comwrote:
S,o as it happens, I just had someone on nacl make the first use of
multiple inheritance this morning.
He hasn't checked it in yet, but the use case is:
'Common': {
# bunch of global stuff
'defines': [
#
We're still in the middle of switching. I had made a pass over the docs a
few weeks ago, but I'm sure I missed some spots. If you see any more spots,
or want to do another pass to make sure the docs push people towards the
make build by default, it'd be much appreciated!
Thanks,
Albert
On
For ffmpeg, you should be able to set GYP_DEFINES=use_system_ffmpeg=1 to
disable the in-tree ffmpeg build. That should get you past that stumbling
block. HTML5 video won't work, but like Evan said, that's probably the
least of your concerns.
-Albert
On Tue, Nov 24, 2009 at 1:25 PM, Evan Martin
addr2line is another possible option.
addr2line -e sconsbuild/Debug/chrome 0x87d9bc
This works even if -fvisbility=hidden. I think w/o address space layout
randomization, it's...relatively deterministic (I think).
So, given that, maybe it would be sensible to find a way to add a small
There have been some changes to the ffmpeg.gyp file recently. Dominic makes
a good point that the GYP_DEFINES will make a large difference.
Thiago, what GYP_DEFINES do you have set?
Note that ffmpeg_asm is not a build dependency. It's a target in the
ffmpeg.gyp file that must somehow be
On Thu, Jan 7, 2010 at 2:46 PM, Darin Fisher da...@chromium.org wrote:
On Thu, Jan 7, 2010 at 1:34 PM, Jeremy Orlow jor...@chromium.org wrote:
(As discussed during lunch...) Why not just do this in this case and
remove EmptyString() altogether?
const std::string MyClass::foo() const {
On Thu, Jan 7, 2010 at 2:53 PM, Victor Khimenko k...@google.com wrote:
On Fri, Jan 8, 2010 at 1:51 AM, Albert J. Wong (王重傑)
ajw...@chromium.orgwrote:
On Thu, Jan 7, 2010 at 2:46 PM, Darin Fisher da...@chromium.org wrote:
On Thu, Jan 7, 2010 at 1:34 PM, Jeremy Orlow jor
[ resending from correct e-mail ]
If you are saying that everywhere in the code can return by value instead
of by const ref and the compiler will optimize it equivalently, you are
wrong; I was under the same misapprehension until yesterday. We've verified
that even in the best case
That's
68 matches
Mail list logo
