Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

2017-12-10 Thread Jaikiran Pai
You are right, that indeed was the issue (for one of that failing test). I have pushed a commit with this change to fix that one. -Jaikiran On 10/12/17 3:13 PM, Stefan Bodewig wrote: On 2017-12-10, Stefan Bodewig wrote: testCreateDoubleHanging is related to https://bz.apache.org/bugzilla

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

2017-12-10 Thread Jaikiran Pai
I'll investigate why this is failing (local tests pass for me) and fix it. -Jaikiran On 10/12/17 2:29 PM, Apache Jenkins Server wrote: See <https://builds.apache.org/job/Ant-Build-Matrix-master-Linux/jdk=JDK%201.8%20(latest)/977/display/redirect?page=chan

[GitHub] ant issue #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/49 Committed to master branch https://github.com/apache/ant/commit/cefdbd398d8e310b218f9e2ca6f0b7fb13eddbb9 --- - To unsubscribe, e

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/49 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/49 >> Overall I'm in favor of this change and if you want to spend the time on fixing the bugzilla issue in a Java5 friendly way for 1.9.x that would certainly be good - bit not something I

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941213 --- Diff: src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java --- @@ -30,6 +30,8 @@ * a symbolic link based on the absent support for them in Java

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941155 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java --- @@ -500,18 +502,12 @@ private void doLink(String res, String lnk) throws

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941101 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java --- @@ -448,49 +432,67 @@ private void handleError(String msg

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941095 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java --- @@ -207,26 +198,30 @@ public void recreate() throws BuildException

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941080 --- Diff: manual/Tasks/symlink.html --- @@ -26,7 +26,7 @@ Symlink Description - Manages symbolic links on Unix based platforms. Can be used

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-08 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/49 [master branch] - Fix BZ-58683 The commit here fixes the issue reported at https://bz.apache.org/bugzilla/show_bug.cgi?id=58683. This commit along with fixing the issue reported in that bug

Re: ant-ivy git commit: tidy up the code

2017-12-08 Thread Jaikiran Pai
inconsistent when someone adding new code using a different construct (like not using explicit brackets), but it's not that big a deal, IMO. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For a

Re: new JDK version scheme

2017-11-28 Thread Jaikiran Pai
[1] http://openjdk.java.net/jeps/223 [2] https://docs.oracle.com/javase/9/docs/api/java/lang/Runtime.html#version-- -Jaikiran On 28/11/17 10:10 PM, Stefan Bodewig wrote: On 2017-11-28, Stefan Bodewig wrote: Maybe we really need to start parsing the java.version syste

[GitHub] ant pull request #48: BZ-61718 Upgrade to 0.1.54 of Jsch library

2017-11-04 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/48 BZ-61718 Upgrade to 0.1.54 of Jsch library The commit here upgrades Jsch library dependency to `0.1.54` (which is the latest released version) as requested in https://bz.apache.org/bugzilla

Re: [2/2] ant-ivy git commit: No need to synchronise a concurrent map

2017-11-01 Thread Jaikiran Pai
removed, it no longer guarantees the entire block to be done serially by a single thread anymore. -Jaikiran On 02/11/17 2:50 AM, gin...@apache.org wrote: No need to synchronise a concurrent map Project: http://git-wip-us.apache.org/repos/asf/ant-ivy/repo Commit: http://git-wip-us.apache.org

Re: ant-ivy git commit: IVY-1420 document current implementation [Forced Update!]

2017-10-21 Thread Jaikiran Pai
Let's not force update the upstream repo please, especially the real branches like the master branch. -Jaikiran On 21/10/17 10:22 PM, gin...@apache.org wrote: Repository: ant-ivy Updated Branches: refs/heads/master 744c31824 -> 2074889ec (forced update) IVY-1420 document curr

[GitHub] ant issue #37: [1.9.x branch] BZ-60644 Fix file corruption during copy task

2017-09-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/37 Tests against various JDK versions against Windows and Linux went fine without any regressions. Will go ahead and merge this now

[GitHub] ant pull request #37: [1.9.x branch] BZ-60644 Fix file corruption during cop...

2017-09-28 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/37#discussion_r141594830 --- Diff: src/main/org/apache/tools/ant/util/ResourceUtils.java --- @@ -666,6 +666,14 @@ private static void copyWithFilterSets(final Resource source, final

Re: Error while testing 2.5.0-SNAPSHOT

2017-09-25 Thread Jaikiran Pai
Is there a source repo and steps that I can follow to build and reproduce this issue? My attempts so far haven't been able to reproduce this. -Jaikiran On 14/09/17 1:57 PM, Aurélien Pupier wrote: Hello, I'm trying to test https://issues.apache.org/jira/browse/IVY-1568 using latest 2.5.0

Re: Ivy upcoming release - where we stand

2017-09-24 Thread Jaikiran Pai
Since the latest released version of that library is 1.58, I think we should use that version, unless there's a specific reason to not use it. A quick compilation of Ivy with this library and checking their docs for JDK compatibility suggested no issues with 1.58. -Jaikiran On 19/09/17 10

[GitHub] ant issue #39: [1.9.x branch] BZ-58589 Preserve last modified time (if asked...

2017-09-24 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/39 Merged to both 1.9.x and master branches. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e

[GitHub] ant issue #39: [1.9.x branch] BZ-58589 Preserve last modified time (if asked...

2017-09-17 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/39 Ignore the Jenkins job message please - I haven't yet got it configured correctly. --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] ant pull request #39: [1.9.x branch] BZ-58589 Preserve last modified time (i...

2017-09-17 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/39 [1.9.x branch] BZ-58589 Preserve last modified time (if asked for) for files uploaded by SFTP The commit here adds support for preserving the last modified time on files when uploaded via SFTP

[GitHub] ant pull request #38: Do not merge

2017-09-17 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/38 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #38: Do not merge

2017-09-17 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant/pull/38 Do not merge Testing Jenkins integration. Do not merge this PR You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaikiran/ant dummy Alternatively

[GitHub] ant pull request #38: Do not merge

2017-09-17 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/38 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #38: Do not merge

2017-09-17 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/38 Do not merge Testing Jenkins integration. Do not merge this PR You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaikiran/ant dummy Alternatively

[GitHub] ant pull request #37: [1.9.x branch] BZ-60644 Fix file corruption during cop...

2017-09-17 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/37 [1.9.x branch] BZ-60644 Fix file corruption during copy task The commit here includes a fix for the issue reported in https://bz.apache.org/bugzilla/show_bug.cgi?id=60644. As described in that issue

Re: Error while testing 2.5.0-SNAPSHOT

2017-09-14 Thread Jaikiran Pai
er instead of the BasicURLHandler. That seems to be one part of the problem. I'll take a more detailed look after checking out the code which invokes Ivy. -Jaikiran On 14/09/17 1:57 PM, Aurélien Pupier wrote: Hello, I'm trying to test https://issues.apache.org/jira/browse/IVY-1568 using la

Re: [1/6] ant-ivy git commit: Documentation review (partly inspired by IVY-1089) [Forced Update!]

2017-09-06 Thread Jaikiran Pai
merge conflicts, if any) against the relevant branch of the latest upstream. -Jaikiran On 06/09/17 8:46 AM, gin...@apache.org wrote: Repository: ant-ivy Updated Branches: refs/heads/master 614bf1ad5 -> b693aa0a2 (forced update) http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/b693a

[GitHub] ant-ivy pull request #60: use Unicode glyphs or SVG data URLs instead of bit...

2017-08-31 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/60#discussion_r136327295 --- Diff: build-release.xml --- @@ -179,11 +180,11 @@ - + --- End diff

[GitHub] ant-ivy issue #53: suppressed warnings

2017-08-31 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/53 Thanks! This is now merged to upstream. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Broken tutorial

2017-08-31 Thread Jaikiran Pai
On 29/08/17 12:35 PM, Gintautas Grigelionis wrote: I noticed another problem with asciidoc: 1.5.4 fails on my box with the latest Java 8u144, I had to downgrade it to 1.5.3 -- did anyone else see that? 1.5.4 works fine for me with Java 8. -Jaikiran

Ivy - Latest snapshots will now be regularly available in Apache Maven Snapshot repository

2017-08-31 Thread Jaikiran Pai
version) are:     org.apache.ivy     ivy     2.5.0-SNAPSHOT and can be found here https://repository.apache.org/content/groups/snapshots/org/apache/ivy/ivy/2.5.0-SNAPSHOT/ [1] https://builds.apache.org/job/Ivy-Snapshot-Deploy/ [2] https://repository.apache.org/snapshots/ -Jaikiran

Re: Broken tutorial

2017-08-28 Thread Jaikiran Pai
effort algorithm during install, so that everything gets installed except the missing artifacts. (Note: these missing artifacts are not in the public maven repository due to licensing issues) ... [1] http://ant.apache.org/ivy/history/master/tutorial/build-repository/basic.html -Jaikiran

Re: Ant-Ivy: Publish don't pull declared dependencies

2017-08-28 Thread Jaikiran Pai
As far as I know, the publish task itself doesn't fetch any dependencies. The dependencies itself are downloaded by a (previous) resolve task that is invoked separately and explicitly. -Jaikiran On 31/07/17 11:32 PM, maikel van den Hurk wrote: Hi all, I am wondering if there is already

[GitHub] ant-ivy issue #59: IVY-1566 - Store External form of URL in cached files

2017-08-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/59 >> thanks @jaikiran do you have an Estimated Time for next release containing this bugfix? @apupier - the plan is to have it soon (no specific date yet). We are almost at the la

[GitHub] ant-ivy issue #59: IVY-1566 - Store External form of URL in cached files

2017-08-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/59 Thank you for the PR and sorry it took a while to merge this. I have included the change you suggested in this PR with a minor change and merged it upstream. --- If your project is set up

Re: Documentation-related issues in Jira

2017-08-22 Thread Jaikiran Pai
. -Jaikiran On 23/08/17 12:12 AM, Gintautas Grigelionis wrote: Earlier, I wrote about the amount of documentation-related issues in Jira. There are 27 of them still open [1], and some of them could be closed right away. I would be glad to help, but I have no privileges. Is there somebody who could

Re: IVY-1485

2017-08-07 Thread Jaikiran Pai
I'm looking into that JIRA. I'll assigned it to my name now. -Jaikiran On 06/08/17 12:52 PM, Gintautas Grigelionis wrote: I went through JIRA issues and noticed https://issues.apache.org/jira/browse/IVY-1485 was discussed relatively recently ;-) Anybody looking into it? Gintas P.S. JIRA

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-08-02 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/57 Hi Gintas, To be clear - what I meant/proposed in the dev list was: - It's fine to have all the changes related to introducing that new method with Java generics

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-07-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/57 Overall, this looks fine to me. I just need some inputs from the rest of the team on one specific change, for which I have raised a dev list thread https://www.mail-archive.com/dev@ant.apache.org

Ivy - PR-57 need inputs

2017-07-28 Thread Jaikiran Pai
that new method, but I think that should be fine for now. I would like some inputs on how we should go about this. [1] https://github.com/apache/ant-ivy/pull/57/files#diff-8078d19e36e6c0b7abb0690fca45db0fR191 -Jaikiran

Ivy - PR-57 need inputs

2017-07-28 Thread Jaikiran Pai
that new method, but I think that should be fine for now. I would like some inputs on how we should go about this. [1] https://github.com/apache/ant-ivy/pull/57/files#diff-8078d19e36e6c0b7abb0690fca45db0fR191 -Jaikiran

Re: Is CacheResolver relevant?

2017-07-27 Thread Jaikiran Pai
On 27/07/17 9:34 PM, Jaikiran Pai wrote: There's a JIRA[2] asking for the docs to be updated to explain this resolver. ... [2] https://issues.apache.org/jira/browse/IVY-804 I meant this JIRA which asks for it to be documented https://issues.apache.org/jira/browse/IVY-612 -Jaikiran

Is CacheResolver relevant?

2017-07-27 Thread Jaikiran Pai
ave to do. On the other hand, if we don't have to support this, then I can just remove it from that typedef.properties file. [1] https://github.com/apache/ant-ivy/blob/master/src/java/org/apache/ivy/plugins/resolver/CacheResolver.java [2] https://issues.apache.org/

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-27 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/53 Commit https://github.com/apache/ant-ivy/pull/53/commits/414651c8841a09a9d9d4b0365ee8e7227fba8429 in this PR has now been merged to upstream https://github.com/apache/ant-ivy/commit

[GitHub] ant-ivy pull request #:

2017-07-27 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23334838 Do you mean for the `symlinkmass` deprecation? In this release, I just wanted it to be deprecated with a log message showing up

Re: Ivy - Move to symlink creation standard Java API?

2017-07-27 Thread Jaikiran Pai
. -Jaikiran On 27/07/17 5:07 PM, Gintautas Grigelionis wrote: I did a few simple tests on Windows 7 + Cygwin and NIO.2 seems to work just fine (if privilege to create symlinks is granted). +1 Gintas 2017-07-27 11:40 GMT+02:00 Gintautas Grigelionis <g.grigelio...@gmail.com>: There

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129757849 --- Diff: src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java --- @@ -85,14 +85,12 @@ public LatestCompatibleConflictManager

Re: Ivy Jenkins jobs have been failing - infra issues

2017-07-26 Thread Jaikiran Pai
https://issues.apache.org/jira/browse/INFRA-14712 -Jaikiran On 26/07/17 6:36 PM, Jaikiran Pai wrote: More of a FYI than anything else - the past couple of days or so, we haven't had regular successful runs of our various Ivy Jenkins jobs. Each run failing with different errors, all pointing

Re: Build failed in Jenkins: Ivy #627

2017-07-26 Thread Jaikiran Pai
To avoid more such mails, I'm going to disable this job for a few hours till we get the infra issues sorted out. -Jaikiran On 26/07/17 10:44 PM, Apache Jenkins Server wrote: See <https://builds.apache.org/job/Ivy/627/display/redirect> -- S

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129587968 --- Diff: src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java --- @@ -85,14 +85,12 @@ public LatestCompatibleConflictManager

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129593699 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -71,132 +71,139 @@ --- End diff -- This file has a large

Ivy - Move to symlink creation standard Java API?

2017-07-26 Thread Jaikiran Pai
ymbolicLink(java.nio.file.Path,%20java.nio.file.Path,%20java.nio.file.attribute.FileAttribute...) -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Ivy Jenkins jobs have been failing - infra issues

2017-07-26 Thread Jaikiran Pai
the Infra team mailing list or their JIRA to see if this is already reported by other projects. I will see if I can find some time tonight to check that and report it, if it hasn't yet been. -Jaikiran - To unsubscribe, e-mail

[GitHub] ant-ivy pull request #:

2017-07-25 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286798 Sure, I'll do a find/replace in one of my upcoming doc fixes commit. --- If your project is set up for it, you can reply

Re: Ivy - No more support for commons-httpclient 2.x in runtime classpath?

2017-07-25 Thread Jaikiran Pai
the latest snapshot a try to see if there are any unforeseen regressions. -Jaikiran On 25/07/17 12:37 AM, Nicolas Lalevée wrote: Le 24 juil. 2017 à 08:19, Jaikiran Pai <jai.forums2...@gmail.com> a écrit : That's a a big enough reason to move to HttpComponents Client 4.x version! I'll

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-25 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/53 Hi Gintas, Given the amount of commits and the changes involved in this PR, it's a bit difficult to review it. I think this PR even includes some of the changes that have already been

Re: Ivy - No more support for commons-httpclient 2.x in runtime classpath?

2017-07-24 Thread Jaikiran Pai
That's a a big enough reason to move to HttpComponents Client 4.x version! I'll have that done in this release of Ivy then. -Jaikiran On 24/07/17 11:43 AM, Stefan Bodewig wrote: On 2017-07-24, Jaikiran Pai wrote: Ivy currently uses commons-httpclient for dealing with HTTP repositories

Re: AW: Ivy - No more support for commons-httpclient 2.x in runtime classpath?

2017-07-24 Thread Jaikiran Pai
and moving to the more latest HttpComponents Client sounds fine to me. -Jaikiran So I'm +1 in dropping commons-http-2 support. What about dropping commons-http-3 too? Here I can't see the requirement for having this dynamic loading (but maybe someone else). Jan -Ursprüngliche Nachrich

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-23 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/54 >> So it's not going to work out supporting 2.x version since we will end up using 3.x APIs at compile time. But that's a different topic altogether and something that I will raise a de

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-23 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/54 >> VsftpRepository has DEFAULT_READ_TIMEOUT and DISCONNECT_COMMAND_TIMEOUT; would that require an additional timeout attribute? I had a look at this. Given that there's currently

Ivy - No more support for commons-httpclient 2.x in runtime classpath?

2017-07-23 Thread Jaikiran Pai
/ivy.xml#L47 -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: Broken link at https://ant.apache.org/mail.html

2017-07-23 Thread Jaikiran Pai
It looks like the domain got repurposed sometime in 2012. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-22 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/54 Gintas, thanks for pointing me to that code. I now understand what you meant. So essentially, Ivy internally tries to support both 2.x and 3.x version of HTTP client library at runtime

[GitHub] ant issue #35: [1.9.x branch] Fix for BZ-43271 BZ-59648

2017-07-22 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/35 All done - applied this commit to 1.9.x branch and then merged to master branch. The pushed commit also includes updates to the WHATSNEW and contributor files. --- If your project is set up

[GitHub] ant pull request #35: [1.9.x branch] Fix for BZ-43271 BZ-59648

2017-07-22 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Next Ivy release?

2017-07-22 Thread Jaikiran Pai
In short, yes - there's a plan to have a Ivy release soon. A more detailed explanation is available in this recent Ivy users mailing list thread https://www.mail-archive.com/ivy-user@ant.apache.org/msg06244.html -Jaikiran On 22/07/17 8:12 AM, Nick C. wrote: Will there be a new Ivy release

[GitHub] ant pull request #35: [1.9.x branch] Fix for BZ-43271 BZ-59648

2017-07-22 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/35 [1.9.x branch] Fix for BZ-43271 BZ-59648 The commit here fixes the issue reported in: https://bz.apache.org/bugzilla/show_bug.cgi?id=43271#c6 https://bz.apache.org/bugzilla/show_bug.cgi?id

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-22 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/54 >> The PR contains additional changes to HttpClientHandler, introducing HttpConnectionManagerParams, which is not available in Commons HTTP Client version 2 (over 10 years old and virtuall

Re: Proposed changes for IVY-735 - Ability to specify timeouts

2017-07-21 Thread Jaikiran Pai
ctually write a test to verify this behaivour, I may have missed or misunderstood the parsing code so if anyone thinks what I state isn't accurate, feel free to correct me. [1] https://github.com/apache/ant-ivy/pull/54 [2] https://ant.apache.org/ivy/history/latest-milestone/settings/resolvers.html#comm

[GitHub] ant-ivy pull request #54: IVY-735 Support timeouts on resolvers

2017-07-21 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/54 IVY-735 Support timeouts on resolvers The commit in this PR adds support for specifying connection and read timeouts for resolvers, so that users have control over how the resolvers behave when

Re: Coding style: import of nested classes

2017-07-20 Thread Jaikiran Pai
of it to use instead of trying to make it consistent via checkstyle or refactoring. -Jaikiran On 18/07/17 5:09 PM, Gintautas Grigelionis wrote: In my last PR I tried to address inconsistencies with import of nested classes, such as Map.Entry; some classes, e.g. IvySettings ended up with foreach loops

[GitHub] ant-ivy issue #52: Generics in core

2017-07-17 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/52 It looks like this PR has been updated with additional unrelated changes. Except for these 2 commits in this PR: https://github.com/apache/ant-ivy/pull/52/commits

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127475255 --- Diff: src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java --- @@ -148,7 +142,7 @@ public void put(File source, String destination

Proposed changes for IVY-735 - Ability to specify timeouts

2017-07-14 Thread jaikiran . pai
but if this whole approach looks fine, I will take this further and make sure things work as expected. [1] https://github.com/jaikiran/ant-ivy/commit/e501d9deca78db8b934f8a2710ebcfeaeb1456c8 [2] https://github.com/jaikiran/ant-ivy/commit/e501d9deca78db8b934f8a2710ebcfeaeb1456c8#diff-cd8ed454a52f

Proposed changes for IVY-735 - Ability to specify timeouts

2017-07-14 Thread Jaikiran Pai
s fine, I will take this further and make sure things work as expected. [1] https://github.com/jaikiran/ant-ivy/commit/e501d9deca78db8b934f8a2710ebcfeaeb1456c8 [2] https://github.com/jaikiran/ant-ivy/commit/e501d9deca78db8b934f8a2710ebcfeaeb1456c8#diff-cd8ed454a52f4afa779574f560

[GitHub] ant-ivy issue #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/52 I've reviewed this PR and apart from the review comments noted, the rest of the changes look fine. Please only include any review comments related changes to this PR, from now on. Else it's going

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127398802 --- Diff: src/java/org/apache/ivy/util/url/HttpClientHandler.java --- @@ -177,7 +177,7 @@ public URLInfo getURLInfo(URL url, int timeout

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127398451 --- Diff: src/java/org/apache/ivy/tools/analyser/JarJarDependencyAnalyser.java --- @@ -39,21 +39,22 @@ public JarJarDependencyAnalyser(File

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127397658 --- Diff: src/java/org/apache/ivy/plugins/repository/ssh/SshCache.java --- @@ -263,9 +263,8 @@ public void clearSession(Session session

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127397389 --- Diff: src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java --- @@ -148,7 +142,7 @@ public void put(File source, String destination

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396424 --- Diff: src/java/org/apache/ivy/osgi/util/VersionRange.java --- @@ -306,7 +306,7 @@ public boolean isClosedRange() { return

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396341 --- Diff: src/java/org/apache/ivy/osgi/repo/RepositoryManifestIterable.java --- @@ -59,11 +59,11 @@ protected InputStream getInputStream(String f) throws

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396320 --- Diff: src/java/org/apache/ivy/osgi/repo/RepositoryManifestIterable.java --- @@ -59,11 +59,11 @@ protected InputStream getInputStream(String f) throws

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395825 --- Diff: src/java/org/apache/ivy/osgi/repo/AbstractFSManifestIterable.java --- @@ -44,9 +44,9 @@ public AbstractFSManifestIterable(T root

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395788 --- Diff: src/java/org/apache/ivy/osgi/repo/AbstractFSManifestIterable.java --- @@ -44,9 +44,9 @@ public AbstractFSManifestIterable(T root

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395633 --- Diff: src/java/org/apache/ivy/osgi/p2/XMLInputParser.java --- @@ -19,12 +19,11 @@ import java.io.IOException; import java.io.InputStream

Re: Fw: [2/2] ant-ivy git commit: Merge remote-tracking branch 'origin/master'

2017-07-13 Thread Jaikiran Pai
s. In this specific case this merge commit just points to the previous commit that was already in the upstream repo. We won't have to revert anything. -Jaikiran On 13/07/17 5:47 AM, Maarten Coene wrote: I remember IntelliJ was saying something about a failed commit asking me to merge to the la

Re: Fw: [2/2] ant-ivy git commit: Merge remote-tracking branch 'origin/master'

2017-07-12 Thread Jaikiran Pai
I'm guessing that while committing the fix for IVY-1404 you probably did a "git merge" against latest master of upstream, which created this merge commit. -Jaikiran On 12/07/17 1:45 PM, Maarten Coene wrote: Any idea where this commit comes from?I didn't touch any of these fi

Re: Build failed in Jenkins: IvyDE #320

2017-07-10 Thread Jaikiran Pai
.eclipse.org which just presents a generic 404 page. I think for us, at this point, it's a matter of changing our build file to just point directly to the relevant specific links listed on archive.eclipse.org here http://archive.eclipse.org/tools/gef/downloads/drops/3.9.100/R201405261516/ -Jaikiran

[GitHub] ant-ivy issue #51: Fix some string comparisons with ==

2017-07-09 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/51 Thanks for the PR. This has now been merged. I had to fix the `ModuleDescriptorMemoryCacheTest` which got exposed by (valid) changes in this PR. --- If your project is set up for it, you can

[GitHub] ant-ivy issue #48: Generics and Java 7 syntax in osgi and plugins packages

2017-07-01 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/48 >> https://stackoverflow.com/questions/30454635/when-using-for-a-primitive-and-a-boxed-value-is-autoboxing-done-or-is-unbox Thanks - the JLS sections[1][2] mentioned in there answ

[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-07-01 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/48#discussion_r125161935 --- Diff: src/java/org/apache/ivy/plugins/signer/bouncycastle/OpenPGPSignatureGenerator.java --- @@ -161,7 +159,7 @@ private PGPSecretKey readSecretKey

[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-07-01 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/48#discussion_r125162592 --- Diff: src/java/org/apache/ivy/plugins/signer/bouncycastle/OpenPGPSignatureGenerator.java --- @@ -161,7 +159,7 @@ private PGPSecretKey readSecretKey

Re: Ivy - we have now moved to asciidoc for docs

2017-07-01 Thread Jaikiran Pai
On 29-Jun-2017, at 11:29 AM, Jaikiran Pai <jai.forums2...@gmail.com> wrote: > I’m picking up “OSGi” section next. I have completed and pushed the migration of “OSGi” and “Using standalone” sections to upstream (it’s actually live on site since yesterday). For the OSGi pages, I had

Re: Ivy - we have now moved to asciidoc for docs

2017-07-01 Thread Jaikiran Pai
the “experimental” note/section that we repeat (copy/paste really) on our OSGi pages. -Jaikiran > Le 29 juin 2017 à 15:16, Jaikiran Pai <jai.forums2...@gmail.com> a écrit : > > > On 29-Jun-2017, at 3:58 PM, Nicolas Lalevée <nicolas.lale...@hibnet.org> > wrote: > &g

Re: Ivy - we have now moved to asciidoc for docs

2017-07-01 Thread Jaikiran Pai
for it) https://github.com/apache/ant-ivy/pull/48#discussion-diff-125161935R162. Other than that, the PR looks fine to me. -Jaikiran On 01-Jul-2017, at 5:37 PM, Nicolas Lalevée <nicolas.lale...@hibnet.org> wrote: Thank you very much Gintas. These PRs are huge, so they will take a litt

Re: Jenkins Jobs of Ivy/IvyDE

2017-06-29 Thread Jaikiran Pai
I have now disabled the nightly job[1] and added a note to the job's description stating that the latest binaries can be obtained from the other Ivy job[2]. [1] https://builds.apache.org/job/Ivy-NightlyDistribution/ [2] https://builds.apache.org/job/Ivy/lastSuccessfulBuild/ -Jaikiran On 29

<    1   2   3   4   5   6   7   8   >