Re: Backporting try-with-resources to Java 7 (was: Re: [imaging] Closing stream)

2013-11-04 Thread Gary Gregory
I thought we were going to Java 7 for 2.0? Gary Original message From: Damjan Jovanovic dam...@apache.org Date:11/04/2013 02:11 (GMT-05:00) To: Commons Developers List dev@commons.apache.org Subject: Re: Backporting try-with-resources to Java 7 (was: Re: [imaging]

Re: [VOTE] Release Apache Commons Pool 2.0 RC3 as 2.0

2013-11-04 Thread Jörg Schaible
Bernd Eckenfels wrote: Hello, I dont think it is a critical thing for OSGi for two reasons: a) typically dependencies are no longer on the bundle name but on packages Yes, but names follow conventions and in other Apache Commons components we use the real package name for the bundle name

Re: Backporting try-with-resources to Java 7 (was: Re: [imaging] Closing stream)

2013-11-04 Thread Matt Benson
On Nov 4, 2013 1:12 AM, Damjan Jovanovic dam...@apache.org wrote: For the record, I would only use this for imaging = 2.0. Weaver looked undocumented and undecipherable to me, but let me look at it again slowly. Tell me how you really feel! :-) More seriously, tell me how to fix these

Re: [VOTE] Release Apache Commons Pool 2.0 RC2 as 2.0

2013-11-04 Thread sebb
On 3 November 2013 19:55, Mark Thomas ma...@apache.org wrote: On 02/11/2013 23:36, Thomas Neidhart wrote: Thanks for the testing. One minor thing: When publishing the site you will most likely encounter problems, as the pom is missing some configurations regarding the scm publishing.

[POOL] Update Commons Parent to current?

2013-11-04 Thread sebb
The Pool2 pom currently uses Cp28; the current release is 32. Note: assuming this is changed, also need to fix: maven.compile.* = maven.compiler.* - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional

[math] Multithreaded performances

2013-11-04 Thread Romain Manni-Bucau
Hi, ATM sirona (a java monitoring library in incubator) relies a lot on Summary stats object from [math3] but it needed a lock to ensure consistency. I know there is a synchronized version but this one scales less then the locked one. My question is quite simple then: will [math] add an

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-04 Thread sebb
On 2 November 2013 14:52, Sean Owen sro...@apache.org wrote: In Math, is there any appetite for large patches containing many instances of particular micro-optimizations? Examples: - Replace: a[i][j] = a[i][j] + foo; with: a[i][j] += foo; … which is faster/leaner in the byte

Re: [math] Multithreaded performances

2013-11-04 Thread Ted Dunning
My experience is that the only way to get really high performance with counter-like objects is to have one per thread and combine them on read. On Mon, Nov 4, 2013 at 8:49 AM, Romain Manni-Bucau rmannibu...@gmail.comwrote: Hi, ATM sirona (a java monitoring library in incubator) relies a

Re: [math] Multithreaded performances

2013-11-04 Thread Romain Manni-Bucau
Thats more or less what does LongAdder in a more clever way. Le 4 nov. 2013 18:15, Ted Dunning ted.dunn...@gmail.com a écrit : My experience is that the only way to get really high performance with counter-like objects is to have one per thread and combine them on read. On Mon, Nov 4, 2013

Re: [math] Multithreaded performances

2013-11-04 Thread Phil Steitz
On 11/4/13 8:49 AM, Romain Manni-Bucau wrote: Hi, ATM sirona (a java monitoring library in incubator) relies a lot on Summary stats object from [math3] but it needed a lock to ensure consistency. I know there is a synchronized version but this one scales less then the locked one. My

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-04 Thread Phil Steitz
On 11/4/13 2:08 AM, Luc Maisonobe wrote: Le 04/11/2013 00:59, Gilles a écrit : On Sun, 03 Nov 2013 15:33:12 -0800, Phil Steitz wrote: On 11/3/13 2:57 PM, Gilles wrote: On Sun, 03 Nov 2013 21:03:02 +0100, Luc Maisonobe wrote: Le 03/11/2013 20:17, Ted Dunning a écrit : On Sun, Nov 3, 2013 at

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-04 Thread Gilles
On Mon, 04 Nov 2013 09:47:32 -0800, Phil Steitz wrote: On 11/4/13 2:08 AM, Luc Maisonobe wrote: Le 04/11/2013 00:59, Gilles a écrit : On Sun, 03 Nov 2013 15:33:12 -0800, Phil Steitz wrote: On 11/3/13 2:57 PM, Gilles wrote: On Sun, 03 Nov 2013 21:03:02 +0100, Luc Maisonobe wrote: Le

Re: [POOL] Update Commons Parent to current?

2013-11-04 Thread Mark Thomas
sebb seb...@gmail.com wrote: The Pool2 pom currently uses Cp28; the current release is 32. Note: assuming this is changed, also need to fix: maven.compile.* = maven.compiler.* - To unsubscribe, e-mail:

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-04 Thread Phil Steitz
On 11/4/13 10:11 AM, Gilles wrote: On Mon, 04 Nov 2013 09:47:32 -0800, Phil Steitz wrote: On 11/4/13 2:08 AM, Luc Maisonobe wrote: Le 04/11/2013 00:59, Gilles a écrit : On Sun, 03 Nov 2013 15:33:12 -0800, Phil Steitz wrote: On 11/3/13 2:57 PM, Gilles wrote: On Sun, 03 Nov 2013 21:03:02

Re: [Math] due-to attribute in changes.xml

2013-11-04 Thread Jochen Wiedmann
On Thu, Oct 31, 2013 at 2:26 PM, Gilles gil...@harfang.homelinux.orgwrote: Hello. Are there criteria about filling the due-to attribute of an issue record in the changes.xml file? Be generous with using it: I've seen examples of people being quite stimulated for more work by them included

Re: [VOTE] Release Imaging 1.0 from RC5

2013-11-04 Thread Damjan Jovanovic
On Sun, Nov 3, 2013 at 1:00 AM, Jörg Schaible joerg.schai...@gmx.de wrote: Hi Damjan, Damjan Jovanovic wrote: Please vote on releasing commons-imaging 1.0 from RC5. RC4 and its problems and their fixes were in this thread:

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-04 Thread Luc Maisonobe
Le 04/11/2013 19:49, Gilles a écrit : [...] What I suggested is to try and see whether the ExceptionContext can be used more. Exceptioncontext has been add more than two years ago (revision 1099771, 2011-05-05). Since then its setValue method is called in only two places in regular code

[CANCELLED][VOTE] Release Apache Commons Pool 2.0 RC3 as 2.0

2013-11-04 Thread Mark Thomas
Cancel the right thread this time. Mark On 04/11/2013 12:36, Jörg Schaible wrote: Bernd Eckenfels wrote: Hello, I dont think it is a critical thing for OSGi for two reasons: a) typically dependencies are no longer on the bundle name but on packages Yes, but names follow conventions

Re: [math] Multithreaded performances

2013-11-04 Thread Romain Manni-Bucau
But aggregation needs to lock so not a real solution. Lock is fine on real cases but not in simple/light ones. ThreadLocal leaks...so a trade off should be found Le 4 nov. 2013 18:42, Phil Steitz phil.ste...@gmail.com a écrit : On 11/4/13 8:49 AM, Romain Manni-Bucau wrote: Hi, ATM sirona

Re: [math] Multithreaded performances

2013-11-04 Thread Phil Steitz
On 11/4/13 12:12 PM, Romain Manni-Bucau wrote: But aggregation needs to lock so not a real solution. Lock is fine on real cases but not in simple/light ones. ThreadLocal leaks...so a trade off should be found Depends on the use case. If the use case is 0) launch a bunch of threads and let

Re: [math] Multithreaded performances

2013-11-04 Thread Romain Manni-Bucau
In sirona we collect (aggregate) data each N ms and we can still use stats during aggregation (worse case surely) Le 4 nov. 2013 21:48, Phil Steitz phil.ste...@gmail.com a écrit : On 11/4/13 12:12 PM, Romain Manni-Bucau wrote: But aggregation needs to lock so not a real solution. Lock is fine

Re: [VOTE] Release Imaging 1.0 from RC5

2013-11-04 Thread Jörg Schaible
Hi Damjan, Damjan Jovanovic wrote: On Sun, Nov 3, 2013 at 1:00 AM, Jörg Schaible joerg.schai...@gmx.de wrote: [snip] The following error was some time ago normal, but I haven't seen it for some time now: = % = $ tar xf commons-imaging-1.0-src.tar.gz

Re: [math] Multithreaded performances

2013-11-04 Thread Phil Steitz
On 11/4/13 12:58 PM, Romain Manni-Bucau wrote: In sirona we collect (aggregate) data each N ms and we can still use stats during aggregation (worse case surely) Can you explain more clearly exactly what you are doing? What needs to be aggregated when? How are the threads managed? Phil Le

Re: [math] Multithreaded performances

2013-11-04 Thread Ted Dunning
I still think that what you need is a thread-safe copy rather than a thread-safe mutate. Even if you force every thread to do the copy, the aggregation still still wins on complexity/correctness/performance ideas. On Mon, Nov 4, 2013 at 12:58 PM, Romain Manni-Bucau rmannibu...@gmail.comwrote:

Re: [math] Multithreaded performances

2013-11-04 Thread Romain Manni-Bucau
A counter has a stat object, then methods are intercepted and duration is added to the stat object (1 by method). Value is copied each 4s. Le 4 nov. 2013 23:23, Ted Dunning ted.dunn...@gmail.com a écrit : I still think that what you need is a thread-safe copy rather than a thread-safe mutate.

Re: [math] Multithreaded performances

2013-11-04 Thread Phil Steitz
On 11/4/13 2:22 PM, Ted Dunning wrote: I still think that what you need is a thread-safe copy rather than a thread-safe mutate. I was just thinking the same thing. Patches welcome. Phil Even if you force every thread to do the copy, the aggregation still still wins on

Re: [math] Multithreaded performances

2013-11-04 Thread Romain Manni-Bucau
The copy will lock too. And it doesnt solve leak issue of the one instance by thread solution, no? Le 4 nov. 2013 23:27, Phil Steitz phil.ste...@gmail.com a écrit : On 11/4/13 2:22 PM, Ted Dunning wrote: I still think that what you need is a thread-safe copy rather than a thread-safe mutate.

Re: [math] Multithreaded performances

2013-11-04 Thread Phil Steitz
On 11/4/13 2:31 PM, Romain Manni-Bucau wrote: The copy will lock too. Right. That is why I asked exactly how things work. If you can't lock during aggregation, we need something different. And it doesnt solve leak issue of the one instance by thread solution, no? Correct, again depends on

Re: [math] Multithreaded performances

2013-11-04 Thread Ted Dunning
The copy doesn't have to lock if you build the right data structure. The thread leak problem can be more serious. On Mon, Nov 4, 2013 at 2:47 PM, Phil Steitz phil.ste...@gmail.com wrote: On 11/4/13 2:31 PM, Romain Manni-Bucau wrote: The copy will lock too. Right. That is why I asked

Re: [math] Multithreaded performances

2013-11-04 Thread Bernd Eckenfels
Am 05.11.2013, 00:44 Uhr, schrieb Ted Dunning ted.dunn...@gmail.com: The thread leak problem can be more serious. What Thread Leak problem? TLS is cited to have that leak since ages, I am not sure I ever have seen one triggered. So, who has details on that? Even the JCL uses (more) thread

[VOTE] Release Apache Commons Pool 2.0 RC4 as 2.0

2013-11-04 Thread Mark Thomas
A change to the component id to pool2 required a new RC. The only other change was some improvements to the Ant build. The Pool 2.0 RC4 is available for review here: https://dist.apache.org/repos/dist/dev/commons/pool/ (r3419) Maven artifacts are here:

Re: [math] Multithreaded performances

2013-11-04 Thread Romain Manni-Bucau
Well before patching a consistent solution needs to be found. Sorry to go back to LongAdder but the idea is to add instances but not as much as thread. Just what is needed. It means you decrease the number of instance to aggregate so the lock time. The queue solution sounds worse since a queue

Re: [math] Multithreaded performances

2013-11-04 Thread Ted Dunning
On Mon, Nov 4, 2013 at 8:23 PM, Phil Steitz phil.ste...@gmail.com wrote: On 11/4/13 3:44 PM, Ted Dunning wrote: The copy doesn't have to lock if you build the right data structure. The individual stats objects need to update multiple quantities atomically when new values come in.

Re: [math] Multithreaded performances

2013-11-04 Thread Romain Manni-Bucau
You cant stop the app cause you take a snapshot of the monitoring metrics so yes Le 5 nov. 2013 06:46, Ted Dunning ted.dunn...@gmail.com a écrit : On Mon, Nov 4, 2013 at 8:23 PM, Phil Steitz phil.ste...@gmail.com wrote: On 11/4/13 3:44 PM, Ted Dunning wrote: The copy doesn't have to lock

Re: [math] Multithreaded performances

2013-11-04 Thread Ted Dunning
That isn't what I meant. Do you really think that more than one metric has to update (increment, say) at precisely the same time? On Mon, Nov 4, 2013 at 9:49 PM, Romain Manni-Bucau rmannibu...@gmail.comwrote: You cant stop the app cause you take a snapshot of the monitoring metrics so yes

Re: [math] Multithreaded performances

2013-11-04 Thread Romain Manni-Bucau
Oh sorry, that's what I said early, in a real app no or not enough to be an issue buy on simple apps or very high thrououtput apps yes. Le 5 nov. 2013 07:00, Ted Dunning ted.dunn...@gmail.com a écrit : That isn't what I meant. Do you really think that more than one metric has to update

Re: [VOTE] Release Apache Commons Pool 2.0 RC4 as 2.0

2013-11-04 Thread Mark Thomas
Gary Gregory garydgreg...@gmail.com wrote: There seems to be something very different from previous RCs WRT the RAT report: 151 Unknown Licenses Odd. It has picked up some of the generated documentation files - almost certainly as a result of the changes I made to the scm plug-in in my attempt