Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-06-30 Thread James Gilliland
On Wed, Jun 30, 2021 at 5:30 AM Stephen Reay wrote: > > > > On 29 Jun 2021, at 02:28, Jan Ehrhardt wrote: > > > > Nikita Popov in php.internals (Mon, 22 Mar 2021 10:24:51 +0100): > >> Hi internals, > >> > >> It's time for another deprecation RFC: > >>

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-06-30 Thread Nikita Popov
On Sat, Apr 24, 2021 at 7:38 PM Rowan Tommins wrote: > On 22/03/2021 09:24, Nikita Popov wrote: > > It's time for another deprecation RFC: > > https://wiki.php.net/rfc/deprecations_php_8_1 > > > I have added another proposal to this list: the 'ssl_method' option to > the SoapClient constructor,

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-06-30 Thread Stephen Reay
> On 29 Jun 2021, at 02:28, Jan Ehrhardt wrote: > > Nikita Popov in php.internals (Mon, 22 Mar 2021 10:24:51 +0100): >> Hi internals, >> >> It's time for another deprecation RFC: >> https://wiki.php.net/rfc/deprecations_php_8_1 > > FWIW, a quick search returned these results. > > ADOdb

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-06-29 Thread Pierre Joye
Hi Nikita, Very good list, thank you. The only one I am totally not sure about is image(filled)polygon $numpoints. There are really tons of codes out there using it. There is little to no gain to remove it but create a load of 1st level support requests to many packages and applications. A

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-06-16 Thread Larry Garfield
On Tue, Jun 15, 2021, at 10:59 PM, Mike Schinkel wrote: > > On Jun 15, 2021, at 6:53 AM, Nikita Popov wrote: > > > > As we're moving closer to feature freeze, I'd like to close down this RFC > > to further additions, and move towards voting. > > > > Feedback on the proposed deprecations is

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-06-15 Thread Mike Schinkel
> On Jun 15, 2021, at 6:53 AM, Nikita Popov wrote: > > As we're moving closer to feature freeze, I'd like to close down this RFC > to further additions, and move towards voting. > > Feedback on the proposed deprecations is appreciated. Personally, the two > I'm unsure about are "get_class(),

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-06-15 Thread Hans Henrik Bergan
thanks > Not going to include a deprecation proposal as part of this RFC though -- from past discussions, the topic was controversial, so I don't want to include it this late in the process. That's fine by me. > the topic was controversial indeed it is/was (at least on Reddit) On Tue, 15 Jun

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-06-15 Thread Nikita Popov
On Tue, Jun 15, 2021 at 12:48 PM Hans Henrik Bergan wrote: > i don't like this part of the RFC: > > > There's a number of bug reports related to this. From what I understand, > the core problem here is not that the ISO8601 format is *wrong*, it's just > one of multiple legal ISO-8601 formats. As

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-06-15 Thread Hans Henrik Bergan
i don't like this part of the RFC: > There's a number of bug reports related to this. From what I understand, the core problem here is not that the ISO8601 format is *wrong*, it's just one of multiple legal ISO-8601 formats. As DateTime formats always refer to a specific format, not a set of

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-06-15 Thread Christoph M. Becker
On 23.03.2021 at 06:04, Stanislav Malyshev wrote: >> t fopen mode > > I'm afraid there's - despite the warning - a bunch of code for Windows > that relies on "t" and I don't think we should be breaking it. Is there > a good reason to drop this mode? I don't see much need for 't' mode nowadays.

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-04-24 Thread Rowan Tommins
On 22/03/2021 09:24, Nikita Popov wrote: It's time for another deprecation RFC: https://wiki.php.net/rfc/deprecations_php_8_1 I have added another proposal to this list: the 'ssl_method' option to the SoapClient constructor, which in practice only allows you to force use of SSLv3. A more

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-04-19 Thread Kamil Tekiela
Hi Nikita, I would like to propose a deprecation of FILTER_SANITIZE_STRING. This is a very dubious filter that has almost no use. It removes NUL bytes, encodes single and double quotes in HTML, and removes anything between < and optional >. It does not function the same as strip_tags() as

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-04-12 Thread Nikita Popov
On Mon, Apr 12, 2021 at 3:15 PM Máté Kocsis wrote: > Hi Nikita and Stanislav, > > > > get_class(), get_parent_class() and get_called_class() without >> argument >> > >> > I'm not sure why. I mean if we want to make them return the same as >> > self::class etc. - up to the point of actually

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-04-12 Thread Máté Kocsis
Hi Nikita and Stanislav, > > get_class(), get_parent_class() and get_called_class() without argument > > > > I'm not sure why. I mean if we want to make them return the same as > > self::class etc. - up to the point of actually compiling them as such - > > no problem, but I don't see why they

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-04-12 Thread Nikita Popov
On Tue, Mar 23, 2021 at 10:44 PM Kalle Sommer Nielsen wrote: > Hi > > Den man. 22. mar. 2021 kl. 11.25 skrev Nikita Popov >: > > > > Hi internals, > > > > It's time for another deprecation RFC: > > https://wiki.php.net/rfc/deprecations_php_8_1 > > I'd like to suggest adding `nl_langinfo()` to

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-04-12 Thread Nikita Popov
On Tue, Mar 23, 2021 at 6:05 AM Stanislav Malyshev wrote: > Hi! > > > date_sunrise() and date_sunset() > > Do we have any information on usage? I am generally not a fan of > deprecating functions that work - even if they are odd and have quirky > APIs - but if the usage is essentially zero than

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-03-23 Thread Kalle Sommer Nielsen
Hi Den man. 22. mar. 2021 kl. 11.25 skrev Nikita Popov : > > Hi internals, > > It's time for another deprecation RFC: > https://wiki.php.net/rfc/deprecations_php_8_1 I'd like to suggest adding `nl_langinfo()` to the list of deprecations, it is a non-cross platform oddity that make less sense

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-03-22 Thread Stanislav Malyshev
Hi! > date_sunrise() and date_sunset() Do we have any information on usage? I am generally not a fan of deprecating functions that work - even if they are odd and have quirky APIs - but if the usage is essentially zero than it might be ok. > key(), current(), next(), prev(), and reset() on

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-03-22 Thread Rowan Tommins
On 22/03/2021 17:27, Nikita Popov wrote: Sure. Rowan, if you would like to add these functions to this RFC, please feel free to just edit it directly. Otherwise, having a separate RFC just for them is also fine. Given the situation is complex, and at least somewhat controversial, I plan

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-03-22 Thread Nikita Popov
On Mon, Mar 22, 2021 at 3:58 PM Ben Ramsey wrote: > > On Mar 22, 2021, at 04:24, Nikita Popov wrote: > > > > Hi internals, > > > > It's time for another deprecation RFC: > > https://wiki.php.net/rfc/deprecations_php_8_1 > > > > This is a collection of minor deprecations that various people have

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-03-22 Thread Björn Larsson
Den 2021-03-22 kl. 15:58, skrev Ben Ramsey: On Mar 22, 2021, at 04:24, Nikita Popov wrote: Hi internals, It's time for another deprecation RFC: https://wiki.php.net/rfc/deprecations_php_8_1 This is a collection of minor deprecations that various people have put together over the last ~2

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-03-22 Thread Ben Ramsey
> On Mar 22, 2021, at 04:24, Nikita Popov wrote: > > Hi internals, > > It's time for another deprecation RFC: > https://wiki.php.net/rfc/deprecations_php_8_1 > > This is a collection of minor deprecations that various people have put > together over the last ~2 years. This RFC was formerly

[PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-03-22 Thread Nikita Popov
Hi internals, It's time for another deprecation RFC: https://wiki.php.net/rfc/deprecations_php_8_1 This is a collection of minor deprecations that various people have put together over the last ~2 years. This RFC was formerly targeted at PHP 8.0, but was delayed to PHP 8.1 to reduce the amount