Hi,
Since we are in a tight schedule, I started the vote and it will end in a
week.
https://wiki.php.net/rfc/curl-wrappers-removal-rfc#vote
Pierrick
On 16 April 2013 09:17, Julien Pauli jpa...@php.net wrote:
On Tue, Apr 16, 2013 at 3:01 PM, Pierrick Charron pierr...@adoy.netwrote:
I
I think by law you have to create a new thread and prefix the subject
line with [VOTE] or something.
-Hannes
On Wed, Apr 17, 2013 at 2:59 PM, Pierrick Charron pierr...@adoy.net wrote:
Hi,
Since we are in a tight schedule, I started the vote and it will end in a
week.
Oh sorry I'm gonna do it right now.
Thanks :)
On 17 April 2013 18:02, Hannes Magnusson hannes.magnus...@gmail.com wrote:
I think by law you have to create a new thread and prefix the subject
line with [VOTE] or something.
-Hannes
On Wed, Apr 17, 2013 at 2:59 PM, Pierrick Charron
I created a straightforward RFC that you can access here
https://wiki.php.net/rfc/curl-wrappers-removal-rfc .
If someone have something more to add in it, feel free. Otherwise I will
start the vote so that we could remove it in 5.5 ASAP.
Thanks
Pierrick
On 12 April 2013 11:09, Julien Pauli
On Tue, Apr 16, 2013 at 3:01 PM, Pierrick Charron pierr...@adoy.net wrote:
I created a straightforward RFC that you can access here
https://wiki.php.net/rfc/curl-wrappers-removal-rfc .
If someone have something more to add in it, feel free. Otherwise I will
start the vote so that we could
On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen ka...@php.net wrote:
Hi
2013/4/12 Pierre Joye pierre@gmail.com:
On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron pierr...@adoy.net
wrote:
Including 5.3 and 5.4 ??
If removed in 5.3 and 5.4, theres no need for the constant
On Fri, Apr 12, 2013 at 4:00 PM, Julien Pauli jpa...@php.net wrote:
On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen ka...@php.netwrote:
Hi
2013/4/12 Pierre Joye pierre@gmail.com:
On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron pierr...@adoy.net
wrote:
Including 5.3 and 5.4
On Fri, 2013-04-12 at 10:00 +0200, Julien Pauli wrote:
On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen ka...@php.net wrote:
Hi
2013/4/12 Pierre Joye pierre@gmail.com:
On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron pierr...@adoy.net
wrote:
Including 5.3 and 5.4 ??
On Fri, Apr 12, 2013 at 10:07 AM, Johannes Schlüter
johan...@schlueters.de wrote:
On Fri, 2013-04-12 at 10:00 +0200, Julien Pauli wrote:
On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen ka...@php.net wrote:
Hi
2013/4/12 Pierre Joye pierre@gmail.com:
On Thu, Apr 11, 2013 at
+1
On 12 April 2013 04:07, Johannes Schlüter johan...@schlueters.de wrote:
On Fri, 2013-04-12 at 10:00 +0200, Julien Pauli wrote:
On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen ka...@php.net
wrote:
Hi
2013/4/12 Pierre Joye pierre@gmail.com:
On Thu, Apr 11, 2013 at
On 2013-04-12, Johannes Schl�ter johan...@schlueters.de wrote:
5.3 users might depend on some part of the behavior and have learned to
live with bugs. We shouldn't kick features at this stage.
curlwrappers should definatly stay in 5.3 and 5.4. I have no problem
with having them removed in 5.5
On Fri, Apr 12, 2013 at 4:09 PM, David Soria Parra d...@php.net wrote:
On 2013-04-12, Johannes Schlüter johan...@schlueters.de wrote:
5.3 users might depend on some part of the behavior and have learned to
live with bugs. We shouldn't kick features at this stage.
curlwrappers should
Hi!
5.3 users might depend on some part of the behavior and have learned to
live with bugs. We shouldn't kick features at this stage.
I agree, for 5.4 too. We had it for a long time, and however buggy or
broken it is, there might be people that use it, and stable version
implies promise they
On Fri, Apr 12, 2013 at 2:00 PM, Stas Malyshev smalys...@sugarcrm.com wrote:
Hi!
5.3 users might depend on some part of the behavior and have learned to
live with bugs. We shouldn't kick features at this stage.
I agree, for 5.4 too. We had it for a long time, and however buggy or
broken it
Hi!
I don't know who suggested getting rid of it in 5.3 or 5.4, that is
ofcourse seriously stupid thing to do.
The original request was to kill it dead in 5.5, and remove the
constant again from 5.3 and 5.4.
OK, I agree with that. I think origination of this was Pierre's comment
to apply
On Wed, Apr 10, 2013 at 6:52 PM, Pierre Joye pierre@gmail.com wrote:
On Wed, Apr 10, 2013 at 6:46 PM, Julien Pauli jpa...@php.net wrote:
Beta3 has been taggued with curl wrappers, and with the new
CURL_WRAPPERS_ENABLED constant :-p
Do we all agree to remove that feature (meaning
On Thu, Apr 11, 2013 at 4:03 PM, Julien Pauli jpa...@php.net wrote:
On Wed, Apr 10, 2013 at 6:52 PM, Pierre Joye pierre@gmail.com wrote:
On Wed, Apr 10, 2013 at 6:46 PM, Julien Pauli jpa...@php.net wrote:
Beta3 has been taggued with curl wrappers, and with the new
Hi Julien
2013/4/11 Julien Pauli jpa...@php.net:
Ok, too bad we taggued beta3 with it. I suggest we remove this feature when
going RC so.
Huge +1
--
regards,
Kalle Sommer Nielsen
ka...@php.net
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:
If you decide to remove it for 5.5 RC, tell me and I'll merge this branch
https://github.com/adoy/php-src/tree/remove-curl-wrappers
Thanks
Pierrick
On 11 April 2013 04:03, Julien Pauli jpa...@php.net wrote:
On Wed, Apr 10, 2013 at 6:52 PM, Pierre Joye pierre@gmail.com wrote:
On Wed, Apr
On Thu, Apr 11, 2013 at 4:54 PM, Pierrick Charron pierr...@adoy.net wrote:
If you decide to remove it for 5.5 RC, tell me and I'll merge this branch
https://github.com/adoy/php-src/tree/remove-curl-wrappers
s,5.5,all branches,
Cheers,
--
Pierre
@pierrejoye
--
PHP Internals - PHP Runtime
Including 5.3 and 5.4 ??
Pierrick
On 11 April 2013 14:12, Pierre Joye pierre@gmail.com wrote:
On Thu, Apr 11, 2013 at 4:54 PM, Pierrick Charron pierr...@adoy.net
wrote:
If you decide to remove it for 5.5 RC, tell me and I'll merge this branch
On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron pierr...@adoy.net wrote:
Including 5.3 and 5.4 ??
Yes, why should we have it there? Either it is stable and ready or it
is not (as it is now).
--
Pierre
@pierrejoye
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe,
Hi
2013/4/12 Pierre Joye pierre@gmail.com:
On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron pierr...@adoy.net wrote:
Including 5.3 and 5.4 ??
If removed in 5.3 and 5.4, theres no need for the constant anymore.
--
regards,
Kalle Sommer Nielsen
ka...@php.net
--
PHP Internals - PHP
On Fri, Apr 5, 2013 at 8:54 PM, Hannes Magnusson hannes.magnus...@gmail.com
wrote:
On Fri, Apr 5, 2013 at 7:14 AM, Julien Pauli jpa...@php.net wrote:
On Fri, Apr 5, 2013 at 12:51 PM, Johannes Schlüter
johan...@schlueters.de
wrote:
On Fri, 2013-04-05 at 08:01 +0200, Pierre Joye wrote:
On Wed, Apr 10, 2013 at 6:46 PM, Julien Pauli jpa...@php.net wrote:
Beta3 has been taggued with curl wrappers, and with the new
CURL_WRAPPERS_ENABLED constant :-p
Do we all agree to remove that feature (meaning moving it to a branch, or
somewhere for the interested developers to keep on
On Thu, Apr 4, 2013 at 9:52 PM, Hannes Magnusson
hannes.magnus...@gmail.com wrote:
Its not only about maintaining it.
This experiment failed a long time ago. Overwriting the core streams
has proven itself to be the wrong way.
I cannot agree more.
If there was a way for userspace to say
On Fri, Apr 5, 2013 at 8:01 AM, Pierre Joye pierre@gmail.com wrote:
On Thu, Apr 4, 2013 at 9:52 PM, Hannes Magnusson
hannes.magnus...@gmail.com wrote:
Its not only about maintaining it.
This experiment failed a long time ago. Overwriting the core streams
has proven itself to be the
On Fri, 2013-04-05 at 08:01 +0200, Pierre Joye wrote:
stream_wrapper_unregister(http);
stream_wrapper_register(http, CurlStreamWrapper);
and then stream_wrapper_restore(http) to go back to the core
streams.
I wonder what one will do with open streams during the switches. That
can't go
On Fri, Apr 5, 2013 at 12:51 PM, Johannes Schlüter
johan...@schlueters.dewrote:
On Fri, 2013-04-05 at 08:01 +0200, Pierre Joye wrote:
stream_wrapper_unregister(http);
stream_wrapper_register(http, CurlStreamWrapper);
and then stream_wrapper_restore(http) to go back to the core
On Fri, Apr 5, 2013 at 7:14 AM, Julien Pauli jpa...@php.net wrote:
On Fri, Apr 5, 2013 at 12:51 PM, Johannes Schlüter johan...@schlueters.de
wrote:
On Fri, 2013-04-05 at 08:01 +0200, Pierre Joye wrote:
stream_wrapper_unregister(http);
stream_wrapper_register(http, CurlStreamWrapper);
I find this somewhat conflicting.
If it's experimental, and will likely be removed because nobody will
maintain it, why is anything being added to it at all?
This simply makes it easier for people to build a dependance on a feature
that will ultimately cease to exist in the next major version.
发自我的 iPhone
在 2013-4-4，16:36，Leigh lei...@gmail.com 写道：
I find this somewhat conflicting.
If it's experimental, and will likely be removed because nobody will
maintain it, why is anything being added to it at all?
Maintaining it.
This simply makes it easier for people to build a dependance
IMO , we should remove that feature from 5.5.
If Laruence is OK to maintain it, then we keep it, but Laruence, please,
improve it so.
We keep it if Laruence can make it stable for 5.5 final. If he cant , or
doesn't want to work on it any more while in betas ; then we should remove
curlwrapper
Hi
I don't think we should remove curlwrappers from 5.5. I do agree that this
is not yet stable and ready to push as non experimental, but since we plan
to release 5.5 soon I don't think removing it right now is worth it.
I started some time ago to maintain the curl extension. I focused mainly
On Thu, Apr 4, 2013 at 11:27 AM, Pierrick Charron pierr...@adoy.net wrote:
Hi
I don't think we should remove curlwrappers from 5.5. I do agree that this
is not yet stable and ready to push as non experimental, but since we plan
to release 5.5 soon I don't think removing it right now is worth
2013/4/4 Hannes Magnusson hannes.magnus...@gmail.com:
stream_wrapper_unregister(http);
stream_wrapper_register(http, CurlStreamWrapper);
and then stream_wrapper_restore(http) to go back to the core streams.
If we alter curlwrappers to work like that, then it could stay, and
since this is an
发自我的 iPhone
在 2013-4-3，13:56，Hannes Magnusson hannes.magnus...@gmail.com 写道：
Wait wait wait. You are introducing a constant that is going to be
available as of 5.4.15 to 5.4.2x and then removed (as it looks like we
are agreeing)?
how could that be? This constant will in the final release of
On Wed, Apr 3, 2013 at 8:10 AM, Xinchen Hui larue...@gmail.com wrote:
发自我的 iPhone
在 2013-4-3，13:56，Hannes Magnusson hannes.magnus...@gmail.com 写道：
Wait wait wait. You are introducing a constant that is going to be
available as of 5.4.15 to 5.4.2x and then removed (as it looks like we
Hi Laruence
2013/3/31 Laruence larue...@php.net
I propose to add a constant : bool CURL_WRAPPERS_ENABLE
or, any other better name...
objections?
I'm a -1 on this, because as we sort of agreed on (like Hannes
implied), this experimental feature did not turn out as we wanted, its
On Wed, Apr 3, 2013 at 12:31 AM, Kalle Sommer Nielsen ka...@php.net wrote:
Hi Laruence
2013/3/31 Laruence larue...@php.net
I propose to add a constant : bool CURL_WRAPPERS_ENABLE
or, any other better name...
objections?
I'm a -1 on this, because as we sort of agreed on (like
2013/4/3 Hannes Magnusson hannes.magnus...@gmail.com:
You'll actually have to assign the value of CURL_WRAPPERS_ENABLED to
$curlwrappers, as defined() only checks if the constant exist.. not if
its set to true :)
well, s/defined('CURL_WRAPPERS_ENABLED')/defined('CURL_WRAPPERS_ENABLED')
Hi!
Added new constant CURL_WRAPPERS_ENABLE in (include 5.4)
https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7
I must say the process of how it was done was not very good. Not only
there were no substantial discussion on adding this new thing in stable
version
On Wed, Apr 3, 2013 at 4:22 PM, Stas Malyshev smalys...@sugarcrm.comwrote:
Hi!
Added new constant CURL_WRAPPERS_ENABLE in (include 5.4)
https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7
I must say the process of how it was done was not very good. Not only
On Wed, Apr 3, 2013 at 10:22 AM, Stas Malyshev smalys...@sugarcrm.com wrote:
Hi!
Added new constant CURL_WRAPPERS_ENABLE in (include 5.4)
https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7
I must say the process of how it was done was not very good. Not only
On Wed, Apr 3, 2013 at 10:37 AM, Laruence larue...@php.net wrote:
On Wed, Apr 3, 2013 at 4:22 PM, Stas Malyshev smalys...@sugarcrm.com
wrote:
Hi!
Added new constant CURL_WRAPPERS_ENABLE in (include 5.4)
发自我的 iPhone
在 2013-4-3，20:42，Ferenc Kovacs tyr...@gmail.com 写道：
On Wed, Apr 3, 2013 at 10:37 AM, Laruence larue...@php.net wrote:
On Wed, Apr 3, 2013 at 4:22 PM, Stas Malyshev smalys...@sugarcrm.com
wrote:
Hi!
Added new constant CURL_WRAPPERS_ENABLE in (include 5.4)
2013/4/3 Laruence larue...@php.net:
On Wed, Apr 3, 2013 at 4:22 PM, Stas Malyshev smalys...@sugarcrm.comwrote:
Hi!
Added new constant CURL_WRAPPERS_ENABLE in (include 5.4)
https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7
I must say the process of how it
On Wed, Apr 3, 2013 at 10:42 PM, Kalle Sommer Nielsen ka...@php.net wrote:
2013/4/3 Laruence larue...@php.net:
On Wed, Apr 3, 2013 at 4:22 PM, Stas Malyshev smalys...@sugarcrm.com
wrote:
Hi!
Added new constant CURL_WRAPPERS_ENABLE in (include 5.4)
Hi
2013/4/3 Laruence larue...@php.net:
Hey:
but as you see, many people was entrapped by the experimental feature,
and whether the experimental is there is out of their hands.
I, from a user aspect, I need to know whether my project can run in the
host environment. if not, I can
On Wed, Apr 3, 2013 at 5:42 AM, Ferenc Kovacs tyr...@gmail.com wrote:
On Wed, Apr 3, 2013 at 10:37 AM, Laruence larue...@php.net wrote:
however, you are right, it's not a long time, so if objections becomes
strong, I can revert it.
this is exactly the kind of behavior why we changed
Hi!
There is absolutely no need for a RFC for it.
Heck, even that initial curtesy mail was more then I would have expected.
Agree, no need for full scale RFC for one constant. However, sending an
email to the list and actually waiting for feedback is exactly what I
would expect, especially
On Wed, Apr 3, 2013 at 2:00 PM, Stas Malyshev smalys...@sugarcrm.com wrote:
Hi!
There is absolutely no need for a RFC for it.
Heck, even that initial curtesy mail was more then I would have expected.
Agree, no need for full scale RFC for one constant. However, sending an
email to the list
On Wed, Apr 3, 2013 at 10:42 PM, Hannes Magnusson
hannes.magnus...@gmail.com wrote:
On Wed, Apr 3, 2013 at 5:42 AM, Ferenc Kovacs tyr...@gmail.com wrote:
On Wed, Apr 3, 2013 at 10:37 AM, Laruence larue...@php.net wrote:
however, you are right, it's not a long time, so if objections
On Thu, Apr 4, 2013 at 5:37 AM, Hannes Magnusson hannes.magnus...@gmail.com
wrote:
On Wed, Apr 3, 2013 at 2:00 PM, Stas Malyshev smalys...@sugarcrm.com
wrote:
Hi!
There is absolutely no need for a RFC for it.
Heck, even that initial curtesy mail was more then I would have
expected.
Did I just read that even though we have reasons to believe this is not a
good addition that we are *still* going to launch 5.5 with it?
On Thu, Apr 4, 2013 at 1:39 PM, Levi Morrison morrison.l...@gmail.comwrote:
Did I just read that even though we have reasons to believe this is not a
good addition that we are *still* going to launch 5.5 with it?
where did you read that(not a good addition)?
thanks
--
Laruence Xinchen Hui
Added new constant CURL_WRAPPERS_ENABLE in (include 5.4)
https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7
thanks
On Mon, Apr 1, 2013 at 9:53 PM, Laruence larue...@php.net wrote:
On Mon, Apr 1, 2013 at 7:18 AM, Hannes Magnusson
hannes.magnus...@gmail.com
Wait wait wait. You are introducing a constant that is going to be
available as of 5.4.15 to 5.4.2x and then removed (as it looks like we
are agreeing)?
People have been living without this constant forever now so people
have their workarounds in place and no need to complicate their code
to for
I actually agree with that. I've reached a point when I consider using
fsockopen instead of curl to fetch information from a website. I can
hardly stand cURL.
There should be a decent OOP based wrapper for making HTTP requests to
handle it decently. Meanwhile, I agree that cURL needs to go.
On
On Mon, Apr 1, 2013 at 10:17 AM, Madara Uchiha dor.tchi...@gmail.com wrote:
I actually agree with that. I've reached a point when I consider using
fsockopen instead of curl to fetch information from a website. I can
hardly stand cURL.
Curl stream wrappers and ext/curl are two different things.
On 01.04.2013 01:18, Hannes Magnusson wrote:
I propose to add a constant : bool CURL_WRAPPERS_ENABLE
+1 on a constant if it has to stay. We had to do pretty ugly stuff to
detect it in the composer installer
https://github.com/composer/getcomposer.org/blob/master/web/installer#L135-148
The
On Mon, Apr 1, 2013 at 7:18 AM, Hannes Magnusson hannes.magnus...@gmail.com
wrote:
On Sun, Mar 31, 2013 at 6:25 AM, Laruence larue...@php.net wrote:
Hey:
there are some issues when people run some codes in a php which is
compiled with --with-curlwrappers, like #61336, or the recently
Hey:
there are some issues when people run some codes in a php which is
compiled with --with-curlwrappers, like #61336, or the recently test script
for #64433 (failed when curl wrappers enabled).
I know, that the curl wrapper should act the same as php http wrapper,
but for now, we need to
On Sun, Mar 31, 2013 at 6:25 AM, Laruence larue...@php.net wrote:
Hey:
there are some issues when people run some codes in a php which is
compiled with --with-curlwrappers, like #61336, or the recently test script
for #64433 (failed when curl wrappers enabled).
I know, that the curl
64 matches
Mail list logo
