Re: WARNING: CPU: 3 PID: 439 at fs/btrfs/ctree.h:1559 btrfs_update_device+0x1c5/0x1d0 [btrfs]

2017-09-19 Thread Qu Wenruo
On 2017年09月20日 13:10, Qu Wenruo wrote: On 2017年09月20日 12:59, Qu Wenruo wrote: On 2017年09月20日 12:49, Rich Rauenzahn wrote: On 9/19/2017 5:31 PM, Qu Wenruo wrote: On 2017年09月19日 23:56, Rich Rauenzahn wrote: [    4.747377] WARNING: CPU: 3 PID: 439 at fs/btrfs/ctree.h:1559

Re: WARNING: CPU: 3 PID: 439 at fs/btrfs/ctree.h:1559 btrfs_update_device+0x1c5/0x1d0 [btrfs]

2017-09-19 Thread Qu Wenruo
On 2017年09月20日 12:59, Qu Wenruo wrote: On 2017年09月20日 12:49, Rich Rauenzahn wrote: On 9/19/2017 5:31 PM, Qu Wenruo wrote: On 2017年09月19日 23:56, Rich Rauenzahn wrote: [    4.747377] WARNING: CPU: 3 PID: 439 at fs/btrfs/ctree.h:1559 btrfs_update_device+0x1c5/0x1d0 [btrfs] Is that line

Re: WARNING: CPU: 3 PID: 439 at fs/btrfs/ctree.h:1559 btrfs_update_device+0x1c5/0x1d0 [btrfs]

2017-09-19 Thread Qu Wenruo
On 2017年09月20日 12:49, Rich Rauenzahn wrote: On 9/19/2017 5:31 PM, Qu Wenruo wrote: On 2017年09月19日 23:56, Rich Rauenzahn wrote: [    4.747377] WARNING: CPU: 3 PID: 439 at fs/btrfs/ctree.h:1559 btrfs_update_device+0x1c5/0x1d0 [btrfs] Is that line the following WARN_ON()? --- static inline

Re: WARNING: CPU: 3 PID: 439 at fs/btrfs/ctree.h:1559 btrfs_update_device+0x1c5/0x1d0 [btrfs]

2017-09-19 Thread Rich Rauenzahn
On 9/19/2017 5:31 PM, Qu Wenruo wrote: On 2017年09月19日 23:56, Rich Rauenzahn wrote: [    4.747377] WARNING: CPU: 3 PID: 439 at fs/btrfs/ctree.h:1559 btrfs_update_device+0x1c5/0x1d0 [btrfs] Is that line the following WARN_ON()? --- static inline void btrfs_set_device_total_bytes(struct

Re: difference between -c and -p for send-receive?

2017-09-19 Thread Andrei Borzenkov
19.09.2017 03:41, Dave пишет: > new subject for new question > > On Mon, Sep 18, 2017 at 1:37 PM, Andrei Borzenkov wrote: > What scenarios can lead to "ERROR: parent determination failed"? >>> >>> The man page for btrfs-send is reasonably clear on the requirements >>>

Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-19 Thread Satoru Takeuchi
At Tue, 19 Sep 2017 16:41:52 +0900, Misono, Tomohiro wrote: > > "btrfs subvolume create/delete" outputs the message of "Create/Delete > subvolume ..." even when an operation fails. > Since it is confusing, let's outputs the message only when an operation > succeeds. > > Signed-off-by: Tomohiro

Re: [PATCH v2] btrfs-progs: allow "none" to disable compression for convenience

2017-09-19 Thread Satoru Takeuchi
At Tue, 19 Sep 2017 17:14:27 +0200, David Sterba wrote: > > On Mon, Sep 18, 2017 at 09:41:17AM +0900, Satoru Takeuchi wrote: > > At Sun, 17 Sep 2017 14:08:40 +0100, > > Mike Fleetwood wrote: > > > > > > On 17 September 2017 at 01:36, Satoru Takeuchi > > > wrote: > > >

Re: SSD caching an existing btrfs raid1

2017-09-19 Thread Duncan
Austin S. Hemmelgarn posted on Tue, 19 Sep 2017 11:47:24 -0400 as excerpted: > A better option if you can afford to remove a single device from that > array temporarily is to use bcache. Bcache has one specific advantage > in this case, multiple backend devices can share the same cache device. >

Re: Does btrfs use crc32 for error correction?

2017-09-19 Thread Timofey Titovets
2017-09-19 21:04 GMT+03:00 Marat Khalili : > Would be cool, but probably not wise IMHO, since on modern hardware you > almost never get one-bit errors (usually it's a whole sector of garbage), and > therefore you'd more often see an incorrect recovery than actually fixed bit. > -- >

RE: SSD caching an existing btrfs raid1

2017-09-19 Thread Paul Jones
> -Original Message- > From: linux-btrfs-ow...@vger.kernel.org [mailto:linux-btrfs- > ow...@vger.kernel.org] On Behalf Of Pat Sailor > Sent: Wednesday, 20 September 2017 1:31 AM > To: Btrfs BTRFS > Subject: SSD caching an existing btrfs raid1 > > Hello, > >

[PATCH] Btrfs: use btrfs_op instead of bio_op in __btrfs_map_block

2017-09-19 Thread Liu Bo
This seems to be a leftover of commit cf8cddd38bab ("btrfs: don't abuse REQ_OP_* flags for btrfs_map_block"). It should use btrfs_op() helper to provide one of 'enum btrfs_map_op' types. Signed-off-by: Liu Bo --- fs/btrfs/volumes.c | 2 +- 1 file changed, 1 insertion(+),

Re: Problems with debian install

2017-09-19 Thread Qu Wenruo
On 2017年09月20日 05:35, Pierre Couderc wrote: I am trying to install stretch on a computer with 2 btrfs disks and EFI. Is there a howto to do that ? Did someone success ? I get problems as soon as the partionning in debian installer. What partitions do I need ? I understand the grub needs

Re: WARNING: CPU: 3 PID: 439 at fs/btrfs/ctree.h:1559 btrfs_update_device+0x1c5/0x1d0 [btrfs]

2017-09-19 Thread Qu Wenruo
On 2017年09月19日 23:56, Rich Rauenzahn wrote: I've filed a bug on this kernel trace -- I get 100's of these a day. I'd like to make them go away https://bugzilla.kernel.org/show_bug.cgi?id=196949 [4.747356] [ cut here ] [4.747377] WARNING: CPU: 3 PID: 439

Re: btrfs-progs: suggestion of removing --commit-after option of subvol delete

2017-09-19 Thread Qu Wenruo
On 2017年09月19日 22:48, David Sterba wrote: On Tue, Sep 19, 2017 at 04:50:04PM +0900, Misono, Tomohiro wrote: I read the code of "subvolume delete" and found that --commit-after option is not working well. Since it issues BTRFS_IOC_START/WAIT_SYNC to the last fd (of directory containing the

Re: btrfs-progs: suggestion of removing --commit-after option of subvol delete

2017-09-19 Thread Misono, Tomohiro
On 2017/09/19 23:48, David Sterba wrote: > On Tue, Sep 19, 2017 at 04:50:04PM +0900, Misono, Tomohiro wrote: >> I read the code of "subvolume delete" and found that --commit-after option is >> not working well. >> >> Since it issues BTRFS_IOC_START/WAIT_SYNC to the last fd (of directory >>

Problems with debian install

2017-09-19 Thread Pierre Couderc
I am trying to install stretch on a computer with 2 btrfs disks and EFI. Is there a howto to do that ? Did someone success ? I get problems as soon as the partionning in debian installer. What partitions do I need ? I understand the grub needs them even if btrfs does not require them. But I

Re: ERROR: parent determination failed (btrfs send-receive)

2017-09-19 Thread Andrei Borzenkov
18.09.2017 09:10, Dave пишет: > I use snap-sync to create and send snapshots. > > GitHub - wesbarnett/snap-sync: Use snapper snapshots to backup to external > drive > https://github.com/wesbarnett/snap-sync > Are you trying to backup top-level subvolume? I just reproduced this behavior with

Re: Storage and snapshots as historical yearly

2017-09-19 Thread Austin S. Hemmelgarn
On 2017-09-19 14:33, Andrei Borzenkov wrote: 19.09.2017 14:49, Senén Vidal Blanco пишет: Perfect!! Just what I was looking for. Sorry for the delay, because before doing so, I preferred to test to see if it actually worked. I have a doubt. The system works perfectly, but at the time of

Re: Storage and snapshots as historical yearly

2017-09-19 Thread Senén Vidal Blanco
Hi Austin, Thank you very much for your answer. I comment a little on your suggestions in the context. El lunes, 11 de septiembre de 2017 14:49:05 (CEST) Austin S. Hemmelgarn escribió: > On 2017-09-11 14:17, Senén Vidal Blanco wrote: > > I am trying to implement a system that stores the data in

How to recover failing filesystem?

2017-09-19 Thread Dmitry Kudriavtsev
Hello, My btrfs filesystem is constantly remounting itself read-only. Relevant log segments: https://hastebin.com/uyegipadex.log https://hastebin.com/wakihobivi.log How do I fix these errors? Thank you, Dmitry Kudriavtsev ⠀⠀⠀⣸⣧⠀⠀⠀ ⠀⠀⣰⣿⣿⣆⠀⠀ ⠀⣀⡙⠿⣿⣿⣆⠀Hey, did you hear

Re: Storage and snapshots as historical yearly

2017-09-19 Thread Andrei Borzenkov
19.09.2017 14:49, Senén Vidal Blanco пишет: > Perfect!! Just what I was looking for. > Sorry for the delay, because before doing so, I preferred to test to see if > it > actually worked. > > I have a doubt. The system works perfectly, but at the time of deleting the > writing disk and merging

Re: snapshots of encrypted directories?

2017-09-19 Thread Dave
On Fri, Sep 15, 2017 at 6:01 AM, Ulli Horlacher wrote: > > On Fri 2017-09-15 (06:45), Andrei Borzenkov wrote: > > > The actual question is - do you need to mount each individual btrfs > > subvolume when using encfs? > > And even worse it goes with ecryptfs: I do not

Re: Does btrfs use crc32 for error correction?

2017-09-19 Thread Marat Khalili
Would be cool, but probably not wise IMHO, since on modern hardware you almost never get one-bit errors (usually it's a whole sector of garbage), and therefore you'd more often see an incorrect recovery than actually fixed bit. -- With Best Regards, Marat Khalili -- To unsubscribe from this

Re: kernel BUG at fs/btrfs/extent_io.c:1989

2017-09-19 Thread Liu Bo
On Tue, Sep 19, 2017 at 05:07:25PM +0200, David Sterba wrote: > On Tue, Sep 19, 2017 at 11:32:46AM +, Paul Jones wrote: > > > This 'mirror 0' looks fishy, (as mirror comes from > > > btrfs_io_bio->mirror_num, > > > which should be at least 1 if raid1 setup is in use.) > > > > > > Not sure if

Re: Does btrfs use crc32 for error correction?

2017-09-19 Thread Eric Sandeen
On 9/19/17 10:35 AM, Timofey Titovets wrote: > Stupid question: > Does btrfs use crc32 for error correction? > If no, why? > > (AFAIK if using CRC that possible to fix 1 bit flip) > > P.S. I try check that (i create image, create text file, flip bit, try > read and btrfs show IO-error) > >

WARNING: CPU: 3 PID: 439 at fs/btrfs/ctree.h:1559 btrfs_update_device+0x1c5/0x1d0 [btrfs]

2017-09-19 Thread Rich Rauenzahn
I've filed a bug on this kernel trace -- I get 100's of these a day. I'd like to make them go away https://bugzilla.kernel.org/show_bug.cgi?id=196949 [4.747356] [ cut here ] [4.747377] WARNING: CPU: 3 PID: 439 at fs/btrfs/ctree.h:1559

Re: SSD caching an existing btrfs raid1

2017-09-19 Thread Austin S. Hemmelgarn
On 2017-09-19 11:30, Pat Sailor wrote: Hello, I have a half-filled raid1 on top of six spinning devices. Now I have come into a spare SSD I'd like to use for caching, if possible without having to rebuild or, failing that, without having to renounce to btrfs and flexible reshaping. I've

Re: Does btrfs use crc32 for error correction?

2017-09-19 Thread Hugo Mills
On Tue, Sep 19, 2017 at 06:35:48PM +0300, Timofey Titovets wrote: > Stupid question: > Does btrfs use crc32 for error correction? It uses it for error _detection_. On read, it'll verify the data (or metadata) against the checksum. With no reduncancy (single, RAID-0), a bad csum check will

Does btrfs use crc32 for error correction?

2017-09-19 Thread Timofey Titovets
Stupid question: Does btrfs use crc32 for error correction? If no, why? (AFAIK if using CRC that possible to fix 1 bit flip) P.S. I try check that (i create image, create text file, flip bit, try read and btrfs show IO-error) Thanks! -- Have a nice day, Timofey. -- To unsubscribe from this

SSD caching an existing btrfs raid1

2017-09-19 Thread Pat Sailor
Hello, I have a half-filled raid1 on top of six spinning devices. Now I have come into a spare SSD I'd like to use for caching, if possible without having to rebuild or, failing that, without having to renounce to btrfs and flexible reshaping. I've been reading about the several options out

Re: [PATCH v2] btrfs-progs: allow "none" to disable compression for convenience

2017-09-19 Thread David Sterba
On Mon, Sep 18, 2017 at 09:41:17AM +0900, Satoru Takeuchi wrote: > At Sun, 17 Sep 2017 14:08:40 +0100, > Mike Fleetwood wrote: > > > > On 17 September 2017 at 01:36, Satoru Takeuchi > > wrote: > > > It's messy to use "" to disable compression. Introduce the new value

Re: [PATCH] btrfs: make array types static const, reduces object code size

2017-09-19 Thread David Sterba
On Tue, Sep 19, 2017 at 04:01:23PM +0100, Colin King wrote: > From: Colin Ian King > > Don't populate the read-only array types on the stack, instead make > it static const. Makes the object code smaller by nearly 60 bytes: > > Before: >text data bss

Re: kernel BUG at fs/btrfs/extent_io.c:1989

2017-09-19 Thread David Sterba
On Tue, Sep 19, 2017 at 11:32:46AM +, Paul Jones wrote: > > This 'mirror 0' looks fishy, (as mirror comes from btrfs_io_bio->mirror_num, > > which should be at least 1 if raid1 setup is in use.) > > > > Not sure if 4.13.2-gentoo made any changes on btrfs, but can you please > > verify with

[PATCH] btrfs: make array types static const, reduces object code size

2017-09-19 Thread Colin King
From: Colin Ian King Don't populate the read-only array types on the stack, instead make it static const. Makes the object code smaller by nearly 60 bytes: Before: textdata bss dec hex filename 905366552 64 97152 17b80

Re: btrfs-progs: suggestion of removing --commit-after option of subvol delete

2017-09-19 Thread David Sterba
On Tue, Sep 19, 2017 at 04:50:04PM +0900, Misono, Tomohiro wrote: > I read the code of "subvolume delete" and found that --commit-after option is > not working well. > > Since it issues BTRFS_IOC_START/WAIT_SYNC to the last fd (of directory > containing the last deleted subvolume), > 1. sync

Re: Storage and snapshots as historical yearly

2017-09-19 Thread Senén Vidal Blanco
Perfect!! Just what I was looking for. Sorry for the delay, because before doing so, I preferred to test to see if it actually worked. I have a doubt. The system works perfectly, but at the time of deleting the writing disk and merging the data on the read-only disk I fail to understand the

RE: kernel BUG at fs/btrfs/extent_io.c:1989

2017-09-19 Thread Paul Jones
> -Original Message- > From: Liu Bo [mailto:bo.li@oracle.com] > Sent: Tuesday, 19 September 2017 3:10 AM > To: Paul Jones > Cc: linux-btrfs@vger.kernel.org > Subject: Re: kernel BUG at fs/btrfs/extent_io.c:1989 > > > This 'mirror 0' looks fishy, (as mirror

Re: difference between -c and -p for send-receive?

2017-09-19 Thread Andrei Borzenkov
On Tue, Sep 19, 2017 at 1:24 PM, Graham Cobb wrote: > On 19/09/17 01:41, Dave wrote: >> Would it be correct to say the following? > > Like Duncan, I am just a user, and I haven't checked the code. I > recommend Duncan's explanation, but in case you are looking for > something

Re: difference between -c and -p for send-receive?

2017-09-19 Thread Graham Cobb
On 19/09/17 01:41, Dave wrote: > Would it be correct to say the following? Like Duncan, I am just a user, and I haven't checked the code. I recommend Duncan's explanation, but in case you are looking for something simpler, how about thinking with the following analogy... Think of -p as like

Re: [PATCH] btrfs-progs: check: check invalid extent_inline_ref type in lowmem

2017-09-19 Thread Qu Wenruo
On 2017年09月19日 17:48, Su Yue wrote: On 09/19/2017 04:48 PM, Qu Wenruo wrote: On 2017年09月19日 16:32, Su Yue wrote: Lowmem check does not skip invalid type in extent_inline_ref then calls btrfs_extent_inline_ref_size(type) which causes crash. Example: $ ./btrfs-corrupt-block -e -l 20971520

Re: [PATCH] btrfs-progs: check: check invalid extent_inline_ref type in lowmem

2017-09-19 Thread Su Yue
On 09/19/2017 04:48 PM, Qu Wenruo wrote: On 2017年09月19日 16:32, Su Yue wrote: Lowmem check does not skip invalid type in extent_inline_ref then calls btrfs_extent_inline_ref_size(type) which causes crash. Example: $ ./btrfs-corrupt-block -e -l 20971520 /tmp/data_small corrupting extent

Re: [PATCH] btrfs-progs: check: check invalid extent_inline_ref type in lowmem

2017-09-19 Thread Qu Wenruo
On 2017年09月19日 16:32, Su Yue wrote: Lowmem check does not skip invalid type in extent_inline_ref then calls btrfs_extent_inline_ref_size(type) which causes crash. Example: $ ./btrfs-corrupt-block -e -l 20971520 /tmp/data_small corrupting extent record: key 20971520 169 0 $ btrfs check

Re: btrfs-progs: suggestion of removing --commit-after option of subvol delete

2017-09-19 Thread Qu Wenruo
On 2017年09月19日 15:50, Misono, Tomohiro wrote: Hello, I read the code of "subvolume delete" and found that --commit-after option is not working well. Since it issues BTRFS_IOC_START/WAIT_SYNC to the last fd (of directory containing the last deleted subvolume), 1. sync operation affects only

[PATCH] btrfs-progs: check: check invalid extent_inline_ref type in lowmem

2017-09-19 Thread Su Yue
Lowmem check does not skip invalid type in extent_inline_ref then calls btrfs_extent_inline_ref_size(type) which causes crash. Example: $ ./btrfs-corrupt-block -e -l 20971520 /tmp/data_small corrupting extent record: key 20971520 169 0 $ btrfs check --mode=lowmem /tmp/data_small Checking

btrfs-progs: suggestion of removing --commit-after option of subvol delete

2017-09-19 Thread Misono, Tomohiro
Hello, I read the code of "subvolume delete" and found that --commit-after option is not working well. Since it issues BTRFS_IOC_START/WAIT_SYNC to the last fd (of directory containing the last deleted subvolume), 1. sync operation affects only the last fd's filesystem. ("subvolume delete"

[PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

2017-09-19 Thread Misono, Tomohiro
"btrfs subvolume create/delete" outputs the message of "Create/Delete subvolume ..." even when an operation fails. Since it is confusing, let's outputs the message only when an operation succeeds. Signed-off-by: Tomohiro Misono --- cmds-subvolume.c | 8

Re: ERROR: parent determination failed (btrfs send-receive)

2017-09-19 Thread Dave
On Mon, Sep 18, 2017 at 12:23 AM, Andrei Borzenkov wrote: > > 18.09.2017 05:31, Dave пишет: > > Sometimes when using btrfs send-receive, I get errors like this: > > > > ERROR: parent determination failed for > > > > When this happens, btrfs send-receive backups fail. And all