Re: [PATCH] Input: ALPS - Report v3 pinnacle trackstick device only if is present

2016-01-05 Thread Pali Rohár
On Monday 23 March 2015 12:42:25 Hans de Goede wrote: > Hi, > > On 22-03-15 14:47, Pali Rohár wrote: > >This patch move v3 pinnacle code for trackstick detection from > >alps_hw_init_v3() > >to alps_set_protocol() so ALPS_DUALPOINT flag can be cleared before > &g

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2016-01-05 Thread Pali Rohár
On Sunday 22 March 2015 14:46:11 Pali Rohár wrote: > This patch adds detection of trackstick for v7 protocol devices. Code in this > patch is used in official Dell touchpad linux drivers for Dell models: > Dell Latitude E5250/5250, E5450/5450, E5550/5550 > > Detection code and ba

Re: [PATCH 2/6] Input: psmouse - fix comment style

2015-12-11 Thread Pali Rohár
Dmitry Torokhov <dmitry.torok...@gmail.com> Reviewed-by: Pali Rohár <pali.ro...@gmail.com> -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 3/6] Input: psmouse - rearrange Focaltech init code

2015-12-11 Thread Pali Rohár
until we get to full reset that Focaltech devices need to work properly. > > Also, replace focaltech_init() with a stub now that it is only called when > protocol is enabled. > > Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> It's also OK, so Reviewed-by: Pali Rohár

Re: [PATCH 1/6] Input: psmouse - use switch statement in psmouse_process_byte()

2015-12-11 Thread Pali Rohár
On Saturday 28 November 2015 21:13:51 Dmitry Torokhov wrote: > Instead of a series mostly exclusive "if" statements testing protocol type > of the mouse let's use "switch" statement. > > Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> Reviewe

Re: [PATCH 4/6] Input: psmouse - move protocol descriptions around

2015-12-11 Thread Pali Rohár
torok...@gmail.com> Reviewed-by: Pali Rohár <pali.ro...@gmail.com> -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/6] Input: psmouse - limit protocols that we try on passthrough ports

2015-12-11 Thread Pali Rohár
etc. > > Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> Reviewed-by: Pali Rohár <pali.ro...@gmail.com> Thanks for this patch series! -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the bo

Re: Regression since commit 92bac83

2015-10-21 Thread Pali Rohár
e with a dualpoint setup > with pass-through support. Ok, in this case, I'm fine with this patch. Hopefully no other obscure problem will be reported... So you can add my Acked-By: Pali Rohár <pali.ro...@gmail.com> -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send

Re: Regression since commit 92bac83

2015-10-21 Thread Pali Rohár
c int alps_set_protocol(struct psmouse *psmouse, > priv->byte0 = protocol->byte0; > priv->mask0 = protocol->mask0; > priv->flags = protocol->flags; > - if (dmi_name_in_vendors("Dell")) > - priv->flags |= ALPS_DELL; &

Re: Regression since commit 92bac83

2015-10-20 Thread Pali Rohár
ssary). > > > > Thanks for the quick response. Removing the two lines mentioned > > above restored correct touchpad operation with kernel 4.2.0. It > > seems that the Latitude D600 is different than other Dell models. > > I wonder if we should not revert all these pa

Re: [PATCH 2/3] Input: alps: drop unlikely before IS_ERR_OR_NULL

2015-10-01 Thread Pali Rohár
s really unlikely that condition will be truth and so this is some case of error/exception or something that normally does not happen too much. But if I read code if (IS_ERR_OR_NULL(priv->dev3)) I know nothing about chance that this condition will be truth. Explicit unlikely in previous

Re: [PATCH v2] Input: drivers/joystick: use parallel port device model

2015-09-28 Thread Pali Rohár
On Friday 14 August 2015 08:55:42 Sudip Mukherjee wrote: > > > Pali Rohár has the hardware and he is ready to test it. > > > > Pali, could you give the v2 version of the patch a spin > > (https://patchwork.kernel.org/patch/6940321/)? > > Adding Pali to the cc li

Re: [PATCH v2] Input: drivers/joystick: use parallel port device model

2015-08-31 Thread Pali Rohár
On Monday 31 August 2015 19:14:19 Sudip Mukherjee wrote: > On Mon, Aug 17, 2015 at 12:59:34PM +0530, Sudip Mukherjee wrote: > > On Fri, Aug 14, 2015 at 09:05:55AM +0200, Pali Rohár wrote: > > > On Friday 14 August 2015 12:25:42 Sudip Mukherjee wrote: > > > > On T

Re: ALPS v7 trackpad passthrough to Thinkpad trackpoint

2015-08-13 Thread Pali Rohár
On Friday 07 August 2015 12:35:33 Ari Entlich wrote: On Fri, Aug 7, 2015 at 10:12 AM, Pali Rohár pali.ro...@gmail.com wrote: For some old ALPS devices which use V1 and V2 protocols (with flag ALPS_PASS) there is something like that. On that devices touchpad is behind trackpoint HW. But you

Re: ALPS v7 trackpad passthrough to Thinkpad trackpoint

2015-08-07 Thread Pali Rohár
, so this is something which you probably want. -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: ALPS v7 trackpad passthrough to Thinkpad trackpoint

2015-08-07 Thread Pali Rohár
On Friday 07 August 2015 09:41:07 Ari Entlich wrote: On Fri, Aug 7, 2015 at 9:26 AM, Pali Rohár pali.ro...@gmail.com wrote: Hello, ALPS devices does not support pass-throw mode like Synaptics devices. Hmm... Then what are all of these references to passthrough in alps.c? Does the alps

Re: [PATCH] Input: drivers/joystick: use parallel port device model

2015-08-04 Thread Pali Rohár
On Monday 03 August 2015 14:41:27 Pali Rohár wrote: On Monday 03 August 2015 18:06:26 Sudip Mukherjee wrote: On Mon, Aug 03, 2015 at 02:26:48PM +0200, Pali Rohár wrote: On Saturday 01 August 2015 18:13:48 Sudip Mukherjee wrote: snip Hey! I believe you are not going to break my Atari

Re: [PATCH] Input: drivers/joystick: use parallel port device model

2015-08-03 Thread Pali Rohár
special homemade reduction for parallel port... :-) That Atari joystick uses db9.ko linux kernel driver and so any untested changes to db9.c could break functionality! -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH] Input: drivers/joystick: use parallel port device model

2015-08-03 Thread Pali Rohár
On Monday 03 August 2015 18:06:26 Sudip Mukherjee wrote: On Mon, Aug 03, 2015 at 02:26:48PM +0200, Pali Rohár wrote: On Saturday 01 August 2015 18:13:48 Sudip Mukherjee wrote: snip Hey! I believe you are not going to break my Atari joystick connected to my desktop PC via special

Re: [PATCH 05/15] drivers: input: Drop unlikely before IS_ERR(_OR_NULL)

2015-08-02 Thread Pali Rohár
On Sunday 02 August 2015 17:43:52 Pavel Machek wrote: On Sat 2015-08-01 13:44:59, Pali Rohár wrote: On Saturday 01 August 2015 13:22:51 Viresh Kumar wrote: On 31-07-15, 09:58, Dmitry Torokhov wrote: On Fri, Jul 31, 2015 at 02:08:25PM +0530, Viresh Kumar wrote: IS_ERR(_OR_NULL

Re: [PATCH 05/15] drivers: input: Drop unlikely before IS_ERR(_OR_NULL)

2015-08-01 Thread Pali Rohár
optimization, but also for me it looks like Clean Code pattern https://de.wikipedia.org/wiki/Clean_Code -- is not it? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Initialization of TPPS/2 IBM TrackPoint in too slow

2015-07-31 Thread Pali Rohár
this is just because of trying to detect device type. Is there any way how to speed it up? Maybe for synaptics serio devices try to probe for TPPS/2 at first? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: Initialization of TPPS/2 IBM TrackPoint in too slow

2015-07-31 Thread Pali Rohár
On Friday 31 July 2015 19:30:34 Dmitry Torokhov wrote: On Fri, Jul 31, 2015 at 07:17:02PM +0200, Pali Rohár wrote: On Friday 31 July 2015 19:08:49 Dmitry Torokhov wrote: On Fri, Jul 31, 2015 at 06:59:21PM +0200, Pali Rohár wrote: Hello, here is output from dmesg for psmouse.ko

Re: ALPS DualPoint double click bug

2015-07-31 Thread Pali Rohár
On Friday 31 July 2015 23:12:56 Douglas Christman wrote: On Thu, Jul 30, 2015 at 11:00 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 30-07-15 16:46, Pali Rohár wrote: What about introducing new flag ALPS_something instead calling dmi_name_in_vendors() function every time when we

Re: [PATCH 1/1] Input - alps: Fix button reporting on the V2 Alps protocol

2015-07-30 Thread Pali Rohár
for the regression Douglas is seeing. I'll write such a patch and post it shortly. Regards, Hans Hans, can you check ec and e7 registers if are same or if they differs? -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [PATCH 1/1] Input - alps: Fix button reporting on the V2 Alps protocol

2015-07-30 Thread Pali Rohár
On Thursday 30 July 2015 16:38:47 Hans de Goede wrote: Hi, On 30-07-15 16:32, Pali Rohár wrote: On Thursday 30 July 2015 16:28:39 Pali Rohár wrote: On Thursday 30 July 2015 16:18:47 Hans de Goede wrote: Hi, On 30-07-15 16:11, Pali Rohár wrote: On Thursday 30 July 2015 15:51:25 Hans de

Re: [PATCH 1/1] Input - alps: Fix button reporting on the V2 Alps protocol

2015-07-30 Thread Pali Rohár
On Thursday 30 July 2015 16:28:39 Pali Rohár wrote: On Thursday 30 July 2015 16:18:47 Hans de Goede wrote: Hi, On 30-07-15 16:11, Pali Rohár wrote: On Thursday 30 July 2015 15:51:25 Hans de Goede wrote: Hi Chandler, On 29-07-15 22:45, cp...@redhat.com wrote: From: Stephen

Re: ALPS DualPoint double click bug

2015-07-30 Thread Pali Rohár
|= packet[0] 2; What about introducing new flag ALPS_something instead calling dmi_name_in_vendors() function every time when we need to process packet? -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH 1/1] Input - alps: Fix button reporting on the V2 Alps protocol

2015-07-30 Thread Pali Rohár
On Thursday 30 July 2015 16:18:47 Hans de Goede wrote: Hi, On 30-07-15 16:11, Pali Rohár wrote: On Thursday 30 July 2015 15:51:25 Hans de Goede wrote: Hi Chandler, On 29-07-15 22:45, cp...@redhat.com wrote: From: Stephen Chandler Paul cp...@redhat.com The data concerning which buttons

Re: [PATCH 1/1] Input - alps: Fix button reporting on the V2 Alps protocol

2015-07-30 Thread Pali Rohár
it :-( Looks like some proto v2 devices report button clicks in packet[0] and some in packet[3]. Any idea how to fix it correctly? Do you have other laptops with proto V2 ALPS devices, to do more tests and dumps and distinguish buttons? -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from

Re: ALPS DualPoint double click bug

2015-07-30 Thread Pali Rohár
On Thursday 30 July 2015 17:00:56 Hans de Goede wrote: Hi, On 30-07-15 16:46, Pali Rohár wrote: What about introducing new flag ALPS_something instead calling dmi_name_in_vendors() function every time when we need to process packet? That is a good idea. Douglas can you test the attached

Re: Potential data race in psmouse_interrupt

2015-07-29 Thread Pali Rohár
: T397 clock: {T397: 175738, T6: 2266233} DBG: T6 clock: {T6: 2266336} == On Thu, Jul 23, 2015 at 3:08 PM, Pali Rohár pali.ro...@gmail.com wrote: On Wednesday 22 July 2015 15:14:42 Andrey Konovalov wrote: Hi! We are working

Re: Potential data race in psmouse_interrupt

2015-07-23 Thread Pali Rohár
that. -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: ALPS DualPoint double click bug

2015-07-22 Thread Pali Rohár
On Tuesday 21 July 2015 19:51:48 Douglas Christman wrote: On Tue, Jul 21, 2015 at 3:12 AM, Pali Rohár pali.ro...@gmail.com wrote: It is not enough. If do not want to recompile full kernel, but just only psmouse.ko I think that the easiest way is to change this define #define psmouse_dbg

Re: ALPS DualPoint double click bug

2015-07-21 Thread Pali Rohár
On Monday 20 July 2015 23:00:27 Douglas Christman wrote: On Mon, Jul 20, 2015 at 3:25 AM, Pali Rohár pali.ro...@gmail.com wrote: Hi! Please recompile psmouse.ko with dev_dbg() debug information and send new dmesg output. We need to know type of ALPS device. Thanks! I recompiled

Re: ALPS DualPoint double click bug

2015-07-20 Thread Pali Rohár
. Let's add a few people... Hi! Please recompile psmouse.ko with dev_dbg() debug information and send new dmesg output. We need to know type of ALPS device. Thanks! -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-06-15 Thread Pali Rohár
and Samuel already tested it, so in this case I would trust them and if there will be some problems I will report them later... I also want to see this option finally in 4.2 kernel. -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH 0/3] Switch input leds over to standard LED class devices

2015-06-09 Thread Pali Rohár
, Pavel Is not trigger only kernel part? If yes, then replacing kernel should not cause any Debian related bug, right? -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH 0/3] Switch input leds over to standard LED class devices

2015-06-09 Thread Pali Rohár
appearing input%::capslock LED class devices. I guess console-setup's maintainer will not be happy about it. I'd say it'd be good to at least give examples how to do it in the documentation. What about CC relevant people who maintains those userspace packages? -- Pali Rohár pali.ro

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2015-05-28 Thread Pali Rohár
On Saturday 28 March 2015 20:59:35 Dmitry Torokhov wrote: On Tue, Mar 24, 2015 at 08:27:29AM +0100, Hans de Goede wrote: Hi, On 23-03-15 18:02, Pali Rohár wrote: On Monday 23 March 2015 12:39:48 Hans de Goede wrote: Hi, On 22-03-15 14:46, Pali Rohár wrote: This patch adds

Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.

2015-04-10 Thread Pali Rohár
On Wednesday 25 February 2015 21:45:22 Pali Rohár wrote: On Wednesday 25 February 2015 19:48:55 Mario Limonciello wrote: On 02/20/2015 02:41 PM, Pali Rohár wrote: On Friday 20 February 2015 20:56:23 Mario Limonciello wrote: resetafter=0 means to never reset (even if driver receive

Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.

2015-04-10 Thread Pali Rohár
On Saturday 11 April 2015 01:07:03 Mario Limonciello wrote: On 04/10/2015 05:39 PM, Pali Rohár wrote: On Wednesday 25 February 2015 21:45:22 Pali Rohár wrote: Hello Mario, have you patched synaptics driver with some resetafter parameter? And have some team in dell found reason

Re: [PATCH] Input: atkbd: Fix release quirk for Dell models

2015-04-09 Thread Pali Rohár
On Thursday 09 April 2015 18:57:19 Dmitry Torokhov wrote: On Wed, Apr 08, 2015 at 10:54:20PM +0200, Pali Rohár wrote: On Monday 06 April 2015 18:20:56 Dmitry Torokhov wrote: On Mon, Apr 06, 2015 at 10:06:10AM +0200, Pali Rohár wrote: Ah, indeed. Sorry, at this time I completely

Re: [PATCH 4.0 REGRESSION FIX] alps: Fix left touchpad button getting stuck when using it with trackpoint

2015-04-08 Thread Pali Rohár
de Goede hdego...@redhat.com Patch looks good to me, so Acked-by: Pali Rohár pali.ro...@gmail.com As this is regression in 4.0 (which was not in 3.19), I'm also for fixing it. But decision is of course on maintainers... I think this is nice example how touchpad+trackstick protocol at HW level

Re: [PATCH] Input: atkbd: Fix release quirk for Dell models

2015-04-08 Thread Pali Rohár
On Monday 06 April 2015 18:20:56 Dmitry Torokhov wrote: On Mon, Apr 06, 2015 at 10:06:10AM +0200, Pali Rohár wrote: On Monday 06 April 2015 01:53:43 Dmitry Torokhov wrote: On Mon, Apr 06, 2015 at 12:00:32AM +0200, Pali Rohár wrote: On Sunday 05 April 2015 23:48:33 Dmitry Torokhov wrote

Re: [PATCH] Input: atkbd: Fix release quirk for Dell models

2015-04-06 Thread Pali Rohár
On Monday 06 April 2015 01:53:43 Dmitry Torokhov wrote: On Mon, Apr 06, 2015 at 12:00:32AM +0200, Pali Rohár wrote: On Sunday 05 April 2015 23:48:33 Dmitry Torokhov wrote: Hi Pali, On Sun, Mar 29, 2015 at 04:36:19PM +0200, Pali Rohár wrote: This patch fixes commit 61579ba83934

Re: [PATCH] Input: atkbd: Fix release quirk for Dell models

2015-04-05 Thread Pali Rohár
On Sunday 05 April 2015 23:48:33 Dmitry Torokhov wrote: Hi Pali, On Sun, Mar 29, 2015 at 04:36:19PM +0200, Pali Rohár wrote: This patch fixes commit 61579ba83934 (Input: atkbd - expand Latitude's force release quirk to other Dells). Before that commit release quirks were called for all

Re: [PATCH] Input: atkbd: Fix release quirk for Dell models

2015-04-04 Thread Pali Rohár
On Sunday 29 March 2015 16:36:19 Pali Rohár wrote: This patch fixes commit 61579ba83934 (Input: atkbd - expand Latitude's force release quirk to other Dells). Before that commit release quirks were called for all Dell Latitude models. After that commit only for Portable Dell devices. But lot

Re: [PATCH] alps: Document that Protocol V2 uses standard PS/2 mouse packets for the stick

2015-04-03 Thread Pali Rohár
when both the stick and +the touchpad are used at the same time. + ALPS Absolute Mode - Protocol Version 3 --- Acked-By: Pali Rohár pali.ro...@gmail.com -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message

Re: [PATCH FIX for 4.0 0/2] alps: Report alps v2 Dualpoint Stick events via the right event node

2015-04-01 Thread Pali Rohár
both patches into one. And can you check if your change is needed only for ALPS_PS2_INTERLEAVED devices? For me it looks like that only those alps devices could mix both 3-bytes and 6-bytes packets... -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed

Re: [PATCH FIX for 4.0 0/2] alps: Report alps v2 Dualpoint Stick events via the right event node

2015-04-01 Thread Pali Rohár
On Wednesday 01 April 2015 18:14:43 Hans de Goede wrote: Hi, On 01-04-15 18:11, Pali Rohár wrote: On Wednesday 01 April 2015 17:44:04 Hans de Goede wrote: Hi Dmitry Pali, While working on some libinput code to deal with trackpoints of different model laptops having quite

[PATCH] Input: atkbd: Fix release quirk for Dell models

2015-03-29 Thread Pali Rohár
quirks are not called. Release quirks are still needed also for new Dell Latitude models, so this patch enables quirks for all Portable, Laptop, Notebook and Sub-Notebook Dell devices. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/input/keyboard/atkbd.c | 48

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2015-03-28 Thread Pali Rohár
is the same I wonder if we are dropping some packets... Is there any messages from psmouse module in dmesg? Thanks. For me output/diff looks ok. Name is based on DUALPOINT flag which is cleared for non trackstick device version. And my patch adding that trackstick detection for v7. -- Pali Rohár

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2015-03-27 Thread Pali Rohár
/gpm.conf says, it is slower than the previous kernel with the stock configuration. Regards Santiago El vie., 27 de marzo de 2015 a las 18:17, Pali Rohár (pali.ro...@gmail.com) escribió: On Thursday 26 March 2015 16:33:13 you wrote: El mar., 24 de marzo de 2015 a las 17:48, Pali

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2015-03-27 Thread Pali Rohár
2015 a las 21:09, Pali Rohár (pali.ro...@gmail.com) escribió: Hello, there should no functional changes (e.g. acceleration speed, etc.). And if yes, there is probably some side effect which should be investigated. Please can you provide output from dmesg (grep for psmouse or input

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2015-03-24 Thread Pali Rohár
Santiago El mar., 24 de marzo de 2015 a las 8:30, Hans de Goede (hdego...@redhat.com) escribió: Hi, On 23-03-15 18:02, Pali Rohár wrote: On Monday 23 March 2015 12:39:48 Hans de Goede wrote: Hi, On 22-03-15 14:46, Pali Rohár wrote: This patch adds detection of trackstick

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2015-03-23 Thread Pali Rohár
On Monday 23 March 2015 12:39:48 Hans de Goede wrote: Hi, On 22-03-15 14:46, Pali Rohár wrote: This patch adds detection of trackstick for v7 protocol devices. Code in this patch is used in official Dell touchpad linux drivers for Dell models: Dell Latitude E5250/5250, E5450/5450

[PATCH] Input: ALPS - Report v3 pinnacle trackstick device only if is present

2015-03-22 Thread Pali Rohár
This patch move v3 pinnacle code for trackstick detection from alps_hw_init_v3() to alps_set_protocol() so ALPS_DUALPOINT flag can be cleared before registering trackstick input device in kernel. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/input/mouse/alps.c | 12 +++- 1

Re: [PATCH] Input: ALPS - fix max coordinates for v5 and v7 protocols

2015-03-22 Thread Pali Rohár
, causing both protocols report incorrect maximum values for X and Y axes which resulted in crash in Synaptics X driver. Reported-by: Santiago Gala sg...@apache.org Reported-by: Pali Rohár pali.ro...@gmail.com Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com Fix looks good

[PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2015-03-22 Thread Pali Rohár
https://bugzilla.kernel.org/show_bug.cgi?id=94801 reported that Toshiba Sattellite Z30-A-1DG has only alps v7 touchpad device without trackstick and kernel reports to userspace also redundant trackstick device. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/input/mouse/alps.c | 12

Re: [PATCH] Input: ALPS - fix memory leak when detection fails

2015-02-28 Thread Pali Rohár
= alps_identify(psmouse, priv); - if (error) + if (error) { + kfree(priv); return error; + } if (set_properties) { psmouse-vendor = ALPS; Acked-by: Pali Rohár pali.ro...@gmail.com -- Pali Rohár pali.ro...@gmail.com signature.asc

Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.

2015-02-25 Thread Pali Rohár
On Wednesday 25 February 2015 19:48:55 Mario Limonciello wrote: On 02/20/2015 02:41 PM, Pali Rohár wrote: On Friday 20 February 2015 20:56:23 Mario Limonciello wrote: resetafter=0 means to never reset (even if driver receive e.g thousand invalid packets). I think this is very dangerous

Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.

2015-02-23 Thread Pali Rohár
On Tuesday 24 February 2015 00:31:52 Mario Limonciello wrote: On 02/22/2015 10:55 AM, Pali Rohár wrote: Thank you for information! Sure, no problem. Mario, do you know if it is possible to switch keyboard into mode under which Fn key will send scancode (like Ctrl or Alt) when presses

Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.

2015-02-20 Thread Pali Rohár
On Friday 20 February 2015 20:56:23 Mario Limonciello wrote: Hi Pali Dmitry, On 02/20/2015 01:24 PM, Pali Rohár wrote: On Friday 20 February 2015 19:47:17 Dmitry Torokhov wrote: Hi Mario, On Thu, Feb 19, 2015 at 12:16:51PM -0600, Mario Limonciello wrote: Can it be related

Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.

2015-02-20 Thread Pali Rohár
kernel? It could fix problem when either sound or touchpad is not working... -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.

2015-02-20 Thread Pali Rohár
something like on-the-fly firmware load (without flashing it) which will be active until notebook shutdown. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH] Input: ALPS: Move v7 packet info to Documentation and v6 packet info

2015-02-16 Thread Pali Rohár
On Monday 16 February 2015 18:28:30 Jonathan Corbet wrote: On Tue, 10 Feb 2015 13:43:33 +0100 Pali Rohár pali.ro...@gmail.com wrote: This patch move all packet info from driver source code to documentation and adds info about v6 packet format (from driver source code). I tried

Re: Dell ALPS patches for Dell Latitude 7250 7450

2015-02-15 Thread Pali Rohár
or not... -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-02-12 Thread Pali Rohár
On Thursday 12 February 2015 08:52:35 Dmitry Torokhov wrote: On Sun, Feb 08, 2015 at 01:26:32PM +0100, Pali Rohár wrote: On Monday 02 February 2015 15:27:55 Pali Rohár wrote: On Monday 02 February 2015 11:49:58 Pali Rohár wrote: On Monday 02 February 2015 06:49:31 Dmitry Torokhov wrote

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-02-11 Thread Pali Rohár
On Tuesday 10 February 2015 07:32:55 Dmitry Torokhov wrote: On Sun, Feb 08, 2015 at 01:26:32PM +0100, Pali Rohár wrote: On Monday 02 February 2015 15:27:55 Pali Rohár wrote: On Monday 02 February 2015 11:49:58 Pali Rohár wrote: On Monday 02 February 2015 06:49:31 Dmitry Torokhov wrote

Dell ALPS patches for Dell Latitude E5250/5250, E5450/5450, E5550/5550

2015-02-10 Thread Pali Rohár
, ALPS_DRIVER_RELEASE_DATE); + /* * Undo part of setup done for us by psmouse core since touchpad * is not a relative device. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Dell ALPS patches for Dell Latitude 7250 7450

2015-02-10 Thread Pali Rohár
Hello, now I found on Dell support website, that they also provide psmouse/alps.c driver for new Dell Latitude 7250 7450 machines: http://www.dell.com/support/home/gh/en/ghdhs1/Drivers/DriversDetails?driverId=N5V5D It is again in Ubuntu support package and so users and developers who do not use

[PATCH] Input: ALPS: Move v7 packet info to Documentation and v6 packet info

2015-02-10 Thread Pali Rohár
This patch move all packet info from driver source code to documentation and adds info about v6 packet format (from driver source code). Signed-off-by: Pali Rohár pali.ro...@gmail.com --- Documentation/input/alps.txt | 68 -- drivers/input/mouse/alps.c

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-02-08 Thread Pali Rohár
On Monday 02 February 2015 15:27:55 Pali Rohár wrote: On Monday 02 February 2015 11:49:58 Pali Rohár wrote: On Monday 02 February 2015 06:49:31 Dmitry Torokhov wrote: On Sun, Jan 18, 2015 at 10:47:06AM +0100, Pali Rohár wrote: On Sunday 18 January 2015 08:22:45 Dmitry Torokhov wrote

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-02-05 Thread Pali Rohár
On Monday 02 February 2015 06:49:31 Dmitry Torokhov wrote: On Sun, Jan 18, 2015 at 10:47:06AM +0100, Pali Rohár wrote: On Sunday 18 January 2015 08:22:45 Dmitry Torokhov wrote: On Sat, Jan 17, 2015 at 11:01:56AM +0100, Pali Rohár wrote: On Thursday 15 January 2015 22:02:16 Dmitry

Re: [PATCH 5/6] Input: ALPS - fix trackstick detection on some Dell Latitudes

2015-02-02 Thread Pali Rohár
On Monday 02 February 2015 06:34:08 Dmitry Torokhov wrote: On Sat, Jan 17, 2015 at 11:26:50AM +0100, Pali Rohár wrote: On Wednesday 14 January 2015 23:55:53 Dmitry Torokhov wrote: On some Dell Latitudes we fail to identify presence of trackstick unless we reset the device. The issue

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-02-02 Thread Pali Rohár
On Monday 02 February 2015 06:49:31 Dmitry Torokhov wrote: On Sun, Jan 18, 2015 at 10:47:06AM +0100, Pali Rohár wrote: On Sunday 18 January 2015 08:22:45 Dmitry Torokhov wrote: On Sat, Jan 17, 2015 at 11:01:56AM +0100, Pali Rohár wrote: On Thursday 15 January 2015 22:02:16 Dmitry

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-02-02 Thread Pali Rohár
On Monday 02 February 2015 11:49:58 Pali Rohár wrote: On Monday 02 February 2015 06:49:31 Dmitry Torokhov wrote: On Sun, Jan 18, 2015 at 10:47:06AM +0100, Pali Rohár wrote: On Sunday 18 January 2015 08:22:45 Dmitry Torokhov wrote: On Sat, Jan 17, 2015 at 11:01:56AM +0100, Pali Rohár

Re: [PATCH 6/6] Input: ALPS - mix trackstick and external PS/2 mouse data

2015-01-18 Thread Pali Rohár
, + failed to allocate trackstick device\n); ^^ 2x space + error = -ENOMEM; + goto init_fail; + } -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-01-18 Thread Pali Rohár
On Sunday 18 January 2015 08:22:45 Dmitry Torokhov wrote: On Sat, Jan 17, 2015 at 11:01:56AM +0100, Pali Rohár wrote: On Thursday 15 January 2015 22:02:16 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 09:28:41PM +0100, Pali Rohár wrote: On Thursday 15 January 2015 20:38:18 Dmitry

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-01-17 Thread Pali Rohár
On Thursday 15 January 2015 22:02:16 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 09:28:41PM +0100, Pali Rohár wrote: On Thursday 15 January 2015 20:38:18 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 08:19:59PM +0100, Pali Rohár wrote: On Thursday 15 January 2015 19:18:20 Dmitry

Re: [PATCH 5/6] Input: ALPS - fix trackstick detection on some Dell Latitudes

2015-01-17 Thread Pali Rohár
is not accurate. In order to fix the issue while avoiding the additional lengthy reset we move the resrt to alps_detect() and keep the discovered state to be used later in alps_init(). Reported-by: Pali Rohár pali.ro...@gmail.com Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com

Re: [PATCH 6/6] Input: ALPS - mix trackstick and external PS/2 mouse data

2015-01-15 Thread Pali Rohár
On Wednesday 14 January 2015 23:55:54 Dmitry Torokhov wrote: From: Pali Rohár pali.ro...@gmail.com Previously dev2 device was used for both external PS/2 mouse and internal trackstick device (if available). This change introduces dev3 device which is used for external PS/2 mouse data

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-01-15 Thread Pali Rohár
On Thursday 15 January 2015 20:38:18 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 08:19:59PM +0100, Pali Rohár wrote: On Thursday 15 January 2015 19:18:20 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 11:49:32AM +0100, Pali Rohár wrote: On Wednesday 14 January 2015 23:55:48 Dmitry

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-01-15 Thread Pali Rohár
On Thursday 15 January 2015 19:18:20 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 11:49:32AM +0100, Pali Rohár wrote: On Wednesday 14 January 2015 23:55:48 Dmitry Torokhov wrote: Hi Pali, This series try to address the issue you brought regarding trackstick initialization on Dell

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-01-15 Thread Pali Rohár
ALPS devices anymore so I'd appreciate you giving it a spin. Thanks! Hi Dmitry, on top of which branch/repository should I apply your patches? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH 5/6] Input: ALPS - fix trackstick detection on some Dell Latitudes

2015-01-15 Thread Pali Rohár
. + */ + psmouse_reset(psmouse); + + priv = kzalloc(sizeof(struct alps_data), GFP_KERNEL); + if (priv) if (!priv) + return -ENOMEM; + -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH 6/7] input: alps: Add sanity checks for non DualPoint devices

2015-01-12 Thread Pali Rohár
On Monday 12 January 2015 01:31:00 Dmitry Torokhov wrote: On Fri, Nov 14, 2014 at 08:38:25PM +0100, Pali Rohár wrote: This patch adds sanity checks and reject trackstick packets from ALPS devices which do not have trackstick present (those without ALPS_DUALPOINT flag). Make sure

Re: [PATCH 1/7] input: alps: Set correct name of psmouse device in alps_init()

2015-01-08 Thread Pali Rohár
On Wednesday 24 December 2014 08:48:42 Pali Rohár wrote: On Saturday 20 December 2014 09:53:38 Pali Rohár wrote: On Tuesday 16 December 2014 12:58:20 Pali Rohár wrote: On Tuesday 16 December 2014 06:02:34 Dmitry Torokhov wrote: Hi Pali, On Fri, Nov 14, 2014 at 08:38:20PM +0100

Re: [PATCH 1/7] input: alps: Set correct name of psmouse device in alps_init()

2014-12-23 Thread Pali Rohár
On Saturday 20 December 2014 09:53:38 Pali Rohár wrote: On Tuesday 16 December 2014 12:58:20 Pali Rohár wrote: On Tuesday 16 December 2014 06:02:34 Dmitry Torokhov wrote: Hi Pali, On Fri, Nov 14, 2014 at 08:38:20PM +0100, Pali Rohár wrote: On some laptops after starting them from

Re: [PATCH 1/7] input: alps: Set correct name of psmouse device in alps_init()

2014-12-20 Thread Pali Rohár
On Tuesday 16 December 2014 12:58:20 Pali Rohár wrote: On Tuesday 16 December 2014 06:02:34 Dmitry Torokhov wrote: Hi Pali, On Fri, Nov 14, 2014 at 08:38:20PM +0100, Pali Rohár wrote: On some laptops after starting them from off state (not after reboot), function

Re: [PATCH 1/7] input: alps: Set correct name of psmouse device in alps_init()

2014-12-16 Thread Pali Rohár
On Tuesday 16 December 2014 06:02:34 Dmitry Torokhov wrote: Hi Pali, On Fri, Nov 14, 2014 at 08:38:20PM +0100, Pali Rohár wrote: On some laptops after starting them from off state (not after reboot), function alps_probe_trackstick_v3() (called from function alps_identify()) does

Re: [PATCH 0/7] Fixes for ALPS trackstick

2014-12-09 Thread Pali Rohár
On Friday 14 November 2014 20:38:19 Pali Rohár wrote: This patch series fix detection and identifying trackstick on machines with ALPS devices. Last patch split trackstick and bare PS/2 mouse packets between dev2 and dev3 input devices which make sure that driver will send only trackstick data

Re: [PATCH 0/7] Fixes for ALPS trackstick

2014-12-03 Thread Pali Rohár
On Thursday 27 November 2014 19:08:04 Dmitry Torokhov wrote: On November 25, 2014 3:08:31 AM PST, Pali Rohár pali.ro...@gmail.com wrote: On Thursday 20 November 2014 00:29:49 Pali Rohár wrote: On Monday 17 November 2014 08:39:14 Pali Rohár wrote: On Friday 14 November 2014 21:59:31 Dmitry

Re: Side effect of pressing special keys

2014-12-03 Thread Pali Rohár
On Wednesday 03 December 2014 13:40:42 Pavel Machek wrote: On Sun 2014-11-23 14:41:17, Pali Rohár wrote: Hello, pressing some keys on laptops could cause some side effects. Example scenario 1: Laptop has Fn key for enabling/disabling WIFI and when that key is pressed BIOS

Re: Side effect of pressing special keys

2014-12-03 Thread Pali Rohár
On Wednesday 03 December 2014 14:12:54 Henrique de Moraes Holschuh wrote: On Wed, 03 Dec 2014, Pali Rohár wrote: Ok, and what about KEY_KBDILLUMTOGGLE when bios also handle keyboard backlight level? Should be this key filtered too? IME, heck yes. If you ever make the mistake of sending

Disable input device

2014-11-29 Thread Pali Rohár
is can be called (e.g. for power management or disabling device at hardware level). Or do you prefer something other? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH 0/7] Fixes for ALPS trackstick

2014-11-25 Thread Pali Rohár
On Thursday 20 November 2014 00:29:49 Pali Rohár wrote: On Monday 17 November 2014 08:39:14 Pali Rohár wrote: On Friday 14 November 2014 21:59:31 Dmitry Torokhov wrote: Hi Pali, On Friday, November 14, 2014 08:38:19 PM Pali Rohár wrote: This patch series fix detection

Re: Reported key not released

2014-11-24 Thread Pali Rohár
On Monday 24 November 2014 21:04:33 Matthew Garrett wrote: On Sun, Nov 23, 2014 at 02:13:30PM +0100, Pali Rohár wrote: When I enable or disable this switch it correctly enable or disable devices (and also hard rfkill status is set correctly). If the switch changes the rfkill state, you

Re: Reported key not released

2014-11-24 Thread Pali Rohár
On Monday 24 November 2014 22:51:47 Matthew Garrett wrote: On Mon, Nov 24, 2014 at 09:58:32PM +0100, Pali Rohár wrote: So kernel should filter i8042 atk key press events which represent HW switch? Yeah - the firmware is sending an Update rfkill state message, not a real keypress

  1   2   >