Re: [PATCH net] hyperv: Fix the carrier status setting

2014-02-10 Thread Sergei Shtylyov
Hello. On 10-02-2014 5:07, Haiyang Zhang wrote: Signed-off-by: Haiyang Zhang haiya...@microsoft.com Reviewed-by: K. Y. Srinivasan k...@microsoft.com --- drivers/net/hyperv/netvsc_drv.c | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git

Re: [PATCH net-next,v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-19 Thread Sergei Shtylyov
Hello. On 03/19/2014 11:40 PM, David Miller wrote: +extern u8 netvsc_hash_key[]; We no longer use extern in header file function declarations. Wait, this is a variable declaration. :-) WBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-19 Thread Sergei Shtylyov
Hello. On 03/20/2014 01:14 AM, Jason Gunthorpe wrote: The preferred multi-line comment style is: /* * bla * bla */ Sergei, the entire file use the 'net' multi-line commenting style, and I have maintined that consistency with the new code. No, you haven't followed the

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-19 Thread Sergei Shtylyov
On 03/20/2014 01:36 AM, Jason Gunthorpe wrote: The preferred multi-line comment style is: /* * bla * bla */ Sergei, the entire file use the 'net' multi-line commenting style, and I have maintined that consistency with the new code. No, you haven't followed the networking

Re: [PATCH 2/2] coding style: fix line over 80 characters

2014-03-20 Thread Sergei Shtylyov
Hello. On 03/20/2014 01:04 AM, Cédric Cabessa wrote: Signed-off-by: Cédric Cabessa c...@ryick.net --- drivers/staging/usbip/vhci_hcd.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/usbip/vhci_hcd.c

Re: [PATCH 2/2] coding style: fix line over 80 characters

2014-03-20 Thread Sergei Shtylyov
On 03/21/2014 12:34 AM, Sergei Shtylyov wrote: Signed-off-by: Cédric Cabessa c...@ryick.net --- drivers/staging/usbip/vhci_hcd.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip

Re: [PATCH 2/2] coding style: fix line over 80 characters

2014-03-20 Thread Sergei Shtylyov
On 03/20/2014 11:45 PM, Joe Perches wrote: diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c [] @@ -271,12 +271,14 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, } break;

Re: [PATCH 2/2] coding style: fix line over 80 characters

2014-03-20 Thread Sergei Shtylyov
On 03/21/2014 12:34 AM, Sergei Shtylyov wrote: Signed-off-by: Cédric Cabessa c...@ryick.net --- drivers/staging/usbip/vhci_hcd.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip

Re: [PATCH] bonding: Inactive slaves should keep inactive flag's value to 1.

2014-03-21 Thread Sergei Shtylyov
Hello. On 03/20/2014 11:51 AM, Zheng Li wrote: Except bond mode 1, in other bond modes, inactive slaves should keep inactive flag to 1 to refuse to receive broadcast packets. Now, active slave send broadcast packets (for example ARP requests) which will arrive inactive slaves on same host

Re: [PATCH] mips: export icache_flush_range

2014-03-22 Thread Sergei Shtylyov
Hello. On 03/22/2014 06:47 PM, Kees Cook wrote: The lkdtm module performs tests against executable memory ranges, so it needs to flush the icache for proper behaviors. Other architectures already export this, so do the same for MIPS. Signed-off-by: Kees Cook keesc...@chromium.org --- This

Re: [PATCH] mips: export icache_flush_range

2014-03-22 Thread Sergei Shtylyov
On 03/23/2014 12:45 AM, Sergei Shtylyov wrote: The lkdtm module performs tests against executable memory ranges, so it needs to flush the icache for proper behaviors. Other architectures already export this, so do the same for MIPS. Signed-off-by: Kees Cook keesc...@chromium.org

Re: [PATCH] mips: export icache_flush_range

2014-03-22 Thread Sergei Shtylyov
On 03/23/2014 12:48 AM, Sergei Shtylyov wrote: The lkdtm module performs tests against executable memory ranges, so it needs to flush the icache for proper behaviors. Other architectures already export this, so do the same for MIPS. Signed-off-by: Kees Cook keesc...@chromium.org

Re: [PATCH] mips: export icache_flush_range

2014-03-22 Thread Sergei Shtylyov
On 03/23/2014 12:05 AM, Kees Cook wrote: The lkdtm module performs tests against executable memory ranges, so it needs to flush the icache for proper behaviors. Other architectures already export this, so do the same for MIPS. Signed-off-by: Kees Cook keesc...@chromium.org --- This is

Re: [GIT PULL] libata maintainership update

2013-05-07 Thread Sergei Shtylyov
Hello. On 07-05-2013 21:19, Tejun Heo wrote: As discussed earlier, Jeff is leaving for something more fun and I'm inheriting the maintainership of libata. Please pull from the following branch to receive MAINTAINERS update. git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git

Re: [PATCH] net: of_mdio: fix behavior on missing phy device

2013-05-07 Thread Sergei Shtylyov
Hello. On 07-05-2013 13:49, Sebastian Hesselbarth wrote: of_mdiobus_register creates a phy_device even if get_phy_device failed to create it previously. This causes indefinite polling on non-existent PHYs. This fix makes of_mdio_register rely on get_phy_device to properly create the device or

Re: net: phy: realtek: add rtl8201f driver

2013-05-08 Thread Sergei Shtylyov
Hello. On 08-05-2013 14:10, Jongsung Kim wrote: This patch adds the minimal driver to manage the Realtek RTL8201F 10/100Mbps Transceivers. Signed-off-by: Jongsung Kim neidhard@lge.com --- drivers/net/phy/realtek.c | 60 +++- 1 files changed,

Re: [PATCH v5, part4 20/41] mm/h8300: prepare for removing num_physpages and simplify mem_init()

2013-05-08 Thread Sergei Shtylyov
Hello. On 08-05-2013 19:51, Jiang Liu wrote: Prepare for removing num_physpages and simplify mem_init(). Signed-off-by: Jiang Liu jiang@huawei.com Cc: Yoshinori Sato ys...@users.sourceforge.jp Cc: Geert Uytterhoeven ge...@linux-m68k.org Cc: linux-kernel@vger.kernel.org ---

Re: [PATCH v5, part4 20/41] mm/h8300: prepare for removing num_physpages and simplify mem_init()

2013-05-08 Thread Sergei Shtylyov
Hello. On 05/08/2013 08:26 PM, Sergei Shtylyov wrote: Prepare for removing num_physpages and simplify mem_init(). Signed-off-by: Jiang Liu jiang@huawei.com Cc: Yoshinori Sato ys...@users.sourceforge.jp Cc: Geert Uytterhoeven ge...@linux-m68k.org Cc: linux-kernel@vger.kernel.org

Re: net: phy: realtek: add rtl8201f driver

2013-05-09 Thread Sergei Shtylyov
Hello. On 09-05-2013 6:35, Jongsung Kim wrote: Removal of unused #define's is a matter of a separate cleanup patch... Sorry. I won't touch them. +static int rtl8201f_ack_interrupt(struct phy_device *phydev) { + int err; + + err = phy_read(phydev, RTL8201F_ISR);

Re: [PATCH] USB: serial/ftdi_sio.c Fix kernel oops

2013-06-07 Thread Sergei Shtylyov
Hello. On 06/07/2013 05:14 PM, Lotfi Manseur wrote: Handle null termios in ftdi_set_termios(), introduced in commit 552f6bf1bb0eda0011c0525dd587aa9e7ba5b846 This has been corrected in the mainline by commits c515598e0f5769916c31c00392cc2bfe6af74e55 and a816e3113b63753c330ca4751ea1d208e93e3015.

Re: [PATCH] USB: cdc-acm: remove unneeded spin_lock_irqsave/restore on write path

2013-06-07 Thread Sergei Shtylyov
Hello. On 06/07/2013 10:32 PM, Greg Kroah-Hartman wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org When writing data we were: lock do some work unlock call function lock do some work unlock

Re: [PATCH 20/31] mips/kvm: Hook into TLB fault handlers.

2013-06-07 Thread Sergei Shtylyov
Hello. On 06/08/2013 03:03 AM, David Daney wrote: From: David Daney david.da...@cavium.com If the CPU is operating in guest mode when a TLB related excpetion occurs, give KVM a chance to do emulation. Signed-off-by: David Daney david.da...@cavium.com --- arch/mips/mm/fault.c | 8

Re: [PATCH 14/15] usb: phy: rcar-usb: Fix comment w.r.t. devm_ioremap_resource

2013-06-10 Thread Sergei Shtylyov
Hello. On 10-06-2013 15:35, Tushar Behera wrote: Commit 75096579c3ac (lib: devres: Introduce devm_ioremap_resource()) introduced devm_ioremap_resource() and deprecated the use of devm_request_and_ioremap(). Signed-off-by: Tushar Behera tushar.beh...@linaro.org CC: linux-...@vger.kernel.org

Re: [PATCH 01/11] ARM: davinci: GPIO: Add platform data structure

2013-06-11 Thread Sergei Shtylyov
Hello. On 11-06-2013 14:36, Sekhar Nori wrote: From: KV Sujith sujit...@ti.com Add struct davinci_gpio_platform_data davinci gpio module. Signed-off-by: KV Sujith sujit...@ti.com Signed-off-by: Philip Avinash avinashphi...@ti.com As Linus commented before, this should be merged with

Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX

2013-06-11 Thread Sergei Shtylyov
Hello. On 11-06-2013 18:57, Markos Chandras wrote: The Vortex driver depends on PCI with optional support for EISA. This fixes build problems when EISA is selected but not PCI. drivers/net/ethernet/3com/3c59x.c:1031:2: error: implicit declaration of function 'pci_iomap'

Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-11 Thread Sergei Shtylyov
Hello. On 06/11/2013 01:45 PM, B, Ravi wrote: + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, phy_wkup); + phy-phy_wkup = ioremap(res-start, resource_size(res)); devm_ioremap? The phy_wakeup register is common across two instances of phy, devm_ioremap_resource()

Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX

2013-06-11 Thread Sergei Shtylyov
Hello. On 06/12/2013 12:16 AM, Paul Gortmaker wrote: The Vortex driver depends on PCI with optional support for EISA. This fixes build problems when EISA is selected but not PCI. drivers/net/ethernet/3com/3c59x.c:1031:2: error: implicit declaration of function 'pci_iomap'

Re: [PATCH net] macvlan: don't touch promisc without passthrough

2013-06-12 Thread Sergei Shtylyov
Hello. On 12-06-2013 15:34, Michael S. Tsirkin wrote: commit df8ef8f3aaa6692970a436204c4429210addb23a in linux 3.5 added a way Please also specify that commit's summary line in parens. to control NOPROMISC macvlan flag through netlink. However, with a non passthrough device we don't

Re: [PATCH 03/31] mips/kvm: Fix 32-bitisms in kvm_locore.S

2013-06-14 Thread Sergei Shtylyov
Hello. On 14-06-2013 17:09, Ralf Baechle wrote: diff --git a/arch/mips/kvm/kvm_locore.S b/arch/mips/kvm/kvm_locore.S index dca2aa6..e86fa2a 100644 --- a/arch/mips/kvm/kvm_locore.S +++ b/arch/mips/kvm/kvm_locore.S @@ -310,7 +310,7 @@ NESTED (MIPSX(GuestException), CALLFRAME_SIZ, ra)

Re: linux-next: manual merge of the arm-soc tree with the net-next tree

2013-06-17 Thread Sergei Shtylyov
Hello. On 17-06-2013 10:39, Stephen Rothwell wrote: Today's linux-next merge of the arm-soc tree got a conflict in arch/arm/mach-shmobile/clock-r8a7740.c between commit e5c9b4cd6651 (sh_eth: get R8A7740 support out of #ifdef) from the net-next tree and commit 9e0b428f079d (ARM: shmobile:

Re: [PATCH] AHCI: Make distinct names for ports in /proc/interrupts

2013-04-29 Thread Sergei Shtylyov
Hello. On 29-04-2013 14:12, Alexander Gordeev wrote: Currently all interrupts assigned to AHCI ports show up in '/proc/interrupts' as 'ahci'. This fix adds port numbers as suffixes and hence makes the descriptions distinct. Reported-by: Jan Beulich jbeul...@suse.com Signed-off-by: Alexander

Re: [PATCH] drivers: mtd: nand: davinci: use devm_ioremap_resource()

2013-05-02 Thread Sergei Shtylyov
Hello. On 02-05-2013 17:22, Laurent Navet wrote: Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet laurent.na...@gmail.com

Re: [PATCH] media: davinci: vpbe: fix layer availability for NV12 format

2013-05-03 Thread Sergei Shtylyov
Hello. On 03-05-2013 13:53, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com For NV12 format, even if display data is single image, both VIDWIN0 and VIDWIN1 parameters must be used. The start address of Y data plane and C data plane is configured in VIDEOWIN0ADH/L and

Re: [PATCH] vhost_net: clear msg.control for non-zerocopy case during tx

2013-06-05 Thread Sergei Shtylyov
Hello. On 05-06-2013 11:40, Jason Wang wrote: When we decide not use zero-copy, msg.control should be set to NULL otherwise macvtap/tap may set zerocopy callbacks which may decrease the kref of ubufs wrongly. Bug were introduced by commit cedb9bdce099206290a2bdd02ce47a7b253b6a84 (vhost-net:

Re: [PATCH] vhost_net: clear msg.control for non-zerocopy case during tx

2013-06-06 Thread Sergei Shtylyov
Hello. On 06/06/2013 07:27 AM, Jason Wang wrote: When we decide not use zero-copy, msg.control should be set to NULL otherwise macvtap/tap may set zerocopy callbacks which may decrease the kref of ubufs wrongly. Bug were introduced by commit cedb9bdce099206290a2bdd02ce47a7b253b6a84 (vhost-net:

Re: [PATCH 07/45] CPU hotplug: Expose the new debug config option

2013-06-23 Thread Sergei Shtylyov
Hello. On 23-06-2013 17:39, Srivatsa S. Bhat wrote: Now that we have all the pieces of the CPU hotplug debug infrastructure in place, expose the feature by growing a new Kconfig option, CONFIG_DEBUG_HOTPLUG_CPU. Cc: Andrew Morton a...@linux-foundation.org Cc: Paul E. McKenney

Re: [PATCH net] tun: fix recovery from gup errors

2013-06-23 Thread Sergei Shtylyov
Hello. On 23-06-2013 18:19, Michael S. Tsirkin wrote: get user pages might fail partially in tun zero copy mode. To recover we need to put all pages that we got, but code used a wrong index resulting in double-free errors. Reported-by: Brad Hubbard bhubb...@redhat.com Signed-off-by: Michael

Re: [PATCH v2] [NET]: Unmap fragment page once iterator is done

2013-06-24 Thread Sergei Shtylyov
Hello. On 24-06-2013 10:33, Wedson Almeida Filho wrote: Callers of skb_seq_read() are currently forced to call skb_abort_seq_read() even when consuming all the data because the last call to skb_seq_read (the one that returns 0 to indicate the end) fails to unmap the last fragment page. With

Re: [PATCH v2 2/2] regulators: max8973: initial DT support

2013-06-24 Thread Sergei Shtylyov
Hello. On 06/24/2013 02:50 PM, Guennadi Liakhovetski wrote: This patch adds primitive DT support to the max8973 regulator driver. None of the configuration parameters, supported in the platform data are yet available in DT, therefore no configuration is performed if booting with no platform

Re: [PATCH v2] [NET]: Unmap fragment page once iterator is done

2013-06-24 Thread Sergei Shtylyov
Hello. On 06/25/2013 02:47 AM, Wedson Almeida Filho wrote: The summary line of the original commit is [NET]: Zerocopy sequential reading of skb data. That's interesting but please update your patch. WBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [PATCH v2] staging: usbip: replace pr_warning() with dev_warn().

2013-06-26 Thread Sergei Shtylyov
Hello. On 26-06-2013 13:41, navin patidar wrote: dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device structure required for dev_warn(). Signed-off-by: navin patidar

Re: [PATCH 11/11] net: emaclite: Update driver header

2013-05-29 Thread Sergei Shtylyov
Hello. On 05/29/2013 07:33 PM, Michal Simek wrote: Corrent email address and years. s/Corrent/Correct/. Perhaps the committer can fix. Signed-off-by: Michal Simek michal.si...@xilinx.com WBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH, v2 13/13] mm/m68k: fix build warning of unused variable

2013-05-29 Thread Sergei Shtylyov
Hello. On 05/29/2013 06:44 PM, Jiang Liu wrote: Fix build warning of unused variable: arch/m68k/mm/init.c: In function 'mem_init': arch/m68k/mm/init.c:151:6: warning: unused variable 'i' [-Wunused-variable] Signed-off-by: Jiang Liu jiang@huawei.com Cc: Geert Uytterhoeven

Re: [PATCH] net: skbuff: use _RET_IP_

2013-05-29 Thread Sergei Shtylyov
Hello. On 05/30/2013 01:09 AM, Davidlohr Bueso wrote: Use the already defined macro to pass the function return address. Signed-off-by: Davidlohr Bueso davidlohr.bu...@hp.com --- net/core/skbuff.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [PATCH v2] ata: increase retry count but shorten duration for Calxeda controller

2013-05-30 Thread Sergei Shtylyov
Hello. On 30-05-2013 18:26, Timur Tabi wrote: - const unsigned long *timing = sata_ehc_deb_timing(link-eh_context); + const unsigned long timing[] = { 5, 100, 500}; You'll save space and time if you also make this array static, otherwise the compiler will build the array every

Re: [PATCH v2 4/6] MIPS: jz4740: Register jz4740 DMA device

2013-05-30 Thread Sergei Shtylyov
Hello. On 05/30/2013 08:25 PM, Lars-Peter Clausen wrote: Register a device for the newly added jz4740 dmaengine driver. Signed-off-by: Lars-Peter Clausen l...@metafoo.de Acked-by: Ralf Baechle r...@linux-mips.org [...] 3 files changed, 23 insertions(+) diff --git

Re: [PATCH v2] ata: increase retry count but shorten duration for Calxeda controller

2013-05-31 Thread Sergei Shtylyov
Hello. On 31-05-2013 10:53, Clemens Ladisch wrote: +const unsigned long timing[] = { 5, 100, 500}; You'll save space and time if you also make this array static, otherwise the compiler will build the array every time this function is called. No, *const* specifier is enough to not

Re: [PATCH] net: skbuff: use _RET_IP_

2013-05-31 Thread Sergei Shtylyov
Hello. On 31-05-2013 9:20, Joe Perches wrote: Why not text:%#lx as already used in this string? It's equivalent to 0x%lx. Well, I don't know the reasoning in this case, but I'd like to note that those are not strictly equivalent. Personally I find the formatting of 0 annoying enough

Re: [net-next rfc V2 6/8] macvtap: allow TUNSETIFF to create multiqueue device

2013-05-31 Thread Sergei Shtylyov
Hello. On 31-05-2013 13:53, Jason Wang wrote: Though the queue were in fact created by open(), we still need to add this check to be compatible with tuntap which can let mgmt software use a single API to manage queues. This patch only validates the device name and moves the TUNSETIFF to a

Re: [PATCH] net: skbuff: use _RET_IP_

2013-05-31 Thread Sergei Shtylyov
Hello. On 05/31/2013 08:54 PM, Joe Perches wrote: Don't use a standalone gcc compiled program to determine what the kernel outputs. [] The kernel output is; printk(0x%lx\n, 0x100ul)0x100 printk(%p\n, (void *)0x100ul) 0100 printk(%#p\n,

Re: [PATCH] usb: musb: Fix format specifier warning

2013-05-31 Thread Sergei Shtylyov
Hello. On 06/01/2013 12:22 AM, Emil Goode wrote: This patch fixes a format specifier warning. dma_addr_t can be either u32 or u64 so we should cast to the largest type and change the format specifier to %llx. The addition of urb-transfer_dma and urb-actual_length is also done a few lines

Re: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx

2013-06-01 Thread Sergei Shtylyov
Hello. On 24-05-2013 9:34, B, Ravi wrote: + phy1: usbphy-gs70@44e10620 { + compatible = ti,dsps-usbphy; + reg = 0x44e10620 0x8 + 0x44e10648 0x4; + reg-names = phy_ctrl,phy_wkup; +

Re: [PATCH 04/10] usb: musb: ux500: harden checks for platform data

2013-04-23 Thread Sergei Shtylyov
Hello. On 04/23/2013 07:03 PM, Lee Jones wrote: In its current state, the ux500-musb driver uses platform data pointers blindly with no prior checking. If no platform data pointer is passed this will Oops the kernel. In this patch we ensure platform data and board data are present prior to

Re: [PATCH 04/10] usb: musb: ux500: harden checks for platform data

2013-04-24 Thread Sergei Shtylyov
Hello. On 24-04-2013 10:53, Lee Jones wrote: struct musb_hdrc_platform_data *plat = dev-platform_data; - struct ux500_musb_board_data *data = plat-board_data; + struct ux500_musb_board_data *data; - param_array = data-dma_rx_param_array; + param_array =

Re: [PATCH] ARM: davinci: dma: Convert to devm_* api

2013-05-16 Thread Sergei Shtylyov
Hello. On 16-05-2013 10:58, Lad Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com Use devm_ioremap_resource instead of reques_mem_region()/ioremap() and devm_request_irq() instead of request_irq(). This ensures more consistent error values and simplifies error paths.

Re: [PATCH 1/5] davinci: net: cpdma: remove unwanted header file incusion and sort thme alphabetically

2013-05-16 Thread Sergei Shtylyov
Hello. On 16-05-2013 11:30, Lad Prabhakar wrote: s/incusion/inclusion/, s/thme/them/ in the subject. Though instead of them it would be better to write headers. From: Lad, Prabhakar prabhakar.cse...@gmail.com Changelog won't hurt here... which unwanted #include's you are removing

Re: [PATCH 2/5] net: davinci_emac: remove unwanted header inclusion and sort the alphabetically

2013-05-16 Thread Sergei Shtylyov
On 16-05-2013 11:30, Lad Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch removes unwanted header inclusion Why are they unwanted? and sorts them alphabetically In the subject you typed the instead of them. Signed-off-by: Lad, Prabhakar

Re: [PATCH 5/5] net: davinci_mdio: trivial cleanup

2013-05-16 Thread Sergei Shtylyov
On 16-05-2013 11:30, Lad Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com remove unwanted header inclusion and sort the alphabetically s/the/them/. also guard the davinci_mdio_of_mtable table and davinci_mdio_probe_dt() with CONFIG_OF. Saying also in the changelog

Re: [PATCH] linux/of_platform.h: fix compilation warnings with DT disabled

2013-05-16 Thread Sergei Shtylyov
help... Reported-by: Vladimir Barinov vladimir.bari...@cogentembedded.com Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Reviewed-by: Simon Horman horms+rene...@verge.net.au Grant, could you consider taking this patch? Yes, I can, but I don't seem to have the original patch. Can

Re: [PATCH 15/19] drivers/net/irda: add missing platform_driver owner

2013-05-21 Thread Sergei Shtylyov
Hello. On 21-05-2013 6:42, Libo Chen wrote: set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/net/irda/bfin_sir.c |1 + drivers/net/irda/sh_irda.c|1 +

Re: [PATCH 18/19] drivers/net/ethernet/marvell: add missing platform_driver owne

2013-05-21 Thread Sergei Shtylyov
Hello. On 21-05-2013 6:42, Libo Chen wrote: set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/net/ethernet/marvell/mvneta.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

Re: [PATCH 02/11] gpio: davinci: coding style correction

2013-05-22 Thread Sergei Shtylyov
Hello. On 22-05-2013 11:10, Philip Avinash wrote: 1. Corrects coding and commenting styles 2. Variables name change to meaningful name 3. Remove unnecessary variable usage 4. Add BINTEN macro definition Signed-off-by: Philip Avinash avinashphi...@ti.com --- drivers/gpio/gpio-davinci.c |

Re: [PATCH -resend 1/6] mISDN: Add support for group membership check

2013-05-22 Thread Sergei Shtylyov
Hello. On 22-05-2013 16:59, Jiri Slaby wrote: From: Jeff Mahoney je...@suse.com This patch adds a module parameter to allow a group access to the mISDN devices. Otherwise, unpriviledged users on systems with ISDN hardware have the ability to dial out, potentially causing expensive bills.

Re: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue

2013-05-23 Thread Sergei Shtylyov
Hello. On 23-05-2013 10:01, Ravi Babu wrote: removed unused nop xceiv (un_)register API's from all musb platform drivers Since when are they unused? Signed-off-by: Ravi Babu ravib...@ti.com WBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the

Re: [PATCH v1 7/9] usb: musb: dsps: use get-usb-phy by phandle for multi instance

2013-05-23 Thread Sergei Shtylyov
On 23-05-2013 10:01, Ravi Babu wrote: In case of mutli instance support, use get-phy object using phandle to return to repsective phy xceiv object for each instance Only respective and s/xceiv/transceiver/. Signed-off-by: Ravi Babu ravib...@ti.com WBR, Sergei -- To unsubscribe from

Re: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx

2013-05-23 Thread Sergei Shtylyov
On 23-05-2013 10:01, Ravi Babu wrote: The am33xx platforms suppors dual musb instance which need two instances of usb-phy. Add dual instance usb-phy DT bindings for am333x platform. Signed-off-by: Ravi Babu ravib...@ti.com --- arch/arm/boot/dts/am33xx.dtsi | 17 + 1

Re: [net-next RFC 3/8] macvtap: introduce macvtap_get_vlan()

2013-05-23 Thread Sergei Shtylyov
Hello. On 23-05-2013 7:12, Jason Wang wrote: Factor out the device holding logic to a macvtap_get_vlan(), this will be also used by multiqueue API. Signed-off-by: Jason Wang jasow...@redhat.com --- drivers/net/macvtap.c | 26 +++--- 1 files changed, 19

Re: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx

2013-05-23 Thread Sergei Shtylyov
Hello. On 05/23/2013 09:13 PM, B, Ravi wrote: + phy1: usbphy-gs70@44e10620 { + compatible = ti,dsps-usbphy; + reg = 0x44e10620 0x8 + 0x44e10648 0x4; + reg-names = phy_ctrl,phy_wkup; +

Re: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue

2013-05-23 Thread Sergei Shtylyov
Hello. On 05/23/2013 09:07 PM, B, Ravi wrote: removed unused nop xceiv (un_)register API's from all musb platform drivers Since when are they unused? Please refer to commit id 662dca54 : usb: otg: support for multiple transceivers by a single controller. Usb_get_phy() is used to get the

Re: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue

2013-05-24 Thread Sergei Shtylyov
Hello. On 24-05-2013 9:34, B, Ravi wrote: removed unused nop xceiv (un_)register API's from all musb platform drivers Since when are they unused? Please refer to commit id 662dca54 : usb: otg: support for multiple transceivers by a single controller. Usb_get_phy() is used to get

Re: [PATCH] usbfs: Increase arbitrary limit for USB 3 isopkt length

2013-05-24 Thread Sergei Shtylyov
Hello. On 24-05-2013 12:47, Federico Manzan wrote: Increase the current arbitrary limit for isocronous packet size to a value large enough to account for USB 3.0 super bandwidth streams, bMaxBurst (0~15 allowed, 1~16 packets) bmAttributes (bit 1:0, mult 0~2, 1~3 packets) so the size max for

Re: [PATCH 1/3] drivers: regulator: palmas: add an API to set/clear the switch bit on SMPS10

2013-05-24 Thread Sergei Shtylyov
Hello. On 24-05-2013 18:31, Kishon Vijay Abraham I wrote: From: Graeme Gregory g...@slimlogic.co.uk Added an API to set/clear the switch bit on SMPS10 which can be used by palmas usb. The switch bit should be set in order for palmas to supply VBUS and is needed when OMAP is acting as USB

Re: [PATCH v2 2/5] media: davinci: vpif: Convert to devm_* api

2013-05-26 Thread Sergei Shtylyov
Hello. On 26-05-2013 4:49, Laurent Pinchart wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com Use devm_ioremap_resource instead of reques_mem_region()/ioremap(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar

Re: [PATCH v3 2/9] media: davinci: vpif: Convert to devm_* api

2013-05-26 Thread Sergei Shtylyov
Hello. On 26-05-2013 16:00, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com Use devm_ioremap_resource instead of reques_mem_region()/ioremap(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar

Re: [PATCH v3 4/9] media: davinci: vpif_capture: move the freeing of irq and global variables to remove()

2013-05-26 Thread Sergei Shtylyov
Hello. On 26-05-2013 16:00, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com Ideally the freeing of irq's and the global variables needs to be done in the remove() rather than module_exit(), this patch moves the freeing up of irq's and freeing the memory allocated to

Re: [Patch v1] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-26 Thread Sergei Shtylyov
Hello. On 26-05-2013 17:17, atom...@redhat.com wrote: From: Aaron Tomlin atom...@redhat.com Failed GFP_ATOMIC allocations by the network stack result in dropped packets, which will be received on a subsequent retransmit, and an unnecessary, noisy warning with a kernel backtrace. These

Re: [PATCH 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once

2013-05-27 Thread Sergei Shtylyov
Hello. On 27-05-2013 0:35, Aaro Koskinen wrote: When booting a new board for the first time, the console is flooded with Unknown board messages. This is not really helpful. Board type is not going to change after the boot, so it's sufficient to print the warning only once. Signed-off-by:

Re: [PATCH v8, part3 12/14] mm: correctly update zone-mamaged_pages

2013-05-27 Thread Sergei Shtylyov
On 26-05-2013 17:38, Jiang Liu wrote: Typo in the subject: s/mamaged_pages/managed_pages/. Enhance adjust_managed_page_count() to adjust totalhigh_pages for highmem pages. And change code which directly adjusts totalram_pages to use adjust_managed_page_count() because it adjusts

Re: [PATCH 2/2] USB: hcd: only unmap the actual completed DMA buffer

2013-05-27 Thread Sergei Shtylyov
Hello. On 27-05-2013 20:13, Ming Lei wrote: This patch only unmap the actual completed DMA buffer instead of the whole transfer buffer. Who will unmap the rest of the buffer? It is common to see only part of DMA transfer is completed, especially in case of DMA_FROM_DEVICE because the

Re: [PATCH 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once

2013-05-27 Thread Sergei Shtylyov
On 27-05-2013 14:19, Sergei Shtylyov wrote: When booting a new board for the first time, the console is flooded with Unknown board messages. This is not really helpful. Board type is not going to change after the boot, so it's sufficient to print the warning only once. Signed-off-by: Aaro

Re: [Patch v1] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-27 Thread Sergei Shtylyov
Hello. On 26-05-2013 20:28, Sergei Shtylyov wrote: From: Aaron Tomlin atom...@redhat.com Failed GFP_ATOMIC allocations by the network stack result in dropped packets, which will be received on a subsequent retransmit, and an unnecessary, noisy warning with a kernel backtrace

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-27 Thread Sergei Shtylyov
Hello. On 27-05-2013 0:19, atom...@redhat.com wrote: From: Aaron Tomlin atom...@redhat.com Since v1: - Removed unnecessary parentheses The changes since version X section should typically go after --- tearline, else the mainatiner will have to edit your patch before applying.

Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Sergei Shtylyov
Hello. On 22-05-2013 7:30, Libo Chen wrote: when omap_get_control_dev faild, we should release related platform_device * Changelog from v1: * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei sergei.shtyl...@cogentembedded.com It seems you've actually replaced

Re: [PATCH] net/core/sock.c: add missing VSOCK string in af_family_*_key_strings

2013-05-28 Thread Sergei Shtylyov
Hello. On 28-05-2013 19:02, Federico Vaga wrote: The three arrays of strings: af_family_kay_strings, s/kay/key/. Maybe whoever applies this could fix the typo... af_family_slock_key_strings and af_family_clock_key_strings have not VSOCK's string Signed-off-by: Federico Vaga

Re: [PATCH 02/12] clocksource: sh_mtu2: Add clk_prepare/unprepare support

2013-10-29 Thread Sergei Shtylyov
Hello. On 29-10-2013 2:49, Laurent Pinchart wrote: Prepare the clock at probe time, as there is no other appropriate place in the driver where we're allowed to sleep. Cc: Daniel Lezcano daniel.lezc...@linaro.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Laurent Pinchart

Re: [PATCH 03/12] clocksource: sh_tmu: Add clk_prepare/unprepare support

2013-10-29 Thread Sergei Shtylyov
On 29-10-2013 2:49, Laurent Pinchart wrote: Prepare the clock at probe time, as there is no other appropriate place in the driver where we're allowed to sleep. Cc: Daniel Lezcano daniel.lezc...@linaro.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Laurent Pinchart

Re: [PATCH] drivers/net: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

2013-11-01 Thread Sergei Shtylyov
Hello. On 01-11-2013 14:00, Duan Jiong wrote: This patch fixes coccinelle error regarding usage of IS_ERR and PTR_ERR instead of PTR_ERR_OR_ZERO. Signed-off-by: Duan Jiong duanj.f...@cn.fujitsu.com --- drivers/net/appletalk/ipddp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

Re: [PATCH v2 9/9] ARM: dts: add usb udc support to bcm281xx

2013-11-01 Thread Sergei Shtylyov
Hello. On 11/01/2013 10:45 PM, Matt Porter wrote: Adds USB OTG/PHY and clock support to BCM281xx and enables UDC support on the bcm11351-brt and bcm28155-ap boards. Signed-off-by: Matt Porter matt.por...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org Reviewed-by: Tim Kryger

Re: [PATCH] davinci_emac.c: Fix IFF_ALLMULTI setup

2013-10-21 Thread Sergei Shtylyov
Hello. On 10/21/2013 08:59 PM, Mariusz Ceier wrote: When IFF_ALLMULTI flag is set on interface and IFF_PROMISC isn't, emac_dev_mcast_set should only enable RX of multicasts and reset MACHASH registers. It does this, but afterwards it either sets up multicast MACs filtering or disables RX of

Re: [PATCH] ARM: dts: am4372: Add McASP nodes

2013-10-21 Thread Sergei Shtylyov
Hello. On 10/21/2013 01:45 PM, Peter Ujfalusi wrote: Add nodes for McASP0 and McASP1 for AM43xx. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/boot/dts/am4372.dtsi | 27 +++ 1 file changed, 27 insertions(+) diff --git

Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls

2013-10-09 Thread Sergei Shtylyov
shdma_free_irq() calls. Tested-by: Simon Horman horms+rene...@verge.net.au Reported-by: Simon Horman ho...@verge.net.au Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Vinod, could you consider taking this and the following patch as a fix for v3.12? Vinod, may I ask when

Re: [RFC 17/42] drivers/net/ethernet/renesas: don't check resource with devm_ioremap_resource

2013-05-10 Thread Sergei Shtylyov
Hello. On 10-05-2013 12:17, Wolfram Sang wrote: devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de Acked-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com WBR, Sergei

Re: [PATCH v2 4/4] net: phy: realtek: cleanup code

2013-05-10 Thread Sergei Shtylyov
Hello. On 10-05-2013 11:29, Jongsung Kim wrote: This patch cleans up the drivers code by: - using a consistent way to reference functions - removing unused macro-definitions - removing unnecessary new-lines - making ack_interrupt functions shorter. Signed-off-by: Jongsung Kim

Re: [PATCH v3 08/10] usb: phy: tegra: Add error handling clean up.

2013-05-10 Thread Sergei Shtylyov
Hello. On 05/10/2013 05:54 PM, Venu Byravarasu wrote: Check return values from all GPIO APIs and handle errors accordingly. Remove the call to clk_disable_unprepare(); this function does not prepare or enable the clock, so the error path should not disable or unprepare it. Signed-off-by:

Re: [PATCH] IDE: bugfix of IDE PIO size calculation

2013-05-10 Thread Sergei Shtylyov
Hello. On 05/10/2013 10:47 PM, Leonid Yegoshin wrote: IDE PIO calculates size wrong. Proven by test on MIPS Malta platform with multiple CPU types with bootparam flag ide-core.nodma=0.0. It is still needed to test non-DMA IO. Change-Id: Id82c2bc5965d85960846db53d84846d9a05d75a3 Please

Re: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-11 Thread Sergei Shtylyov
Hello. On 11-05-2013 18:02, Dong Zhu wrote: From e6a55411486de8a09b859e73140bf35c0ee36047 Mon Sep 17 00:00:00 2001 From: Dong Zhu bluezhud...@gmail.com Date: Sat, 11 May 2013 21:44:54 +0800 Subject: [PATCH] igb: add a method to get the nic hw time stamping policy Please, don't send this

Re: [PATCH v6, part3 15/16] mm: report available pages as MemTotal for each NUMA node

2013-05-11 Thread Sergei Shtylyov
Hello. On 05/11/2013 09:34 PM, Jiang Liu wrote: I've noticed a small typo in the changelog. As reported by https://bugzilla.kernel.org/show_bug.cgi?id=53501, MemTotal from /proc/meminfo means memory pages managed by the buddy system (managed_pages), but MemTotal from

Re: [RFC 17/42] drivers/net/ethernet/renesas: don't check resource with devm_ioremap_resource

2013-05-11 Thread Sergei Shtylyov
Hello. On 05/10/2013 03:07 PM, Sergei Shtylyov wrote: devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de Acked-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com I was too

Re: [RFC 17/42] drivers/net/ethernet/renesas: don't check resource with devm_ioremap_resource

2013-05-11 Thread Sergei Shtylyov
Hello. On 05/10/2013 12:17 PM, Wolfram Sang wrote: devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/net/ethernet/renesas/sh_eth.c | 14 +- 1 file changed, 1

Re: [RFC 17/42] drivers/net/ethernet/renesas: don't check resource with devm_ioremap_resource

2013-05-12 Thread Sergei Shtylyov
Hello. On 12-05-2013 13:42, Wolfram Sang wrote: You should really compile-test your patches. Easier said than done with a cleanup series touching various platforms and architectures. If there are already solutions how to find a .config compiling the source file modified, I am all ears.

<    2   3   4   5   6   7   8   9   10   11   >