Re: [RFC] Create test script(s?) for regression testing

On 11/07/2018 12:10 PM, Mauro Carvalho Chehab wrote: > Em Wed, 07 Nov 2018 12:06:55 +0200 > Laurent Pinchart escreveu: > >> Hi Hans, >> >> On Wednesday, 7 November 2018 10:05:12 EET Hans Verkuil wrote: >>> On 11/06/2018 08:58 PM, Laurent Pinchart wrote: On Tuesday, 6 November 2018

Re: [PATCH] media: rc: self test for IR encoders and decoders

IR encoders and decoders themselves. > > No hardware is required for this test. > > Signed-off-by: Sean Young > Cc: Shuah Khan Hi Sean, This looks good. I will get this into the next release. It will show up in linux-kselftest next after 4.20-rc1 comes out. thanks, -- Shuah

Re: [PATCH 2/2] media: rc: self test for IR encoders and decoders

Hi Sean, Thanks for the patch. I just happened to see this when Mauro sent it to me. Doesn't look like linux-ksefltest and I weren't on the patch? On 07/17/2018 03:33 PM, Sean Young (by way of Mauro Carvalho Chehab ) wrote: > ir-loopback can transmit IR on one rc device and check the correct >

Re: [RFC] Make entity to interface links immutable

Hi Mauro and Hans, On 07/02/2018 03:41 AM, Mauro Carvalho Chehab wrote: > Em Mon, 2 Jul 2018 10:18:37 +0200 > Hans Verkuil escreveu: > >> While working on v4l2-compliance I noticed that entity to interface links >> have just the MEDIA_LNK_FL_ENABLED flag set. >> >> Shouldn't we also set the

[PATCH v2] media: v4l2-core: v4l2-mc: Add SPDX license identifier

Replace GPL license statement with SPDX GPL-2.0 license identifier. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- Changes since v1: - Fixed SPDX comment format - Fixed SPDX license text to eliminate change in license. It now reads GPL-2.0-or-later to maintain the original. d

Re: [PATCH] media: v4l2-core: v4l2-mc: Add SPDX license identifier

On 01/11/2018 02:33 PM, Laurent Pinchart wrote: > Hi Shuah, > > On Thursday, 11 January 2018 22:44:08 EET Shuah Khan wrote: >> On 01/11/2018 11:42 AM, Laurent Pinchart wrote: >>> On Thursday, 11 January 2018 17:45:15 EET Shuah Khan wrote: >>>> On 01/11/2

Re: [PATCH] media: v4l2-core: v4l2-mc: Add SPDX license identifier

On 01/11/2018 11:42 AM, Laurent Pinchart wrote: > Hi Shuah, > > On Thursday, 11 January 2018 17:45:15 EET Shuah Khan wrote: >> On 01/11/2018 05:55 AM, Laurent Pinchart wrote: >>> On Wednesday, 10 January 2018 18:35:36 EET Shuah Khan wrote: >>>> Replace GPL

Re: [PATCH] media: v4l2-core: v4l2-mc: Add SPDX license identifier

On 01/11/2018 05:55 AM, Laurent Pinchart wrote: > Hi Shuah, > > Thank you for the patch. > > On Wednesday, 10 January 2018 18:35:36 EET Shuah Khan wrote: >> Replace GPL license statement with SPDX GPL-2.0 license identifier. >> >> Signed-off-by: Sh

[PATCH] media: v4l2-core: v4l2-mc: Add SPDX license identifier

Replace GPL license statement with SPDX GPL-2.0 license identifier. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- drivers/media/v4l2-core/v4l2-mc.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-mc.c b/drivers/medi

Re: [PATCH v2 1/2] media: exynos-gsc: fix lockdep warning

On 11/07/2017 09:53 AM, Shuah Khan wrote: > On 10/16/2017 09:18 AM, Hans Verkuil wrote: >> On 10/16/2017 05:16 PM, Shuah Khan wrote: >>> The driver mmap functions shouldn't take lock when calling vb2_mmap(). >>> Fix it to not take the lock. &g

Re: [PATCH v2 1/2] media: exynos-gsc: fix lockdep warning

On 10/16/2017 09:18 AM, Hans Verkuil wrote: > On 10/16/2017 05:16 PM, Shuah Khan wrote: >> The driver mmap functions shouldn't take lock when calling vb2_mmap(). >> Fix it to not take the lock. >> >> Reference: commit log for f035eb4e976ef

[PATCH v2 2/2] media: s5p-mfc: fix lock confection - request_firmware() once and keep state

lock(>i_mutex_dir_key#2); [ 552.456329]lock(>mmap_sem); [ 552.46] lock(>mfc_mutex); [ 552.465775] *** DEADLOCK *** Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- drivers/media/platform/s5p-mfc/s5p_mfc.c

[PATCH v2 1/2] media: s5p-mfc: remove firmware buf null check in s5p_mfc_load_firmware()

s5p_mfc_load_firmware() will not get called if fw_buf.virt allocation fails. The allocation happens very early on in the probe routine and probe fails if allocation fails. There is no need to check if it is null in s5p_mfc_load_firmware(). Remove the check. Signed-off-by: Shuah Khan <s

[PATCH v2 0/2] Fix s5p-mfc lock contention in request firmware paths

ase it works. Shuah Khan (2): media: s5p-mfc: remove firmware buf null check in s5p_mfc_load_firmware() media: s5p-mfc: fix lock confection - request_firmware() once and keep state drivers/media/platform/s5p-mfc/s5p_mfc.c| 6 ++ drivers/media/platform/s5p-mfc/s5p_mfc_common.h |

Re: [PATCH 2/2] media: s5p-mfc: fix lock confection - request_firmware() once and keep state

On 11/02/2017 06:43 PM, Marian Mihailescu wrote: > I can confirm, with this patch, there is always error loading MFC in > boot log, since FS is not mounted. > > -Marian > Please refrain from top posting to a kernel email threads. It is very difficult to follow. Bottom post is the norm. thanks,

Re: [PATCH 2/2] media: s5p-mfc: fix lock confection - request_firmware() once and keep state

On 11/02/2017 02:31 AM, Andrzej Hajda wrote: > On 06.10.2017 23:30, Shuah Khan wrote: >> Driver calls request_firmware() whenever the device is opened for the >> first time. As the device gets opened and closed, dev->num_inst == 1 >> is true several times. This is not nece

Re: [PATCH 1/2] media: s5p-mfc: check for firmware allocation before requesting firmware

On 11/02/2017 02:12 AM, Andrzej Hajda wrote: > Hi Shuah, > > On 06.10.2017 23:30, Shuah Khan wrote: >> Check if firmware is allocated before requesting firmware instead of >> requesting firmware only to release it if firmware is not allocated. >> >>

Re: [PATCH 0/2] Fix s5p-mfc lock contention in request firmware paths

't have the unused warn problem. I fixed the problem in media: s5p-mfc: fix lockdep warning patch that has the warning and sent v2. > On Thu, Oct 26, 2017 at 7:54 AM, Shuah Khan <shua...@osg.samsung.com> wrote: >> On 10/06/2017 03:30 PM, Shuah Khan wrote: >>> This patch seri

[PATCH v2] media: s5p-mfc: fix lockdep warning

ap_pgoff+0x90/0xb8) [ 2106.512260] [] (vm_mmap_pgoff) from [] (SyS_mmap_pgoff+0x90/0xc0) [ 2106.520059] [] (SyS_mmap_pgoff) from [] (ret_fast_syscall+0x0/0x28) Signed-off-by: Shuah Khan <shua...@osg.samsung.com> Suggested-by: Hans Verkuil <hansv...@cisco.com> Acked-by: Marek Szyprow

Re: [PATCH 0/2] Fix s5p-mfc lock contention in request firmware paths

On 10/25/2017 04:28 PM, Marian Mihailescu wrote: > Hi Shuah, > > For MFC patch, you can delete the "dev" variable since it's not being > used anymore and results in a compile warning. > > - struct s5p_mfc_dev *dev = ctx->dev; > > Cheers, > Marian Oops. I thought I handled that. I will fix that

Re: [PATCH 0/2] Fix s5p-mfc lock contention in request firmware paths

On 10/06/2017 03:30 PM, Shuah Khan wrote: > This patch series fixes inefficiencies and lock contention in the request > firmware paths. > > Shuah Khan (2): > media: s5p-mfc: check for firmware allocation before requesting > firmware > media: s5p-mfc: fix lock confecti

Re: Exynos MFC issues on 4.14-rc4

On Mon, Oct 16, 2017 at 7:11 AM, Marek Szyprowski wrote: > Hi Marian, > > On 2017-10-12 02:49, Marian Mihailescu wrote: >> >> I've been testing 4.14-rc4 on Odroid-XU4, and here's a kernel >> complaint when running: >> >> gst-launch-1.0 filesrc

Re: [PATCH 0/2] fix lockdep warnings in s5p_mfc and exynos-gsc vb2 drivers

Hi Marek, On 10/16/2017 06:48 AM, Marek Szyprowski wrote: > Hi Shuah, > > On 2017-10-14 01:13, Shuah Khan wrote: >> Driver mmap functions shouldn't hold lock when calling vb2_mmap(). The >> vb2_mmap() function has its own lock that it uses to protect the critical >&g

[PATCH 0/2] fix lockdep warnings in s5p_mfc and exynos-gsc vb2 drivers

Driver mmap functions shouldn't hold lock when calling vb2_mmap(). The vb2_mmap() function has its own lock that it uses to protect the critical section. Reference: commit log for f035eb4e976ef5a059e30bc91cfd310ff030a7d3 Shuah Khan (2): media: exynos-gsc: fix lockdep warning media: s5p-mfc

[PATCH 1/2] media: exynos-gsc: fix lockdep warning

rom [] (SyS_mmap_pgoff+0x90/0xc0) [ 1991.309977] [] (SyS_mmap_pgoff) from [] (ret_fast_syscall+0x0/0x28) Signed-off-by: Shuah Khan <shua...@osg.samsung.com> Suggested-by: Hans Verkuil <hansv...@cisco.com> --- drivers/media/platform/exynos-gsc/gsc-m2m.c | 5 - 1 file changed, 5 deletions(-

[PATCH 2/2] media: s5p-mfc: fix lockdep warning

ap_pgoff+0x90/0xb8) [ 2106.512260] [] (vm_mmap_pgoff) from [] (SyS_mmap_pgoff+0x90/0xc0) [ 2106.520059] [] (SyS_mmap_pgoff) from [] (ret_fast_syscall+0x0/0x28) Signed-off-by: Shuah Khan <shua...@osg.samsung.com> Suggested-by: Hans Verkuil <hansv...@cisco.com> --- drivers/media/platf

Re: [ANN] Call for topics for the media mini-summit on Friday Oct 27 in Prague

On 10/13/2017 09:05 AM, Hans Verkuil wrote: > On 10/13/17 16:43, Shuah Khan wrote: >> Hi Hans, >> >> On 10/13/2017 01:36 AM, Hans Verkuil wrote: >>> Hi Shuah, >>> >>> On 10/05/2017 03:53 PM, Shuah Khan wrote: >>>> Hi Hans/Gustavo. >

Re: [ANN] Call for topics for the media mini-summit on Friday Oct 27 in Prague

Hi Hans, On 10/13/2017 01:36 AM, Hans Verkuil wrote: > Hi Shuah, > > On 10/05/2017 03:53 PM, Shuah Khan wrote: >> Hi Hans/Gustavo. >> >> On Wed, Oct 4, 2017 at 1:34 PM, Gustavo Padovan <gust...@padovan.org> wrote: >>> Hi Hans, >>> >>>

[PATCH 1/2] media: s5p-mfc: check for firmware allocation before requesting firmware

Check if firmware is allocated before requesting firmware instead of requesting firmware only to release it if firmware is not allocated. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 10 +- 1 file changed, 5 insertions

[PATCH 0/2] Fix s5p-mfc lock contention in request firmware paths

This patch series fixes inefficiencies and lock contention in the request firmware paths. Shuah Khan (2): media: s5p-mfc: check for firmware allocation before requesting firmware media: s5p-mfc: fix lock confection - request_firmware() once and keep state drivers/media/platform/s5p

[PATCH 2/2] media: s5p-mfc: fix lock confection - request_firmware() once and keep state

lock(>i_mutex_dir_key#2); [ 552.456329]lock(>mmap_sem); [ 552.46] lock(>mfc_mutex); [ 552.465775] *** DEADLOCK *** Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- drivers/media/platform/s5p-mfc/s5p_mfc.c

Re: [ANN] Call for topics for the media mini-summit on Friday Oct 27 in Prague

Hi Hans/Gustavo. On Wed, Oct 4, 2017 at 1:34 PM, Gustavo Padovan wrote: > Hi Hans, > > > > On Fri, Sep 1, 2017 at 6:46 AM, Hans Verkuil wrote: >> Hi all, >> >> We are organizing a media mini-summit on Friday October 27 in Prague, >> co-located >> with

Re: [RFC 5/5] pm: remove kernel thread freezing

On Tue, Oct 3, 2017 at 3:00 PM, Jiri Kosina wrote: > On Tue, 3 Oct 2017, Pavel Machek wrote: > >> > Again, I agree that the (rare) kthreads that are actually "creating" new >> > I/O have to be somehow frozen and require special care. >> >> Agreed. Was any effort made to identify

Re: s5p-mfc - WARNING: possible circular locking dependency detected,[ 4.14.0-rc2

On 09/26/2017 02:10 PM, Shuah Khan wrote: > When running gstreamer pipeline with s5p-mfc → exynos-gsc→ exynos-drm, > I am seeing circular locking dependency detected warning in 4.14-rc2. > This is a regression from 4.13. The pipeline does run to completion > video streaming works. A

s5p-mfc - WARNING: possible circular locking dependency detected,[ 4.14.0-rc2

off) from [] (SyS_mmap_pgoff+0x90/0xc0) [ 2135.437054] [] (SyS_mmap_pgoff) from [] (ret_fast_syscall+0x0/0x28) thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shua...@osg.samsung.com

Re: [PATCH 18/25] media: dvb_frontend: get rid of dtv_get_property_dump()

On 09/20/2017 01:11 PM, Mauro Carvalho Chehab wrote: > Simplify the get property handling and move it to the existing > code at dtv_property_process_get() directly. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/dvb-core/dvb_frontend.c | 43 >

Re: [PATCH 17/25] media: dvb_frontend: dtv_property_process_set() cleanups

eam_id = data; > break; > > /* ATSC-MH */ > case DTV_ATSCMH_PARADE_ID: > - fe->dtv_property_cache.atscmh_parade_id = tvp->u.data; > + fe->dtv_property_cache.atscmh_parade_id = data; > break; > case DTV_ATSCMH_RS_FRAME_ENSEMBLE: > - fe->dtv_property_cache.atscmh_rs_frame_ensemble = tvp->u.data; > + fe->dtv_property_cache.atscmh_rs_frame_ensemble = data; > break; > > case DTV_LNA: > - c->lna = tvp->u.data; > + c->lna = data; > if (fe->ops.set_lna) > r = fe->ops.set_lna(fe); > if (r < 0) > @@ -2137,7 +2154,9 @@ static int dvb_frontend_handle_ioctl(struct file *file, > return PTR_ERR(tvp); > > for (i = 0; i < tvps->num; i++) { > - err = dtv_property_process_set(fe, tvp + i, file); > + err = dtv_property_process_set(fe, file, > + (tvp + i)->cmd, > + (tvp + i)->u.data); > if (err < 0) { > kfree(tvp); > return err; > The rest looks good. Once the other comments are addressed and/or explained. Reviewed-by: Shuah Khan <shua...@osg.samsung.com> thanks, -- Shuah

Re: [PATCH 02/25] media: dvb_frontend: fix return values for FE_SET_PROPERTY

uld fix the above, it could cause regressions. > > So, let's just assume what the code really does, updating > the documentation accordingly and removing the logic that > would update the discarded tvp->result. > > Signed-off-by: Mauro Carvalho Chehab <mche...

Re: [PATCH 01/25] media: dvb_frontend: better document the -EPERM condition

gt; + && (_IOC_DIR(cmd) != _IOC_READ > + || cmd == FE_GET_EVENT > + || cmd == FE_DISEQC_RECV_SLAVE_REPLY)) { > up(>sem); > return -EPERM; > } > Same comment from your previous series. I started looking at the old series and now the latest. Didn't realize the series has been revised. :( Looks good to me Reviewed by: Shuah Khan <shua...@osg.samsung.com> thanks, -- Shuah

Re: [PATCH 5/6] media: dvb_frontend: better document the -EPERM condition

gt; + && (_IOC_DIR(cmd) != _IOC_READ > + || cmd == FE_GET_EVENT > + || cmd == FE_DISEQC_RECV_SLAVE_REPLY)) { > up(>sem); > return -EPERM; > } > Looks good to me Reviewed by: Shuah Khan <shua...@osg.samsung.com> thanks, -- Shuah

Re: [PATCH 3/6] media: dvb_frontend: get rid of proprierty cache's state

ndicate when the properties > got flushed. > > So, just get rid of it for good. Okay now PATCH 2/3 makes sense. Looks good to me. Reviewed-by: Shuah Khan <shua...@osg.samsung.com> > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> > --- >

Re: [PATCH 2/6] media: dvb_frontend: cleanup ioctl handling logic

> + * different types (terrestrial and cable, for example), > + * a pure DVBv3 application won't be able to use all delivery > + * systems. Yet, changing the DVBv5 cache to the other delivery > + * system should be enough for making it work. > + */ > + switch (dvbv3_type(c->delivery_system)) { > + case DVBV3_QPSK: > + info->type = FE_QPSK; > + break; > + case DVBV3_ATSC: > + info->type = FE_ATSC; > + break; > + case DVBV3_QAM: > + info->type = FE_QAM; > + break; > + case DVBV3_OFDM: > + info->type = FE_OFDM; > + break; > + default: > + dev_err(fe->dvb->device, > + "%s: doesn't know how to handle a DVBv3 > call to delivery system %i\n", > + __func__, c->delivery_system); > + fe->ops.info.type = FE_OFDM; > + } > + dev_dbg(fe->dvb->device, "%s: current delivery system on cache: > %d, V3 type: %d\n", > + __func__, c->delivery_system, > fe->ops.info.type); > + > + /* Set CAN_INVERSION_AUTO bit on in other than oneshot mode */ > + if (!(fepriv->tune_mode_flags & FE_TUNE_MODE_ONESHOT)) > + info->caps |= FE_CAN_INVERSION_AUTO; > + err = 0; > break; > + } > > case FE_SET_FRONTEND: > err = dvbv3_set_delivery_system(fe); > @@ -2466,11 +2455,10 @@ static int dvb_frontend_ioctl_legacy(struct file > *file, > err = dtv_get_frontend(fe, , parg); > break; > } > - case FE_SET_FRONTEND_TUNE_MODE: > - fepriv->tune_mode_flags = (unsigned long) parg; > - err = 0; > - break; > - } > + > + default: > + return -ENOTSUPP; > + } /* switch */ > > return err; > } > Rest looks okay to me. With c->state issue addressed and/or explained: Reviewed-by: Shuah Khan <shua...@osg.samsung.com> thanks, -- Shuah

Re: [PATCH 1/6] media: dvb_frontend: cleanup dvb_frontend_ioctl_properties()

ult = err; > } > > if (copy_to_user((void __user *)tvps->props, tvp, >tvps->num * sizeof(struct dtv_property))) { > - err = -EFAULT; > - goto out; > + kfree(tvp); > + return -EFAULT; > } Could avoid duplicate code keeping out logic perhaps? Is there a reason for removing this? > - > - } else > - err = -EOPNOTSUPP; > - > -out: > - kfree(tvp); > - return err; > + kfree(tvp); > + break; > + } > + default: > + return -ENOTSUPP; > + } /* switch */ > + return 0; > } > > static int dtv_set_frontend(struct dvb_frontend *fe) > Reviewed-by: Shuah Khan <shua...@osg.samsung.com> thanks, -- Shuah

Re: [PATCH] dvb_frontend: initialize variable s with FE_NONE instead of 0

lt;colin.k...@canonical.com> The change looks good to me. Reviewed-by: Shuah Khan <shua...@osg.samsung.com> I think this patch should be part of a patch series that includes the uAPI Documentation change, uAPI change, and the following patch: [PATCH][V2] dvb_frontend: ensure that inital

Re: [PATCH][V2] dvb_frontend: ensure that inital front end status initialized

ff-by: Colin Ian King <colin.k...@canonical.com> Reviewed-by: Shuah Khan <shua...@osg.samsung.com> Looks good to me. Do you mind fixing dvb_frontend_swzigzag() as well. It currently initializes enum fe_status s = 0; in a separate patch. > --- > drivers/media/dvb-core/dvb_fronten

Re: [PATCH] [media] dvb_frontend: ensure that front end status is initialized

Hi Colin, On 07/20/2017 09:29 AM, Colin King wrote: > From: Colin Ian King > > The fe_status variable s is not initialized meaning it can have any > random garbage status. This could be problematic if fe->ops.tune is > false as s is not updated by the call to

Re: [PATCH 09/12] [media] vivid: mark vivid queues as ordered

On 06/16/2017 01:39 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > To enable vivid to be used with explicit synchronization we need > to mark its queues as ordered. > > Signed-off-by: Gustavo Padovan > --- >

Re: [PATCH 05/12] [media] vivid: assign the specific device to the vb2_queue->dev

On 06/16/2017 01:39 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Instead of assigning the global v4l2 device, assign the specific device. > This was causing trouble when using using V4L2 events with vivid > devices. The device's queue should be the same

Re: [PATCH 04/12] [media] uvc: enable subscriptions to other events

On 06/16/2017 01:39 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Call v4l2_ctrl_subscribe_event to subscribe to more events supported by > v4l. > > Signed-off-by: Gustavo Padovan > --- > drivers/media/usb/uvc/uvc_v4l2.c |

Re: [RFC 00/10] V4L2 explicit synchronization support

On 06/09/2017 12:25 AM, Gustavo Padovan wrote: > 2017-06-08 Shuah Khan <shuahk...@gmail.com>: > >> Hi Gustavo, >> >> On Thu, Jun 8, 2017 at 2:17 PM, Mauro Carvalho Chehab >> <mche...@osg.samsung.com> wrote: >>> Hi Gustavo, >>> >

Re: [RFC 00/10] V4L2 explicit synchronization support

Hi Gustavo, On Thu, Jun 8, 2017 at 2:17 PM, Mauro Carvalho Chehab wrote: > Hi Gustavo, > > Em Wed, 24 May 2017 21:31:01 -0300 > Gustavo Padovan escreveu: > >> Hi all, >> >> I've been working on the v2 of this series, but I think I hit a blocker >>

Re: [PATCH 5/9] [media] s5p-jpeg: Add IOMMU support

On Fri, Jun 2, 2017 at 10:02 AM, Thierry Escande wrote: > From: Tony K Nadackal > > This patch adds support for IOMMU s5p-jpeg driver if the Exynos IOMMU > and ARM DMA IOMMU configurations are supported. The address space is > created with size

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

Hi Sailus/Mauro, On 01/26/2017 02:10 AM, Mauro Carvalho Chehab wrote: > Em Wed, 25 Jan 2017 13:02:31 +0200 > Sakari Ailus escreveu: > >> Hi Mauro, >> >> On Tue, Jan 24, 2017 at 08:49:02AM -0200, Mauro Carvalho Chehab wrote: >>> Hi Sakari, >>> >>> Just returned this week

Re: [PATCH] arm: dma: fix sharing of coherent DMA memory without struct page

Hi Russell, and Marek, On 04/14/2017 03:46 AM, Russell King - ARM Linux wrote: > On Fri, Apr 14, 2017 at 09:56:07AM +0200, Marek Szyprowski wrote: This would be however quite large task, especially taking into account all current users of DMA-buf framework... >>> Yeah it will be a large

Re: [PATCH] arm: dma: fix sharing of coherent DMA memory without struct page

On 04/14/2017 03:46 AM, Russell King - ARM Linux wrote: > On Fri, Apr 14, 2017 at 09:56:07AM +0200, Marek Szyprowski wrote: This would be however quite large task, especially taking into account all current users of DMA-buf framework... >>> Yeah it will be a large task. >> >> Maybe once

Re: [PATCH] arm: dma: fix sharing of coherent DMA memory without struct page

On 04/06/2017 06:01 AM, Marek Szyprowski wrote: > Hi Shuah, > > On 2017-04-05 18:02, Shuah Khan wrote: >> When coherent DMA memory without struct page is shared, importer >> fails to find the page and runs into kernel page fault when it >> tries to dmabuf_ops_attach/

Re: [PATCH] arm: dma: fix sharing of coherent DMA memory without struct page

On 04/05/2017 05:14 PM, Russell King - ARM Linux wrote: > On Wed, Apr 05, 2017 at 10:02:42AM -0600, Shuah Khan wrote: >> When coherent DMA memory without struct page is shared, importer >> fails to find the page and runs into kernel page fault when it >> tries to dmabuf_ops_a

[PATCH] arm: dma: fix sharing of coherent DMA memory without struct page

force-modesetting=true I am sending RFC patch to get feedback on the approach and see if I missed anything. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- arch/arm/mm/dma-mapping.c | 34 ++ drivers/base/dma-coherent.c

Re: [RFC 00/10] V4L2 explicit synchronization support

Hi Gustavo, On Mon, Apr 3, 2017 at 1:46 PM, Javier Martinez Canillas wrote: > Hello Mauro and Gustavo, > > On 04/03/2017 07:16 AM, Mauro Carvalho Chehab wrote: >> Hi Gustavo, >> >> Em Mon, 13 Mar 2017 16:20:25 -0300 >> Gustavo Padovan escreveu: >>

Re: [RFC v2 07/11] vb2: dma-contig: Remove redundant sgt_base field

On Thu, Dec 15, 2016 at 6:24 PM, Laurent Pinchart wrote: > From: Sakari Ailus > > The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and > dma_sgt. The former is used by DMA-BUF buffers whereas the latter

Re: [RFC v2 05/11] v4l2-core: Don't sync cache for a buffer if so requested

On Thu, Dec 15, 2016 at 6:24 PM, Laurent Pinchart wrote: > From: Samu Onkalo > > The user may request to the driver (vb2) to skip the cache maintenance > operations in case the buffer does not need cache synchronisation, e.g. in >

Re: [RFC v2 03/11] vb2: Move cache synchronisation from buffer done to dqbuf handler

On Thu, Dec 15, 2016 at 6:24 PM, Laurent Pinchart wrote: > From: Sakari Ailus > > The cache synchronisation may be a time consuming operation and thus not > best performed in an interrupt which is a typical context for >

Re: [PATCH 14/15] media: s5p-mfc: Use preallocated block allocator always for MFC v6+

On 02/27/2017 05:50 AM, Marek Szyprowski wrote: > Hi Shuah, > > On 2017-02-24 15:23, Shuah Khan wrote: >> On Thu, Feb 23, 2017 at 11:26 PM, Marek Szyprowski >> <m.szyprow...@samsung.com> wrote: >>> On 2017-02-23 22:43, Shuah Khan wrote: >>>> On

Re: [PATCH 14/15] media: s5p-mfc: Use preallocated block allocator always for MFC v6+

Hi Marek, On Thu, Feb 23, 2017 at 11:26 PM, Marek Szyprowski <m.szyprow...@samsung.com> wrote: > Hi Shuah > > > > On 2017-02-23 22:43, Shuah Khan wrote: >> >> On Tue, Feb 14, 2017 at 12:52 AM, Marek Szyprowski >> <m.szyprow...@samsung.com> wrote: >

Re: [PATCH 14/15] media: s5p-mfc: Use preallocated block allocator always for MFC v6+

On Tue, Feb 14, 2017 at 12:52 AM, Marek Szyprowski wrote: > It turned out that all versions of MFC v6+ hardware doesn't have a strict > requirement for ALL buffers to be allocated on higher addresses than the > firmware base like it was documented for MFC v5. This

Re: [PATCH v2 08/15] media: s5p-mfc: Move firmware allocation to DMA configure function

On Mon, Feb 20, 2017 at 6:38 AM, Marek Szyprowski wrote: > To complete DMA memory configuration for MFC device, allocation of the > firmware buffer is needed, because some parameters are dependant on its base > address. Till now, this has been handled in the

Re: [PATCH v2 03/15] media: s5p-mfc: Replace mem_dev_* entries with an array

On Mon, Feb 20, 2017 at 6:38 AM, Marek Szyprowski wrote: > Internal MFC driver device structure contains two pointers to devices used > for DMA memory allocation: mem_dev_l and mem_dev_r. Replace them with the > mem_dev[] array and use defines for accessing particular

[PATCH v2] media: s5p_mfc print buf pointer in hex constistently

Fix s5p_mfc_set_dec_frame_buffer_v6() to print buffer pointer in hex to be consistent with the rest of the messages in the routine. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- Fixed commit log. No code changes. Thanks for the catch. drivers/media/platform/s5p-mfc/s5p_mfc_op

[PATCH] media: fix s5p_mfc_set_dec_frame_buffer_v6() to print buf size in hex

Fix s5p_mfc_set_dec_frame_buffer_v6() to print buffer size in hex to be consistent with the rest of the messages in the routine. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] media: s5p_mfc - remove unneeded io_modes initialzation in s5p_mfc_open()

Remove unneeded io_modes initialzation in s5p_mfc_open(). It gets done right below in vdev == dev->vfd_dec conditional. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/pla

Re: [PATCH] [media] exynos-gsc: Avoid spamming the log on VIDIOC_TRY_FMT

On 01/24/2017 02:42 PM, Javier Martinez Canillas wrote: > There isn't an ioctl to enum the supported field orders, so a user-space > application can call VIDIOC_TRY_FMT using different field orders to know > if one is supported. For example, GStreamer does this so during playback > dozens of the

Re: Media summit in Feb? - Was: Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

On Tue, Dec 20, 2016 at 6:31 PM, Mauro Carvalho Chehab wrote: > Em Mon, 19 Dec 2016 07:28:29 -0200 > Mauro Carvalho Chehab escreveu: > >> Em Fri, 16 Dec 2016 15:45:10 +0100 >> Hans Verkuil escreveu: >> >> > We really need a

Re: [RFC v3 21/21] omap3isp: Don't rely on devm for memory resource management

On 12/16/2016 06:32 AM, Sakari Ailus wrote: > Hi Laurent, > > On Thu, Dec 15, 2016 at 01:23:50PM +0200, Laurent Pinchart wrote: >>> @@ -1596,7 +1604,6 @@ static void isp_unregister_entities(struct isp_device >>> *isp) omap3isp_stat_unregister_entities(>isp_af); >>>

Re: [PATCH 1/2] media: omap3isp fix media_entity_cleanup() after media device unregister

On 12/15/2016 03:32 PM, Laurent Pinchart wrote: > Hello Shuah, > > Thank you for the patch. > > On Thursday 15 Dec 2016 12:40:07 Shuah Khan wrote: >> During unbind isp_remove() media_entity_cleanup() after it unregisters the > > I assume you meant "

Re: [PATCH 2/2] media: omap3isp change to devm for resources

s on top of 4.9-rc8 without any dependencies on Sakari's RFC patch. thanks, -- Shuah > On Thursday 15 Dec 2016 12:40:08 Shuah Khan wrote: >> Using devm resources that have external dependencies such as a dev >> for a file handler could result in devm resources getting released >>

[PATCH 0/2] omap3 devm usage removal

This patch series contains two patches. The first one removes calls to media_entity_cleanup() after media device has been unregistered. The second one removes devm usage. Shuah Khan (2): media: omap3isp fix media_entity_cleanup() after media device unregister media: omap3isp change

[PATCH 2/2] media: omap3isp change to devm for resources

-off-by: Shuah Khan <shua...@osg.samsung.com> --- drivers/media/platform/omap3isp/isp.c | 71 +++ drivers/media/platform/omap3isp/ispccp2.c | 10 +++- drivers/media/platform/omap3isp/isph3a_aewb.c | 21 +--- drivers/media/platform/omap3isp/isph3a_af.c

[PATCH 1/2] media: omap3isp fix media_entity_cleanup() after media device unregister

During unbind isp_remove() media_entity_cleanup() after it unregisters the media_device. Cleanup routine calls media_entity_cleanup() accessing subdev entities that have been removed. This will cause problems during unbind. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- drivers

Re: [RFC v3 21/21] omap3isp: Don't rely on devm for memory resource management

Hi Skarai, On 12/15/2016 04:57 AM, Laurent Pinchart wrote: > On Thursday 15 Dec 2016 13:45:25 Sakari Ailus wrote: >> Hi Laurent, >> >> On 12/15/16 13:42, Laurent Pinchart wrote: >>> You can split that part out. The devm_* removal is independent and could >>> be moved to the beginning of the

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

On 12/15/2016 10:25 AM, Mauro Carvalho Chehab wrote: > Em Thu, 15 Dec 2016 10:09:53 -0700 > Shuah Khan <shua...@osg.samsung.com> escreveu: > >> On 12/15/2016 09:28 AM, Hans Verkuil wrote: >>> On 15/12/16 17:06, Shuah Khan wrote: > >>> >>

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

On 12/15/2016 09:28 AM, Hans Verkuil wrote: > On 15/12/16 17:06, Shuah Khan wrote: >> On 12/15/2016 08:26 AM, Hans Verkuil wrote: >>> On 15/12/16 15:45, Shuah Khan wrote: >>>> On 12/15/2016 07:03 AM, Hans Verkuil wrote: >>>>> On 15/12/16 13

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

On 12/15/2016 08:26 AM, Hans Verkuil wrote: > On 15/12/16 15:45, Shuah Khan wrote: >> On 12/15/2016 07:03 AM, Hans Verkuil wrote: >>> On 15/12/16 13:56, Laurent Pinchart wrote: >>>> Hi Sakari, >>>> >>>> On Thursday 15 Dec 2016 13:30:41 Sakari

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

On 12/15/2016 03:39 AM, Laurent Pinchart wrote: > Hello, > > On Tuesday 13 Dec 2016 15:23:53 Shuah Khan wrote: >> On 12/13/2016 05:24 AM, Mauro Carvalho Chehab wrote: >>> Em Tue, 13 Dec 2016 12:53:05 +0200 Sakari Ailus escreveu: >>>> On Tue, Nov 29, 2016 at 09:

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

On 12/15/2016 07:03 AM, Hans Verkuil wrote: > On 15/12/16 13:56, Laurent Pinchart wrote: >> Hi Sakari, >> >> On Thursday 15 Dec 2016 13:30:41 Sakari Ailus wrote: >>> On Tue, Dec 13, 2016 at 10:24:47AM -0200, Mauro Carvalho Chehab wrote: Em Tue, 13 Dec 2016 12:53:05 +0200 Sakari Ailus

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

gt; character device. >>> >>> The struct device kobject refcount ensures that everything associated >>> with it will only be freed after the refcount goes to zero. >>> >>> As I said before, if are there any cases where the refcount is going >>> e

Re: Omap3-isp isp_remove() access subdev.entity after media_device_cleanup()

On 12/12/2016 01:03 AM, Sakari Ailus wrote: > Hi Shuah, > > On Fri, Dec 09, 2016 at 09:52:44AM -0700, Shuah Khan wrote: >> Hi Sakari, >> >> I am looking at omap3 isp_remove() closely and I think there are a few >> issues there that could cause problems during

Omap3-isp isp_remove() access subdev.entity after media_device_cleanup()

inux/tree/master now and if I can get it to boot - I can send you some logs. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shua...@osg.samsung.com -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources

On 12/09/2016 06:17 AM, Sakari Ailus wrote: > Hi Shuah, > > On Fri, Dec 09, 2016 at 01:44:07AM +0200, Sakari Ailus wrote: >> Hi Shuah, >> >> On Thu, Dec 08, 2016 at 07:46:03AM -0700, Shuah Khan wrote: >>> Hi Sakari, >>> >>> On

Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources

Hi Sakari, On 12/07/2016 03:27 PM, Sakari Ailus wrote: > Hi Shuah, > > On Wed, Dec 07, 2016 at 01:03:59PM -0700, Shuah Khan wrote: >> Hi Sakari, >> >> On 12/07/2016 03:52 AM, Sakari Ailus wrote: >>> Hi Shuah, >>> >>> On Mon, Dec 05, 2016 at

Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources

Hi Sakari, On 12/07/2016 03:52 AM, Sakari Ailus wrote: > Hi Shuah, > > On Mon, Dec 05, 2016 at 05:38:23PM -0700, Shuah Khan wrote: >> On 12/05/2016 04:21 PM, Laurent Pinchart wrote: >>> Hi Shuah, >>> >>> On Monday 05 Dec 2016 15:44:30 Shuah Khan wrot

[PATCH v7 0/3] Media Device Allocator API

/selftests/media_tests/regression_test.txt for testing done on this series. Shuah Khan (3): media: Media Device Allocator API media: change au0828 to use Media Device Allocator API sound/usb: Use Media Controller API to share media resources Documentation/media/kapi/mc-core.rst | 37

[PATCH v7 1/3] media: Media Device Allocator API

the references are released. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- No changes since v6 Documentation/media/kapi/mc-core.rst | 37 ++ drivers/media/Makefile | 3 +- drivers/media/media-dev-allocator.c | 133 +++ i

[PATCH v7 2/3] media: change au0828 to use Media Device Allocator API

Change au0828 to use Media Device Allocator API to allocate media device with the parent usb struct device as the key, so it can be shared with the snd_usb_audio driver. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- No changes since v6 drivers/media/usb/au0828/au0828-core.

[PATCH v7 3/3] sound/usb: Use Media Controller API to share media resources

in usb_audio_disconnect(). Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- Changes to patch 0003 since v6: - Addressed Takashi's review comments on patch v6 sound/usb/Kconfig| 4 + sound/usb/Makefile | 2 + sound/usb/card.c | 14 +++ sound/usb/card.h | 3 +

Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources

Hi Takashi, On 12/05/2016 11:50 PM, Takashi Iwai wrote: > On Wed, 30 Nov 2016 23:01:16 +0100, > Shuah Khan wrote: >> >> --- a/sound/usb/card.c >> +++ b/sound/usb/card.c > (snip) >> @@ -616,6 +617,11 @@ static int usb_audio_probe(struct usb_int

Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources

On 12/05/2016 04:21 PM, Laurent Pinchart wrote: > Hi Shuah, > > On Monday 05 Dec 2016 15:44:30 Shuah Khan wrote: >> On 11/30/2016 03:01 PM, Shuah Khan wrote: >>> Change ALSA driver to use Media Controller API to share media resources >>> with DVB, and V4L2

Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources

On 11/30/2016 03:01 PM, Shuah Khan wrote: > Change ALSA driver to use Media Controller API to share media resources > with DVB, and V4L2 drivers on a AU0828 media device. > > Media Controller specific initialization is done after sound card is > registered. ALSA creates Media inter

Re: [PATCH 2/2] media: protect enable and disable source handler checks and calls

Hi Sakari, On 12/01/2016 06:51 AM, Sakari Ailus wrote: > Hi Shuah, > > On Tue, Nov 29, 2016 at 10:41:51AM -0700, Shuah Khan wrote: >> On 11/29/2016 02:22 AM, Sakari Ailus wrote: >>> Hi Shuah, >>> >>> On Mon, Nov 28, 2016 at 07:15:14PM -0700, Shuah K

[PATCH v6 1/3] media: Media Device Allocator API

the references are released. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> --- Changes to patch 0001 since v5: (comments from Mauro and Sakari) - Removed struct device from media_device_instance. mdev.dev is used instead. - Added d

[PATCH v6 2/3] media: change au0828 to use Media Device Allocator API

Change au0828 to use Media Device Allocator API to allocate media device with the parent usb struct device as the key, so it can be shared with the snd_usb_audio driver. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- Changes to patch 0002: - No changes since patch v2, applies c

  1   2   3   4   5   6   7   >