Re: [media-ctl PATCH 1/1] libmediactl: Implement MEDIA_ENT_ID_FLAG_NEXT in media_get_entity_by_id()

2012-01-15 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: On Saturday 14 January 2012 20:33:36 Sakari Ailus wrote: Signed-off-by: Sakari Ailussakari.ai...@iki.fi --- src/mediactl.c |9 +++-- src/mediactl.h |4 +++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mediactl.c b/src

Re: [RFC 08/17] v4l: Image source control class

2012-01-15 Thread Sakari Ailus
Hi Sylwester, Sylwester Nawrocki wrote: On 01/14/2012 09:51 PM, Sakari Ailus wrote: diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c index 083bb79..da1ec52 100644 --- a/drivers/media/video/v4l2-ctrls.c +++ b/drivers/media/video/v4l2-ctrls.c @@ -606,6 +606,12

Re: [RFC 08/17] v4l: Image source control class

2012-01-15 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: On Saturday 14 January 2012 21:51:31 Sakari Ailus wrote: Laurent Pinchart wrote: On Tuesday 20 December 2011 21:28:00 Sakari Ailus wrote: From: Sakari Ailus sakari.ai...@iki.fi Add image source control class. This control class is intended to contain low

Re: [RFC 08/17] v4l: Image source control class

2012-01-15 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: On Sunday 15 January 2012 20:44:02 Sakari Ailus wrote: Laurent Pinchart wrote: On Saturday 14 January 2012 21:51:31 Sakari Ailus wrote: Laurent Pinchart wrote: On Tuesday 20 December 2011 21:28:00 Sakari Ailus wrote: From: Sakari Ailus sakari.ai...@iki.fi

Re: [RFC PATCH] Fixup control names to use consistent capitalization

2012-01-16 Thread Sakari Ailus
of the affected strings are either MPEG or Flash controls. Looks good to me. I looked at the flash controls only. Regards, -- Sakari Ailus e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: [PATCH 13/23] omap3isp: Add lane configuration to platform data

2012-01-17 Thread Sakari Ailus
Hi Laurent, Thanks for the review! On Mon, Jan 16, 2012 at 03:08:26PM +0100, Laurent Pinchart wrote: On Wednesday 11 January 2012 22:26:50 Sakari Ailus wrote: Add lane configuration (order of clock and data lane) to platform data on both CCP2 and CSI-2. Signed-off-by: Sakari Ailus

Re: [PATCH 09/23] v4l: Add DPCM compressed formats

2012-01-17 Thread Sakari Ailus
Hi Laurent, Thanks for the review! On Mon, Jan 16, 2012 at 03:01:50PM +0100, Laurent Pinchart wrote: On Wednesday 11 January 2012 22:26:46 Sakari Ailus wrote: Add three other colour orders for 10-bit to 8-bit DPCM compressed formats. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi

Re: [PATCH 14/23] omap3isp: Configure CSI-2 phy based on platform data

2012-01-17 Thread Sakari Ailus
Hi Laurent, Many thanks for reviewing these! On Mon, Jan 16, 2012 at 03:22:42PM +0100, Laurent Pinchart wrote: On Wednesday 11 January 2012 22:26:51 Sakari Ailus wrote: Configure CSI-2 phy based on platform data in the ISP driver. For that, the new V4L2_CID_IMAGE_SOURCE_PIXEL_RATE control

Re: [PATCH 16/23] media: Add link_validate op to check links to the sink pad

2012-01-17 Thread Sakari Ailus
Hi Laurent, Thanks for the review. On Mon, Jan 16, 2012 at 03:35:07PM +0100, Laurent Pinchart wrote: On Wednesday 11 January 2012 22:26:53 Sakari Ailus wrote: Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/media-entity.c | 73

Re: [PATCH 17/23] v4l: Implement v4l2_subdev_link_validate()

2012-01-17 Thread Sakari Ailus
Hi Laurent, Thanks for the review! On Mon, Jan 16, 2012 at 03:44:08PM +0100, Laurent Pinchart wrote: On Wednesday 11 January 2012 22:26:54 Sakari Ailus wrote: v4l2_subdev_link_validate() is the default op for validating a link. In V4L2 subdev context, it is used to call a pad op which

Re: [PATCH 19/23] omap3isp: Default error handling for ccp2, csi2, preview and resizer

2012-01-17 Thread Sakari Ailus
On Mon, Jan 16, 2012 at 03:50:07PM +0100, Laurent Pinchart wrote: Hi Sakari, Thanks for the patch. On Wednesday 11 January 2012 22:26:56 Sakari Ailus wrote: Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispccp2.c|2 ++ drivers/media/video

Re: [PATCH 14/23] omap3isp: Configure CSI-2 phy based on platform data

2012-01-19 Thread Sakari Ailus
Hi Laurent, On Thu, Jan 19, 2012 at 05:16:50PM +0100, Laurent Pinchart wrote: On Tuesday 17 January 2012 20:45:18 Sakari Ailus wrote: On Mon, Jan 16, 2012 at 03:22:42PM +0100, Laurent Pinchart wrote: On Wednesday 11 January 2012 22:26:51 Sakari Ailus wrote: Configure CSI-2 phy based

Re: [PATCH 16/23] media: Add link_validate op to check links to the sink pad

2012-01-19 Thread Sakari Ailus
in it. Is it ? Not in this patch at least. Hmm. Good point. I'll check if I can get rid of it and still keep it looking nice. -- Sakari Ailus e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: [RFCv1 2/4] v4l:vb2: add support for shared buffer (dma_buf)

2012-01-25 Thread Sakari Ailus
? This is currently done by virtually all V4L2 drivers where such mappings are relevant. Not doing so would really kill the performance i.e. it's infeasible. Same goes to (m)any other multimedia devices dealing with buffers containing streaming video data. Kind regards, -- Sakari Ailus e-mail

Re: [PATCH v2 2/2] v4l2: add new pixel formats supported on dm365

2012-01-25 Thread Sakari Ailus
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Sakari Ailus e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 06/11] v4l: Add support for omap4iss driver

2012-01-26 Thread Sakari Ailus
in the same queue. Kind regards, -- Sakari Ailus sakari.ai...@iki.fi -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/1] omap3isp: Prevent crash at module unload

2012-01-27 Thread Sakari Ailus
iommu_domain_free() was called in isp_remove() before omap3isp_put(). omap3isp_put() must not save the context if the IOMMU no longer is there. Fix this. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- The issue only seems to affect the staging/for_v3.4 branch in media-tree.git. drivers

Re: [PATCH 1/1] omap3isp: Prevent crash at module unload

2012-01-27 Thread Sakari Ailus
Hi Laurent, On Fri, Jan 27, 2012 at 10:36:02AM +0100, Laurent Pinchart wrote: On Friday 27 January 2012 10:05:55 Sakari Ailus wrote: iommu_domain_free() was called in isp_remove() before omap3isp_put(). omap3isp_put() must not save the context if the IOMMU no longer is there. Fix

[PATCH v2 1/1] omap3isp: Prevent crash at module unload

2012-01-27 Thread Sakari Ailus
iommu_domain_free() was called in isp_remove() before omap3isp_put(). omap3isp_put() must not save the context if the IOMMU no longer is there. Fix this. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Compared to v1, neither the ISP context is saved. drivers/media/video/omap3isp/isp.c

[PATCH 1/1] omap3isp: Fix CCDC vsync event delivery

2012-01-27 Thread Sakari Ailus
The devnode already is a pointer in struct v4l2_subdev, we don't need a pointer to that. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- This issue is present in for_v3.3 branch and in for_v3.4. This patch is for the former. drivers/media/video/omap3isp/ispccdc.c |3 +-- 1 files changed

[RFC] Format and frame rate configuration in subdev video and pad ops

2012-01-29 Thread Sakari Ailus
rectangle boundaries */ struct v4l2_subdev_crop { __u32 which; __u32 pad; struct v4l2_rect rect; __u32 reserved[8]; }; Cheers, -- Sakari Ailus sakari.ai...@iki.fi -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [RFCv1 2/4] v4l:vb2: add support for shared buffer (dma_buf)

2012-01-29 Thread Sakari Ailus
Hi Daniel, Daniel Vetter wrote: On Thu, Jan 26, 2012 at 01:28:16AM +0200, Sakari Ailus wrote: Why you should not hang onto mappings forever? This is currently done by virtually all V4L2 drivers where such mappings are relevant. Not doing so would really kill the performance i.e. it's

[RFC] More on subdev selections API: composition

2012-01-29 Thread Sakari Ailus
discuss this further on #v4l-meeting, I propose Tuesday 2012-01-31 15:00 Finnish time (13:00 GMT). Kind regards, -- Sakari Ailus e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [RFCv1 2/4] v4l:vb2: add support for shared buffer (dma_buf)

2012-01-30 Thread Sakari Ailus
Hi Daniel, On Sun, Jan 29, 2012 at 02:03:40PM +0100, Daniel Vetter wrote: On Sun, Jan 29, 2012 at 01:03:39PM +0200, Sakari Ailus wrote: Daniel Vetter wrote: On Thu, Jan 26, 2012 at 01:28:16AM +0200, Sakari Ailus wrote: Why you should not hang onto mappings forever? This is currently done

Re: [RFC PATCH 0/4] Add some new camera controls

2012-01-30 Thread Sakari Ailus
Hi Sylwester, On Sat, Jan 28, 2012 at 06:01:59PM +0100, Sylwester Nawrocki wrote: On 01/04/2012 10:07 PM, Sakari Ailus wrote: On Fri, Dec 30, 2011 at 12:18:40PM +0100, Sylwester Nawrocki wrote: Thus we would three levels of controls for camera, 1) image source class (lowest possible

Re: [Q] Interleaved formats on the media bus

2012-02-01 Thread Sakari Ailus
creating a single hardware-specific solution. Cheers, -- Sakari Ailus e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH v2 0/31] V4L2 subdev and sensor control changes, SMIA++ driver and N9 camera board code

2012-02-02 Thread Sakari Ailus
://www.spinics.net/lists/linux-media/msg42848.html [8] http://www.spinics.net/lists/linux-media/msg42991.html [9] http://www.spinics.net/lists/linux-media/msg43810.html Kind regards, -- Sakari Ailus sakari.ai...@iki.fi -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

[PATCH v2 02/31] v4l: Document integer menu controls

2012-02-02 Thread Sakari Ailus
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Documentation/DocBook/media/v4l/compat.xml | 10 + Documentation/DocBook/media/v4l/v4l2.xml |6 +++ .../DocBook/media/v4l/vidioc-queryctrl.xml

[PATCH v2 11/31] v4l: Document raw bayer 4CC codes

2012-02-02 Thread Sakari Ailus
Document guidelines how 4CC codes should be named. Only raw bayer is included currently. Other formats should be documented later on. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/video4linux/4CCs.txt | 32 1 files changed, 32 insertions

[PATCH v2 21/31] omap3isp: Add lane configuration to platform data

2012-02-02 Thread Sakari Ailus
Add lane configuration (order of clock and data lane) to platform data on both CCP2 and CSI-2. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/omap3isp/ispcsiphy.h | 15 ++- include/media

[PATCH v2 05/31] v4l: Support s_crop and g_crop through s/g_selection

2012-02-02 Thread Sakari Ailus
Fall back to s_selection if s_crop isn't implemented by a driver. Same for g_selection / g_crop. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/v4l2-subdev.c | 37 +++-- 1

[PATCH v2 23/31] omap3isp: Introduce omap3isp_get_external_info()

2012-02-02 Thread Sakari Ailus
omap3isp_get_external_info() will retrieve external subdev's bits-per-pixel and pixel rate for the use of other ISP subdevs at streamon time. omap3isp_get_external_info() is used during pipeline validation. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/isp.c

[PATCH v2 09/31] v4l: Image source control class

2012-02-02 Thread Sakari Ailus
Add image source control class. This control class is intended to contain low level controls which deal with control of the image capture process --- the A/D converter in image sensors, for example. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/DocBook/media/v4l/controls.xml

[PATCH v2 27/31] omap3isp: Configure CSI-2 phy based on platform data

2012-02-02 Thread Sakari Ailus
Configure CSI-2 phy based on platform data in the ISP driver. For that, the new V4L2_CID_IMAGE_SOURCE_PIXEL_RATE control is used. Previously the same was configured from the board code. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispcsi2.c | 10

[PATCH v2 24/31] omap3isp: Default link validation for ccp2, csi2, preview and resizer

2012-02-02 Thread Sakari Ailus
-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispccdc.c| 23 +++ drivers/media/video/omap3isp/ispccp2.c| 20 drivers/media/video/omap3isp/ispcsi2.c| 19 +++ drivers/media/video/omap3isp/isppreview.c |2

[PATCH v2 28/31] omap3isp: Add resizer data rate configuration to resizer_set_stream

2012-02-02 Thread Sakari Ailus
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispresizer.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/omap3isp/ispresizer.c b/drivers/media/video/omap3isp/ispresizer.c index 6ce2349..81e1bc4 100644

[PATCH v2 29/31] omap3isp: Remove isp_validate_pipeline and other old stuff

2012-02-02 Thread Sakari Ailus
() --- this will live on as ccdc_is_shiftable in ispccdc.c. Remove isp_video_validate_pipeline(). Pipeline validation is now split into appropriate subdevs, so this can be removed. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/isp.c | 14 --- drivers/media/video

[PATCH v2 26/31] omap3isp: Move setting constaints above media_entity_pipeline_start

2012-02-02 Thread Sakari Ailus
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispvideo.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/media/video/omap3isp/ispvideo.c b/drivers/media/video/omap3isp/ispvideo.c index f1c68ca..2e4786d 100644

[PATCH v2 15/31] v4l: Implement v4l2_subdev_link_validate()

2012-02-02 Thread Sakari Ailus
v4l2_subdev_link_validate() is the default op for validating a link. In V4L2 subdev context, it is used to call a pad op which performs the proper link check without much extra work. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/video4linux/v4l2-framework.txt | 12

[PATCH v2 03/31] vivi: Add an integer menu test control

2012-02-02 Thread Sakari Ailus
Add an integer menu test control for the vivi driver. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/vivi.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/drivers

[PATCH v2 31/31] rm680: Add camera init

2012-02-02 Thread Sakari Ailus
From: Sakari Ailus sakari.ai...@maxwell.research.nokia.com This currently introduces an extra file to the arch/arm/mach-omap2 directory: board-rm680-camera.c. Keeping the device tree in mind, the context of the file could be represented as static data with one exception: the external clock

[PATCH v2 22/31] omap3isp: Add information on external subdev to struct isp_pipeline

2012-02-02 Thread Sakari Ailus
Add pointer to external subdev, pixel rate of the external subdev and bpp of the format to struct isp_pipeline. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispvideo.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media

[PATCH v2 25/31] omap3isp: Implement proper CCDC link validation, check pixel rate

2012-02-02 Thread Sakari Ailus
Implement correct link validation for the CCDC. Use external_rate from isp_pipeline to configurat vp divisor and check that external_rate does not exceed our data rate limitations. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispccdc.c | 69

[PATCH v2 08/31] v4l: Mark VIDIOC_SUBDEV_G_CROP and VIDIOC_SUBDEV_S_CROP obsolete

2012-02-02 Thread Sakari Ailus
These two IOCTLS are obsoleted by VIDIOC_SUBDEV_G_SELECTION and VIDIOC_SUBDEV_S_SELECTION. Mark them obsolete. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/DocBook/media/v4l/compat.xml |7 +++ .../DocBook/media/v4l/vidioc-subdev-g-crop.xml |9

[PATCH v2 14/31] v4l: Improve sub-device documentation for pad ops

2012-02-02 Thread Sakari Ailus
Document that format related configuration is done through pad ops in case the driver does use the media framework. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/video4linux/v4l2-framework.txt |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git

[PATCH v2 16/31] v4l: Allow changing control handler lock

2012-02-02 Thread Sakari Ailus
Allow choosing the lock used by the control handler. This may be handy sometimes when a driver providing multiple subdevs does not want to use several locks to serialise its functions. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/adp1653.c|8 +++--- drivers

[PATCH v2 17/31] omap3isp: Support additional in-memory compressed bayer formats

2012-02-02 Thread Sakari Ailus
This also prevents accessing NULL pointer in csi2_try_format(). Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/omap3isp/ispvideo.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff

[PATCH v2 07/31] v4l: Add subdev selections documentation

2012-02-02 Thread Sakari Ailus
Add documentation for V4L2 subdev selection API. This changes also experimental V4L2 subdev API so that scaling now works through selection API only. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/DocBook/media/Makefile |2 +- Documentation/DocBook/media/v4l

[PATCH v2 20/31] omap3isp: Assume media_entity_pipeline_start may fail

2012-02-02 Thread Sakari Ailus
Since media_entity_pipeline_start() now does link validation, it may actually fail. Perform the error handling. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispvideo.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git

[PATCH v2 04/31] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-02-02 Thread Sakari Ailus
-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/v4l2-subdev.c | 34 +- include/linux/v4l2-subdev.h | 41 + include/media/v4l2-subdev.h | 21 +++--- 3 files changed, 82 insertions(+), 14

[PATCH v2 13/31] media: Add link_validate() op to check links to the sink pad

2012-02-02 Thread Sakari Ailus
-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/media-framework.txt | 19 + drivers/media/media-entity.c | 53 +++- include/media/media-entity.h |5 ++- 3 files changed, 73 insertions(+), 4 deletions(-) diff --git a/Documentation/media

[PATCH v2 01/31] v4l: Introduce integer menu controls

2012-02-02 Thread Sakari Ailus
Create a new control type called V4L2_CTRL_TYPE_INTEGER_MENU. Integer menu controls are just like menu controls but the menu items are 64-bit integers rather than strings. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers

[PATCH v2 10/31] v4l: Image processing control class

2012-02-02 Thread Sakari Ailus
Add control class for image processing controls. The control class deals with controls processing image, for example digital gain or noise filtering, which can be present in any part of the pipeline. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/DocBook/media/v4l/controls.xml

[PATCH v2 12/31] v4l: Add DPCM compressed formats

2012-02-02 Thread Sakari Ailus
Add three other colour orders for 10-bit to 8-bit DPCM compressed formats. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/DocBook/media/v4l/pixfmt-srggb10.xml |2 +- .../DocBook/media/v4l/pixfmt-srggb10dpcm8.xml | 29 Documentation/DocBook/media

[PATCH v2 18/31] omap3isp: Move definitions required by board code under include/media.

2012-02-02 Thread Sakari Ailus
XCLK definitions are often required by the board code. Move them to public include file. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/omap3isp/isp.h |4 include/media/omap3isp.h |4

Re: [Q] Interleaved formats on the media bus

2012-02-04 Thread Sakari Ailus
Hi Sylwester, Sylwester Nawrocki wrote: On 02/01/2012 11:00 AM, Sakari Ailus wrote: I'd guess that all the ISP would do to such formats is to write them to memory since I don't see much use for either in ISPs --- both typically are output of the ISP. Yep, correct. In fact in those cases

Re: [RFCv1 2/4] v4l:vb2: add support for shared buffer (dma_buf)

2012-02-04 Thread Sakari Ailus
Hi Rob, Clark, Rob wrote: On Mon, Jan 30, 2012 at 4:01 PM, Sakari Ailus sakari.ai...@iki.fi wrote: So to summarize I understand your constraints - gpu drivers have worked like v4l a few years ago. The thing I'm trying to achieve with this constant yelling is just to raise awereness

Re: [PATCH] media, adp1653: Remove unneeded include of version.h from drivers/media/video/adp1653.c

2012-02-04 Thread Sakari Ailus
-device.h Thanks for the patch! I've applied it to my tree --- plus removing extra module.h at the same time. -- Sakari Ailus e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [Q] Interleaved formats on the media bus

2012-02-04 Thread Sakari Ailus
Hi Sylwester, Sylwester Nawrocki wrote: On 02/04/2012 12:22 PM, Sakari Ailus wrote: Sylwester Nawrocki wrote: On 02/01/2012 11:00 AM, Sakari Ailus wrote: I'd guess that all the ISP would do to such formats is to write them to memory since I don't see much use for either in ISPs --- both

Re: [PATCH v2 09/31] v4l: Image source control class

2012-02-04 Thread Sakari Ailus
Hi Sylwester, Thanks for the review! Sylwester Nawrocki wrote: On 02/03/2012 12:54 AM, Sakari Ailus wrote: Add image source control class. This control class is intended to contain low level controls which deal with control of the image capture process --- the A/D converter in image sensors

Re: [PATCH v2 04/31] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-02-04 Thread Sakari Ailus
Hi Sylwester, Thanks for the comments!! Sylwester Nawrocki wrote: On 02/03/2012 12:54 AM, Sakari Ailus wrote: Add support for VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs. They replace functionality provided by VIDIOC_SUBDEV_S_CROP and VIDIOC_SUBDEV_G_CROP IOCTLs and also

Re: [PATCH v2 04/31] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-02-05 Thread Sakari Ailus
Hi Sylwester, On Sat, Feb 04, 2012 at 11:37:38PM +0100, Sylwester Nawrocki wrote: On 02/04/2012 09:30 PM, Sakari Ailus wrote: +#define V4L2_SUBDEV_SEL_FLAG_SIZE_GE (1 0) +#define V4L2_SUBDEV_SEL_FLAG_SIZE_LE (1 1) +#define

Re: [PATCH v2 2/2] v4l2: add new pixel formats supported on dm365

2012-02-05 Thread Sakari Ailus
is finally here: URL:http://www.spinics.net/lists/linux-media/msg43890.html Cheers, -- Sakari Ailus e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org

Re: [PATCH v2 11/31] v4l: Document raw bayer 4CC codes

2012-02-08 Thread Sakari Ailus
Hi Prabhakar, Prabhakar Lad wrote: +The following first charcters are used by raw bayer formats: A small spelling mistake 'charcters', just pointing out since its a documentation file :-) Regards, --Prabhakar Lad Thanks; fixed for the next version of the patchset. Cheers, -- Sakari

Re: [PATCH v2 27/31] omap3isp: Configure CSI-2 phy based on platform data

2012-02-10 Thread Sakari Ailus
Hi Sergio, Thanks for the review! Aguirre, Sergio wrote: On Thu, Feb 2, 2012 at 5:54 PM, Sakari Ailus sakari.ai...@iki.fi wrote: Configure CSI-2 phy based on platform data in the ISP driver. For that, the new V4L2_CID_IMAGE_SOURCE_PIXEL_RATE control is used. Previously the same

Re: [PATCH v2 27/31] omap3isp: Configure CSI-2 phy based on platform data

2012-02-13 Thread Sakari Ailus
Hi Sergio, Aguirre, Sergio wrote: On Sat, Feb 11, 2012 at 11:17 AM, Aguirre, Sergio saagui...@ti.com wrote: Hi Sakari, On Fri, Feb 10, 2012 at 2:32 PM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Sergio, Thanks for the review! Aguirre, Sergio wrote: On Thu, Feb 2, 2012 at 5:54 PM, Sakari

[PATCH v2.1 1/1] omap3isp: Configure CSI-2 phy based on platform data

2012-02-15 Thread Sakari Ailus
From: Sakari Ailus sakari.ai...@iki.fi Configure CSI-2 phy based on platform data in the ISP driver. For that, the new V4L2_CID_IMAGE_SOURCE_PIXEL_RATE control is used. Previously the same was configured from the board code. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media

Re: [PATCH] adp1653: included linux/module.h twice

2012-02-16 Thread Sakari Ailus
-#include linux/module.h #include linux/slab.h #include linux/version.h #include media/adp1653.h Thanks for the patch. However, I've got a patch in my tree that already contains this change. Kind regards, -- Sakari Ailus e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi.org.uk

Re: [RFC/PATCH 1/6] V4L: Add V4L2_MBUS_FMT_VYUY_JPEG_I1_1X8 media bus format

2012-02-16 Thread Sakari Ailus
for something or is that just a blob? Kind regards, -- Sakari Ailus e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFC/PATCH 4/6] V4L: Add get/set_frame_config subdev callbacks

2012-02-16 Thread Sakari Ailus
of time that has prevented me from doing that. :-I Cheers, -- Sakari Ailus sakari.ai...@iki.fi -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH 1/6] V4L: Add V4L2_MBUS_FMT_VYUY_JPEG_I1_1X8 media bus format

2012-02-17 Thread Sakari Ailus
Hi Sylwester, On Fri, Feb 17, 2012 at 03:26:29PM +0100, Sylwester Nawrocki wrote: On 02/16/2012 08:46 PM, Sakari Ailus wrote: On Thu, Feb 16, 2012 at 07:23:54PM +0100, Sylwester Nawrocki wrote: This patch adds media bus pixel code for the interleaved JPEG/YUYV image format used by S5C73MX

Re: [RFC/PATCH 3/6] V4L: Add g_embedded_data subdev callback

2012-02-17 Thread Sakari Ailus
controlled digital camera depend on that. Some receivers are also able to put such metadata into a separate memory area using DMA, such as the OMAP 3 ISP CCP-2 receiver. Cheers, -- Sakari Ailus sakari.ai...@iki.fi -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

[PATCH v3 0/33] V4L2 subdev and sensor control changes, SMIA++ driver and N9 camera board code

2012-02-19 Thread Sakari Ailus
, -- Sakari Ailus sakari.ai...@iki.fi -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH v3 01/33] v4l: Introduce integer menu controls

2012-02-19 Thread Sakari Ailus
Create a new control type called V4L2_CTRL_TYPE_INTEGER_MENU. Integer menu controls are just like menu controls but the menu items are 64-bit integers rather than strings. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers

[PATCH v3 02/33] v4l: Document integer menu controls

2012-02-19 Thread Sakari Ailus
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Documentation/DocBook/media/v4l/compat.xml | 10 + Documentation/DocBook/media/v4l/v4l2.xml |6 +++ .../DocBook/media/v4l/vidioc-queryctrl.xml

[PATCH v3 03/33] vivi: Add an integer menu test control

2012-02-19 Thread Sakari Ailus
Add an integer menu test control for the vivi driver. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/vivi.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/drivers

[PATCH v3 04/33] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-02-19 Thread Sakari Ailus
-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/v4l2-subdev.c | 34 +- include/linux/v4l2-subdev.h | 41 + include/media/v4l2-subdev.h | 21 +++--- 3 files changed, 82 insertions(+), 14

[PATCH v3 05/33] v4l: vdev_to_v4l2_subdev() should have return type struct v4l2_subdev *

2012-02-19 Thread Sakari Ailus
vdev_to_v4l2_subdev() should return struct v4l2_subdev *, not void *. Fix this. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- include/media/v4l2-subdev.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h

[PATCH v3 06/33] v4l: Check pad number in get try pointer functions

2012-02-19 Thread Sakari Ailus
Unify functions to get try pointers and validate the pad number accessed by the user. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- include/media/v4l2-subdev.h | 31 ++- 1 files changed, 14 insertions(+), 17 deletions(-) diff --git a/include/media/v4l2

[PATCH v3 07/33] v4l: Support s_crop and g_crop through s/g_selection

2012-02-19 Thread Sakari Ailus
Fall back to s_selection if s_crop isn't implemented by a driver. Same for g_selection / g_crop. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/v4l2-subdev.c | 37 +++-- 1

[PATCH v3 09/33] v4l: Add subdev selections documentation

2012-02-19 Thread Sakari Ailus
Add documentation for V4L2 subdev selection API. This changes also experimental V4L2 subdev API so that scaling now works through selection API only. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/DocBook/media/Makefile |2 +- Documentation/DocBook/media/v4l

[PATCH v3 10/33] v4l: Mark VIDIOC_SUBDEV_G_CROP and VIDIOC_SUBDEV_S_CROP obsolete

2012-02-19 Thread Sakari Ailus
These two IOCTLS are obsoleted by VIDIOC_SUBDEV_G_SELECTION and VIDIOC_SUBDEV_S_SELECTION. Mark them obsolete. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/DocBook/media/v4l/compat.xml |7 +++ .../DocBook/media/v4l/vidioc-subdev-g-crop.xml |9

[PATCH v3 11/33] v4l: Image source control class

2012-02-19 Thread Sakari Ailus
Add image source control class. This control class is intended to contain low level controls which deal with control of the image capture process --- the A/D converter in image sensors, for example. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/DocBook/media/v4l/controls.xml

[PATCH v3 12/33] v4l: Image processing control class

2012-02-19 Thread Sakari Ailus
Add control class for image processing controls. The control class deals with controls processing image, for example digital gain or noise filtering, which can be present in any part of the pipeline. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/DocBook/media/v4l/controls.xml

[PATCH v3 13/33] v4l: Document raw bayer 4CC codes

2012-02-19 Thread Sakari Ailus
Document guidelines how 4CC codes should be named. Only raw bayer is included currently. Other formats should be documented later on. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/video4linux/4CCs.txt | 32 1 files changed, 32 insertions

[PATCH v3 14/33] v4l: Add DPCM compressed formats

2012-02-19 Thread Sakari Ailus
Add three other colour orders for 10-bit to 8-bit DPCM compressed formats. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/DocBook/media/v4l/pixfmt-srggb10.xml |2 +- .../DocBook/media/v4l/pixfmt-srggb10dpcm8.xml | 29 Documentation/DocBook/media

[PATCH v3 15/33] media: Add link_validate() op to check links to the sink pad

2012-02-19 Thread Sakari Ailus
-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/media-framework.txt | 19 + drivers/media/media-entity.c | 53 +++- include/media/media-entity.h |5 ++- 3 files changed, 73 insertions(+), 4 deletions(-) diff --git a/Documentation/media

[PATCH v3 16/33] v4l: Improve sub-device documentation for pad ops

2012-02-19 Thread Sakari Ailus
Document that format related configuration is done through pad ops in case the driver does use the media framework. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/video4linux/v4l2-framework.txt |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git

[PATCH v3 17/33] v4l: Implement v4l2_subdev_link_validate()

2012-02-19 Thread Sakari Ailus
v4l2_subdev_link_validate() is the default op for validating a link. In V4L2 subdev context, it is used to call a pad op which performs the proper link check without much extra work. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/video4linux/v4l2-framework.txt | 12

[PATCH v3 18/33] v4l: Allow changing control handler lock

2012-02-19 Thread Sakari Ailus
Allow choosing the lock used by the control handler. This may be handy sometimes when a driver providing multiple subdevs does not want to use several locks to serialise its functions. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/adp1653.c|8 +++--- drivers

[PATCH v3 19/33] omap3isp: Support additional in-memory compressed bayer formats

2012-02-19 Thread Sakari Ailus
This also prevents accessing NULL pointer in csi2_try_format(). Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/omap3isp/ispvideo.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff

[PATCH v3 20/33] omap3isp: Move definitions required by board code under include/media.

2012-02-19 Thread Sakari Ailus
XCLK definitions are often required by the board code. Move them to public include file. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/omap3isp/isp.h |4 include/media/omap3isp.h |4

[PATCH v3 21/33] omap3: add definition for CONTROL_CAMERA_PHY_CTRL

2012-02-19 Thread Sakari Ailus
This register is available only in OMAP3630. The original patch was submitted by Vimarsh Zutshi. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- arch/arm/mach-omap2/control.h |1 + 1 files changed, 1 insertions(+), 0 deletions

[PATCH v3 22/33] omap3isp: Assume media_entity_pipeline_start may fail

2012-02-19 Thread Sakari Ailus
Since media_entity_pipeline_start() now does link validation, it may actually fail. Perform the error handling. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispvideo.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git

[PATCH v3 23/33] omap3isp: Add lane configuration to platform data

2012-02-19 Thread Sakari Ailus
Add lane configuration (order of clock and data lane) to platform data on both CCP2 and CSI-2. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/omap3isp/ispcsiphy.h | 15 ++- include/media

[PATCH v3 24/33] omap3isp: Add information on external subdev to struct isp_pipeline

2012-02-19 Thread Sakari Ailus
Add pointer to external subdev, pixel rate of the external subdev and bpp of the format to struct isp_pipeline. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispvideo.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media

[PATCH v3 25/33] omap3isp: Introduce omap3isp_get_external_info()

2012-02-19 Thread Sakari Ailus
omap3isp_get_external_info() will retrieve external subdev's bits-per-pixel and pixel rate for the use of other ISP subdevs at streamon time. omap3isp_get_external_info() is used during pipeline validation. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/isp.c

[PATCH v3 26/33] omap3isp: Default link validation for ccp2, csi2, preview and resizer

2012-02-19 Thread Sakari Ailus
-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispccdc.c| 23 +++ drivers/media/video/omap3isp/ispccp2.c| 20 drivers/media/video/omap3isp/ispcsi2.c| 19 +++ drivers/media/video/omap3isp/isppreview.c |2

[PATCH v3 27/33] omap3isp: Implement proper CCDC link validation, check pixel rate

2012-02-19 Thread Sakari Ailus
Implement correct link validation for the CCDC. Use external_rate from isp_pipeline to configurat vp divisor and check that external_rate does not exceed our data rate limitations. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispccdc.c | 69

[PATCH v3 28/33] omap3isp: Move setting constaints above media_entity_pipeline_start

2012-02-19 Thread Sakari Ailus
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispvideo.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/media/video/omap3isp/ispvideo.c b/drivers/media/video/omap3isp/ispvideo.c index f1c68ca..2e4786d 100644

<    2   3   4   5   6   7   8   9   10   11   >