Re: [Patch] Last Q3 reference in the qt4 frontend (hopefully) (was Re: Is really Qt3Support gone?)

2006-08-28 Thread Andre Poenitz
On Thu, Aug 24, 2006 at 09:36:07PM +0200, Abdelrazak Younes wrote: Will commit soon the attached patch. You could have removed the line entirely. Andre'

Re: [Patch] Last Q3 reference in the qt4 frontend (hopefully) (was Re: Is really Qt3Support gone?)

2006-08-28 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, Aug 24, 2006 at 09:36:07PM +0200, Abdelrazak Younes wrote: Will commit soon the attached patch. You could have removed the line entirely. I tried that but Qt designer will put it again if you open it. So in order to avoid unnecessary future commit I decided to

Re: [Patch] Last Q3 reference in the qt4 frontend (hopefully) (was Re: Is really Qt3Support gone?)

2006-08-28 Thread Andre Poenitz
On Thu, Aug 24, 2006 at 09:36:07PM +0200, Abdelrazak Younes wrote: > Will commit soon the attached patch. You could have removed the line entirely. Andre'

Re: [Patch] Last Q3 reference in the qt4 frontend (hopefully) (was Re: Is really Qt3Support gone?)

2006-08-28 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, Aug 24, 2006 at 09:36:07PM +0200, Abdelrazak Younes wrote: Will commit soon the attached patch. You could have removed the line entirely. I tried that but Qt designer will put it again if you open it. So in order to avoid unnecessary future commit I decided to

[Patch] Last Q3 reference in the qt4 frontend (hopefully) (was Re: Is really Qt3Support gone?)

2006-08-24 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Georg Baum wrote: Abdelrazak Younes wrote: Enrico Forestieri wrote: I think this not a big deal, but LyX/Qt4 is not really Qt3Support free ;-) On my system it really is... Grepping for Q3 and Qt3 gives absolutely nothing: Enrico is right, it is not. Grep the build

[Patch] Last Q3 reference in the qt4 frontend (hopefully) (was Re: Is really Qt3Support gone?)

2006-08-24 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Georg Baum wrote: Abdelrazak Younes wrote: Enrico Forestieri wrote: I think this not a big deal, but LyX/Qt4 is not really Qt3Support free ;-) On my system it really is... Grepping for Q3 and Qt3 gives absolutely nothing: Enrico is right, it is not. Grep the build

Re: Qt4 frontend save/restore geoemtry patch

2006-06-27 Thread Peter Kümmel
void GuiView::closeEvent(QCloseEvent *) { + // FIXME: + // change the ifdef to 'geometry = normalGeometry();' only + // when Trolltech has fixed the broken normalGeometry on X11. + // Then also the moveEvent, resizeEvent, and the + // code for floatingGeometry_ can

Re: Qt4 frontend save/restore geoemtry patch

2006-06-27 Thread Peter Kümmel
void GuiView::closeEvent(QCloseEvent *) { + // FIXME: + // change the ifdef to 'geometry = normalGeometry();' only + // when Trolltech has fixed the broken normalGeometry on X11. + // Then also the moveEvent, resizeEvent, and the + // code for floatingGeometry_ can

Re: Qt4 frontend save/restore geoemtry patch

2006-06-23 Thread Abdelrazak Younes
Andre Poenitz wrote: On Wed, Jun 21, 2006 at 10:24:31AM +, Angus Leeming wrote: I think it's just because we decided it improves readability. These things should be read from right to left: QRect const A reference to a const QRect char const * const A const pointer to a const

Re: Qt4 frontend save/restore geoemtry patch

2006-06-23 Thread Lars Gullik Bjønnes
Abdelrazak Younes [EMAIL PROTECTED] writes: | Andre Poenitz wrote: | On Wed, Jun 21, 2006 at 10:24:31AM +, Angus Leeming wrote: | I think it's just because we decided it improves readability. These things | should be read from right to left: | QRect const | A reference to a const

Re: Qt4 frontend save/restore geoemtry patch

2006-06-23 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes [EMAIL PROTECTED] writes: | Andre Poenitz wrote: | On Wed, Jun 21, 2006 at 10:24:31AM +, Angus Leeming wrote: | I think it's just because we decided it improves readability. These things | should be read from right to left: | QRect const

Re: Qt4 frontend save/restore geoemtry patch

2006-06-23 Thread Peter Kümmel
Andre Poenitz wrote: On Tue, Jun 20, 2006 at 01:09:15PM +0200, Peter Kümmel wrote: +if (width != -1 height != -1 posx != -1 posy != -1) { +view.initNormalGeometry(QRect(posx, posy, width, height)); +view.resize(width, height); +view.move(posx,

Re: Qt4 frontend save/restore geoemtry patch

2006-06-23 Thread Andre Poenitz
On Fri, Jun 23, 2006 at 11:06:20AM +0200, Lars Gullik Bjønnes wrote: | I always have to force myself to put it to the right. When you get used to it, it feels a lot more natural. I think you agree that I have written enough code with 'const' on the right and still like it more on the left.

Re: Qt4 frontend save/restore geoemtry patch

2006-06-23 Thread Abdelrazak Younes
Andre Poenitz wrote: On Wed, Jun 21, 2006 at 10:24:31AM +, Angus Leeming wrote: I think it's just because we decided it improves readability. These things should be read from right to left: QRect const & A reference to a const QRect char const * const A const pointer to a const

Re: Qt4 frontend save/restore geoemtry patch

2006-06-23 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: | > On Wed, Jun 21, 2006 at 10:24:31AM +, Angus Leeming wrote: | >> I think it's just because we decided it improves readability. These things | >> should be read from right to left: | >>QRect const & | >>A reference

Re: Qt4 frontend save/restore geoemtry patch

2006-06-23 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: | > On Wed, Jun 21, 2006 at 10:24:31AM +, Angus Leeming wrote: | >> I think it's just because we decided it improves readability. These things | >> should be read from right to left: | >>

Re: Qt4 frontend save/restore geoemtry patch

2006-06-23 Thread Peter Kümmel
Andre Poenitz wrote: > On Tue, Jun 20, 2006 at 01:09:15PM +0200, Peter Kümmel wrote: >> +if (width != -1 && height != -1 && posx != -1 && posy != -1) { >> +view.initNormalGeometry(QRect(posx, posy, width, height)); >> +view.resize(width, height); >> +

Re: Qt4 frontend save/restore geoemtry patch

2006-06-23 Thread Andre Poenitz
On Fri, Jun 23, 2006 at 11:06:20AM +0200, Lars Gullik Bjønnes wrote: > | I always have to force myself to put it to the right. > > When you get used to it, it feels a lot more natural. I think you agree that I have written enough code with 'const' on the right and still like it more on the left.

Re: Qt4 frontend save/restore geoemtry patch

2006-06-22 Thread younes . a
Quoting Peter Kümmel [EMAIL PROTECTED]: Abdelrazak Younes wrote: I think we should use QMainWindow::centralWidget().width/height instead. In this particular case, yes. But I would prefer to fix the problem at the source: We don't need the width and height on BufferView creation. My

Re: Qt4 frontend save/restore geoemtry patch

2006-06-22 Thread Andre Poenitz
On Tue, Jun 20, 2006 at 01:09:15PM +0200, Peter Kümmel wrote: + if (width != -1 height != -1 posx != -1 posy != -1) { + view.initNormalGeometry(QRect(posx, posy, width, height)); + view.resize(width, height); + view.move(posx, posy); +

Re: Qt4 frontend save/restore geoemtry patch

2006-06-22 Thread Andre Poenitz
On Wed, Jun 21, 2006 at 10:24:31AM +, Angus Leeming wrote: I think it's just because we decided it improves readability. These things should be read from right to left: QRect const A reference to a const QRect char const * const A const pointer to a const char. Well, in

Re: Qt4 frontend save/restore geoemtry patch

2006-06-22 Thread younes . a
Quoting Peter Kümmel <[EMAIL PROTECTED]>: > Abdelrazak Younes wrote: > >> > >> I think we should use QMainWindow::centralWidget().width/height instead. > > > > In this particular case, yes. But I would prefer to fix the problem at > > the source: We don't need the width and height on BufferView

Re: Qt4 frontend save/restore geoemtry patch

2006-06-22 Thread Andre Poenitz
On Tue, Jun 20, 2006 at 01:09:15PM +0200, Peter Kümmel wrote: > + if (width != -1 && height != -1 && posx != -1 && posy != -1) { > + view.initNormalGeometry(QRect(posx, posy, width, height)); > + view.resize(width, height); > + view.move(posx, posy); > +

Re: Qt4 frontend save/restore geoemtry patch

2006-06-22 Thread Andre Poenitz
On Wed, Jun 21, 2006 at 10:24:31AM +, Angus Leeming wrote: > I think it's just because we decided it improves readability. These things > should be read from right to left: >QRect const & >A reference to a const QRect > >char const * const >A const pointer to a const char.

Re: Qt4 frontend save/restore geoemtry patch

2006-06-21 Thread Abdelrazak Younes
Peter Kümmel wrote: Hi Abdel, Bo here the next version with your embedded suggestions. I've also simplified the floating code. If you correct Lars small issue, that's fine with me. Good work. Abdel.

Re: Qt4 frontend save/restore geoemtry patch

2006-06-21 Thread Peter Kümmel
Bo Peng wrote: On 6/20/06, Peter Kümmel [EMAIL PROTECTED] wrote: Hi Abdel, Bo here the next version with your embedded suggestions. I've also simplified the floating code. Looks fine to me (others may have higher standard though). Is this patch against the trunk or some branch? I can

Re: Qt4 frontend save/restore geoemtry patch

2006-06-21 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: | + maxWidth=QApplication::desktop()-width()-20; Oooo... spacing. Year, I've only one line with spacing errors ;) | + if (width() maxWidth) | + maxWidth = width(); maxWidth = max(width(), maxWidth); Msvc needs std::max and #include algorithm.

Re: Qt4 frontend save/restore geoemtry patch

2006-06-21 Thread Lars Gullik Bjønnes
Peter Kümmel [EMAIL PROTECTED] writes: | Done. | | Attached the new patch. This is ok with me now. -- Lgb

Re: Qt4 frontend save/restore geoemtry patch

2006-06-21 Thread Angus Leeming
Peter Kümmel [EMAIL PROTECTED] writes: Lars Gullik Bjønnes wrote: QRect const Done. (Will search for the reason for this in the mailing list archive. The doc says Asger had strong arguments) I think it's just because we decided it improves readability. These things should be read from

Re: Qt4 frontend save/restore geoemtry patch

2006-06-21 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: Peter Kümmel [EMAIL PROTECTED] writes: | Done. | | Attached the new patch. This is ok with me now. I've checked it in. Having now the qt3 and the qt4 version of lyx on my machine here my two benchmark timings: Windows qt3: 18 sec qt4: 31 sec

Re: Qt4 frontend save/restore geoemtry patch

2006-06-21 Thread Abdelrazak Younes
Peter Kümmel wrote: Hi Abdel, Bo here the next version with your embedded suggestions. I've also simplified the floating code. If you correct Lars small issue, that's fine with me. Good work. Abdel.

Re: Qt4 frontend save/restore geoemtry patch

2006-06-21 Thread Peter Kümmel
Bo Peng wrote: > On 6/20/06, Peter Kümmel <[EMAIL PROTECTED]> wrote: >> Hi Abdel, Bo >> >> here the next version with your embedded suggestions. >> I've also simplified the floating code. > > Looks fine to me (others may have higher standard though). > > Is this patch against the trunk or some

Re: Qt4 frontend save/restore geoemtry patch

2006-06-21 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > | + maxWidth=QApplication::desktop()->width()-20; > > Oooo... spacing. Year, I've only one line with spacing errors ;) > | + if (width() > maxWidth) > | + maxWidth = width(); > > maxWidth = max(width(), maxWidth); Msvc needs std::max and #include .

Re: Qt4 frontend save/restore geoemtry patch

2006-06-21 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Done. | | Attached the new patch. This is ok with me now. -- Lgb

Re: Qt4 frontend save/restore geoemtry patch

2006-06-21 Thread Angus Leeming
Peter Kümmel <[EMAIL PROTECTED]> writes: > Lars Gullik Bjønnes wrote: >> QRect const & > Done. > (Will search for the reason for this in the mailing list archive. > The doc says Asger had strong arguments) I think it's just because we decided it improves readability. These things should be read

Re: Qt4 frontend save/restore geoemtry patch

2006-06-21 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | Done. > | > | Attached the new patch. > > This is ok with me now. > I've checked it in. Having now the qt3 and the qt4 version of lyx on my machine here my two benchmark timings: Windows qt3: 18 sec qt4: 31 sec

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Bo Peng wrote: But when you prefer the (-1,-1) solution I'll change it. Since (-1, -1) will save a significant amount of coding, I prefer this. Bo Here the patch with above changes. I've also implemented the patch for the qt3 frontend. Now Qt3 and Qt4 are an par on Linux and Windows. Diff

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Abdelrazak Younes
Peter Kümmel wrote: Bo Peng wrote: But when you prefer the (-1,-1) solution I'll change it. Since (-1, -1) will save a significant amount of coding, I prefer this. Bo Here the patch with above changes. Hello Peter, Thanks for the updated patch and sorry for the inconvenience that my

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Abdelrazak Younes wrote: Peter Kümmel wrote: Bo Peng wrote: But when you prefer the (-1,-1) solution I'll change it. Since (-1, -1) will save a significant amount of coding, I prefer this. Bo Here the patch with above changes. Hello Peter, Thanks for the updated patch and sorry for

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
-QtView::QtView(unsigned int width, unsigned int height) +QtView::QtView() : QMainWindow(), LyXView(), commandbuffer_(0), frontend_(*this) { -resize(width, height); - qApp-setMainWidget(this); -bufferview_.reset(new BufferView(this, width, height)); +

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Peter Kümmel wrote: -QtView::QtView(unsigned int width, unsigned int height) +QtView::QtView() : QMainWindow(), LyXView(), commandbuffer_(0), frontend_(*this) { -resize(width, height); - qApp-setMainWidget(this); -bufferview_.reset(new BufferView(this, width,

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: view.show(); -view.init(); So you don't need LyXView::init() anymore or is it done elsewhere? before the if (width ... I think it makes more sense to initialize before showing and resizing. Of course yes. I haven't seen it. //

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Abdelrazak Younes
Peter Kümmel wrote: Peter Kümmel wrote: -QtView::QtView(unsigned int width, unsigned int height) +QtView::QtView() : QMainWindow(), LyXView(), commandbuffer_(0), frontend_(*this) { -resize(width, height); - qApp-setMainWidget(this); -bufferview_.reset(new

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Abdelrazak Younes wrote: No, this is given by frameGeometry, see http://doc.trolltech.com/4.1/geometry.html same for Qt3 Hum, frameGeometry doesn't include the Window Title but it still include menubar and toolbar IIUC so I guess I am still right :-) Yes, I've realized it, see other mail.

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Abdelrazak Younes wrote: Peter Kümmel wrote: Peter Kümmel wrote: -QtView::QtView(unsigned int width, unsigned int height) +QtView::QtView() : QMainWindow(), LyXView(), commandbuffer_(0), frontend_(*this) { -resize(width, height); - qApp-setMainWidget(this); -

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Bo Peng
I've also implemented the patch for the qt3 frontend. Now Qt3 and Qt4 are an par on Linux and Windows. Diff against current svn. Thanks. I have not read what Abdel says about the patch. Here is mine: - if (posx != -1 posy != -1) - view.move(QPoint(posx, posy)); +

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Hum, we are talking about floating window geometry right? Why do you think about floatingGeometry_ instead of normalGeometry and setFloatingGeometry() instead of initNormalGeometry() ? floating is also a good description, but 'normal' is the name

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Bo Peng wrote: I've also implemented the patch for the qt3 frontend. Now Qt3 and Qt4 are an par on Linux and Windows. Diff against current svn. Thanks. I have not read what Abdel says about the patch. Here is mine: - if (posx != -1 posy != -1) -

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Bo Peng
The logic is that width and height should work without valid posx, and poxy. (saveGeometry controls that). I wondered if there is a case where the width is saved but not the position, couldn't the pos!=-1 be removed? At least this was the original logic. Saving windows width/height is safe,

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Hi Abdel, Bo here the next version with your embedded suggestions. I've also simplified the floating code. Peter Index: frontends/qt3/lyx_gui.C === --- frontends/qt3/lyx_gui.C (revision 14157) +++ frontends/qt3/lyx_gui.C

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Bo Peng
On 6/20/06, Peter Kümmel [EMAIL PROTECTED] wrote: Hi Abdel, Bo here the next version with your embedded suggestions. I've also simplified the floating code. Looks fine to me (others may have higher standard though). Is this patch against the trunk or some branch? I can not apply cleanly. Bo

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Lars Gullik Bjønnes
Peter Kümmel [EMAIL PROTECTED] writes: | Hi Abdel, Bo | | here the next version with your embedded suggestions. | I've also simplified the floating code. | | Peter | Index: frontends/qt3/QtView.C | === | --- frontends/qt3/QtView.C

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Bo Peng wrote: >> But when you prefer the (-1,-1) solution I'll change it. > > Since (-1, -1) will save a significant amount of coding, I prefer this. > > Bo Here the patch with above changes. I've also implemented the patch for the qt3 frontend. Now Qt3 and Qt4 are an par on Linux and

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Abdelrazak Younes
Peter Kümmel wrote: Bo Peng wrote: But when you prefer the (-1,-1) solution I'll change it. Since (-1, -1) will save a significant amount of coding, I prefer this. Bo Here the patch with above changes. Hello Peter, Thanks for the updated patch and sorry for the inconvenience that my

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Abdelrazak Younes wrote: > Peter Kümmel wrote: >> Bo Peng wrote: But when you prefer the (-1,-1) solution I'll change it. >>> Since (-1, -1) will save a significant amount of coding, I prefer this. >>> >>> Bo >> >> Here the patch with above changes. > > Hello Peter, > > Thanks for the

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
>>> -QtView::QtView(unsigned int width, unsigned int height) >>> +QtView::QtView() >>> : QMainWindow(), LyXView(), commandbuffer_(0), frontend_(*this) >>> { >>> -resize(width, height); >>> - >>> qApp->setMainWidget(this); >>> >>> -bufferview_.reset(new BufferView(this,

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Peter Kümmel wrote: -QtView::QtView(unsigned int width, unsigned int height) +QtView::QtView() : QMainWindow(), LyXView(), commandbuffer_(0), frontend_(*this) { -resize(width, height); - qApp->setMainWidget(this); -

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: view.show(); -view.init(); So you don't need LyXView::init() anymore or is it done elsewhere? before the if (width ... I think it makes more sense to initialize before showing and resizing. Of course yes. I haven't seen it. //

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Abdelrazak Younes
Peter Kümmel wrote: Peter Kümmel wrote: -QtView::QtView(unsigned int width, unsigned int height) +QtView::QtView() : QMainWindow(), LyXView(), commandbuffer_(0), frontend_(*this) { -resize(width, height); - qApp->setMainWidget(this); -bufferview_.reset(new

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Abdelrazak Younes wrote: >> No, this is given by frameGeometry, see >> http://doc.trolltech.com/4.1/geometry.html >> same for Qt3 > > Hum, frameGeometry doesn't include the "Window Title" but it still > include menubar and toolbar IIUC so I guess I am still right :-) Yes, I've realized it, see

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Abdelrazak Younes wrote: > Peter Kümmel wrote: >> Peter Kümmel wrote: >> -QtView::QtView(unsigned int width, unsigned int height) >> +QtView::QtView() >> : QMainWindow(), LyXView(), commandbuffer_(0), >> frontend_(*this) >> { >> -resize(width, height); >> -

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Bo Peng
I've also implemented the patch for the qt3 frontend. Now Qt3 and Qt4 are an par on Linux and Windows. Diff against current svn. Thanks. I have not read what Abdel says about the patch. Here is mine: - if (posx != -1 && posy != -1) - view.move(QPoint(posx, posy)); +

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Hum, we are talking about floating window geometry right? Why do you think about floatingGeometry_ instead of normalGeometry and setFloatingGeometry() instead of initNormalGeometry() ? floating is also a good description, but 'normal' is the name

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Bo Peng wrote: >> I've also implemented the patch for the qt3 frontend. >> Now Qt3 and Qt4 are an par on Linux and Windows. >> Diff against current svn. > > Thanks. I have not read what Abdel says about the patch. Here is mine: > >> - if (posx != -1 && posy != -1) >> -

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Bo Peng
> The logic is that width and height should work without valid posx, and > poxy. (saveGeometry controls that). I wondered if there is a case where the width is saved but not the position, couldn't the pos!=-1 be removed? At least this was the original logic. Saving windows width/height is

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Hi Abdel, Bo here the next version with your embedded suggestions. I've also simplified the floating code. Peter Index: frontends/qt3/lyx_gui.C === --- frontends/qt3/lyx_gui.C (revision 14157) +++ frontends/qt3/lyx_gui.C

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Bo Peng
On 6/20/06, Peter Kümmel <[EMAIL PROTECTED]> wrote: Hi Abdel, Bo here the next version with your embedded suggestions. I've also simplified the floating code. Looks fine to me (others may have higher standard though). Is this patch against the trunk or some branch? I can not apply cleanly.

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Hi Abdel, Bo | | here the next version with your embedded suggestions. | I've also simplified the floating code. | | Peter | Index: frontends/qt3/QtView.C | === | ---

Re: Qt4 frontend save/restore geoemtry patch

2006-06-19 Thread Peter Kümmel
Bo Peng wrote: Index: frontends/gtk/lyx_gui.C === Index: frontends/gt3/lyx_gui.C === Index: frontends/xforms/lyx_gui.C

Re: Qt4 frontend save/restore geoemtry patch

2006-06-19 Thread Peter Kümmel
Bo Peng wrote: Also, if -geometry is going to override everything, can not we do if (geometry option present) { width = -1; height = -1; start(... width, height, isMaximized) } Bo I also thought about this, and I also preferred it first because then I don't have to pass an

Re: Qt4 frontend save/restore geoemtry patch

2006-06-19 Thread Bo Peng
But when you prefer the (-1,-1) solution I'll change it. Since (-1, -1) will save a significant amount of coding, I prefer this. Bo

Re: Qt4 frontend save/restore geoemtry patch

2006-06-19 Thread Peter Kümmel
Bo Peng wrote: >> Index: frontends/gtk/lyx_gui.C >> === >> Index: frontends/gt3/lyx_gui.C >> === >> Index: frontends/xforms/lyx_gui.C >>

Re: Qt4 frontend save/restore geoemtry patch

2006-06-19 Thread Peter Kümmel
Bo Peng wrote: > Also, if -geometry is going to override everything, can not we do > > if (geometry option present) { > width = -1; > height = -1; > start(... width, height, isMaximized) > } > > Bo > > I also thought about this, and I also preferred it first because then I don't have to

Re: Qt4 frontend save/restore geoemtry patch

2006-06-19 Thread Bo Peng
But when you prefer the (-1,-1) solution I'll change it. Since (-1, -1) will save a significant amount of coding, I prefer this. Bo

Qt4 frontend save/restore geoemtry patch

2006-06-18 Thread Peter Kümmel
Bo Peng wrote: On 6/16/06, Peter Kümmel [EMAIL PROTECTED] wrote: I've fixed the save/restore and -geometry problem for Qt4. Therefore I have to remember lyx if there was the geometry option, and I have to emulate the QWidget::normalGeometry() function. I've tested it with Linux and Windows.

Re: Qt4 frontend save/restore geoemtry patch

2006-06-18 Thread Bo Peng
On 6/18/06, Peter Kümmel [EMAIL PROTECTED] wrote: The added event handlers of QtView are needed to remember the last geometry values) This part I trust you. Index: frontends/gtk/lyx_gui.C === Index: frontends/gt3/lyx_gui.C

Re: Qt4 frontend save/restore geoemtry patch

2006-06-18 Thread Bo Peng
Also, if -geometry is going to override everything, can not we do if (geometry option present) { width = -1; height = -1; start(... width, height, isMaximized) } Bo

Re: Qt4 frontend save/restore geoemtry patch

2006-06-18 Thread Abdelrazak Younes
Peter Kümmel wrote: I've changed the code so that the geometryOption is now passed as argument to lyx_gui::start. But I don't see a way to handle the geometry option in lyx_main. Hello Peter, I appreciate very much your work on qt4 but, in this particular case, could you wait a bit until my

Re: Qt4 frontend save/restore geoemtry patch

2006-06-18 Thread Lars Gullik Bjønnes
Bo Peng [EMAIL PROTECTED] writes: | Also, if -geometry is going to override everything, can not we do | | if (geometry option present) { |width = -1; | height = -1; |start(... width, height, isMaximized) | } I'd like that a lot better. -- Lgb

Qt4 frontend save/restore geoemtry patch

2006-06-18 Thread Peter Kümmel
Bo Peng wrote: > On 6/16/06, Peter Kümmel <[EMAIL PROTECTED]> wrote: >> I've fixed the save/restore and -geometry problem for Qt4. >> Therefore I have to remember lyx if there was the geometry option, >> and I have to emulate the QWidget::normalGeometry() function. >> >> I've tested it with Linux

Re: Qt4 frontend save/restore geoemtry patch

2006-06-18 Thread Bo Peng
On 6/18/06, Peter Kümmel <[EMAIL PROTECTED]> wrote: The added event handlers of QtView are needed to remember the last geometry values) This part I trust you. Index: frontends/gtk/lyx_gui.C === Index: frontends/gt3/lyx_gui.C

Re: Qt4 frontend save/restore geoemtry patch

2006-06-18 Thread Bo Peng
Also, if -geometry is going to override everything, can not we do if (geometry option present) { width = -1; height = -1; start(... width, height, isMaximized) } Bo

Re: Qt4 frontend save/restore geoemtry patch

2006-06-18 Thread Abdelrazak Younes
Peter Kümmel wrote: I've changed the code so that the geometryOption is now passed as argument to lyx_gui::start. But I don't see a way to handle the geometry option in lyx_main. Hello Peter, I appreciate very much your work on qt4 but, in this particular case, could you wait a bit until my

Re: Qt4 frontend save/restore geoemtry patch

2006-06-18 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | Also, if -geometry is going to override everything, can not we do | | if (geometry option present) { |width = -1; | height = -1; |start(... width, height, isMaximized) | } I'd like that a lot better. -- Lgb

Is the qt4 frontend ready for (experimental) use?

2006-03-23 Thread Helge Hafting
I finally got my compiler sorted out, I can compile lyx again. :-) At least I got the qt frontend going with g++ 4.1 I then tried to install qt4 tools libraries to compile that frontend, but it failed. Is qt4 simply not ready for testing yet, or broken in svn right now, or should I look for

Re: Is the qt4 frontend ready for (experimental) use?

2006-03-23 Thread Georg Baum
Helge Hafting wrote: Is qt4 simply not ready for testing yet, or broken in svn right now, or should I look for errors in my setup? It compiles fine here with gcc 3.3. Please send the error messages, maybe some error is tolerated by older gccs but not by gcc 4.1 Georg

Re: Is the qt4 frontend ready for (experimental) use?

2006-03-23 Thread Abdelrazak Younes
Helge Hafting a écrit : I finally got my compiler sorted out, I can compile lyx again. :-) At least I got the qt frontend going with g++ 4.1 I then tried to install qt4 tools libraries to compile that frontend, but it failed. Is qt4 simply not ready for testing yet, or broken in svn right

Is the qt4 frontend ready for (experimental) use?

2006-03-23 Thread Helge Hafting
I finally got my compiler sorted out, I can compile lyx again. :-) At least I got the qt frontend going with g++ 4.1 I then tried to install qt4 tools & libraries to compile that frontend, but it failed. Is qt4 simply not ready for testing yet, or broken in svn right now, or should I look

Re: Is the qt4 frontend ready for (experimental) use?

2006-03-23 Thread Georg Baum
Helge Hafting wrote: > Is qt4 simply not ready for testing yet, or broken in svn right now, > or should I look for errors in my setup? It compiles fine here with gcc 3.3. Please send the error messages, maybe some error is tolerated by older gccs but not by gcc 4.1 Georg

Re: Is the qt4 frontend ready for (experimental) use?

2006-03-23 Thread Abdelrazak Younes
Helge Hafting a écrit : I finally got my compiler sorted out, I can compile lyx again. :-) At least I got the qt frontend going with g++ 4.1 I then tried to install qt4 tools & libraries to compile that frontend, but it failed. Is qt4 simply not ready for testing yet, or broken in svn right

Re: Qt4 frontend

2006-03-20 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Fri, Mar 17, 2006 at 04:21:16PM +0200, Martin Vermeer wrote: On Fri, Mar 17, 2006 at 02:49:13PM +0100, Abdelrazak Younes wrote: ... Actually with your first patch, if you open a document, type Ctrl+end, then only half of of screen is redrawn :-) And if you open a

Re: Qt4 frontend

2006-03-20 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin On Fri, Mar 17, 2006 at 04:21:16PM +0200, Martin Vermeer Martin wrote: On Fri, Mar 17, 2006 at 02:49:13PM +0100, Abdelrazak Younes wrote: ... Actually with your first patch, if you open a document, type Ctrl+end, then only half

Re: Qt4 frontend

2006-03-20 Thread Martin Vermeer
On Mon, 2006-03-20 at 14:01 +0100, Abdelrazak Younes wrote: Martin Vermeer a écrit : On Fri, Mar 17, 2006 at 04:21:16PM +0200, Martin Vermeer wrote: On Fri, Mar 17, 2006 at 02:49:13PM +0100, Abdelrazak Younes wrote: ... Actually with your first patch, if you open a document, type

Re: Qt4 frontend

2006-03-20 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin On Fri, Mar 17, 2006 at 04:21:16PM +0200, Martin Vermeer Martin wrote: On Fri, Mar 17, 2006 at 02:49:13PM +0100, Abdelrazak Younes wrote: ... Actually with your first patch, if you open a document,

Re: Qt4 frontend

2006-03-20 Thread Martin Vermeer
On Mon, 2006-03-20 at 16:08 +0100, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin On Fri, Mar 17, 2006 at 04:21:16PM +0200, Martin Vermeer Martin wrote: On Fri, Mar 17, 2006 at 02:49:13PM +0100, Abdelrazak Younes wrote: ... Actually with

Re: Qt4 frontend

2006-03-20 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Is this supposed to help with 1.4? We have some reports of operations on mac being dependent on document size Martin Which operations? Core operations are unrelated to this patch. Things like that:

Re: Qt4 frontend

2006-03-20 Thread Martin Vermeer
On Mon, 2006-03-20 at 17:01 +0100, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Is this supposed to help with 1.4? We have some reports of operations on mac being dependent on document size Martin Which operations? Core operations are unrelated to this

Re: Qt4 frontend

2006-03-20 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Fri, Mar 17, 2006 at 04:21:16PM +0200, Martin Vermeer wrote: On Fri, Mar 17, 2006 at 02:49:13PM +0100, Abdelrazak Younes wrote: ... Actually with your first patch, if you open a document, type Ctrl+end, then only half of of screen is redrawn :-) And if you open a

Re: Qt4 frontend

2006-03-20 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Fri, Mar 17, 2006 at 04:21:16PM +0200, Martin Vermeer Martin> wrote: >> On Fri, Mar 17, 2006 at 02:49:13PM +0100, Abdelrazak Younes wrote: >> >> ... >> >> > Actually with your first patch, if you open a document, type >>

Re: Qt4 frontend

2006-03-20 Thread Martin Vermeer
On Mon, 2006-03-20 at 14:01 +0100, Abdelrazak Younes wrote: > Martin Vermeer a écrit : > > On Fri, Mar 17, 2006 at 04:21:16PM +0200, Martin Vermeer wrote: > >> On Fri, Mar 17, 2006 at 02:49:13PM +0100, Abdelrazak Younes wrote: > >> > >> ... > >> > >>> Actually with your first patch, if you open

  1   2   3   >