Re: [PATCH] How to setup image converters on Mac?

2017-09-30 Thread Scott Kostyshak
On Thu, Sep 28, 2017 at 07:30:45AM +, Enrico Forestieri wrote: > On Wed, Sep 27, 2017 at 10:34:20PM +0200, Stephan Witt wrote: > > > > Ok, here is my next proposed patch. Now lyxconvert should be compiled > > and installed on Mac only, in convertDefault.py a test for platform > > darwin is

Re: [PATCH] How to setup image converters on Mac?

2017-09-28 Thread Enrico Forestieri
On Wed, Sep 27, 2017 at 10:34:20PM +0200, Stephan Witt wrote: > > Ok, here is my next proposed patch. Now lyxconvert should be compiled > and installed on Mac only, in convertDefault.py a test for platform > darwin is active to ensure it is called on Mac only. > > This should avoid to fix

Re: [PATCH] How to setup image converters on Mac?

2017-09-27 Thread Stephan Witt
Am 27.09.2017 um 18:54 schrieb Scott Kostyshak : > > On Tue, Sep 26, 2017 at 09:32:34PM +, Enrico Forestieri wrote: > >>> What do you think? IMO, the benefit on Mac is enough to take the risk. >>> That’s not true for the other platforms. >> >> I agree. > > Whatever you

Re: [PATCH] How to setup image converters on Mac?

2017-09-27 Thread Scott Kostyshak
On Tue, Sep 26, 2017 at 09:32:34PM +, Enrico Forestieri wrote: > > What do you think? IMO, the benefit on Mac is enough to take the risk. > > That’s not true for the other platforms. > > I agree. Whatever you all agree on for 2.3.x is fine in my opinion. Thanks for all of your work on this

Re: [PATCH] How to setup image converters on Mac?

2017-09-26 Thread Enrico Forestieri
On Tue, Sep 26, 2017 at 11:07:00PM +0200, Stephan Witt wrote: > Am 26.09.2017 um 21:10 schrieb Enrico Forestieri : > > > > On Mon, Sep 25, 2017 at 11:38:05PM +0200, Stephan Witt wrote: > >> Am 25.09.2017 um 23:23 schrieb Enrico Forestieri : > >>> > >>> There are a

Re: [PATCH] How to setup image converters on Mac?

2017-09-26 Thread Stephan Witt
Am 26.09.2017 um 21:10 schrieb Enrico Forestieri : > > On Mon, Sep 25, 2017 at 11:38:05PM +0200, Stephan Witt wrote: >> Am 25.09.2017 um 23:23 schrieb Enrico Forestieri : >>> >>> There are a few icons with empty text, but there are also all the ipa icons >>> that

Re: [PATCH] How to setup image converters on Mac?

2017-09-26 Thread Enrico Forestieri
On Mon, Sep 25, 2017 at 11:38:05PM +0200, Stephan Witt wrote: > Am 25.09.2017 um 23:23 schrieb Enrico Forestieri : > > > > There are a few icons with empty text, but there are also all the ipa icons > > that contain text. These texts should be changed to paths, otherwise they > >

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Stephan Witt
Am 25.09.2017 um 23:23 schrieb Enrico Forestieri : > > On Mon, Sep 25, 2017 at 08:50:11PM +0200, Stephan Witt wrote: >> Am 25.09.2017 um 17:05 schrieb Enrico Forestieri : >>> >>> So, it seems that a QApplication is necessary when the svg image contains >>> text.

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Enrico Forestieri
On Mon, Sep 25, 2017 at 08:50:11PM +0200, Stephan Witt wrote: > Am 25.09.2017 um 17:05 schrieb Enrico Forestieri : > > > > So, it seems that a QApplication is necessary when the svg image contains > > text. All of our icons should be text free, but some pathological cases > > may

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Stephan Witt
Am 25.09.2017 um 17:05 schrieb Enrico Forestieri : > > On Mon, Sep 25, 2017 at 03:13:18PM +0200, Stephan Witt wrote: > >> Am 25.09.2017 um 14:15 schrieb Enrico Forestieri : >>> >>> On Mon, Sep 25, 2017 at 09:17:41AM +0200, Stephan Witt wrote: Oh no. I

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Kornel Benko
Am Montag, 25. September 2017 um 16:12:08, schrieb Stephan Witt > Am 25.09.2017 um 15:00 schrieb Kornel Benko : > > > > Am Montag, 25. September 2017 um 14:33:04, schrieb Enrico Forestieri > > > >> On Mon, Sep 25, 2017 at 09:31:45AM +0200,

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Enrico Forestieri
On Mon, Sep 25, 2017 at 03:13:18PM +0200, Stephan Witt wrote: > Am 25.09.2017 um 14:15 schrieb Enrico Forestieri : > > > > On Mon, Sep 25, 2017 at 09:17:41AM +0200, Stephan Witt wrote: > >> > >> Oh no. I did some further testing and now I’m feeling blue. > >> > >> Not all SVG

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Stephan Witt
Am 25.09.2017 um 15:00 schrieb Kornel Benko : > > Am Montag, 25. September 2017 um 14:33:04, schrieb Enrico Forestieri > >> On Mon, Sep 25, 2017 at 09:31:45AM +0200, Jean-Marc Lasgouttes wrote: >>> Le 25/09/2017 à 08:26, Stephan Witt a écrit : Now I wonder

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Stephan Witt
Am 25.09.2017 um 14:15 schrieb Enrico Forestieri : > > On Mon, Sep 25, 2017 at 09:17:41AM +0200, Stephan Witt wrote: >> >> Oh no. I did some further testing and now I’m feeling blue. >> >> Not all SVG images we provide can be converted this way. >> >> $

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Kornel Benko
Am Montag, 25. September 2017 um 14:33:04, schrieb Enrico Forestieri > On Mon, Sep 25, 2017 at 09:31:45AM +0200, Jean-Marc Lasgouttes wrote: > > Le 25/09/2017 à 08:26, Stephan Witt a écrit : > > > Now I wonder if it would be better to name the utility lyxconvert. > > > It will be

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Enrico Forestieri
On Mon, Sep 25, 2017 at 09:31:45AM +0200, Jean-Marc Lasgouttes wrote: > Le 25/09/2017 à 08:26, Stephan Witt a écrit : > > Now I wonder if it would be better to name the utility lyxconvert. > > It will be installed in /usr/local/bin or something like that? > > I was about to suggest this. And then

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Enrico Forestieri
On Mon, Sep 25, 2017 at 09:17:41AM +0200, Stephan Witt wrote: > > Oh no. I did some further testing and now I’m feeling blue. > > Not all SVG images we provide can be converted this way. > > $ lyx-build/LyX-2.4.0dev.app/Contents/MacOS/lyxconvert -d > lyx/lib/images/math-subscript.svgz

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Jean-Marc Lasgouttes
Le 25/09/2017 à 10:57, Stephan Witt a écrit : Am 25.09.2017 um 09:31 schrieb Jean-Marc Lasgouttes : Le 25/09/2017 à 08:26, Stephan Witt a écrit : Now I wonder if it would be better to name the utility lyxconvert. It will be installed in /usr/local/bin or something like

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Stephan Witt
Am 25.09.2017 um 09:31 schrieb Jean-Marc Lasgouttes : > > Le 25/09/2017 à 08:26, Stephan Witt a écrit : >> Now I wonder if it would be better to name the utility lyxconvert. >> It will be installed in /usr/local/bin or something like that? > > I was about to suggest this. And

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Jean-Marc Lasgouttes
Le 25/09/2017 à 08:26, Stephan Witt a écrit : Now I wonder if it would be better to name the utility lyxconvert. It will be installed in /usr/local/bin or something like that? I was about to suggest this. And then do we want to honor version-suffix? I guess not, but we might end up installing

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Stephan Witt
Am 25.09.2017 um 04:35 schrieb Scott Kostyshak : > > On Sun, Sep 24, 2017 at 11:39:09PM +0200, Enrico Forestieri wrote: > >> It works for me on linux and cygwin. Of course, one has to move away >> convert, rsvg-convert, and inkscape to appreciate that. > > Thanks, Stephan, for

Re: [PATCH] How to setup image converters on Mac?

2017-09-25 Thread Stephan Witt
Am 24.09.2017 um 23:39 schrieb Enrico Forestieri : > > On Sun, Sep 24, 2017 at 10:06:24PM +0200, Stephan Witt wrote: >> Am 24.09.2017 um 18:26 schrieb Stephan Witt : >>> Am 24.09.2017 um 18:12 schrieb Enrico Forestieri : On Sun, Sep 24, 2017

Re: [PATCH] How to setup image converters on Mac?

2017-09-24 Thread Scott Kostyshak
On Sun, Sep 24, 2017 at 11:39:09PM +0200, Enrico Forestieri wrote: > It works for me on linux and cygwin. Of course, one has to move away > convert, rsvg-convert, and inkscape to appreciate that. Thanks, Stephan, for the patch, and Enrico, for testing on Linux and Cygwin. I think it is a good

Re: [PATCH] How to setup image converters on Mac?

2017-09-24 Thread Enrico Forestieri
On Sun, Sep 24, 2017 at 10:06:24PM +0200, Stephan Witt wrote: > Am 24.09.2017 um 18:26 schrieb Stephan Witt : > > Am 24.09.2017 um 18:12 schrieb Enrico Forestieri : > >> On Sun, Sep 24, 2017 at 12:24:26PM +0200, Stephan Witt wrote: > >>> > >>> This is the solution

Re: [PATCH] How to setup image converters on Mac?

2017-09-24 Thread Stephan Witt
Am 24.09.2017 um 18:26 schrieb Stephan Witt : > > Am 24.09.2017 um 18:12 schrieb Enrico Forestieri : >> >> On Sun, Sep 24, 2017 at 12:24:26PM +0200, Stephan Witt wrote: >>> >>> This is the solution I’d like to propose. It’s not tested on Linux and >>> Windows.

Re: [PATCH] How to setup image converters on Mac?

2017-09-24 Thread Stephan Witt
Am 24.09.2017 um 18:12 schrieb Enrico Forestieri : > > On Sun, Sep 24, 2017 at 12:24:26PM +0200, Stephan Witt wrote: >> >> This is the solution I’d like to propose. It’s not tested on Linux and >> Windows. >> >> The idea is to add imgconvert as fallback-converter for SVG to PDF