Re: Wireless network card capabilities

2007-02-05 Thread Ashwin Chaugule
On Sun, 2007-02-04 at 13:27 +0100, Ulrich Kunitz wrote: On 07-02-04 10:42 James Courtier-Dutton wrote: Hi, Can Wireless network cards receive and transmit on two channels at once? I am thinking of implementing a way for a wireless VoIP phone on Linux being able to hand off from one

NAPI quota and budget

2007-02-05 Thread Robert Olsson
Hello! K. Salah writes: I have a question about the quota per poll in NAPI. Any idea how the quota of 64 packets per poll per NIC was selected? Why 64, not any other number? Is there science behind this number. The number comes from experimentation. The science is thats it's

Re: [PATCH] HTB O(1) class lookup

2007-02-05 Thread Jarek Poplawski
On 01-02-2007 12:30, Andi Kleen wrote: Simon Lodal [EMAIL PROTECTED] writes: Memory is generally not an issue, but CPU is, and you can not beat the CPU efficiency of plain array lookup (always faster, and constant time). Probably for some old (or embedded) lean boxes used for small network

Re: [PATCH] HTB O(1) class lookup

2007-02-05 Thread Andi Kleen
On Monday 05 February 2007 11:16, Jarek Poplawski wrote: Strange - it seems you gave only arguments against this analysis... For a naturally clustered key space (as is common in this case) the two level structure is likely more cache efficient than a generic hash function. That is because

Re: [PATCH] HTB O(1) class lookup

2007-02-05 Thread Ingo Oeser
Andi Kleen schrieb: On Monday 05 February 2007 11:16, Jarek Poplawski wrote: I wonder, why not try, at least for a while, to do this a compile (menuconfig) option with a comment: recommended for a large number of classes. After hash optimization and some testing, final decisions could be

Re: [PATCH 3/4] skge: WOL support

2007-02-05 Thread Ingo Oeser
Hi Stephen, just a nitpick. Stephen Hemminger schrieb: --- skge.orig/drivers/net/skge.c +++ skge/drivers/net/skge.c @@ -132,18 +132,93 @@ static void skge_get_regs(struct net_dev } /* Wake on Lan only supported on Yukon chips with rev 1 or above */ -static int wol_supported(const

[RESEND PATCH 0/7] [S390]: Introduction of AF_IUCV sockets support

2007-02-05 Thread Frank Pavlic
Hello, seems that Patch 1/7 is lost and did not make its way to the mailing list :-( That's the reason why I resend the whole patch set again. Here we go ... The Inter-User Communication Vehicle (IUCV) is a z/VM communication facility that enables a program running in one virtual machine to

[PATCH 6/7] [S390]: Adapt special message interface to new IUCV API

2007-02-05 Thread Frank Pavlic
From: Martin Schwidefsky [EMAIL PROTECTED] Adapt special message interface to new IUCV API Signed-off-by: Frank Pavlic [EMAIL PROTECTED] Signed-off-by: Martin Schwidefsky [EMAIL PROTECTED] --- drivers/s390/net/smsgiucv.c | 147 ++- 1 files changed, 74

[PATCH 3/7] [S390]: Adapt monreader driver to new IUCV API

2007-02-05 Thread Frank Pavlic
From: Martin Schwidefsky [EMAIL PROTECTED] Adapt monreader character device driver to new IUCV API Signed-off-by: Frank Pavlic [EMAIL PROTECTED] Signed-off-by: Martin Schwidefsky [EMAIL PROTECTED] --- drivers/s390/char/monreader.c | 218 +++-- 1 files

[PATCH 7/7] [S390]: Add AF_IUCV socket support

2007-02-05 Thread Frank Pavlic
From: Jennifer Hunt[EMAIL PROTECTED] This patch adds AF_IUCV socket support. Signed-off-by: Frank Pavlic [EMAIL PROTECTED] Signed-off-by: Martin Schwidefsky [EMAIL PROTECTED] --- arch/s390/defconfig|1 include/linux/net.h|2 include/linux/socket.h |4

[PATCH 4/7] [S390]: Adapt vmlogrdr driver to new IUCV API

2007-02-05 Thread Frank Pavlic
From: Martin Schwidefsky [EMAIL PROTECTED] Adapt vmlogrdr character device driver to new IUCV API Signed-off-by: Frank Pavlic [EMAIL PROTECTED] Signed-off-by: Martin Schwidefsky [EMAIL PROTECTED] --- drivers/s390/char/vmlogrdr.c | 284 +++--- 1 files

RE: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-02-05 Thread Steve Hill
Vlad Yasevich wrote on 25 January 2007 16:33: Can you try the attached patch and let me know if the problem is fixed. You can try reducing rto_max or path_max_retrans to get the failover to happen a little faster. Sorry for the delay - I've been on vacation for the past week. I've tried

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-02-05 Thread John W. Linville
On Sat, Feb 03, 2007 at 08:43:49PM -0200, Marcelo Tosatti wrote: On Sat, Jan 27, 2007 at 02:53:07AM +0100, Arnd Bergmann wrote: On Tuesday 16 January 2007 19:55, Marcelo Tosatti wrote: +#define ENTER() dprintk(1, Enter: %s, %s:%i\n, __FUNCTION__, \ +

[PATCH] igmp: check add_grhead() return value

2007-02-05 Thread Alexey Dobriyan
OK, now that we aren't seeing crashes which can be attributed to these NULL dereferences any longer. -- add_grhead() allocates memory with GFP_ATOMIC and in at least two places skb from it passed to skb_put() without checking. Signed-off-by: Alexey Dobriyan

[PATCH 1/7] too big ??

2007-02-05 Thread Frank Pavlic
Hi, I realized that PATCH 1/7 of the AF_IUCV patch set is more than 100kb . Seems that this is too much for the mailing list. Well since I resent them some minutes ago I am wondering what would be the best way now to get PATCH 1/7 onto netdev . Shall I only send the splitted PATCH 1/7 or really

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-02-05 Thread Arnd Bergmann
On Monday 05 February 2007 15:01, John W. Linville wrote: I disagree, entry/exit points have been shown to be useful in practice to identify firmware problems on field. I'm not too fond of the ENTER/LEAVE stuff either.  But, I do sympathize that they _can_ be useful in certain

[PATCH 0/3] NetXen: 1G/10G Ethernet Driver updates

2007-02-05 Thread Amit S. Kale
Hi All, I will be sending NetXen: 1G/10G Ethernet Driver updates with respect to netdev #master in the subsequent emails. We have incorporated the feedbacks we got for the patch on the ethtool support for user level tools, except for these: Jeff Garzik wrote: is it ok to return without

[PATCH] d80211: respect extra_tx_headroom

2007-02-05 Thread Ivo van Doorn
When a driver requested additional header room through the extra_tx_headroom field, the stack should respect that and make sure that all frames that are being send to the stack actually have that extra header room. Signed-off-by Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3

[PATCH 1/3] NetXen: Fixes for ppc architecture.

2007-02-05 Thread Amit S. Kale
NetXen: Fixes for ppc architecture. Signed-off-by: Amit S. Kale [EMAIL PROTECTED] --- netxen_nic.h | 98 -- netxen_nic_hw.c | 31 - netxen_nic_init.c | 16 netxen_nic_main.c |7 ++- netxen_nic_niu.c

[PATCH 3/3] NetXen: Added ethtool support for user level tools.

2007-02-05 Thread Amit S. Kale
NetXen: Added ethtool support for user level firmware management utilities. Signed-off-by: Amit S. Kale [EMAIL PROTECTED] --- netxen_nic.h | 17 ++- netxen_nic_ethtool.c | 96 +++--- netxen_nic_init.c| 267++- 3 files

[PATCH 2.6.21-rc1] ehea: Fixed error recovery

2007-02-05 Thread Jan-Bernd Themann
Error recovery for QP errors: Reset QPs and dump error information Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c |8 +++- drivers/net/ehea/ehea_phyp.c | 10 ++ drivers/net/ehea/ehea_phyp.h |3

Re: [take35 0/10] kevent: Generic event handling mechanism.

2007-02-05 Thread Evgeniy Polyakov
On Thu, Feb 01, 2007 at 01:12:30PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: Generic event handling mechanism. Kevent is a generic subsytem which allows to handle event notifications. It supports both level and edge triggered events. It is similar to poll/epoll in some cases, but

Re: when having to acquire an SA, ipsec drops the packet

2007-02-05 Thread James Morris
On Sun, 4 Feb 2007, David Miller wrote: Something like this (untested) on the ipv4 side, for example: Looks like it should work. Will do some testing. -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-02-05 Thread Vlad Yasevich
Steve Hill wrote: Vlad Yasevich wrote on 25 January 2007 16:33: Can you try the attached patch and let me know if the problem is fixed. You can try reducing rto_max or path_max_retrans to get the failover to happen a little faster. Sorry for the delay - I've been on vacation for the past

Re: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-02-05 Thread Vlad Yasevich
Hi Steve Steve Hill wrote: Vlad Yasevich wrote on 05 February 2007 16:39: Once you start simulating the network failure, how long do you wait? If you have not changed rto_max and path_max_retrans, you can end up waiting quite a while for the full path switchover. This will also severely

Question on IOAT

2007-02-05 Thread Olaf Kirch
Hi, I looked into the IOAT code today as I'm trying to find out how to add support for it to NFS. I ran into this piece of code, which waits for the DMA operation to complete: while (dma_async_memcpy_complete(tp-ucopy.dma_chan,

RE: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-02-05 Thread Steve Hill
Vlad Yasevich wrote on 05 February 2007 17:08: 1. What did you set the sinfo_timetolive to? I presume you mean the timetolive parameter of sctp_sendmsg()? - this was set to 1400ms (as previously mentioned, this was in error but it does appear to have highlighted a problem with the stack

Re: [PATCH] sky2: flow control off

2007-02-05 Thread Stephen Hemminger
Here is what I saw. The transmitter on the Marvell Yukon II (88e8053) hangs when doing transmit flow control under load. There appears to be a bug or race condition that causes the MAC to stop transmitting data. There are two drivers for the Yukon II device on Linux. SysKonnect/Marvell has one

Re: [PATCH 1/2] d80211: Add software RTS support

2007-02-05 Thread Jiri Benc
On Wed, 31 Jan 2007 20:16:50 +0100, Ivo van Doorn wrote: Not all hardware are capable of generating their own RTS frames. This patch will add support for creating the RTS frame in software, when the driver requests this through the flag IEEE80211_HW_SOFTWARE_RTS It seems this is not the ideal

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-05 Thread Brian Haley
Please, if you think you can find a way for us to do optimistic dad flags as opt-in, rather than masked out, I'm all for it. Thanks! This patch should apply on-top of yours, if you want I can send the whole thing out too. I've only compile-tested it, so don't know if it behaves the same as

Re: [PATCH 2/2] d80211: Add software sequence support

2007-02-05 Thread Jiri Benc
On Sat, 3 Feb 2007 12:45:26 +0100, Ivo van Doorn wrote: --- dscape/net/d80211/ieee80211_i.h 2007-01-31 19:41:53.0 +0100 +++ dscape_seq/net/d80211/ieee80211_i.h 2007-01-31 20:06:26.0 +0100 @@ -405,6 +405,7 @@ int *supp_rates[NUM_IEEE80211_MODES]; int

Re: [PATCH 1/2] d80211: Add software RTS support

2007-02-05 Thread Michael Buesch
On Monday 05 February 2007 18:28, Jiri Benc wrote: On Wed, 31 Jan 2007 20:16:50 +0100, Ivo van Doorn wrote: Not all hardware are capable of generating their own RTS frames. This patch will add support for creating the RTS frame in software, when the driver requests this through the flag

Re: [PATCH 1/2] d80211: Add software RTS support

2007-02-05 Thread Ivo van Doorn
On Monday 05 February 2007 18:28, Jiri Benc wrote: On Wed, 31 Jan 2007 20:16:50 +0100, Ivo van Doorn wrote: Not all hardware are capable of generating their own RTS frames. This patch will add support for creating the RTS frame in software, when the driver requests this through the flag

Re: [PATCH 1/2] d80211: Add software RTS support

2007-02-05 Thread Michael Buesch
On Monday 05 February 2007 18:43, Ivo van Doorn wrote: On Monday 05 February 2007 18:28, Jiri Benc wrote: On Wed, 31 Jan 2007 20:16:50 +0100, Ivo van Doorn wrote: Not all hardware are capable of generating their own RTS frames. This patch will add support for creating the RTS frame in

Re: [PATCH 2/2] d80211: Add software sequence support

2007-02-05 Thread Ivo van Doorn
On Monday 05 February 2007 18:37, Jiri Benc wrote: On Sat, 3 Feb 2007 12:45:26 +0100, Ivo van Doorn wrote: --- dscape/net/d80211/ieee80211_i.h 2007-01-31 19:41:53.0 +0100 +++ dscape_seq/net/d80211/ieee80211_i.h 2007-01-31 20:06:26.0 +0100 @@ -405,6 +405,7 @@ int

Re: [PATCH 1/2] d80211: Add software RTS support

2007-02-05 Thread Ivo van Doorn
Hi, Not all hardware are capable of generating their own RTS frames. This patch will add support for creating the RTS frame in software, when the driver requests this through the flag IEEE80211_HW_SOFTWARE_RTS It seems this is not the ideal solution. Most of drivers needing

Re: [PATCH 1/2] d80211: Add software RTS support

2007-02-05 Thread Jiri Benc
On Mon, 5 Feb 2007 18:43:06 +0100, Michael Buesch wrote: I also think that sending RTS in software is not going to work, as the timing can not be guaranteed. And timing is why we do it in the first place. If the HW is not capable of sending RTS frames, we should not try to emulate them in SW,

Re: Extensible hashing and RCU

2007-02-05 Thread akepner
On Sat, 4 Feb 2007 [EMAIL PROTECTED] wrote: I noticed in an LCA talk mention that apprently extensible hashing with RCU access is an unsolved problem. Here's an idea for solving it. Yes, I have been playing around with the same idea for doing dynamic resizing of the TCP hashtable. Did

Re: [PATCH 1/2] d80211: Add software RTS support

2007-02-05 Thread Ivo van Doorn
On Monday 05 February 2007 19:08, Jiri Benc wrote: On Mon, 5 Feb 2007 18:43:06 +0100, Michael Buesch wrote: I also think that sending RTS in software is not going to work, as the timing can not be guaranteed. And timing is why we do it in the first place. If the HW is not capable of sending

Re: [PATCH 1/2] d80211: Add software RTS support

2007-02-05 Thread Michael Buesch
On Monday 05 February 2007 19:07, Ivo van Doorn wrote: Hi, Not all hardware are capable of generating their own RTS frames. This patch will add support for creating the RTS frame in software, when the driver requests this through the flag IEEE80211_HW_SOFTWARE_RTS

Re: Question on IOAT

2007-02-05 Thread Chris Leech
On 2/5/07, Olaf Kirch [EMAIL PROTECTED] wrote: Nowhere in the dma_async_*complete functions can I see any code that would sleep if the DMA is not yet complete. Am I missing something, or are we really busy-waiting on the DMA engine? Wouldn't this kind of defeat the purpose of freeing up the CPU

Re: [PATCH 1/2] d80211: Add software RTS support

2007-02-05 Thread Michael Buesch
On Monday 05 February 2007 19:08, Jiri Benc wrote: On Mon, 5 Feb 2007 18:43:06 +0100, Michael Buesch wrote: I also think that sending RTS in software is not going to work, as the timing can not be guaranteed. And timing is why we do it in the first place. If the HW is not capable of sending

Re: [PATCH] sky2: flow control off

2007-02-05 Thread Willy Tarreau
Hi Stephen, First, thanks for this detailed explanation. On Mon, Feb 05, 2007 at 09:22:53AM -0800, Stephen Hemminger wrote: Here is what I saw. The transmitter on the Marvell Yukon II (88e8053) hangs when doing transmit flow control under load. There appears to be a bug or race condition

Re: [PATCH 1/2] d80211: Add software RTS support

2007-02-05 Thread Ivo van Doorn
Hi, Did you already send that patchset to the netdev list? Because I haven't seen a patch series about rts for d80211 yet. No, [EMAIL PROTECTED] Hmm, wasn't subscribed to that list yet. :( But now I am. :) The new rt2500usb and rt73usb packet ring handling no longer use a DMA buffer

[PATCH] phy devices: use same arg types

2007-02-05 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] sparse complains about differing types from prototype to definition, so change the u32 to phy_interface_t: drivers/net/phy/phy_device.c:140:19: error: symbol 'phy_connect' redeclared with different type (originally declared at include/linux/phy.h:362) -

Re: [RFC/TOY]Extensible hashing and RCU

2007-02-05 Thread akepner
On Sat, 4 Feb 2007 [EMAIL PROTECTED] wrote: I noticed in an LCA talk mention that apprently extensible hashing with RCU access is an unsolved problem. Here's an idea for solving it. I'm assuming the table is a power of 2 in size with open chaining for collisions. When the chains get too

Re: [PATCH 1/3] d80211: Add control structure for beacontemplates

2007-02-05 Thread Jiri Benc
On Sat, 3 Feb 2007 17:25:18 +0100, Ivo van Doorn wrote: When rt2500usb and rt73usb will start using beacontemplates, they would also need a control structure to be passed along to correctly set the tx parameters. Good catch, thanks. This patch will add the allocation an initialization of a

Re: when having to acquire an SA, ipsec drops the packet

2007-02-05 Thread James Morris
On Mon, 5 Feb 2007, James Morris wrote: On Sun, 4 Feb 2007, David Miller wrote: Something like this (untested) on the ipv4 side, for example: Looks like it should work. Will do some testing. Appears to work well, with a slight delay on the first packet as expected. Tested with tcp,

Re: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-02-05 Thread Vlad Yasevich
Hi Steve would you mind terribly, changing the -d $net to the -i $net, and run the script with the interface name instead? The reason is, that I see 2 different behaviors between blocking by interface and blocking by IP and would like to find out if you see it too. When I block at the

RE: when having to acquire an SA, ipsec drops the packet

2007-02-05 Thread Venkat Yekkirala
Something like this (untested) on the ipv4 side, for example: diff --git a/include/net/route.h b/include/net/route.h index 486e37a..a8af632 100644 --- a/include/net/route.h +++ b/include/net/route.h @@ -146,7 +146,8 @@ static inline char rt_tos2priority(u8 tos) static inline int

Re: when having to acquire an SA, ipsec drops the packet

2007-02-05 Thread Joy Latten
On Thu, 2007-02-01 at 18:44 -0500, James Morris wrote: On Thu, 1 Feb 2007, Joy Latten wrote: IPsec returns EAGAIN when it needs to acquire an SA. There have been a thread or two about this... Has there been any info or progress in how best to fix this? James Morris presented some

Re: when having to acquire an SA, ipsec drops the packet

2007-02-05 Thread David Miller
From: James Morris [EMAIL PROTECTED] Date: Mon, 5 Feb 2007 15:34:39 -0500 (EST) On Mon, 5 Feb 2007, James Morris wrote: On Sun, 4 Feb 2007, David Miller wrote: Something like this (untested) on the ipv4 side, for example: Looks like it should work. Will do some testing.

Re: when having to acquire an SA, ipsec drops the packet

2007-02-05 Thread Joy Latten
I can run some tests with this patch and report any results... Regards, Joy On Sun, 2007-02-04 at 20:53 -0800, David Miller wrote: From: James Morris [EMAIL PROTECTED] Date: Thu, 1 Feb 2007 18:44:48 -0500 (EST) A quick dirty solution, which is what I think the BSD kernels do, is to

Re: when having to acquire an SA, ipsec drops the packet

2007-02-05 Thread David Miller
From: Venkat Yekkirala [EMAIL PROTECTED] Date: Mon, 5 Feb 2007 14:49:17 -0600 Something like this (untested) on the ipv4 side, for example: diff --git a/include/net/route.h b/include/net/route.h index 486e37a..a8af632 100644 --- a/include/net/route.h +++ b/include/net/route.h @@

Re: when having to acquire an SA, ipsec drops the packet

2007-02-05 Thread David Miller
From: Joy Latten [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 14:53:39 -0600 I can run some tests with this patch and report any results... Please check out the two most recent patches I posted: 1) Updated core patch with ipv6 side added. 2) Fix for thinko noticed by Venkat. Thanks. - To

netdev-2.6 rebased

2007-02-05 Thread Jeff Garzik
I just rebased all branches of netdev-2.6.git, against current Linus TOT (v2.6.20). New maintainers (hi Jay) for example will want to re-clone rather than pulling the remote branch 'foo' into local branch 'foo'. Jeff - To unsubscribe from this list: send the line unsubscribe netdev

[PATCH] apply cwnd rules to FIN packets with data

2007-02-05 Thread John Heffner
This is especially important with TSO enabled. Currently, it will send a burst of up to 64k at the end of a connection, even when cwnd is much smaller than 64k. This patch still lets out empty FIN packets, but does not apply the special case to FINs carrying data. -John Apply cwnd rules

Re: [PATCH] apply cwnd rules to FIN packets with data

2007-02-05 Thread David Miller
From: John Heffner [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 16:58:18 -0500 This is especially important with TSO enabled. Currently, it will send a burst of up to 64k at the end of a connection, even when cwnd is much smaller than 64k. This patch still lets out empty FIN packets, but does

Re: [PATCH] apply cwnd rules to FIN packets with data

2007-02-05 Thread David Miller
From: John Heffner [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 18:02:19 -0500 David Miller wrote: From: John Heffner [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 16:58:18 -0500 This is especially important with TSO enabled. Currently, it will send a burst of up to 64k at the end of a

Re: [PATCH] apply cwnd rules to FIN packets with data

2007-02-05 Thread John Heffner
David Miller wrote: From: John Heffner [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 16:58:18 -0500 This is especially important with TSO enabled. Currently, it will send a burst of up to 64k at the end of a connection, even when cwnd is much smaller than 64k. This patch still lets out empty FIN

Re: [PATCH] d80211: respect extra_tx_headroom

2007-02-05 Thread Ivo van Doorn
On Monday 05 February 2007 22:37, Jiri Benc wrote: On Mon, 5 Feb 2007 16:32:24 +0100, Ivo van Doorn wrote: When a driver requested additional header room through the extra_tx_headroom field, the stack should respect that and make sure that all frames that are being send to the stack

Re: [PATCH] HTB O(1) class lookup

2007-02-05 Thread Simon Lodal
On Monday 05 February 2007 11:16, Jarek Poplawski wrote: On 01-02-2007 12:30, Andi Kleen wrote: Simon Lodal [EMAIL PROTECTED] writes: Memory is generally not an issue, but CPU is, and you can not beat the CPU efficiency of plain array lookup (always faster, and constant time). Probably

Re: [PATCH] HTB O(1) class lookup

2007-02-05 Thread Simon Lodal
On Thursday 01 February 2007 12:30, Andi Kleen wrote: Simon Lodal [EMAIL PROTECTED] writes: Memory is generally not an issue, but CPU is, and you can not beat the CPU efficiency of plain array lookup (always faster, and constant time). Actually that's not true when the array doesn't fit in

Re: [PATCH] apply cwnd rules to FIN packets with data

2007-02-05 Thread John Heffner
David Miller wrote: However, I can't think of any reason why the cwnd test should not apply. Care to elaborate here? You can view the FIN special case as an off by one error in the CWND test, it's not going to melt the internet. :-) True, it's not going to melt the internet, but why stop at

Re: [PATCH] apply cwnd rules to FIN packets with data

2007-02-05 Thread Rick Jones
John Heffner wrote: David Miller wrote: However, I can't think of any reason why the cwnd test should not apply. Care to elaborate here? You can view the FIN special case as an off by one error in the CWND test, it's not going to melt the internet. :-) True, it's not going to melt the

Re: [PATCH] apply cwnd rules to FIN packets with data

2007-02-05 Thread John Heffner
Rick Jones wrote: John Heffner wrote: David Miller wrote: However, I can't think of any reason why the cwnd test should not apply. Care to elaborate here? You can view the FIN special case as an off by one error in the CWND test, it's not going to melt the internet. :-) True, it's not

[patch 01/11] user of the jiffies rounding code: Networking

2007-02-05 Thread akpm
From: Arjan van de Ven [EMAIL PROTECTED] This patch introduces users of the round_jiffies() function in the networking code. These timers all were of the about once a second or about once every X seconds variety and several showed up in the what wakes the cpu up profiles that the tickless

[patch 05/11] bonding: Replace kmalloc() + memset() pairs with the appropriate kzalloc() calls

2007-02-05 Thread akpm
From: Joe Jin [EMAIL PROTECTED] Replace kmalloc() + memset() pairs with the appropriate kzalloc() calls in the bonding driver. Signed-off-by: Joe Jin [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/bonding/bond_alb.c |4 +---

[patch 08/11] slip: Replace kmalloc() + memset() pairs with the appropriate kzalloc() calls

2007-02-05 Thread akpm
From: joe jin [EMAIL PROTECTED] This patch replace kmalloc() + memset() pairs with the appropriate kzalloc(). Signed-off-by: Joe Jin [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/slip.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff -puN

[patch 04/11] z85230: spinlock logic

2007-02-05 Thread akpm
From: Alan Cox [EMAIL PROTECTED] At some point someone added a spin_lock(dev-lock) to the IRQ handler for the Z85230 driver. This actually correctly fixes a bug but the necessary changes to remove the chan-lock calls in the event handlers were not made (c-lock is the same lock). Simona Dascenzo

[patch 09/11] Remove unused kernel config option DLCI_COUNT

2007-02-05 Thread akpm
From: Robert P. J. Day [EMAIL PROTECTED] Remove the unused kernel config option DLCI_COUNT. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Cc: David S. Miller [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Krzysztof Halasa [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

[patch 11/11] netfilter warning fix

2007-02-05 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] using smp_processor_id() in preemptible code Cc: Patrick McHardy [EMAIL PROTECTED] Cc: David S. Miller [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- include/net/netfilter/nf_conntrack.h |7 ++- 1 file changed, 6

[patch 02/11] net/irda/: proper prototypes

2007-02-05 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] Add proper prototypes for some functions in include/net/irda/irda.h Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Acked-by: Samuel Ortiz [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- include/net/irda/irda.h | 15 +++

[patch 10/11] dccp-warning-fixes

2007-02-05 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] sparc64: net/dccp/ccids/ccid3.c: In function `ccid3_hc_tx_packet_recv': net/dccp/ccids/ccid3.c:480: warning: long long unsigned int format, __u64 arg (arg 6) net/dccp/ccids/ccid3.c: In function `ccid3_hc_rx_packet_recv': net/dccp/ccids/ccid3.c:1007:

[patch 03/11] fix for crash in adummy_init()

2007-02-05 Thread akpm
From: Daniel Walker [EMAIL PROTECTED] This was reported by Ingo Molnar here, http://lkml.org/lkml/2006/12/18/119 The problem is that adummy_init() depends on atm_init() , but adummy_init() is called first. So I put atm_init() into subsys_initcall which seems appropriate, and it will still get

[patch 06/11] net/wanrouter/wanmain.c: cleanups

2007-02-05 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] This patch contains the following cleanups: - make the following needlessly global functions static: - lock_adapter_irq() - unlock_adapter_irq() - #if 0 the following unused global functions: - wanrouter_encapsulate() - wanrouter_type_trans()

[PATCH 2.4 0/3] e1000: update to 7.3.20

2007-02-05 Thread Kok, Auke
Willy, Please pull: git-pull git://lost.foo-projects.org/~ahkok/git/linux-2.4 e1000 to receive an update for the e1000 driver. This updates the e1000 driver in the 2.4 kernel to version 7.3.20-k4, roughly the equivalent of what is in 2.6.20 and the latest of our out-of-tree driver. This adds

[PATCH 2/3] [MAINTAINERS]: update e1000 maintainers

2007-02-05 Thread Kok, Auke
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- MAINTAINERS | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 13759e9..c001147 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH 3/3] e1000: update README

2007-02-05 Thread Kok, Auke
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- Documentation/networking/e1000.txt | 785 +--- 1 files changed, 542 insertions(+), 243 deletions(-) diff --git a/Documentation/networking/e1000.txt

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-05 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article [EMAIL PROTECTED] (at Mon, 5 Feb 2007 15:56:51 -0500), Neil Horman [EMAIL PROTECTED] says: if (ifp == NULL valid_lft) { int max_addresses = in6_dev-cnf.max_addresses; + u32 addr_flags = 0; + +#ifdef

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-05 Thread David Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Tue, 06 Feb 2007 10:24:05 +0900 (JST) @@ -498,7 +500,8 @@ static void ndisc_send_na(struct net_device *dev, struct neighbour *neigh, msg-icmph.icmp6_unused = 0; msg-icmph.icmp6_router= router;

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-05 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Mon, 05 Feb 2007 17:32:58 -0800 (PST)), David Miller [EMAIL PROTECTED] says: From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Tue, 06 Feb 2007 10:24:05 +0900 (JST) @@ -498,7 +500,8 @@ static void ndisc_send_na(struct net_device *dev, struct neighbour

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-05 Thread David Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Tue, 06 Feb 2007 10:44:08 +0900 (JST) Yes, I agree, but I think it is different issue, and maybe, we should check and change other places as well, in separate patch(es). I agree. - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH] apply cwnd rules to FIN packets with data

2007-02-05 Thread David Miller
From: John Heffner [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 19:11:09 -0500 My first patch was broken anyway (should not have pulled the test from tso_should_defer), and the change is not needed to the nagle test since it's implicit. This patch just restores the old behavior from before

Re: [patch 01/11] user of the jiffies rounding code: Networking

2007-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 16:30:52 -0800 From: Arjan van de Ven [EMAIL PROTECTED] This patch introduces users of the round_jiffies() function in the networking code. These timers all were of the about once a second or about once every X seconds variety and several

Re: [patch 02/11] net/irda/: proper prototypes

2007-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 16:30:53 -0800 From: Adrian Bunk [EMAIL PROTECTED] Add proper prototypes for some functions in include/net/irda/irda.h Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Acked-by: Samuel Ortiz [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

Re: [patch 03/11] fix for crash in adummy_init()

2007-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 16:30:56 -0800 From: Daniel Walker [EMAIL PROTECTED] This was reported by Ingo Molnar here, http://lkml.org/lkml/2006/12/18/119 The problem is that adummy_init() depends on atm_init() , but adummy_init() is called first. So I put

Re: [patch 05/11] bonding: Replace kmalloc() + memset() pairs with the appropriate kzalloc() calls

2007-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 16:31:04 -0800 From: Joe Jin [EMAIL PROTECTED] Replace kmalloc() + memset() pairs with the appropriate kzalloc() calls in the bonding driver. Signed-off-by: Joe Jin [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Jeff, you

Re: [patch 06/11] net/wanrouter/wanmain.c: cleanups

2007-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 16:31:05 -0800 From: Adrian Bunk [EMAIL PROTECTED] This patch contains the following cleanups: - make the following needlessly global functions static: - lock_adapter_irq() - unlock_adapter_irq() - #if 0 the following unused global

Re: [patch 08/11] slip: Replace kmalloc() + memset() pairs with the appropriate kzalloc() calls

2007-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 16:31:06 -0800 From: joe jin [EMAIL PROTECTED] This patch replace kmalloc() + memset() pairs with the appropriate kzalloc(). Signed-off-by: Joe Jin [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Applied, thanks. - To

Re: [patch 11/11] netfilter warning fix

2007-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 16:31:11 -0800 From: Andrew Morton [EMAIL PROTECTED] using smp_processor_id() in preemptible code Cc: Patrick McHardy [EMAIL PROTECTED] Cc: David S. Miller [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] We NAK'd this

Re: [patch 11/11] netfilter warning fix

2007-02-05 Thread Andrew Morton
On Mon, 05 Feb 2007 18:10:26 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: From: [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 16:31:11 -0800 From: Andrew Morton [EMAIL PROTECTED] using smp_processor_id() in preemptible code Cc: Patrick McHardy [EMAIL PROTECTED] Cc: David S.

Re: [patch 11/11] netfilter warning fix

2007-02-05 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Mon, 5 Feb 2007 18:18:10 -0800 I think the finger was pointed at preemptible rcu, in -mm. iirc, the net stats code is assuming that rcu_read_lock() disables preemption as a side-effect, which rcu-preempt makes no-longer-true. Not sure what to do

Re: [patch 05/11] bonding: Replace kmalloc() + memset() pairs with the appropriate kzalloc() calls

2007-02-05 Thread Jeff Garzik
David Miller wrote: From: [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 16:31:04 -0800 From: Joe Jin [EMAIL PROTECTED] Replace kmalloc() + memset() pairs with the appropriate kzalloc() calls in the bonding driver. Signed-off-by: Joe Jin [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

Re: [patch 11/11] netfilter warning fix

2007-02-05 Thread Andrew Morton
On Mon, 05 Feb 2007 18:44:08 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: I bet this rcu_read_lock()-implies-preempt_disable() assumption has spread into other areas of the tree as well. Me too. Although one expects that other holes will cause might_sleep or lockdep warnings pretty

[PATCH 00] A series of patches to use ARRAY_SIZE in `net' drivers

2007-02-05 Thread Ahmed S. Darwish
Hi all, Follows is a sereis of patches to use ARRAY_SIZE macro in drivers/net. Patches are sent separately according to their maintaners as replies to this thread. apne.c |2 +- arm/am79c961a.c|2 +- atarilance.c |2 +- cs89x0.c

[PATCH 2.6.20] e1000: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] --- Patch is compile tested. diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c index fb96c87..d21706e 100644 ---

[PATCH 01/02] misc-net-drivers: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A 2.6.20 patch to use ARRAY_SIZE macro already defined in kernel.h for some miscellaneous network drivers with no specific maintaners. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] --- [PATCH 01/02] is compile tested. [PATCH 02/02] isn't compile tested cause of missing hardware. diff

[PATCH 2.6.20] ipw2100: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi all, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] --- Patch is compile tested. diff --git a/drivers/net/wireless/ipw2100.c b/drivers/net/wireless/ipw2100.c index b85857a..a9d944a 100644 --- a/drivers/net/wireless/ipw2100.c +++

[PATCH 02/02] misc-net-drivers: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A 2.6.20 patch to use ARRAY_SIZE macro already defined in kernel.h for some miscellaneous network drivers with no specific maintaners. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] --- Patch isn't compile-tested due to missing hardware. diff --git a/drivers/net/apne.c

  1   2   >