Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-05-18 Thread Tudor Girba
Hi, In this thread, there were several cs proposed. I thought they were integrated in 1.3, but they do not seem to be there. I was so looking forward to using them :). Igor, could you take a look? Cheers, Doru On 6 Apr 2011, at 13:43, Igor Stasenko wrote: Okay, here the updated version.

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-05-18 Thread Igor Stasenko
On 18 May 2011 14:14, Tudor Girba tudor.gi...@gmail.com wrote: Hi, In this thread, there were several cs proposed. I thought they were integrated in 1.3, but they do not seem to be there. I was so looking forward to using them :). Igor, could you take a look? hmm.. strange.. i thought we

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-05-18 Thread Tudor Girba
I just tried to load Glamorous Toolkit and run GTCoder open in a Pharo 1.3 and the tree does not fill the space horizontally. This prompted my mail. Cheers, Doru On 18 May 2011, at 17:10, Igor Stasenko wrote: On 18 May 2011 14:14, Tudor Girba tudor.gi...@gmail.com wrote: Hi, In this

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-05-18 Thread Igor Stasenko
On 18 May 2011 17:15, Tudor Girba tudor.gi...@gmail.com wrote: I just tried to load Glamorous Toolkit and run GTCoder open in a Pharo 1.3 and the tree does not fill the space horizontally. This prompted my mail. We just checked it with Marcus, and yes, this stuff are already integrated into

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-05-18 Thread Igor Stasenko
On 18 May 2011 17:43, Tudor Girba tudor.gi...@gmail.com wrote: Hi, On 18 May 2011, at 17:28, Igor Stasenko wrote: On 18 May 2011 17:15, Tudor Girba tudor.gi...@gmail.com wrote: I just tried to load Glamorous Toolkit and run GTCoder open in a Pharo 1.3 and the tree does not fill the space

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-05-18 Thread Tudor Girba
Hi, On 18 May 2011, at 17:53, Igor Stasenko wrote: On 18 May 2011 17:43, Tudor Girba tudor.gi...@gmail.com wrote: Hi, On 18 May 2011, at 17:28, Igor Stasenko wrote: On 18 May 2011 17:15, Tudor Girba tudor.gi...@gmail.com wrote: I just tried to load Glamorous Toolkit and run GTCoder open

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-05-18 Thread Tudor Girba
Hi, On 18 May 2011, at 18:17, Igor Stasenko wrote: On 18 May 2011 17:57, Tudor Girba tudor.gi...@gmail.com wrote: Hi, The rows with text with a gray background should span the entire horizontal space. Actually, the reason why there is the gray background is to reveal the bounds of the

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-07 Thread Stéphane Ducasse
Indeed this is really important to improve key infrastructure widgets. They are enablers of the future. This is why SM and polymorph are important. Stef On Apr 6, 2011, at 10:30 PM, Tudor Girba wrote: Excellent job :). And very highly appreciated. Cheers, Doru On 6 Apr 2011, at 22:06,

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-07 Thread Tudor Girba
Hi, On 6 Apr 2011, at 23:03, Igor Stasenko wrote: On 6 April 2011 22:54, Tudor Girba tudor.gi...@gmail.com wrote: And if we are at it, how would it be possible to get vertical resizers between rows? between rows.. For example, in the case of GTCoder, I would like to be able to resize

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Igor Stasenko
On 5 April 2011 21:39, Alain Plantec alain.plan...@yahoo.com wrote: Le 05/04/2011 20:08, Igor Stasenko a écrit : Cut out some code and extra morphs. It speeds up rendering to 60% of original. cool thanks for reviewing this code! @Benjamin Please verify if it positioning stuff correctly.

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Tudor Girba
Hi, 60% sounds excellent! If you are looking into MorphTreeMorph, would it be possible to look into the problem of making the submorphs fill the entire horizontal space? Let me give you an example: - download the Glamorous Toolkit image:

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Alain Plantec
Le 06/04/2011 08:57, Igor Stasenko a écrit : another point, try all examples in Morphic-MorphTreeWidget-Examples. now, the height of each row is constant. Yes, so what it should be instead? it should be dependent on the content height, so as it was before. another problem is the spacers

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Alain Plantec
Le 06/04/2011 09:30, Tudor Girba a écrit : Hi, 60% sounds excellent! If you are looking into MorphTreeMorph, would it be possible to look into the problem of making the submorphs fill the entire horizontal space? arrrh! yes sorry, it is on my todo list and the intergration of the cleaner

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Igor Stasenko
On 6 April 2011 09:45, Alain Plantec alain.plan...@yahoo.com wrote: Le 06/04/2011 08:57, Igor Stasenko a écrit : another point, try all examples in Morphic-MorphTreeWidget-Examples. now, the height of each row is constant. Yes, so what it should be instead? it should be dependent on the

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Stéphane Ducasse
Hi guys this is ***REALLLY*** important that we get scalable List and Tree so thanks a lot for your effort. Please continue Stef On Apr 6, 2011, at 10:02 AM, Igor Stasenko wrote: On 6 April 2011 09:45, Alain Plantec alain.plan...@yahoo.com wrote: Le 06/04/2011 08:57, Igor Stasenko a écrit

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Tudor Girba
Indeed. For example, in the context of Moose, we sometimes have lists in the order of 100k elements. The LazyMorphTreeMorph offers pagination and it works well, but it would be super cool to have a stronger solution. Cheers, Doru On 6 Apr 2011, at 10:08, Stéphane Ducasse wrote: Hi guys

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Igor Stasenko
On 6 April 2011 09:45, Alain Plantec alain.plan...@yahoo.com wrote: Le 06/04/2011 08:57, Igor Stasenko a écrit : another point, try all examples in Morphic-MorphTreeWidget-Examples. now, the height of each row is constant. Yes, so what it should be instead? it should be dependent on the

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Alain Plantec
Le 06/04/2011 10:02, Igor Stasenko a écrit : yes, positioning is not quite correct. But the idea is to use layouts instead of morphs to adjust positioning. Because having 3 extra morphs per list item which sitting there only for markup is not fun. And it affects a rendering speed considerably.

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Alain Plantec
Le 06/04/2011 10:23, Igor Stasenko a écrit : Btw, why in this grid example it uses tree morph? As to me it sounds a bit of abuse. Tree morph widget should focus on displaying trees, but not grids. I think it would be better to use separate widget for representing the grids, because obviously

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Stéphane Ducasse
yes, it is a workaround. take the current implementation as a functional requirement. Good point! Yes igor we want the same, simpler and faster :D MorphTreeMorph is cool because it can be used for lists, trees and tables, but I agree, it is badly implemented. So I fully agree with you,

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Igor Stasenko
Okay, here the updated version. GTCoder open looks fine Settings look fine. and SimpleGridExample new open looking fine as well -- Best regards, Igor Stasenko AKA sig. theTreee.8.cs Description: Binary data

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Igor Stasenko
and a little more cleanup (should be applied after theTreee) now a block which responsible for providing an icon for concrete item, actually could provide a morph, which means that one could put there an iconic button instead of simple image. -- Best regards, Igor Stasenko AKA sig.

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Alain Plantec
Le 06/04/2011 15:14, Igor Stasenko a écrit : and a little more cleanup (should be applied after theTreee) now a block which responsible for providing an icon for concrete item, actually could provide a morph, which means that one could put there an iconic button instead of simple image. super.

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Igor Stasenko
On 6 April 2011 15:52, Alain Plantec alain.plan...@yahoo.com wrote: Le 06/04/2011 15:14, Igor Stasenko a écrit : and a little more cleanup (should be applied after theTreee) now a block which responsible for providing an icon for concrete item, actually could provide a morph, which means

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Igor Stasenko
On 6 April 2011 17:22, Igor Stasenko siguc...@gmail.com wrote: On 6 April 2011 15:52, Alain Plantec alain.plan...@yahoo.com wrote: Le 06/04/2011 15:14, Igor Stasenko a écrit : and a little more cleanup (should be applied after theTreee) now a block which responsible for providing an icon for

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Igor Stasenko
okay.. i found one bug forgot to add cellPositioning: #leftCenter; for colum wrapper morph -- Best regards, Igor Stasenko AKA sig. Tree2.3.cs Description: Binary data

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Stéphane Ducasse
so can you open an issue with all the stuff that the slaveMasters = me or marcus or igor or alain :) should integrate. Stef On Apr 6, 2011, at 6:01 PM, Igor Stasenko wrote: okay.. i found one bug forgot to add cellPositioning: #leftCenter; for colum wrapper morph -- Best regards,

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Tudor Girba
This is great! I tested it on Glamour and it looks pretty cool. And, it is definitely snappier. I tested LazyMorphTreeMorph it on a list with 1 million items in the context of Glamour with a pagination of 50 items I got: - before: 6414 ms - after: 3526 ms The code I used is (works in a Moose

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Stéphane Ducasse
Good! I'm happy. Igor and Ben are doing a great job. Stef This is great! I tested it on Glamour and it looks pretty cool. And, it is definitely snappier. I tested LazyMorphTreeMorph it on a list with 1 million items in the context of Glamour with a pagination of 50 items I got: -

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Tudor Girba
Excellent job :). And very highly appreciated. Cheers, Doru On 6 Apr 2011, at 22:06, Stéphane Ducasse wrote: Good! I'm happy. Igor and Ben are doing a great job. Stef This is great! I tested it on Glamour and it looks pretty cool. And, it is definitely snappier. I tested

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Tudor Girba
And if we are at it, how would it be possible to get vertical resizers between rows? For example, in the case of GTCoder, I would like to be able to resize the pane with code inside. Cheers, Doru On 6 Apr 2011, at 18:01, Igor Stasenko wrote: okay.. i found one bug forgot to add

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-06 Thread Igor Stasenko
On 6 April 2011 22:54, Tudor Girba tudor.gi...@gmail.com wrote: And if we are at it, how would it be possible to get vertical resizers between rows? between rows.. For example, in the case of GTCoder, I would like to be able to resize the pane with code inside. i think you'd better do a

[Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-05 Thread Igor Stasenko
Cut out some code and extra morphs. It speeds up rendering to 60% of original. @Benjamin Please verify if it positioning stuff correctly. Because in my image Settings are now OK. @all I need your feedback to know if it works correctly in other places, where tree morph used. -- Best regards,

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-05 Thread Stéphane Ducasse
**TX!!** :) It was cool to see you both hacking to speed it up. Stef Cut out some code and extra morphs. It speeds up rendering to 60% of original. @Benjamin Please verify if it positioning stuff correctly. Because in my image Settings are now OK. @all I need your feedback to know if

Re: [Pharo-project] A lil simplification of MorphTreeNodeMorph

2011-04-05 Thread Alain Plantec
Le 05/04/2011 20:08, Igor Stasenko a écrit : Cut out some code and extra morphs. It speeds up rendering to 60% of original. cool thanks for reviewing this code! @Benjamin Please verify if it positioning stuff correctly. Because in my image Settings are now OK. @all I need your feedback to