Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-18 Thread Pierre Ossman
On Tue, 17 Jul 2012 12:28:14 -0400 Brian Hinz bph...@users.sourceforge.net wrote: So far everything looks good!! I'll continue testing today but in either case thank you for taking the time to work on this. Np. It's been on the todo list for a bit long already. Good to have it out of the way.

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-17 Thread Pierre Ossman
On Fri, 13 Jul 2012 15:36:28 +0200 Pierre Ossman oss...@cendio.se wrote: Not sure what the fix is. Starting to activate hooks even for just the screen pixmap still means we have to audit the code for assumptions about windows. Not terribly appealing. I'll dig around and see if I can find

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-17 Thread Pierre Ossman
On Tue, 17 Jul 2012 07:48:11 -0400 Brian Hinz bph...@users.sourceforge.net wrote: I think this patch causes backgrounds to be drawn when they should not be (see the attached screen captures). The borders seem to be correct in fluxbox though. Ehm... That's extremely odd. The affected code

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-17 Thread Brian Hinz
On Tue, Jul 17, 2012 at 8:00 AM, Pierre Ossman wrote: On Tue, 17 Jul 2012 07:48:11 -0400 Brian Hinz wrote: I think this patch causes backgrounds to be drawn when they should not be (see the attached screen captures). The borders seem to be correct in fluxbox though. Ehm... That's

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-17 Thread Pierre Ossman
On Tue, 17 Jul 2012 08:14:15 -0400 Brian Hinz bph...@users.sourceforge.net wrote: Completely reproducible. I only sent a couple of screenshots, but it's nearly unusable because the background is painted over on almost any menu, textbox, etc. DeferUpdate=0 paints the background instantly, so

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-17 Thread Brian Hinz
On Tue, Jul 17, 2012 at 10:14 AM, Pierre Ossman wrote: On Tue, 17 Jul 2012 08:14:15 -0400 Brian Hinz wrote: Completely reproducible. I only sent a couple of screenshots, but it's nearly unusable because the background is painted over on almost any menu, textbox, etc. DeferUpdate=0

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-13 Thread Pierre Ossman
On Thu, 12 Jul 2012 18:04:40 +0200 Adam Tkac at...@redhat.com wrote: I dived into vncHooks and xserver sources and attached patch should fix both screen artefacts and XDrawArc crashes. It reverts r4220 and fixes vncHooksFillSpans hook which used wrong clip pointer. -Inf Hooking pixmaps

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-13 Thread DRC
On 7/13/12 3:09 AM, Pierre Ossman wrote: I dived into vncHooks and xserver sources and attached patch should fix both screen artefacts and XDrawArc crashes. It reverts r4220 and fixes vncHooksFillSpans hook which used wrong clip pointer. -Inf Hooking pixmaps is just asking for problems.

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-13 Thread Pierre Ossman
On Fri, 13 Jul 2012 05:18:16 -0500 DRC dcomman...@users.sourceforge.net wrote: Maybe I'm missing something, but isn't the goal to hook only drawing commands that actually produce visible information? That being the case, isn't the relevant data already being hooked when the pixmap gets

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-13 Thread Pierre Ossman
On Fri, 13 Jul 2012 12:50:00 +0200 Pierre Ossman oss...@cendio.se wrote: On Fri, 13 Jul 2012 05:18:16 -0500 DRC dcomman...@users.sourceforge.net wrote: Maybe I'm missing something, but isn't the goal to hook only drawing commands that actually produce visible information? That being

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-12 Thread Adam Tkac
On Fri, Jun 29, 2012 at 04:00:14PM +0200, Pierre Ossman wrote: On Fri, 29 Jun 2012 09:17:39 -0400 Brian Hinz bph...@users.sourceforge.net wrote: r4220 appears to be the cause of bug #3415308. When I revert the change made in r4220 fluxbox and other apps that exhibit rendering artifacts

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-12 Thread Brian Hinz
On Thu, Jul 12, 2012 at 12:04 PM, Adam Tkac wrote: On Fri, Jun 29, 2012 at 04:00:14PM +0200, Pierre Ossman wrote: On Fri, 29 Jun 2012 09:17:39 -0400 Brian Hinz wrote: r4220 appears to be the cause of bug #3415308. When I revert the change made in r4220 fluxbox and other apps that

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-11 Thread Pierre Ossman
On Tue, 10 Jul 2012 23:41:55 -0400 Brian Hinz bph...@users.sourceforge.net wrote: I've been trying to trace back the source of the PolyFillRects and they definitely come from miHandleValidateExposures in mi/miwindow.c - miPaintWindow in mi/miexpose.c and then the PolyFillRect hook should be

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-11 Thread Brian Hinz
On Wed, Jul 11, 2012 at 4:11 AM, Pierre Ossman wrote: On Tue, 10 Jul 2012 23:41:55 -0400 Brian Hinz wrote: I've been trying to trace back the source of the PolyFillRects and they definitely come from miHandleValidateExposures in mi/miwindow.c - miPaintWindow in mi/miexpose.c and then

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-10 Thread Brian Hinz
On Fri, Jul 6, 2012 at 9:45 AM, Brian Hinz wrote: On Wed, Jul 4, 2012 at 3:35 AM, Pierre Ossman wrote: On Tue, 3 Jul 2012 16:42:11 -0400 Brian Hinz wrote: Hi Pierre, I'm not sure if this means anything to you, but I found that if I set 'AlwaysSetDeferUpdateTimer=1' then outline

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-04 Thread Pierre Ossman
On Tue, 3 Jul 2012 16:42:11 -0400 Brian Hinz bph...@users.sourceforge.net wrote: Hi Pierre, I'm not sure if this means anything to you, but I found that if I set 'AlwaysSetDeferUpdateTimer=1' then outline boxes are partially drawn and damaged regions are sometimes partially redrawn. The

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-03 Thread Brian Hinz
On Mon, Jul 2, 2012 at 9:55 AM, Pierre Ossman wrote: On Mon, 2 Jul 2012 08:31:41 -0400 Brian Hinz wrote: I put some debug print statements in and it seems to either in vncHooksPolyRectangle or vncHooksPolyFillRect (oddly, RHEL5 seems to call PolyRectangle and Fedora 16 calls

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-03 Thread DRC
On 7/3/12 3:42 PM, Brian Hinz wrote: I'm not sure if this means anything to you, but I found that if I set 'AlwaysSetDeferUpdateTimer=1' then outline boxes are partially drawn and damaged regions are sometimes partially redrawn. The location and extent to which the lines are drawn is

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-03 Thread Brian Hinz
On Tue, Jul 3, 2012 at 5:32 PM, DRC wrote: On 7/3/12 3:42 PM, Brian Hinz wrote: I'm not sure if this means anything to you, but I found that if I set 'AlwaysSetDeferUpdateTimer=1' then outline boxes are partially drawn and damaged regions are sometimes partially redrawn. The location and

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-02 Thread Brian Hinz
On Fri, Jun 29, 2012 at 10:00 AM, Pierre Ossman oss...@cendio.se wrote: The fact that your patch fixes something is an indication that we are overlooking some screen updates somewhere else. Unfortunately it's not really trivial to figure out what and where. You have to find a simple test

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-06-29 Thread Pierre Ossman
On Fri, 29 Jun 2012 09:17:39 -0400 Brian Hinz bph...@users.sourceforge.net wrote: r4220 appears to be the cause of bug #3415308. When I revert the change made in r4220 fluxbox and other apps that exhibit rendering artifacts along their window decorations all behave properly. I have not seen