[webkit-dev] Experimental features in Safari Web Inspector

2012-09-26 Thread Mihai Balan
Hello webkittens! We have recently been working on some WebInspector features related to CSS Regions. Most of the work was done using Chromium's Developer Tools, as this allowed us to have this work under a DevTools experiment flag. Now that this work has reached a more stable state, it would be

[webkit-dev] WKCreateCTLineWithUniCharProvider

2012-09-26 Thread Glenn Adams
Where can I find the source for WKCreateCTLineWithUniCharProvider? I'm working on a bug [1] in which I will need to at least understand and perhaps modify its behavior. Basically, to fix this bug, I need to pass character context from adjacent text runs (or adjacent inline text nodes) that will

[webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Simon Fraser
We have a lot of tests that poke internal settings, via testRunner: testRunner.setFrameFlatteningEnabled(true); or window.internals: internals.settings.setPageScaleFactor(0.5, 0, 0); and some that poke preferences, like:

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Ryosuke Niwa
On Wed, Sep 26, 2012 at 1:44 PM, Simon Fraser simon.fra...@apple.comwrote: We have a lot of tests that poke internal settings, via testRunner: testRunner.setFrameFlatteningEnabled(true); or window.internals: internals.settings.setPageScaleFactor(0.5, 0, 0); and some that poke

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
On Sep 26, 2012, at 1:48 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Sep 26, 2012 at 1:44 PM, Simon Fraser simon.fra...@apple.com wrote: First, direct calls on testRunner that just set preferences should be migrated to internals.settings or testRunner.overridePreference calls, I

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Jeffrey Pfau
On Sep 26, 2012, at 1:44 PM, Simon Fraser simon.fra...@apple.com wrote: * we should choose between internals.settings or testRunner.overridePreference if that makes sense. I've recently been working on a new API and I've discovered that internals.settings and testRunner.overridePreference go

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Adam Barth
[re-sent from the proper address] On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth abarth@nowhere wrote: On Wed, Sep 26, 2012 at 1:53 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 1:48 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Sep 26, 2012 at 1:44 PM, Simon Fraser

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Eric Seidel
I would agree with Adam, and the more we can move to window.internals, the less technical debt we incur with each new DRT feature. I would love to see overridePreferences go away (or only be used for preferences which need to test the WebKit-side plumbing). TestExpectation files on all ports are

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote: [re-sent from the proper address] On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth abarth@nowhere wrote: On Wed, Sep 26, 2012 at 1:53 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 1:48 PM, Ryosuke Niwa

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Dirk Pranke
On a related note, there is a gradual movement to pass more command line flags along with each test to DRT during run-webkit-tests (to toggle between pixel tests and non, change timeout values, etc.), and being able to ensure we reset the state to the default between each test is kinda necessary

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
On Sep 26, 2012, at 2:14 PM, Eric Seidel e...@webkit.org wrote: TestExpectation files on all ports are full of: # unskip these tests when we add obscure-drt-feature-x http://trac.webkit.org/browser/trunk/LayoutTests/platform/wk2/Skipped#L107

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Tony Chang
On Wed, Sep 26, 2012 at 2:35 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote: [re-sent from the proper address] On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth abarth@nowhere wrote: On Wed, Sep 26, 2012 at 1:53 PM, Brady Eidson

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Adam Barth
On Wed, Sep 26, 2012 at 2:35 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote: [re-sent from the proper address] On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth abarth@nowhere wrote: On Wed, Sep 26, 2012 at 1:53 PM, Brady Eidson

Re: [webkit-dev] Experimental features in Safari Web Inspector

2012-09-26 Thread Dean Jackson
On 26/09/2012, at 6:15 PM, Mihai Balan miba...@adobe.com wrote: We have recently been working on some WebInspector features related to CSS Regions. Most of the work was done using Chromium's Developer Tools, as this allowed us to have this work under a DevTools experiment flag. Now that

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
On Sep 26, 2012, at 2:46 PM, Tony Chang t...@chromium.org wrote: On Wed, Sep 26, 2012 at 2:35 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote: [re-sent from the proper address] On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Simon Fraser
On Sep 26, 2012, at 4:13 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 2:46 PM, Tony Chang t...@chromium.org wrote: On Wed, Sep 26, 2012 at 2:35 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote: [re-sent from the

Re: [webkit-dev] Experimental features in Safari Web Inspector

2012-09-26 Thread Pavel Feldman
On Sep 27, 2012 1:56 AM, Dean Jackson dino d...@apple.com@d...@apple.com apple.com d...@apple.com wrote: On 26/09/2012, at 6:15 PM, Mihai Balan mibalan miba...@adobe.com@miba...@adobe.com adobe.com miba...@adobe.com wrote: We have recently been working on some WebInspector features related

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
On Sep 26, 2012, at 4:43 PM, Adam Barth aba...@webkit.org wrote: Maybe a better solution is auto-generate all this boilerplate code? If we had a Settings.in file, we could generate all the port-specific code (and maybe even much of Settings.h/cpp) automatically. Then all of these patches

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Adam Barth
On Wed, Sep 26, 2012 at 4:51 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 4:43 PM, Adam Barth aba...@webkit.org wrote: Maybe a better solution is auto-generate all this boilerplate code? If we had a Settings.in file, we could generate all the port-specific code (and maybe

Re: [webkit-dev] WKCreateCTLineWithUniCharProvider

2012-09-26 Thread Elliott Sprehn
WKCreateCTLineWithUniCharProvider is in the WebKitSystemInterface so its source is not available outside Apple. On Wed, Sep 26, 2012 at 2:34 AM, Glenn Adams gl...@skynav.com wrote: Where can I find the source for WKCreateCTLineWithUniCharProvider? I'm working on a bug [1] in which I will need