On Fri 03. Nov - 14:57:10, Stefan Seyfried wrote:
> On Thu, Nov 02, 2006 at 04:08:20PM +0100, Rafael J. Wysocki wrote:
> > On Thursday, 2 November 2006 13:13, Stefan Seyfried wrote:
> > > On Thu, Nov 02, 2006 at 11:29:47AM +0100, Rafael J. Wysocki wrote:
> > > > On Thursday, 2 November 2006 11:24, Pavel Machek wrote:
> > > > > Hi!
> > > > >
> > > > > > The appended patch allows the users of suspend to abort the image
> > > > > > saving by
> > > > > > pressing Ctrl+c.
> > > > >
> > > > > It would be nice to abort with escape or something... ctrl+c is going
> > > > > to be "interesting" for users using splashscreen.
> > > >
> > > > OK
> > >
> > > Escape (and f2) switches the splash screen to verbose. I sometimes
> > > probably
> > > would want to do that without aborting suspend.
> > >
> > > I'm not sure if the first escape (that switches bootsplash to verbose) is
> > > even passed on to the terminal, though. Would need to test that...
> >
> > OK
> >
> > Which key do you prefer?
>
> I don't know. Escape sounds pretty logical :-)
> Go ahead, i don't even know if this is an issue (Holger could probably test
> what happens to the escape that sends bootsplash into verbose mode, i'm not
> sure if this one is even propagated to userspace) and if it is, i could still
> either change the define for the SUSE package or
>
> if (bootsplash.is_silent())
> ignore_first_esc;
>
> something ugly like that.
Bootsplash only drops to verbose mode on escape and F2 as far as I can
see. At least the kernel has something like this:
---
#ifdef CONFIG_BOOTSPLASH
/* This code has to be redone for some non-x86 platforms */
if (down == 1 && (keycode == 0x3c || keycode == 0x01)) { /* F2
and ESC on PC keyboard */
extern int splash_verbose(void);
printk(KERN_INFO "splash_verbose in keyboard.c 1\n");
if (splash_verbose())
return;
}
#endif
---
But I agree escape would be more senseable. So why is this an issue at
all? Distribution which have bootsplash will have something like "press
escape to abort" in their bootsplash theme anyway. So I don't think that
the usual user likes to press the 'abort key' multiple times. If you like
to see what's going on, just disable splash in the config file. And if
something is going wrong during suspend, the escape key just drops
bootsplash to verbose mode and you'll hopefully see the failure messages
but then there's nothing to abort anymore anyway ;-)
Regards,
Holger
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel
