--- Begin Message ---
On 24/09/2020 21:51, Denis Ovsienko via tcpdump-workers wrote:
> On Sat, 5 Sep 2020 18:20:42 +0200
> Francois-Xavier Le Bail via tcpdump-workers
> <tcpdump-workers@lists.tcpdump.org> wrote:
> 
> [...]
>> 2) Process all the truncated cases with:
>> ndo->ndo_ll_hdr_len = 0;
>> longjmp(ndo->ndo_truncated, 1);
>> (With a new macro, like 'ND_TRUNCATED' or 'ND_IS_TRUNCATED')
> [...]
> 
> It could be simpler and more reliable to reset or to ignore
> ndo->ndo_ll_hdr_len in pretty_print_packet() after "returning" from
> setjmp for the second time (longjmp() can happen in many different
> places, but there is only one setjmp()).

Agreed. Done with commit 387c58edb5f053eb719d8e9cdf05d626d367bddd.

--- End Message ---
_______________________________________________
tcpdump-workers mailing list
tcpdump-workers@lists.tcpdump.org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers

Reply via email to