Amita, I have reviewed the RDB DAS Architecture Guide:
- It is still missing the design diagram file( http://incubator.apache.org/tuscany/rdb-das-class-diagram.html). It seems you've uploaded it as attachment, but I don't know why it is not loading on the page. - On ResultSetProcessor description the word GrapbBuilderMetadata is incorrect written. - On Configuration Schema I think it should be made explicit that the order ResultDescriptor are declared are the order they appear on ResultSet. Am I wrong? - What SingleTableRegistry is used for? On its description it says it has now functionality. PS: I could fix some of these issues I`ve pointed, but I don't know why I'm not being able to edit it : ( Regards, Adriano Crestani On 6/15/07, Amita Vadhavkar <[EMAIL PROTECTED]> wrote: Hi Luciano, I tested latest from trunk and the issues discussed here seemed to be fixed now. Thank you very much. Regards, Amita On 6/15/07, Luciano Resende <[EMAIL PROTECTED]> wrote: > > Thanks Amita for looking into this... > I have fixed the distribution issue as in TUSCANY-1348, and the > logging issue as in TUSCANY-1349. I also noticed an issue with logging > in dbConfig, where we were not checking if logging was enabled and > always calling log, and I have also fixed that. > > Please let me know if things are looking better now. > > On 6/14/07, Amita Vadhavkar <[EMAIL PROTECTED]> wrote: > > Small update, tried to build and test with empty repos and it went > through > > with no issues. > > > > Regards, > > Amita > > > > On 6/13/07, Amita Vadhavkar <[EMAIL PROTECTED]> wrote: > > > > > > Things tested to be working - > > > all UT as part of mvn build > > > all samples in different browsers. > > > > > > Apart from das\distribution\binary\pom.xml - change and documentation > > > changes in JIRA 1335, I have a doubt in logging mechanism in web > samples. > > > > > > In DBConfig utility , the code uses Logger.getLogger(className) - to > get > > > logger from log4j. > > > > > > Whereas in all RDB DAS code, it is > > > LoggerFactory.INSTANCE.getLogger(className) - to get logger from RDB > DAS > > > util. > > > In this, the level is OFF - hardcoded in the code. > > > > > > So, when the log4j.properties file is used in tomcat to switch on > logging, > > > the logging works for DBConfig (as it is using direct log4j), but > logging > > > does not switch on for RDB DAS classes, as it is hardcoded OFF in the > RDB > > > DAS jar. > > > > > > Is this the desired behavior? Will there be any need to switch on > logging > > > in web samples for RDB DAS code and how to do it without touching > > > tuscany-das-rdb-1.0-incubating.jar? > > > > > > Regards, > > > Amita > > > > > > On 6/11/07, Amita Vadhavkar <[EMAIL PROTECTED]> wrote: > > > > > > > > Hi All, > > > > > > > > When tried mvn -Pdistribution on das:- > > > > das\distribution\binary\pom.xml - does not list ajax web sample > under > > > > dependency and thus does not package same > > > > > > > > As now, non-committer does not have access to edit wiki, I have > created > > > > JIRA-TUSCANY-1335 for all the pending updates for DAS I was doing. > Please > > > > see how these can be completed using attached zipped files. > > > > > > > > Architecture Guide - > http://cwiki.apache.org/confluence/display/TUSCANY/RDB+DAS+architecture+guide > > > > > > > > images to upload - ClassDiag.jpg, rdbDAS.gif > > > > > > > > User Guide - > > > > > http://cwiki.apache.org/confluence/display/TUSCANY/RDB+DAS+-+User+Guide > > > > Under Samples(See Capabilities in use) > > > > Put links for:- > > > > Web Sample - > > > > > https://svn.apache.org/repos/asf/incubator/tuscany/java/das/samples/companyweb/readme.htm > > > > J2SE Sample - > > > > > https://svn.apache.org/repos/asf/incubator/tuscany/java/das/samples/customer/readme.htm > > > > Advanced Web Sample - > https://svn.apache.org/repos/asf/incubator/tuscany/java/das/samples/sample-ajax-das/readme.htm > > > > > > > > > > > > Development Guide - DAS_Java_Development_Guide.txt - need to add to > wiki > > > > > > > > need to checkin under > https://svn.apache.org/repos/asf/incubator/tuscany/java/das/distribution/src/main/release/RELEASE > > > > NOTES > > > > RELEASE_NOTES.txt > > > > > > > > About to complete CHANGES.txt , will add by eod to JIRA 1335.. > > > > > > > > Regards, > > > > Amita > > > > > > > > On 6/10/07, Adriano Crestani <[EMAIL PROTECTED] > wrote: > > > > > > > > > > I went through all das samples and they seem to be working fine on > > > > > Windows > > > > > XP Home Edition SP 2 environment. I also corrected some links on > > > > > readmes > > > > > that were pointing to old tuscany website. > > > > > > > > > > I ran the rat on java/das directory and added Apache Licence > header to > > > > > files > > > > > that were missing it. > > > > > > > > > > Regards, > > > > > Adriano Crestani > > > > > > > > > > On 6/8/07, Luciano Resende < [EMAIL PROTECTED]> wrote: > > > > > > > > > > > > First of all, let me thank you all for helping on this release. > > > > > > Recently there has been a lot of progress, and things are > looking > > > > > good > > > > > > from the list of issues we had listed in the wiki [1]. The > remaining > > > > > > documentation tasks could probably go in parallel with the > release > > > > > > candidates. So, we should start thinking about creating a branch > for > > > > > > the next release sometime soon, probably over the weekend or > Monday > > > > > > and then start publishing release candidates from that. > > > > > > > > > > > > Also, I think we should look into the following items before we > > > > > create > > > > > > the first RC : > > > > > > > > > > > > - run rat and make the results available > > > > > > - review the contents of license, readme, release_notes, > changes, > > > > > etc > > > > > > - review javadoc > > > > > > - make sure samples readme are updated and correct and the > > > > > samples > > > > > > are working ok on different environments > > > > > > > > > > > > I'd also like to suggest two other things : > > > > > > - Name the release beta1, to be aligned with the beta1 > release of > > > > > SDO. > > > > > > - Any blocking issue to be tracked as blocking JIRA and > directly > > > > > > assigned to beta1 release. > > > > > > > > > > > > Does this sound ok to everyone? Any Thoughts ? > > > > > > > > > > > > > > > > > > [1] > > > > > > > http://cwiki.apache.org/confluence/display/TUSCANY/RDB+DAS+-+Java+DAS+Beta1+Release > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Luciano Resende > > > > > > Apache Tuscany Committer > > > > > > http://people.apache.org/~lresende > > > > > > http://lresende.blogspot.com/ > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > Luciano Resende > Apache Tuscany Committer > http://people.apache.org/~lresende > http://lresende.blogspot.com/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
