On 10 December 2012 21:06, Dan Allen <[email protected]> wrote: > And to follow-up on that point more concretely, I created an example pull > request with the changes to the asciidoc.vim file that were posted. > > https://github.com/mojavelinux/asciidoc-mirror/pull/1 > > (I may not have gotten the patch right, which further demonstrates how > important it is that the patch be made and followed by the contributor, so > it's the right patch).
Patches or PRs should all be accepted, the point is to increase participation, not to force a workflow on contributors. Personally I'm fine with Github and PRs, except for the grumbles I voiced before :) And what is going to be the workflow? Cheers Lex > > -Dan > > > On Mon, Dec 10, 2012 at 2:51 AM, Dan Allen <[email protected]> wrote: >> >> As a case in point, consider the updates to the vim syntax files that were >> just recently posted to the list. Contributions like those would be much >> more manageable as pull requests...and likely a lot more natural for the >> contributor. Just something to keep in mind. >> >> On Mon, Dec 10, 2012 at 2:32 AM, Dan Allen <[email protected]> wrote: >>> >>> Regardless of where the canonical source code repository is located, I >>> think there is tremendous benefit in having a mirror on GitHub. I've >>> observed first hand how much visibility GitHub brings to a project. The >>> obvious benefit is that you can say "find us on GitHub", which is a >>> surprisingly powerful. It also makes it so easy to see the activity and >>> history of a project, more so than any other web-based viewer I've ever come >>> across. Finally, it provides a very elegant way to share patches (either >>> through pull requests or just the "forks" themselves). That definitely beats >>> sending patch files through a mailinglist. Do not underestimating the impact >>> this can have. >> >> >> -Dan >> >> >> -- >> Dan Allen >> Principal Software Engineer, Red Hat | Author of Seam in Action >> Registered Linux User #231597 >> >> http://google.com/profiles/dan.j.allen >> http://mojavelinux.com >> http://mojavelinux.com/seaminaction >> > > > > -- > Dan Allen > Principal Software Engineer, Red Hat | Author of Seam in Action > Registered Linux User #231597 > > http://google.com/profiles/dan.j.allen > http://mojavelinux.com > http://mojavelinux.com/seaminaction > > -- > You received this message because you are subscribed to the Google Groups > "asciidoc" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/asciidoc?hl=en. -- You received this message because you are subscribed to the Google Groups "asciidoc" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/asciidoc?hl=en.
